)]}'
{"manifests/cron/archive_deleted_rows.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f1f66d54147e42ce11547e3bd26d2458df2312bb","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":58,"context_line":"  $max_rows    \u003d \u0027100\u0027,"},{"line_number":59,"context_line":"  $user        \u003d \u0027nova\u0027,"},{"line_number":60,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowsflush.log\u0027"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_0004f6bd","line":60,"updated":"2015-08-04 11:21:59.000000000","message":"minor question: should we name this parameter more clearly? (e.g. archive_log_path) what do you think?","commit_id":"459d075c61a6719aabe2af825153acd3456c7d07"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"54529ef00012f81e341aae8449eb828f088e8a56","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":58,"context_line":"  $max_rows    \u003d \u0027100\u0027,"},{"line_number":59,"context_line":"  $user        \u003d \u0027nova\u0027,"},{"line_number":60,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowsflush.log\u0027"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_ee58d458","line":60,"in_reply_to":"1a4dcd0f_0004f6bd","updated":"2015-08-04 13:18:11.000000000","message":"Isn\u0027t parameter documentation enough explanation? I personally don\u0027t like long parameters, but I don\u0027t mind changing the name. Let\u0027s see what core guys will think about it.","commit_id":"459d075c61a6719aabe2af825153acd3456c7d07"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"549d1362996eb929fc5a420fc689a38b4143de56","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":58,"context_line":"  $max_rows    \u003d \u0027100\u0027,"},{"line_number":59,"context_line":"  $user        \u003d \u0027nova\u0027,"},{"line_number":60,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowsflush.log\u0027"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_22440348","line":60,"in_reply_to":"1a4dcd0f_14bd8f67","updated":"2015-08-12 17:44:38.000000000","message":"Good point, let\u0027s stay consistent","commit_id":"459d075c61a6719aabe2af825153acd3456c7d07"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9ec5044bd044cb26d01c1fbe2fcc897ff6b72b16","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":58,"context_line":"  $max_rows    \u003d \u0027100\u0027,"},{"line_number":59,"context_line":"  $user        \u003d \u0027nova\u0027,"},{"line_number":60,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowsflush.log\u0027"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_50010337","line":60,"in_reply_to":"1a4dcd0f_413e3bdb","updated":"2015-08-12 00:15:16.000000000","message":"I think $log_destination or $log_path would be better, $destination to me implies we have some sort of control over the database table these are archived to, which I don\u0027t think is what this means (\"Move deleted rows from production tables to shadow tables.\" - http://docs.openstack.org/developer/nova/man/nova-manage.html)","commit_id":"459d075c61a6719aabe2af825153acd3456c7d07"},{"author":{"_account_id":5241,"name":"Martin Magr","email":"mmagr@redhat.com","username":"mmagr"},"change_message_id":"3f96ba627b6d3769fb4bd085c978c704d404940e","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":58,"context_line":"  $max_rows    \u003d \u0027100\u0027,"},{"line_number":59,"context_line":"  $user        \u003d \u0027nova\u0027,"},{"line_number":60,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowsflush.log\u0027"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_14bd8f67","line":60,"in_reply_to":"1a4dcd0f_50010337","updated":"2015-08-12 14:20:01.000000000","message":"Does it make sense to break consistency now, when following classes are using $destination? Or do you want me to submit another patches for puppet-cinder and puppet-keystone?\n\nI5e51562338f68b4ba1b2e942907e6f6a0ab7a61e\nI677f2ef3d9ca81fff0f672c8e34b6e4278674a96","commit_id":"459d075c61a6719aabe2af825153acd3456c7d07"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"49bdce79474c1fab3ff75639fd9df5362d375844","unresolved":false,"context_lines":[{"line_number":57,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":58,"context_line":"  $max_rows    \u003d \u0027100\u0027,"},{"line_number":59,"context_line":"  $user        \u003d \u0027nova\u0027,"},{"line_number":60,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowsflush.log\u0027"},{"line_number":61,"context_line":") {"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a4dcd0f_413e3bdb","line":60,"in_reply_to":"1a4dcd0f_ee58d458","updated":"2015-08-11 13:27:08.000000000","message":"As I can see, the name is ok, so I also agree","commit_id":"459d075c61a6719aabe2af825153acd3456c7d07"}]}