)]}'
{"manifests/api.pp":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"fcfb039484bbc98d1f1fb330fd1660f59b04a364","unresolved":false,"context_lines":[{"line_number":193,"context_line":") inherits nova::params {"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  include ::nova::db"},{"line_number":196,"context_line":"  include ::nova::params"},{"line_number":197,"context_line":"  include ::nova::policy"},{"line_number":198,"context_line":"  require ::keystone::python"},{"line_number":199,"context_line":"  include ::cinder::client"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_b9baf4be","line":196,"updated":"2015-09-15 20:49:21.000000000","message":"Just noticed this.  Redundant because we inherit nova::params.","commit_id":"2dce27b793ff22c2a616a5b41599e826fe6df8af"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"12679319c0ce9bea2e0baf19a308718caa22eee0","unresolved":false,"context_lines":[{"line_number":193,"context_line":") inherits nova::params {"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  include ::nova::db"},{"line_number":196,"context_line":"  include ::nova::params"},{"line_number":197,"context_line":"  include ::nova::policy"},{"line_number":198,"context_line":"  require ::keystone::python"},{"line_number":199,"context_line":"  include ::cinder::client"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_0471de43","line":196,"in_reply_to":"ba15a1d1_b9baf4be","updated":"2015-09-17 14:45:06.000000000","message":"Done","commit_id":"2dce27b793ff22c2a616a5b41599e826fe6df8af"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"fcfb039484bbc98d1f1fb330fd1660f59b04a364","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"  # when running wsgi, we need to know what to exactly enable or not."},{"line_number":214,"context_line":"  # since enabled_apis is not an array, so we need to grep services"},{"line_number":215,"context_line":"  # so we can detect what is actually activated for eventlet or not."},{"line_number":216,"context_line":"  if (! empty(grep(any2array($enabled_apis), \u0027ec2\u0027)) and $service_name \u003d\u003d \u0027httpd\u0027) {"},{"line_number":217,"context_line":"    # this boolean is consumed in ::nova::wsgi::apache"},{"line_number":218,"context_line":"    $enable_ec2 \u003d true"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_b9643449","line":215,"updated":"2015-09-15 20:49:21.000000000","message":"Can we just make \"enabled_apis\" an array and get rid of all this or am I missing something?  The value passed in at line 213 just becomes \"join($something, \u0027,\u0027)\".","commit_id":"2dce27b793ff22c2a616a5b41599e826fe6df8af"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"12679319c0ce9bea2e0baf19a308718caa22eee0","unresolved":false,"context_lines":[{"line_number":212,"context_line":""},{"line_number":213,"context_line":"  # when running wsgi, we need to know what to exactly enable or not."},{"line_number":214,"context_line":"  # since enabled_apis is not an array, so we need to grep services"},{"line_number":215,"context_line":"  # so we can detect what is actually activated for eventlet or not."},{"line_number":216,"context_line":"  if (! empty(grep(any2array($enabled_apis), \u0027ec2\u0027)) and $service_name \u003d\u003d \u0027httpd\u0027) {"},{"line_number":217,"context_line":"    # this boolean is consumed in ::nova::wsgi::apache"},{"line_number":218,"context_line":"    $enable_ec2 \u003d true"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_447b5628","line":215,"in_reply_to":"ba15a1d1_b9643449","updated":"2015-09-17 14:45:06.000000000","message":"the problem is more complicated than that. For backward compatibility purpose, you need this code.\nYou can\u0027t just set the param as an array and expect people magically using an array.\n\nOur users are currently having a non-array param that can be:\n\n  enabled_apis \u003d\u003e \u0027ec2,osapi\u0027\n\nSo we have to maintain them at least one release.\nWhat we can do is, add a warning to deprecate the non-array parameter and transform it in an array in the next cycle so we will drop this code later and our users will have time to update their composition layer.","commit_id":"2dce27b793ff22c2a616a5b41599e826fe6df8af"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47a5f9c44500c0a7a26b4dc72ea625b140596f3f","unresolved":false,"context_lines":[{"line_number":249,"context_line":"    # if running evenlet, we use the original puppet parameter"},{"line_number":250,"context_line":"    # so people can enable custom service names and we keep backward compatibility."},{"line_number":251,"context_line":"    $enabled_apis_real \u003d $enabled_apis"},{"line_number":252,"context_line":"    $service_enabled \u003d $enabled"},{"line_number":253,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":254,"context_line":"    include ::apache::params"},{"line_number":255,"context_line":"    # when running wsgi, we want to enable metadata in eventlet if part of enabled_apis"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_0b7b1f29","line":252,"updated":"2015-09-17 19:49:16.000000000","message":"here too ;-)","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    # when running wsgi, we want to enable metadata in eventlet if part of enabled_apis"},{"line_number":256,"context_line":"    if $enable_metadata {"},{"line_number":257,"context_line":"      $enabled_apis_real \u003d \u0027metadata\u0027"},{"line_number":258,"context_line":"      $service_enabled \u003d $enabled"},{"line_number":259,"context_line":"    } else {"},{"line_number":260,"context_line":"      # otherwise, set it to undef"},{"line_number":261,"context_line":"      $enabled_apis_real \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_d70ab389","line":258,"updated":"2015-09-17 15:43:12.000000000","message":"Maybe in another patched you can indent the \u003d","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47a5f9c44500c0a7a26b4dc72ea625b140596f3f","unresolved":false,"context_lines":[{"line_number":255,"context_line":"    # when running wsgi, we want to enable metadata in eventlet if part of enabled_apis"},{"line_number":256,"context_line":"    if $enable_metadata {"},{"line_number":257,"context_line":"      $enabled_apis_real \u003d \u0027metadata\u0027"},{"line_number":258,"context_line":"      $service_enabled \u003d $enabled"},{"line_number":259,"context_line":"    } else {"},{"line_number":260,"context_line":"      # otherwise, set it to undef"},{"line_number":261,"context_line":"      $enabled_apis_real \u003d undef"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_eb7fcb12","line":258,"in_reply_to":"ba15a1d1_d70ab389","updated":"2015-09-17 19:49:16.000000000","message":"Done","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":261,"context_line":"      $enabled_apis_real \u003d undef"},{"line_number":262,"context_line":"      # if running wsgi for ec2 and compute, and metadata disabled"},{"line_number":263,"context_line":"      # we don\u0027t need to enable nova-api service."},{"line_number":264,"context_line":"      $service_enabled \u003d false"},{"line_number":265,"context_line":"    }"},{"line_number":266,"context_line":"  } else {"},{"line_number":267,"context_line":"    fail(\u0027Invalid service_name. Either nova-api/openstack-nova-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_7a986e6a","line":264,"updated":"2015-09-17 15:43:12.000000000","message":"same here","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47a5f9c44500c0a7a26b4dc72ea625b140596f3f","unresolved":false,"context_lines":[{"line_number":261,"context_line":"      $enabled_apis_real \u003d undef"},{"line_number":262,"context_line":"      # if running wsgi for ec2 and compute, and metadata disabled"},{"line_number":263,"context_line":"      # we don\u0027t need to enable nova-api service."},{"line_number":264,"context_line":"      $service_enabled \u003d false"},{"line_number":265,"context_line":"    }"},{"line_number":266,"context_line":"  } else {"},{"line_number":267,"context_line":"    fail(\u0027Invalid service_name. Either nova-api/openstack-nova-api for running as a standalone service, or httpd for being run by a httpd server\u0027)"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_4846fd7b","line":264,"in_reply_to":"ba15a1d1_7a986e6a","updated":"2015-09-17 19:49:16.000000000","message":"Done","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    }"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"  } else {"},{"line_number":360,"context_line":"    nova_config {"},{"line_number":361,"context_line":"      \u0027keystone_authtoken/auth_host\u0027: ensure \u003d\u003e absent;"},{"line_number":362,"context_line":"      \u0027keystone_authtoken/auth_port\u0027: ensure \u003d\u003e absent;"},{"line_number":363,"context_line":"      \u0027keystone_authtoken/auth_protocol\u0027: ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_fac31e36","line":360,"updated":"2015-09-17 15:43:12.000000000","message":"Maybe in another patched you can indent the \u003d","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47a5f9c44500c0a7a26b4dc72ea625b140596f3f","unresolved":false,"context_lines":[{"line_number":357,"context_line":"    }"},{"line_number":358,"context_line":""},{"line_number":359,"context_line":"  } else {"},{"line_number":360,"context_line":"    nova_config {"},{"line_number":361,"context_line":"      \u0027keystone_authtoken/auth_host\u0027: ensure \u003d\u003e absent;"},{"line_number":362,"context_line":"      \u0027keystone_authtoken/auth_port\u0027: ensure \u003d\u003e absent;"},{"line_number":363,"context_line":"      \u0027keystone_authtoken/auth_protocol\u0027: ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_2843896d","line":360,"in_reply_to":"ba15a1d1_fac31e36","updated":"2015-09-17 19:49:16.000000000","message":"this one is out of context.","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8918bc4ab61a512de19b947bdb3493a73758fa3f","unresolved":false,"context_lines":[{"line_number":188,"context_line":"  $osapi_compute_listen_port \u003d 8774,"},{"line_number":189,"context_line":"  $metadata_listen           \u003d \u00270.0.0.0\u0027,"},{"line_number":190,"context_line":"  $metadata_listen_port      \u003d 8775,"},{"line_number":191,"context_line":"  $enabled_apis              \u003d \u0027osapi_compute,metadata\u0027,"},{"line_number":192,"context_line":"  $volume_api_class          \u003d \u0027nova.volume.cinder.API\u0027,"},{"line_number":193,"context_line":"  $use_forwarded_for         \u003d false,"},{"line_number":194,"context_line":"  $osapi_compute_workers     \u003d $::processorcount,"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"5aef4532_da7e2869","line":191,"updated":"2016-03-09 18:15:25.000000000","message":"Is there a reason we don\u0027t just switch the default to an array so we\u0027re not throwing a warning by default?","commit_id":"4342e4ed56e313f7263de3da457df76c494c1d6b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8918bc4ab61a512de19b947bdb3493a73758fa3f","unresolved":false,"context_lines":[{"line_number":250,"context_line":"    # so we can detect what is actually activated for eventlet or not."},{"line_number":251,"context_line":"    $enabled_apis_string \u003d $enabled_apis"},{"line_number":252,"context_line":"    warning(\u0027In N cycle, enabled_apis will have to be an array of APIs to enable.\u0027)"},{"line_number":253,"context_line":"    if (! empty(grep(any2array($enabled_apis_string), \u0027metadata\u0027)) and $service_name \u003d\u003d \u0027httpd\u0027) {"},{"line_number":254,"context_line":"      # metadata can\u0027t be run in wsgi so we have to enable it in eventlet anyway."},{"line_number":255,"context_line":"      $enable_metadata \u003d true"},{"line_number":256,"context_line":"    } else {"}],"source_content_type":"text/x-puppet","patch_set":28,"id":"5aef4532_dab2a8e4","line":253,"updated":"2016-03-09 18:15:25.000000000","message":"Shouldn\u0027t this check exist no matter if $enabled_apis is a string or an array?","commit_id":"4342e4ed56e313f7263de3da457df76c494c1d6b"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"d8af2657048a014719aefb35857e9984302b7e4b","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  # metadata can\u0027t be run in wsgi so we have to enable it in eventlet anyway."},{"line_number":255,"context_line":"  if (! empty(grep(any2array($enabled_apis_string), \u0027metadata\u0027)) and $service_name \u003d\u003d \u0027httpd\u0027) {"},{"line_number":256,"context_line":"    $enable_metadata \u003d true"},{"line_number":257,"context_line":"  } else {"},{"line_number":258,"context_line":"    $enable_metadata \u003d false"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"5aef4532_9428e8e3","line":255,"updated":"2016-03-09 23:15:02.000000000","message":"The \"in\" expression has been a part of the language for a while so this is probably safe to read.\n\nif \u0027metadata\u0027 in $enabled_apis and $service_name \u003d\u003d \u0027httpd\u0027) {\n\nQuick test with \"puppet apply\" indicates that this is safe and works if $enabled_apis is a string.","commit_id":"66da3a0c82647cf2543d79be1dda501f85598ada"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"41931dfc133eb644f375f4cc7acfff53aa8872c0","unresolved":false,"context_lines":[{"line_number":252,"context_line":"  }"},{"line_number":253,"context_line":""},{"line_number":254,"context_line":"  # metadata can\u0027t be run in wsgi so we have to enable it in eventlet anyway."},{"line_number":255,"context_line":"  if (! empty(grep(any2array($enabled_apis_string), \u0027metadata\u0027)) and $service_name \u003d\u003d \u0027httpd\u0027) {"},{"line_number":256,"context_line":"    $enable_metadata \u003d true"},{"line_number":257,"context_line":"  } else {"},{"line_number":258,"context_line":"    $enable_metadata \u003d false"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"5aef4532_88fba8c0","line":255,"in_reply_to":"5aef4532_9428e8e3","updated":"2016-03-09 23:25:50.000000000","message":"Done","commit_id":"66da3a0c82647cf2543d79be1dda501f85598ada"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"d8af2657048a014719aefb35857e9984302b7e4b","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    # so people can enable custom service names and we keep backward compatibility."},{"line_number":265,"context_line":"    $enabled_apis_real \u003d $enabled_apis_string"},{"line_number":266,"context_line":"    $service_enabled   \u003d $enabled"},{"line_number":267,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":268,"context_line":"    # when running wsgi, we want to enable metadata in eventlet if part of enabled_apis"},{"line_number":269,"context_line":"    if $enable_metadata {"},{"line_number":270,"context_line":"      $enabled_apis_real \u003d \u0027metadata\u0027"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"5aef4532_7476fcd7","line":267,"updated":"2016-03-09 23:15:02.000000000","message":"Does this in fact have the side effect that this only works on EL?  Isn\u0027t debian still calling is \"apache\"?","commit_id":"66da3a0c82647cf2543d79be1dda501f85598ada"},{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"a3a06034df2b4e976e9c1cefcaed88dbbcb91726","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    # so people can enable custom service names and we keep backward compatibility."},{"line_number":265,"context_line":"    $enabled_apis_real \u003d $enabled_apis_string"},{"line_number":266,"context_line":"    $service_enabled   \u003d $enabled"},{"line_number":267,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":268,"context_line":"    # when running wsgi, we want to enable metadata in eventlet if part of enabled_apis"},{"line_number":269,"context_line":"    if $enable_metadata {"},{"line_number":270,"context_line":"      $enabled_apis_real \u003d \u0027metadata\u0027"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"5aef4532_78ad21e8","line":267,"in_reply_to":"5aef4532_4824005f","updated":"2016-03-10 16:36:32.000000000","message":"Ok.  I just wasn\u0027t traveling down the rabbit hole far enough.","commit_id":"66da3a0c82647cf2543d79be1dda501f85598ada"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"41931dfc133eb644f375f4cc7acfff53aa8872c0","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    # so people can enable custom service names and we keep backward compatibility."},{"line_number":265,"context_line":"    $enabled_apis_real \u003d $enabled_apis_string"},{"line_number":266,"context_line":"    $service_enabled   \u003d $enabled"},{"line_number":267,"context_line":"  } elsif $service_name \u003d\u003d \u0027httpd\u0027 {"},{"line_number":268,"context_line":"    # when running wsgi, we want to enable metadata in eventlet if part of enabled_apis"},{"line_number":269,"context_line":"    if $enable_metadata {"},{"line_number":270,"context_line":"      $enabled_apis_real \u003d \u0027metadata\u0027"}],"source_content_type":"text/x-puppet","patch_set":33,"id":"5aef4532_4824005f","line":267,"in_reply_to":"5aef4532_7476fcd7","updated":"2016-03-09 23:25:50.000000000","message":"https://github.com/puppetlabs/puppetlabs-apache/blob/master/manifests/service.pp#L42\n\nResource name is the same everywhere.","commit_id":"66da3a0c82647cf2543d79be1dda501f85598ada"}],"manifests/params.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027, \u0027Scientific\u0027, \u0027OracleLinux\u0027: {"},{"line_number":56,"context_line":"          if (versioncmp($::operatingsystemmajrelease, \u00277\u0027) \u003c 0) {"},{"line_number":57,"context_line":"            $messagebus_service_name \u003d \u0027messagebus\u0027"},{"line_number":58,"context_line":"            $special_service_provider \u003d \u0027init\u0027"},{"line_number":59,"context_line":"          } else {"},{"line_number":60,"context_line":"            $messagebus_service_name \u003d \u0027dbus\u0027"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_97b67bf7","line":57,"updated":"2015-09-17 15:43:12.000000000","message":"Maybe in another patched you can indent the \u003d","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47a5f9c44500c0a7a26b4dc72ea625b140596f3f","unresolved":false,"context_lines":[{"line_number":54,"context_line":"        }"},{"line_number":55,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027, \u0027Scientific\u0027, \u0027OracleLinux\u0027: {"},{"line_number":56,"context_line":"          if (versioncmp($::operatingsystemmajrelease, \u00277\u0027) \u003c 0) {"},{"line_number":57,"context_line":"            $messagebus_service_name \u003d \u0027messagebus\u0027"},{"line_number":58,"context_line":"            $special_service_provider \u003d \u0027init\u0027"},{"line_number":59,"context_line":"          } else {"},{"line_number":60,"context_line":"            $messagebus_service_name \u003d \u0027dbus\u0027"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_6b8bbb1f","line":57,"in_reply_to":"ba15a1d1_97b67bf7","updated":"2015-09-17 19:49:16.000000000","message":"out of context","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":57,"context_line":"            $messagebus_service_name \u003d \u0027messagebus\u0027"},{"line_number":58,"context_line":"            $special_service_provider \u003d \u0027init\u0027"},{"line_number":59,"context_line":"          } else {"},{"line_number":60,"context_line":"            $messagebus_service_name \u003d \u0027dbus\u0027"},{"line_number":61,"context_line":"            $special_service_provider \u003d undef"},{"line_number":62,"context_line":"          }"},{"line_number":63,"context_line":"        }"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_7ac94eab","line":60,"updated":"2015-09-17 15:43:12.000000000","message":"same here","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":107,"context_line":"        \u0027Debian\u0027: {"},{"line_number":108,"context_line":"          $spicehtml5proxy_package_name \u003d \u0027nova-consoleproxy\u0027"},{"line_number":109,"context_line":"          $spicehtml5proxy_service_name \u003d \u0027nova-spicehtml5proxy\u0027"},{"line_number":110,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-consoleproxy\u0027"},{"line_number":111,"context_line":"          # Use default provider on Debian"},{"line_number":112,"context_line":"          $special_service_provider \u003d undef"},{"line_number":113,"context_line":"          $nova_log_group               \u003d \u0027nova\u0027"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"ba15a1d1_5ac32a89","line":110,"updated":"2015-09-17 15:43:12.000000000","message":"same here","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":7423,"name":"Cody Herriges","email":"cody@herriges.org","username":"ody"},"change_message_id":"fcfb039484bbc98d1f1fb330fd1660f59b04a364","unresolved":false,"context_lines":[{"line_number":100,"context_line":") {"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  include ::nova::api"},{"line_number":103,"context_line":"  include ::nova::params"},{"line_number":104,"context_line":"  include ::apache"},{"line_number":105,"context_line":"  include ::apache::mod::wsgi"},{"line_number":106,"context_line":"  if $ssl {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_f972ac48","line":103,"updated":"2015-09-15 20:49:21.000000000","message":"I\u0027d argue that someone MUST declare this classes before they declare nova::wsgi::apache and it is better to fail the catalog with a \"if ! defined(Class[::nova::api]\" check if they haven\u0027t.  With classes declared here if a person uses the \"class {}\" syntax for declaring either of these after declaring this class, they\u0027ll get a duplicate resource definition error.  Plus, declaring nova::params here is unneeded since we can guarantee it is declared since nova::api inherits it.","commit_id":"2dce27b793ff22c2a616a5b41599e826fe6df8af"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"12679319c0ce9bea2e0baf19a308718caa22eee0","unresolved":false,"context_lines":[{"line_number":100,"context_line":") {"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  include ::nova::api"},{"line_number":103,"context_line":"  include ::nova::params"},{"line_number":104,"context_line":"  include ::apache"},{"line_number":105,"context_line":"  include ::apache::mod::wsgi"},{"line_number":106,"context_line":"  if $ssl {"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"ba15a1d1_e4762a05","line":103,"in_reply_to":"ba15a1d1_f972ac48","updated":"2015-09-17 14:45:06.000000000","message":"Done","commit_id":"2dce27b793ff22c2a616a5b41599e826fe6df8af"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"5aa536b9b0ea3338af843650ce4441feea47fa3d","unresolved":false,"context_lines":[{"line_number":105,"context_line":"    fail(\u0027::nova::api class must be declared in composition layer.\u0027)"},{"line_number":106,"context_line":"  }"},{"line_number":107,"context_line":""},{"line_number":108,"context_line":"  if $::nova::api::enable_compute {"},{"line_number":109,"context_line":"    ::openstacklib::wsgi::apache { \u0027nova_api_wsgi\u0027:"},{"line_number":110,"context_line":"      bind_host           \u003d\u003e $bind_host,"},{"line_number":111,"context_line":"      bind_port           \u003d\u003e $api_port,"}],"source_content_type":"text/x-puppet","patch_set":27,"id":"5aef4532_d7e4d13c","line":108,"range":{"start_line":108,"start_character":19,"end_line":108,"end_character":33},"updated":"2016-03-07 15:13:25.000000000","message":"Why do you check enable_compute here?","commit_id":"bda99738ec585b9cadec739d85e2f73d7821c898"}],"spec/acceptance/basic_nova_spec.rb":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"646e0164263966033d84ab5026d388ef402a7c16","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      pp\u003d \u003c\u003c-EOS"},{"line_number":9,"context_line":"      Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"      # make sure apache is stopped before ceilometer-api eventlet"},{"line_number":12,"context_line":"      # in case of wsgi was run before"},{"line_number":13,"context_line":"      class { \u0027::apache\u0027:"},{"line_number":14,"context_line":"        service_ensure \u003d\u003e \u0027stopped\u0027,"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"ba15a1d1_a01c45c2","line":11,"updated":"2015-09-21 08:34:40.000000000","message":"Should it be nova-api?","commit_id":"964ad2e73ecedc95025f714c38c86fd6cea9f1c9"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e53a2839040bf713c54de6561e5aaf37cfbd748c","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      pp\u003d \u003c\u003c-EOS"},{"line_number":9,"context_line":"      Exec { logoutput \u003d\u003e \u0027on_failure\u0027 }"},{"line_number":10,"context_line":""},{"line_number":11,"context_line":"      # make sure apache is stopped before ceilometer-api eventlet"},{"line_number":12,"context_line":"      # in case of wsgi was run before"},{"line_number":13,"context_line":"      class { \u0027::apache\u0027:"},{"line_number":14,"context_line":"        service_ensure \u003d\u003e \u0027stopped\u0027,"}],"source_content_type":"text/x-ruby","patch_set":16,"id":"ba15a1d1_07d6e44e","line":11,"in_reply_to":"ba15a1d1_a01c45c2","updated":"2015-09-23 16:08:02.000000000","message":"yes thanks","commit_id":"964ad2e73ecedc95025f714c38c86fd6cea9f1c9"}],"spec/classes/nova_wsgi_apache_spec.rb":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":200,"context_line":"      {"},{"line_number":201,"context_line":"        :httpd_service_name \u003d\u003e \u0027httpd\u0027,"},{"line_number":202,"context_line":"        :httpd_ports_file   \u003d\u003e \u0027/etc/httpd/conf/ports.conf\u0027,"},{"line_number":203,"context_line":"        :wsgi_script_path   \u003d\u003e \u0027/var/www/cgi-bin/nova\u0027,"},{"line_number":204,"context_line":"        :api_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/site-packages/nova/wsgi/nova-api.py\u0027,"},{"line_number":205,"context_line":"        :ec2_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/site-packages/nova/wsgi/nova-ec2-api.py\u0027,"},{"line_number":206,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"ba15a1d1_773ac7e8","line":203,"updated":"2015-09-17 15:43:12.000000000","message":"Maybe in another patched you can indent the \u003d","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47a5f9c44500c0a7a26b4dc72ea625b140596f3f","unresolved":false,"context_lines":[{"line_number":200,"context_line":"      {"},{"line_number":201,"context_line":"        :httpd_service_name \u003d\u003e \u0027httpd\u0027,"},{"line_number":202,"context_line":"        :httpd_ports_file   \u003d\u003e \u0027/etc/httpd/conf/ports.conf\u0027,"},{"line_number":203,"context_line":"        :wsgi_script_path   \u003d\u003e \u0027/var/www/cgi-bin/nova\u0027,"},{"line_number":204,"context_line":"        :api_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/site-packages/nova/wsgi/nova-api.py\u0027,"},{"line_number":205,"context_line":"        :ec2_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/site-packages/nova/wsgi/nova-ec2-api.py\u0027,"},{"line_number":206,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"ba15a1d1_eb982b7a","line":203,"in_reply_to":"ba15a1d1_773ac7e8","updated":"2015-09-17 19:49:16.000000000","message":"Done","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"c812a8c50fb08285db5730cf8ea0fecb351264a2","unresolved":false,"context_lines":[{"line_number":222,"context_line":"      {"},{"line_number":223,"context_line":"        :httpd_service_name \u003d\u003e \u0027apache2\u0027,"},{"line_number":224,"context_line":"        :httpd_ports_file   \u003d\u003e \u0027/etc/apache2/ports.conf\u0027,"},{"line_number":225,"context_line":"        :wsgi_script_path   \u003d\u003e \u0027/usr/lib/cgi-bin/nova\u0027,"},{"line_number":226,"context_line":"        :api_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/dist-packages/nova/wsgi/nova-api.py\u0027,"},{"line_number":227,"context_line":"        :ec2_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/dist-packages/nova/wsgi/nova-ec2-api.py\u0027,"},{"line_number":228,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"ba15a1d1_f72ed7a3","line":225,"updated":"2015-09-17 15:43:12.000000000","message":"Same here","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"47a5f9c44500c0a7a26b4dc72ea625b140596f3f","unresolved":false,"context_lines":[{"line_number":222,"context_line":"      {"},{"line_number":223,"context_line":"        :httpd_service_name \u003d\u003e \u0027apache2\u0027,"},{"line_number":224,"context_line":"        :httpd_ports_file   \u003d\u003e \u0027/etc/apache2/ports.conf\u0027,"},{"line_number":225,"context_line":"        :wsgi_script_path   \u003d\u003e \u0027/usr/lib/cgi-bin/nova\u0027,"},{"line_number":226,"context_line":"        :api_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/dist-packages/nova/wsgi/nova-api.py\u0027,"},{"line_number":227,"context_line":"        :ec2_wsgi_script_source \u003d\u003e \u0027/usr/lib/python2.7/dist-packages/nova/wsgi/nova-ec2-api.py\u0027,"},{"line_number":228,"context_line":"      }"}],"source_content_type":"text/x-ruby","patch_set":13,"id":"ba15a1d1_0b947f40","line":225,"in_reply_to":"ba15a1d1_f72ed7a3","updated":"2015-09-17 19:49:16.000000000","message":"Done","commit_id":"70a58aa8fb65da56d13a83e9e1947da1535f501c"}]}