)]}'
{"manifests/extensions.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b185152b3b7f55cb250e1815331f07ee4ffb4492","unresolved":false,"context_lines":[{"line_number":14,"context_line":") {"},{"line_number":15,"context_line":""},{"line_number":16,"context_line":"  if $fping {"},{"line_number":17,"context_line":"    ensure_packages([\u0027fping\u0027])"},{"line_number":18,"context_line":"  }"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba15a1d1_d86f17c2","line":17,"updated":"2015-09-18 15:43:48.000000000","message":"It might be better to follow more of the pattern that we use for configuration settings.  For example:\n\n  ensure_packages([\u0027fping\u0027], { ensure \u003d\u003e $fping })\n\nWe wouldn\u0027t need the if clause and the $fping parameter would be like present/absent/undef.\n\nThat way we could in theory support the removal of something.","commit_id":"add4b31853196cd5ffffa7ecacff07497b3f72c6"}]}