)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9d2cbe3b05fe733ed6852573dbd20e9c7fa69597","unresolved":false,"context_lines":[{"line_number":199,"context_line":"    nova_config {"},{"line_number":200,"context_line":"      \u0027libvirt/cpu_model\u0027: value \u003d\u003e $libvirt_cpu_model;"},{"line_number":201,"context_line":"    }"},{"line_number":202,"context_line":"  } else {"},{"line_number":203,"context_line":"    warning(\u0027$libvirt_cpu_model requires that $libvirt_cpu_mode \u003d\u003e \"custom\" and will be removed\u0027)"},{"line_number":204,"context_line":"    nova_config {"},{"line_number":205,"context_line":"      \u0027libvirt/cpu_model\u0027: ensure \u003d\u003e absent;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"fa1b9901_ab81afc4","line":202,"updated":"2015-08-21 12:55:31.000000000","message":"your logic is not correct, because it will add a new warning by default.\n\nSee http://logs.openstack.org/42/214542/3/check/gate-puppet-nova-puppet-beaker-rspec-dsvm-centos7/00f9719/console.html#_2015-08-21_09_17_31_875\n\nI would rather test the value only if it\u0027s defined.","commit_id":"c4a683143cc989ec63ac5d601319bffaa722a5bd"},{"author":{"_account_id":9448,"name":"Ivan Ponomarev","email":"iponomarev@mirantis.com","username":"iponomarev"},"change_message_id":"4f0b3ad9e156857ebc0d262b8ff34e4240040f54","unresolved":false,"context_lines":[{"line_number":204,"context_line":"      \u0027libvirt/cpu_model\u0027: ensure \u003d\u003e absent;"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"    if $libvirt_cpu_model {"},{"line_number":207,"context_line":"      warning(\u0027$libvirt_cpu_model requires that $libvirt_cpu_mode \u003d\u003e \"custom\" and will be ignored\u0027)"},{"line_number":208,"context_line":"    }"},{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa1b9901_e263f3db","line":207,"updated":"2015-08-24 15:16:34.000000000","message":"$libvirt_cpu_mode -\u003e $libvirt_cpu_mode_real","commit_id":"708d778812f8a57315f4e05b990b3782d2e4c69c"},{"author":{"_account_id":9448,"name":"Ivan Ponomarev","email":"iponomarev@mirantis.com","username":"iponomarev"},"change_message_id":"ec2196f75d660f2483163f37bb551e3d8e05c179","unresolved":false,"context_lines":[{"line_number":204,"context_line":"      \u0027libvirt/cpu_model\u0027: ensure \u003d\u003e absent;"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"    if $libvirt_cpu_model {"},{"line_number":207,"context_line":"      warning(\u0027$libvirt_cpu_model requires that $libvirt_cpu_mode \u003d\u003e \"custom\" and will be ignored\u0027)"},{"line_number":208,"context_line":"    }"},{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa1b9901_53bb5ee5","line":207,"in_reply_to":"fa1b9901_821a3716","updated":"2015-08-25 14:34:24.000000000","message":"Done","commit_id":"708d778812f8a57315f4e05b990b3782d2e4c69c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"743f47cf1660f42412868f1f0fdaf32db2614db5","unresolved":false,"context_lines":[{"line_number":204,"context_line":"      \u0027libvirt/cpu_model\u0027: ensure \u003d\u003e absent;"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"    if $libvirt_cpu_model {"},{"line_number":207,"context_line":"      warning(\u0027$libvirt_cpu_model requires that $libvirt_cpu_mode \u003d\u003e \"custom\" and will be ignored\u0027)"},{"line_number":208,"context_line":"    }"},{"line_number":209,"context_line":"  }"},{"line_number":210,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa1b9901_821a3716","line":207,"in_reply_to":"fa1b9901_e263f3db","updated":"2015-08-24 15:19:23.000000000","message":"This is not evaluated so this is an explanation with the parameter names. It should not be the _real version.","commit_id":"708d778812f8a57315f4e05b990b3782d2e4c69c"}]}