)]}'
{"manifests/init.pp":[{"author":{"_account_id":9410,"name":"Yanis Guenane","email":"yguenane@redhat.com","username":"yguenane"},"change_message_id":"b40b4f63381ddc72483ddd33f332ff2c3fe01fe9","unresolved":false,"context_lines":[{"line_number":604,"context_line":"    nova_config { \u0027DEFAULT/log_dir\u0027: ensure \u003d\u003e absent;}"},{"line_number":605,"context_line":"  }"},{"line_number":606,"context_line":""},{"line_number":607,"context_line":"  if ! empty($notification_driver) {"},{"line_number":608,"context_line":"    $notification_driver_real \u003d is_string($notification_driver) ? {"},{"line_number":609,"context_line":"      true    \u003d\u003e $notification_driver,"},{"line_number":610,"context_line":"      default \u003d\u003e join($notification_driver, \u0027,\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"ba15a1d1_3fa059f4","line":607,"updated":"2015-09-14 09:12:07.000000000","message":"I think the logic implemented here can be even simpler.\n\n$notification_driver \u003d undef,\n\n...\n\nif $notifications_driver {\n\nnova_config {\u0027DEFAULT/notification_driver\u0027: value \u003d\u003e join(any2array($notification_driver), \u0027,\u0027)}\n\n} else {\n\nnova_config {\u0027DEFAULT/notification_driver\u0027: ensure \u003d\u003e absent}\n\n}\n\nThis would remain backward compatible with what was in place before and will prepare the way to the move to \u0027\u003cSERVICE DEFAULT\u003e\u0027","commit_id":"351e7443d96f9298a618a1fbacbba399bb8ff62d"}]}