)]}'
{"manifests/network.pp":[{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"20ca2f6ff6c5ebf38801a8d22e8e493a564bfa03","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # because nova_network provider uses nova client, so it assumes"},{"line_number":128,"context_line":"    # that nova-network service is running already"},{"line_number":129,"context_line":"    if $create_networks and $enabled {"},{"line_number":130,"context_line":"      nova::manage::network { \u0027nova-vm-net\u0027:"},{"line_number":131,"context_line":"        network       \u003d\u003e $fixed_range,"},{"line_number":132,"context_line":"        num_networks  \u003d\u003e $num_networks,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a2fa921_024ac0c5","line":129,"updated":"2015-10-06 15:17:12.000000000","message":"Maybe I\u0027m wrong.. but enable is like \"the service is installed\"?\nMaybe you can use service_ensure (https://github.com/openstack/puppet-nova/blob/24f8b79c5c670d5569ef020ee50eed8e8711499d/manifests/generic_service.pp)","commit_id":"b5e67db3d72aa4dd99d97fbea08c75b82d9ee59a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"23f4097cf26efe670905ddc1ab4b8411e3b8583d","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # because nova_network provider uses nova client, so it assumes"},{"line_number":128,"context_line":"    # that nova-network service is running already"},{"line_number":129,"context_line":"    if $create_networks and $enabled {"},{"line_number":130,"context_line":"      nova::manage::network { \u0027nova-vm-net\u0027:"},{"line_number":131,"context_line":"        network       \u003d\u003e $fixed_range,"},{"line_number":132,"context_line":"        num_networks  \u003d\u003e $num_networks,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a2fa921_cf9ab014","line":129,"in_reply_to":"7a2fa921_024ac0c5","updated":"2015-10-06 15:55:39.000000000","message":"lury, take a look on 120 line.\n\n\u0027$enabled\u0027:\n   nova::generic_service { \u0027network\u0027:\n     enabled        \u003d\u003e $enabled,\n     ...\n   }\n\nSo, we can create networks when nova-network is running ($enabled \u003d true).\n\nOr i misunderstood your question :)","commit_id":"b5e67db3d72aa4dd99d97fbea08c75b82d9ee59a"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"2d414e50b6fc974605c101e20eed7dda9a0b4161","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # because nova_network provider uses nova client, so it assumes"},{"line_number":128,"context_line":"    # that nova-network service is running already"},{"line_number":129,"context_line":"    if $create_networks and $enabled {"},{"line_number":130,"context_line":"      nova::manage::network { \u0027nova-vm-net\u0027:"},{"line_number":131,"context_line":"        network       \u003d\u003e $fixed_range,"},{"line_number":132,"context_line":"        num_networks  \u003d\u003e $num_networks,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a2fa921_a512f3b2","line":129,"in_reply_to":"7a2fa921_cf9ab014","updated":"2015-10-06 16:29:35.000000000","message":"Sure ;) I\u0027ve missed that sorry","commit_id":"b5e67db3d72aa4dd99d97fbea08c75b82d9ee59a"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49d4f5763a0ad49c9690cfc88a402196283d11aa","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # because nova_network provider uses nova client, so it assumes"},{"line_number":128,"context_line":"    # that nova-network service is running already"},{"line_number":129,"context_line":"    if $create_networks and $enabled {"},{"line_number":130,"context_line":"      nova::manage::network { \u0027nova-vm-net\u0027:"},{"line_number":131,"context_line":"        network       \u003d\u003e $fixed_range,"},{"line_number":132,"context_line":"        num_networks  \u003d\u003e $num_networks,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a2fa921_f8a062a1","line":129,"updated":"2015-10-07 18:25:49.000000000","message":"It would be beneficial to throw a warning indicating that we aren\u0027t actually creating the network if $create_networks is true and $enabled is false.  A user might do this and wonder why their networks are not created.","commit_id":"ed2d72d9e61e0d848d389adf02b4ea11bb9f171a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"14e8f80953ff85ba77f7555b88c539b805476b5d","unresolved":false,"context_lines":[{"line_number":126,"context_line":""},{"line_number":127,"context_line":"    # because nova_network provider uses nova client, so it assumes"},{"line_number":128,"context_line":"    # that nova-network service is running already"},{"line_number":129,"context_line":"    if $create_networks and $enabled {"},{"line_number":130,"context_line":"      nova::manage::network { \u0027nova-vm-net\u0027:"},{"line_number":131,"context_line":"        network       \u003d\u003e $fixed_range,"},{"line_number":132,"context_line":"        num_networks  \u003d\u003e $num_networks,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a2fa921_dd49b161","line":129,"in_reply_to":"7a2fa921_f8a062a1","updated":"2015-10-08 10:34:01.000000000","message":"Done","commit_id":"ed2d72d9e61e0d848d389adf02b4ea11bb9f171a"}]}