)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f96e518b9039fbd2d0429c851f8d2a84378288bb","unresolved":false,"context_lines":[{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  # libvirt_vif_driver param should be exposed only if it is set,"},{"line_number":268,"context_line":"  # otherwise it should be commented out"},{"line_number":269,"context_line":"  if $libvirt_vif_driver !\u003d undef {"},{"line_number":270,"context_line":"    nova_config {"},{"line_number":271,"context_line":"      \u0027libvirt/libvirt_vif_driver\u0027: value \u003d\u003e $libvirt_vif_driver;"},{"line_number":272,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a2fa921_86570857","line":269,"updated":"2015-10-10 02:54:53.000000000","message":"undef is alraedy a boolean so you don\u0027t need the !\u003d undef.\nJust if libvirt_vif_driver {\n}\nis enough.","commit_id":"cd56257e742b403c8c3e054878595d02822547fb"},{"author":{"_account_id":6525,"name":"Gilles Dubreuil","email":"gilles@redhat.com","username":"q-1illes-a"},"change_message_id":"bafb3f69cfb89913804cd022e4c7f4863d45b12f","unresolved":false,"context_lines":[{"line_number":264,"context_line":"    }"},{"line_number":265,"context_line":"  }"},{"line_number":266,"context_line":""},{"line_number":267,"context_line":"  # libvirt_vif_driver param should be exposed only if it is set,"},{"line_number":268,"context_line":"  # otherwise it should be commented out"},{"line_number":269,"context_line":"  if $libvirt_vif_driver {"},{"line_number":270,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a2fa921_85f4cc87","line":267,"updated":"2015-10-12 04:54:58.000000000","message":"The comments are not necessary,  the code is already explicit.\nEffectively it doubles up with the code.\nAlso down the road, if the code changes then the comments would have to be changed too and if not then it becomes confusing.","commit_id":"a89b9795401e9106823aa73b5ae5f94b669ccd97"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"66a5c8e88c9bcc6a746869aacf3147b687f4b3c2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"#   (optional) Compute driver."},{"line_number":89,"context_line":"#   Defaults to \u0027libvirt.LibvirtDriver\u0027"},{"line_number":90,"context_line":"#"},{"line_number":91,"context_line":"# [*libvirt_vif_driver*]"},{"line_number":92,"context_line":"#   (optional) The libvirt VIF driver to configure the VIFs"},{"line_number":93,"context_line":"#   based on the network configuration."},{"line_number":94,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a2ca52d_7248515c","line":91,"updated":"2015-10-13 13:05:15.000000000","message":"the parameter already exist in manifests/compute/neutron.pp","commit_id":"37f487d18b56a0637b7c0159deb57a1db7e57b97"}]}