)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0c25436fb8d6c383504847a47b194c9b18c1bb30","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"the value of `rbd.keyring` is protected by `creates` defined in"},{"line_number":10,"context_line":"`get-or-set virsh secret`, with this changes, allowing system to"},{"line_number":11,"context_line":"detect if the value of `rbd.keyring` is chnaged or not. If it\u0027s"},{"line_number":12,"context_line":"changed puppet will regenerated with required changes, or puppet"},{"line_number":13,"context_line":"will leave it untouched."},{"line_number":14,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"3a29b11f_e4bf94ce","line":11,"updated":"2015-10-19 16:08:17.000000000","message":"typo: changed","commit_id":"9599df72bdd08068915a462b9d4d909cf89ac224"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"8277a9bd7815c92a82dafc90330d412ce37a04f3","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update rbd.keyring value if changed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The value of `rbd.keyring` is protected by `creates` defined in"},{"line_number":10,"context_line":"`get-or-set virsh secret`; this change allows puppet to regenerate"},{"line_number":11,"context_line":"the secret or update its key if they change."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"bacf61ea_986d93ce","line":9,"updated":"2016-08-01 15:52:10.000000000","message":"creates --\u003e \"unless\"","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"03b8f9ae539ae5211312535b3bc017ddaf3ccd88","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Update rbd.keyring value if changed"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The value of `rbd.keyring` is protected by `creates` defined in"},{"line_number":10,"context_line":"`get-or-set virsh secret`; this change allows puppet to regenerate"},{"line_number":11,"context_line":"the secret or update its key if they change."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":18,"id":"bacf61ea_7bb89975","line":9,"in_reply_to":"bacf61ea_986d93ce","updated":"2016-08-01 16:20:52.000000000","message":"I think this is correct, before the change it was protected by \u0027creates\u0027","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"}],"manifests/compute/rbd.pp":[{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5293a0b2e10c29a1a430a861d1d5f98e12eddfa4","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":85,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":86,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":87,"context_line":"      onlyif  \u003d\u003e \"test -z \\\"$(virsh secret-dumpxml --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null | grep -w \\\"${rbd_keyring}\\\")\\\"\","},{"line_number":88,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":89,"context_line":"    } -\u003e"},{"line_number":90,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a2fa921_dabc1abd","line":87,"updated":"2015-10-09 11:05:57.000000000","message":"what we aim at here is to compare the existing key stored in the virsh secret with the new key which we save in $libvirt_rbd_secret_key\n\nyou can use \"virsh secret-get-value\" to get the secret key base64 encoded; that should be compared with a base64 encoded version of the key coming as $libvirt_rbd_secret_key","commit_id":"882dd580ea981e32cbea0f5c36372965b9e63980"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"383830bd108dc8e0243254c4f88ed8b934308af1","unresolved":false,"context_lines":[{"line_number":84,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":85,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":86,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":87,"context_line":"      onlyif  \u003d\u003e \"test -z \\\"$(virsh secret-dumpxml --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null | grep -w \\\"${rbd_keyring}\\\")\\\"\","},{"line_number":88,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":89,"context_line":"    } -\u003e"},{"line_number":90,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a2fa921_da1e5a6f","line":87,"in_reply_to":"7a2fa921_dabc1abd","updated":"2015-10-09 11:17:27.000000000","message":"working on that, thanks","commit_id":"882dd580ea981e32cbea0f5c36372965b9e63980"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c3565bca1a29a01abb5b6880ba758a78dfb6b8b6","unresolved":false,"context_lines":[{"line_number":90,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":91,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":92,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":93,"context_line":"      onlyif  \u003d\u003e \"test \\\"${libvirt_key}\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\","},{"line_number":94,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":95,"context_line":"    } -\u003e"},{"line_number":96,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a29b11f_845820fc","line":93,"updated":"2015-10-19 16:04:54.000000000","message":"secret-get-value is returning base64 encoded representation, we should compare with base64 encoded version of libvirt_key","commit_id":"9599df72bdd08068915a462b9d4d909cf89ac224"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"2774ab7f2a98dc7b8b9260a33ca9a05540040527","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":92,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":93,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":94,"context_line":"      onlyif  \u003d\u003e \"test \\\"${libvirt_key}\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\","},{"line_number":95,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":96,"context_line":"    } -\u003e"},{"line_number":97,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a7b0d38_f9aacc6f","line":94,"updated":"2015-12-23 19:21:19.000000000","message":"secret-get-value will return a base64 encoded representation of the key, we should compare it with a base64 encoded version of libvirt_key or they will accidentally always look different","commit_id":"da341a782c2e5b85095db05c4d42c4311ac2bfaa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"957ef371144bdaa6817a7f1db8bd35b8e6e0de85","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":92,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":93,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":94,"context_line":"      onlyif  \u003d\u003e \"test \\\"${libvirt_key}\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\","},{"line_number":95,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":96,"context_line":"    } -\u003e"},{"line_number":97,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa69d971_6a50d3d4","line":94,"in_reply_to":"1a7b0d38_4adaff79","updated":"2016-01-05 15:24:36.000000000","message":"that\u0027s the problem, $libvirt_key is not base64 encoded because get-key returns the actual key, not the base64 encoded representation of the key ... so despite being the same key it will differ from the output of sectet-get-value which returns instead the base64 encoded representation of the key","commit_id":"da341a782c2e5b85095db05c4d42c4311ac2bfaa"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"dca7ad21955b6bda5edcb40e4616f44dad985f06","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":92,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":93,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":94,"context_line":"      onlyif  \u003d\u003e \"test \\\"${libvirt_key}\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\","},{"line_number":95,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":96,"context_line":"    } -\u003e"},{"line_number":97,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1a7b0d38_4adaff79","line":94,"in_reply_to":"1a7b0d38_f9aacc6f","updated":"2015-12-25 01:41:51.000000000","message":"sorry for the late reply,\nbut I think I didn\u0027t get your point,\n\nat the line: 76-81, $libvirt_key has already assign to the base64 encoded string return from \"ceph auth get-key XXX\", or user pre-defined input.\n\ndid i miss something?","commit_id":"da341a782c2e5b85095db05c4d42c4311ac2bfaa"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"b4699d0088c78e1aa0dc8547da837d83b2a29a49","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":92,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":93,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":94,"context_line":"      onlyif  \u003d\u003e \"test \\\"${libvirt_key}\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\","},{"line_number":95,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":96,"context_line":"    } -\u003e"},{"line_number":97,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"fa69d971_877a8722","line":94,"in_reply_to":"fa69d971_6a50d3d4","updated":"2016-01-07 08:19:17.000000000","message":"are you trying to say \"$libvirt_key\" should be set as the value of the command `$ base64 \u003c\u003c\u003c $(ceph auth get-key ${rbd_keyring})` ...?","commit_id":"da341a782c2e5b85095db05c4d42c4311ac2bfaa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"86a4bebd8e71b48b7607606dc60f1d5456eea16b","unresolved":false,"context_lines":[{"line_number":91,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":92,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":93,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":94,"context_line":"      onlyif  \u003d\u003e \"test \\\"${libvirt_key}\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\","},{"line_number":95,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":96,"context_line":"    } -\u003e"},{"line_number":97,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"da6ed579_1b8986c9","line":94,"in_reply_to":"fa69d971_877a8722","updated":"2016-01-14 02:11:56.000000000","message":"not exactly, we can\u0027t touch the ${libvirt_key} var itself, more like:\n\n  onlyif \u003d\u003e \"test \\\"$(echo ${libvirt_key} | base64)\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\",","commit_id":"da341a782c2e5b85095db05c4d42c4311ac2bfaa"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"b471f0774541fc1096131615799ffd55aa14e7fd","unresolved":false,"context_lines":[{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    exec { \u0027undefine-if-changed virsh secret\u0027:"},{"line_number":110,"context_line":"      path    \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":111,"context_line":"      command \u003d\u003e \"virsh secret-undefine --secret ${libvirt_rbd_secret_uuid} \u0026\u0026 rm -f /etc/nova/virsh.secret\","},{"line_number":112,"context_line":"      onlyif  \u003d\u003e \"test \\\"${libvirt_key}\\\" !\u003d \\\"$(virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null)\\\"\","},{"line_number":113,"context_line":"      require \u003d\u003e File[\u0027/etc/nova/secret.xml\u0027]"},{"line_number":114,"context_line":"    } -\u003e"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"bacf61ea_02b23794","line":111,"updated":"2016-07-29 09:29:48.000000000","message":"undefine fails on first run","commit_id":"ac8aa65ff3cd808b49dcdad6367467feb4511507"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1256ad273def544cfd038e0cc0373a5b665efeb1","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      unless  \u003d\u003e \"virsh secret-get-value --secret ${libvirt_rbd_secret_uuid} 2\u003e/dev/null | grep \\\"${libvirt_key}\\\"\","},{"line_number":113,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"},{"line_number":114,"context_line":"    } -\u003e"},{"line_number":115,"context_line":"    exec { \u0027get-or-set virsh secret\u0027:"},{"line_number":116,"context_line":"      command \u003d\u003e \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":117,"context_line":"      creates \u003d\u003e \u0027/etc/nova/virsh.secret\u0027,"},{"line_number":118,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"bacf61ea_f6c945ad","line":115,"updated":"2016-08-01 14:43:18.000000000","message":"actually, as suggested by the title this is idempotent","commit_id":"347ac2cd8d3426306f1caec30738f5af4e5ef933"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1256ad273def544cfd038e0cc0373a5b665efeb1","unresolved":false,"context_lines":[{"line_number":119,"context_line":"    }"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    exec { \u0027set-secret-value virsh\u0027:"},{"line_number":122,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-set-value --secret ${libvirt_rbd_secret_uuid} --base64 ${libvirt_key}\","},{"line_number":123,"context_line":"      unless  \u003d\u003e \"/usr/bin/virsh secret-get-value ${libvirt_rbd_secret_uuid}\","},{"line_number":124,"context_line":"      require \u003d\u003e Exec[\u0027get-or-set virsh secret\u0027],"},{"line_number":125,"context_line":"      before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"bacf61ea_16717976","line":122,"updated":"2016-08-01 14:43:18.000000000","message":"this is idempotent too","commit_id":"347ac2cd8d3426306f1caec30738f5af4e5ef933"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"1256ad273def544cfd038e0cc0373a5b665efeb1","unresolved":false,"context_lines":[{"line_number":120,"context_line":""},{"line_number":121,"context_line":"    exec { \u0027set-secret-value virsh\u0027:"},{"line_number":122,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-set-value --secret ${libvirt_rbd_secret_uuid} --base64 ${libvirt_key}\","},{"line_number":123,"context_line":"      unless  \u003d\u003e \"/usr/bin/virsh secret-get-value ${libvirt_rbd_secret_uuid}\","},{"line_number":124,"context_line":"      require \u003d\u003e Exec[\u0027get-or-set virsh secret\u0027],"},{"line_number":125,"context_line":"      before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"},{"line_number":126,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"bacf61ea_766c359c","line":123,"updated":"2016-08-01 14:43:18.000000000","message":"we just need to fix the unless","commit_id":"347ac2cd8d3426306f1caec30738f5af4e5ef933"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"8277a9bd7815c92a82dafc90330d412ce37a04f3","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      command \u003d\u003e \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":105,"context_line":"      unless \u003d\u003e \u0027/usr/bin/virsh secret-list | grep ${libvirt_rbd_secret_uuid}\u0027,"},{"line_number":106,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    if $libvirt_rbd_secret_key {"},{"line_number":110,"context_line":"      $libvirt_key \u003d $libvirt_rbd_secret_key"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_359bd019","line":107,"updated":"2016-08-01 15:52:10.000000000","message":"my original intention is to make sure it is \"undefined\" before \"define\". secret-define does not allow an \"value-update-if-changed\", that\u0027s why I create a new \u0027exec\u0027 before.","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"3bb3a6306530626967d9fbd69634ba5d6018a8c1","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      command \u003d\u003e \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":105,"context_line":"      unless \u003d\u003e \u0027/usr/bin/virsh secret-list | grep ${libvirt_rbd_secret_uuid}\u0027,"},{"line_number":106,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    if $libvirt_rbd_secret_key {"},{"line_number":110,"context_line":"      $libvirt_key \u003d $libvirt_rbd_secret_key"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_ac1e5909","line":107,"in_reply_to":"bacf61ea_06f2e499","updated":"2016-08-01 17:05:25.000000000","message":"I\u0027m failing because \"@rbd_keyring\" changed, but keep the \"@libvirt_rbd_secret_uuid\" the same.","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"03b8f9ae539ae5211312535b3bc017ddaf3ccd88","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      command \u003d\u003e \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":105,"context_line":"      unless \u003d\u003e \u0027/usr/bin/virsh secret-list | grep ${libvirt_rbd_secret_uuid}\u0027,"},{"line_number":106,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    if $libvirt_rbd_secret_key {"},{"line_number":110,"context_line":"      $libvirt_key \u003d $libvirt_rbd_secret_key"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_1b06bd1f","line":107,"in_reply_to":"bacf61ea_359bd019","updated":"2016-08-01 16:20:52.000000000","message":"I tried it locally, it\u0027s safe to run multiple times, it won\u0027t destroy the pre-existing secret if already defined","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"66f2e9b1c8e9416d86220faa489a0b8e6a956a5f","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      command \u003d\u003e \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":105,"context_line":"      unless \u003d\u003e \u0027/usr/bin/virsh secret-list | grep ${libvirt_rbd_secret_uuid}\u0027,"},{"line_number":106,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    if $libvirt_rbd_secret_key {"},{"line_number":110,"context_line":"      $libvirt_key \u003d $libvirt_rbd_secret_key"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_d8d42bed","line":107,"in_reply_to":"bacf61ea_359bd019","updated":"2016-08-01 15:54:26.000000000","message":"if the UUID is listed in secret-list, but the value is not desirable, it could not been detected by puppet.","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"a16d82e1931fc44c9f1d0a7e57c388c63d295bb4","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      command \u003d\u003e \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":105,"context_line":"      unless \u003d\u003e \u0027/usr/bin/virsh secret-list | grep ${libvirt_rbd_secret_uuid}\u0027,"},{"line_number":106,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    if $libvirt_rbd_secret_key {"},{"line_number":110,"context_line":"      $libvirt_key \u003d $libvirt_rbd_secret_key"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_06f2e499","line":107,"in_reply_to":"bacf61ea_a6115854","updated":"2016-08-01 16:33:23.000000000","message":"test the command (line 115), I got \"error: internal error: a secret with UUID XXXXXXX-XXXX-XXXX-XXXX-XXXX is already defined for use with XXXX secret\"","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"03b8f9ae539ae5211312535b3bc017ddaf3ccd88","unresolved":false,"context_lines":[{"line_number":104,"context_line":"      command \u003d\u003e \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":105,"context_line":"      unless \u003d\u003e \u0027/usr/bin/virsh secret-list | grep ${libvirt_rbd_secret_uuid}\u0027,"},{"line_number":106,"context_line":"      require \u003d\u003e [File[\u0027/etc/nova/secret.xml\u0027], Service[\u0027libvirt\u0027]],"},{"line_number":107,"context_line":"    }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"    if $libvirt_rbd_secret_key {"},{"line_number":110,"context_line":"      $libvirt_key \u003d $libvirt_rbd_secret_key"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_a6115854","line":107,"in_reply_to":"bacf61ea_d8d42bed","updated":"2016-08-01 16:20:52.000000000","message":"correct, at this stage we want to see if we need to redefine the secret and we don\u0027t need to even if the key changed\n\nline 115 will refresh the key if needed","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"8277a9bd7815c92a82dafc90330d412ce37a04f3","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"    exec { \u0027set-secret-value virsh\u0027:"},{"line_number":115,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-set-value --secret ${libvirt_rbd_secret_uuid} --base64 ${libvirt_key}\","},{"line_number":116,"context_line":"      unless  \u003d\u003e \"/usr/bin/virsh secret-get-value ${libvirt_rbd_secret_uuid} | grep ${libvirt_key}\","},{"line_number":117,"context_line":"      require \u003d\u003e Exec[\u0027get-or-set virsh secret\u0027],"},{"line_number":118,"context_line":"      before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"},{"line_number":119,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_b587c0b3","line":116,"updated":"2016-08-01 15:52:10.000000000","message":"adding \"grep\" does not change the result of the \"unless\" condition.","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"a16d82e1931fc44c9f1d0a7e57c388c63d295bb4","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"    exec { \u0027set-secret-value virsh\u0027:"},{"line_number":115,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-set-value --secret ${libvirt_rbd_secret_uuid} --base64 ${libvirt_key}\","},{"line_number":116,"context_line":"      unless  \u003d\u003e \"/usr/bin/virsh secret-get-value ${libvirt_rbd_secret_uuid} | grep ${libvirt_key}\","},{"line_number":117,"context_line":"      require \u003d\u003e Exec[\u0027get-or-set virsh secret\u0027],"},{"line_number":118,"context_line":"      before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"},{"line_number":119,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_a6495833","line":116,"in_reply_to":"bacf61ea_8656d403","updated":"2016-08-01 16:33:23.000000000","message":"ok, got your point, adding grep would be better :)","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"03b8f9ae539ae5211312535b3bc017ddaf3ccd88","unresolved":false,"context_lines":[{"line_number":113,"context_line":"    }"},{"line_number":114,"context_line":"    exec { \u0027set-secret-value virsh\u0027:"},{"line_number":115,"context_line":"      command \u003d\u003e \"/usr/bin/virsh secret-set-value --secret ${libvirt_rbd_secret_uuid} --base64 ${libvirt_key}\","},{"line_number":116,"context_line":"      unless  \u003d\u003e \"/usr/bin/virsh secret-get-value ${libvirt_rbd_secret_uuid} | grep ${libvirt_key}\","},{"line_number":117,"context_line":"      require \u003d\u003e Exec[\u0027get-or-set virsh secret\u0027],"},{"line_number":118,"context_line":"      before  \u003d\u003e Anchor[\u0027nova::config::end\u0027],"},{"line_number":119,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":18,"id":"bacf61ea_8656d403","line":116,"in_reply_to":"bacf61ea_b587c0b3","updated":"2016-08-01 16:20:52.000000000","message":"shouldn\u0027t it exit with 0 only if the key is found in the output?","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"}],"spec/classes/nova_compute_rbd_spec.rb":[{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"8277a9bd7815c92a82dafc90330d412ce37a04f3","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        ])"},{"line_number":141,"context_line":"        is_expected.to contain_exec(\u0027get-or-set virsh secret\u0027).with("},{"line_number":142,"context_line":"          :command \u003d\u003e  \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":143,"context_line":"          :creates \u003d\u003e \u0027/etc/nova/virsh.secret\u0027,"},{"line_number":144,"context_line":"          :require \u003d\u003e [\u0027File[/etc/nova/secret.xml]\u0027, \u0027Service[libvirt]\u0027],"},{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":"        is_expected.to contain_exec(\u0027set-secret-value virsh\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":18,"id":"bacf61ea_b8117754","line":143,"updated":"2016-08-01 15:52:10.000000000","message":"missing change, \"unless\"","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"03b8f9ae539ae5211312535b3bc017ddaf3ccd88","unresolved":false,"context_lines":[{"line_number":140,"context_line":"        ])"},{"line_number":141,"context_line":"        is_expected.to contain_exec(\u0027get-or-set virsh secret\u0027).with("},{"line_number":142,"context_line":"          :command \u003d\u003e  \u0027/usr/bin/virsh secret-define --file /etc/nova/secret.xml | /usr/bin/awk \\\u0027{print $2}\\\u0027 | sed \\\u0027/^$/d\\\u0027 \u003e /etc/nova/virsh.secret\u0027,"},{"line_number":143,"context_line":"          :creates \u003d\u003e \u0027/etc/nova/virsh.secret\u0027,"},{"line_number":144,"context_line":"          :require \u003d\u003e [\u0027File[/etc/nova/secret.xml]\u0027, \u0027Service[libvirt]\u0027],"},{"line_number":145,"context_line":"        )"},{"line_number":146,"context_line":"        is_expected.to contain_exec(\u0027set-secret-value virsh\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":18,"id":"bacf61ea_c6444c4b","line":143,"in_reply_to":"bacf61ea_b8117754","updated":"2016-08-01 16:20:52.000000000","message":"yep, thanks!","commit_id":"035f1f3fb0c837ecb5e89a50143f35f5c13299f7"}]}