)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"aafa88a7618caf0a924f4c00b5955cab929f64fe","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rohit Pagedar \u003crohitpagedar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 17:38:45 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Making instance_name_template configurable."},{"line_number":8,"context_line":"This will allow users to configure the value."},{"line_number":9,"context_line":"The parameter will be added only if required,"},{"line_number":10,"context_line":"and exposed via heat templates."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a2ca52d_2d408533","line":7,"updated":"2015-10-16 18:07:09.000000000","message":"please let an empty line between the title and the description.","commit_id":"9805225ec95379bc5927bcc330a3aec1e68c3d4e"},{"author":{"_account_id":18815,"name":"Rohit Pagedar","email":"rohitpagedar@gmail.com","username":"rohitpagedar"},"change_message_id":"cffacf684654337d715e4f1ff8803042cc327a1f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Rohit Pagedar \u003crohitpagedar@gmail.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2015-10-14 17:38:45 -0400"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Making instance_name_template configurable."},{"line_number":8,"context_line":"This will allow users to configure the value."},{"line_number":9,"context_line":"The parameter will be added only if required,"},{"line_number":10,"context_line":"and exposed via heat templates."}],"source_content_type":"text/x-gerrit-commit-message","patch_set":2,"id":"5a2ca52d_676c5608","line":7,"in_reply_to":"5a2ca52d_2d408533","updated":"2015-10-20 21:17:23.000000000","message":"Done","commit_id":"9805225ec95379bc5927bcc330a3aec1e68c3d4e"}],"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"035db02e4228969b2c51952d7299a019277e31a5","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    warning(\u0027The conductor_workers parameter is deprecated and has no effect. Use workers parameter of nova::conductor class instead.\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  if $instance_name_template {"},{"line_number":236,"context_line":"    nova_config {"},{"line_number":237,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"},{"line_number":238,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a29b11f_4de188fd","line":235,"updated":"2015-10-20 20:03:51.000000000","message":"If you use $::os_service_default for the default value of this, you don\u0027t have to do this if $instance_name_template { ... } else { ... } block","commit_id":"ec835816626b80df6703be7c342c071c98aa4bc2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"139c0a2f22d16ac4efe7c8cd90f988fad76ff93f","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    warning(\u0027The conductor_workers parameter is deprecated and has no effect. Use workers parameter of nova::conductor class instead.\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  if $instance_name_template {"},{"line_number":236,"context_line":"    nova_config {"},{"line_number":237,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"},{"line_number":238,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a29b11f_1e396df2","line":235,"in_reply_to":"3a29b11f_03227fb9","updated":"2015-10-21 02:00:45.000000000","message":"So using $::os_service_default honors that and results in the same thing. We\u0027ve added support in the providers that if the value from $::os_service_default is detected it does an ensure \u003d\u003e absent.","commit_id":"ec835816626b80df6703be7c342c071c98aa4bc2"},{"author":{"_account_id":18815,"name":"Rohit Pagedar","email":"rohitpagedar@gmail.com","username":"rohitpagedar"},"change_message_id":"bd233d0cefbda837b03f8a7180d3c146094da8e9","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    warning(\u0027The conductor_workers parameter is deprecated and has no effect. Use workers parameter of nova::conductor class instead.\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  if $instance_name_template {"},{"line_number":236,"context_line":"    nova_config {"},{"line_number":237,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"},{"line_number":238,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a29b11f_fd09ed84","line":235,"in_reply_to":"3a29b11f_1e396df2","updated":"2015-10-21 18:10:24.000000000","message":"Done","commit_id":"ec835816626b80df6703be7c342c071c98aa4bc2"},{"author":{"_account_id":18815,"name":"Rohit Pagedar","email":"rohitpagedar@gmail.com","username":"rohitpagedar"},"change_message_id":"0de21aa494640804f38c57ee66361ddf31094f2e","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    warning(\u0027The conductor_workers parameter is deprecated and has no effect. Use workers parameter of nova::conductor class instead.\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  if $instance_name_template {"},{"line_number":236,"context_line":"    nova_config {"},{"line_number":237,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"},{"line_number":238,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a29b11f_9be3fad8","line":235,"in_reply_to":"3a29b11f_1e396df2","updated":"2015-10-22 15:17:07.000000000","message":"These are the failures that I observe after making the above changes.\n\nReasons:\nThe $::os_service_default sets the value of instance_name_template to nil. Hence, there is a failure observed.\n\nWhat should be my next steps to fix this?\n\n******************************************************************************\nFAILURE from the LOG\n******************************************************************************\n\nFailures:\n2015-10-21 18:22:22.506 | \n2015-10-21 18:22:22.506 |   1) nova::api on Debian platforms behaves like nova-api with default parameters should contain Nova_config[DEFAULT/instance_name_template] with ensure \u003d\u003e \"absent\"\n2015-10-21 18:22:22.507 |      Failure/Error: it { is_expected.to contain_nova_config(\u0027DEFAULT/instance_name_template\u0027).with_ensure(\u0027absent\u0027)}\n2015-10-21 18:22:22.507 |        expected that the catalogue would contain Nova_config[DEFAULT/instance_name_template] with ensure set to \"absent\" but it is set to nil\n2015-10-21 18:22:22.507 |      Shared Example Group: \"nova-api\" called from ./spec/classes/nova_api_spec.rb:331\n2015-10-21 18:22:22.508 |      # ./spec/classes/nova_api_spec.rb:59:in `block (4 levels) in \u003ctop (required)\u003e\u0027\n\n\n\n2015-10-21 18:22:22.508 | \n2015-10-21 18:22:22.508 |   2) nova::api on RedHat platforms behaves like nova-api with default parameters should contain Nova_config[DEFAULT/instance_name_template] with ensure \u003d\u003e \"absent\"\n2015-10-21 18:22:22.508 |      Failure/Error: it { is_expected.to contain_nova_config(\u0027DEFAULT/instance_name_template\u0027).with_ensure(\u0027absent\u0027)}\n2015-10-21 18:22:22.509 |        expected that the catalogue would contain Nova_config[DEFAULT/instance_name_template] with ensure set to \"absent\" but it is set to nil\n2015-10-21 18:22:22.509 |      Shared Example Group: \"nova-api\" called from ./spec/classes/nova_api_spec.rb:344\n2015-10-21 18:22:22.509 |      # ./spec/classes/nova_api_spec.rb:59:in `block (4 levels) in \u003ctop (required)\u003e\u0027\n\n****************************************************************************\nEND of LOG\n****************************************************************************","commit_id":"ec835816626b80df6703be7c342c071c98aa4bc2"},{"author":{"_account_id":18815,"name":"Rohit Pagedar","email":"rohitpagedar@gmail.com","username":"rohitpagedar"},"change_message_id":"8136081314b88486b45cab8e608e3821ab631cde","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    warning(\u0027The conductor_workers parameter is deprecated and has no effect. Use workers parameter of nova::conductor class instead.\u0027)"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  if $instance_name_template {"},{"line_number":236,"context_line":"    nova_config {"},{"line_number":237,"context_line":"      \u0027DEFAULT/instance_name_template\u0027: value \u003d\u003e $instance_name_template;"},{"line_number":238,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3a29b11f_03227fb9","line":235,"in_reply_to":"3a29b11f_4de188fd","updated":"2015-10-20 21:11:23.000000000","message":"The current implementation has the instance_name_template commented out from nova.conf. I did not want to change the default behavior and hence I used the \"if $instance_name_template { ... } else { ... } block\"","commit_id":"ec835816626b80df6703be7c342c071c98aa4bc2"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7b87e595d1578b9c2b0584011144f815669cb35d","unresolved":false,"context_lines":[{"line_number":112,"context_line":"#"},{"line_number":113,"context_line":"# [*instance_name_template*]"},{"line_number":114,"context_line":"#   (optional) Template string to be used to generate instance names"},{"line_number":115,"context_line":"#   Defaults to $::os_service_default"},{"line_number":116,"context_line":"#"},{"line_number":117,"context_line":"# [*sync_db*]"},{"line_number":118,"context_line":"#   (optional) Run nova-manage db sync on api nodes after installing the package."}],"source_content_type":"text/x-puppet","patch_set":8,"id":"fa80f949_cf0df238","line":115,"range":{"start_line":115,"start_character":19,"end_line":115,"end_character":37},"updated":"2015-11-03 13:59:52.000000000","message":"Rohit, very sorry for the confusion but os_service_default is not stable yet, we found a bug in puppet-cinder about that, and we are currently investigating this.\nWe don\u0027t want to spread the feature everywhere since we\u0027re not sure it\u0027s stable enough.\n\nIn the meantime, please use the default value in OpenStack.\n\nThanks!","commit_id":"56a563824326e7243ac7d70b559a35a30a2a5e90"}],"spec/classes/nova_api_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"aafa88a7618caf0a924f4c00b5955cab929f64fe","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    end"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    context \u0027with instance-%08x\u0027 do"},{"line_number":279,"context_line":"      let :params do {"},{"line_number":280,"context_line":"        :instance_name_template \u003d\u003e \u0027instance-%08x\u0027,"},{"line_number":281,"context_line":"      }"},{"line_number":282,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5a2ca52d_ed2e0d8b","line":279,"updated":"2015-10-16 18:07:09.000000000","message":"you need to use:\n\n  before do\n    params.merhe!({\n    })\n  end\n\n  (...)","commit_id":"9805225ec95379bc5927bcc330a3aec1e68c3d4e"},{"author":{"_account_id":18815,"name":"Rohit Pagedar","email":"rohitpagedar@gmail.com","username":"rohitpagedar"},"change_message_id":"cffacf684654337d715e4f1ff8803042cc327a1f","unresolved":false,"context_lines":[{"line_number":276,"context_line":"    end"},{"line_number":277,"context_line":""},{"line_number":278,"context_line":"    context \u0027with instance-%08x\u0027 do"},{"line_number":279,"context_line":"      let :params do {"},{"line_number":280,"context_line":"        :instance_name_template \u003d\u003e \u0027instance-%08x\u0027,"},{"line_number":281,"context_line":"      }"},{"line_number":282,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5a2ca52d_4776fad7","line":279,"in_reply_to":"5a2ca52d_ed2e0d8b","updated":"2015-10-20 21:17:23.000000000","message":"Done","commit_id":"9805225ec95379bc5927bcc330a3aec1e68c3d4e"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c80705b2f2d79e64d22340a35b4518a3a9aef3ed","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":318,"context_line":"    let :facts do"},{"line_number":319,"context_line":"      @default_facts.merge!({"},{"line_number":320,"context_line":"        :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":321,"context_line":"        :processorcount \u003d\u003e 5"},{"line_number":322,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a26ad4f_dc180f87","line":319,"updated":"2015-10-29 15:27:39.000000000","message":"According to Alex\u0027s comments here: https://review.openstack.org/#/c/240034/1/spec/classes/gnocchi_api_spec.rb i guess, we should use merge() now.","commit_id":"6bf379dfaa450124b631f8947af0e20c2834ea6b"},{"author":{"_account_id":18815,"name":"Rohit Pagedar","email":"rohitpagedar@gmail.com","username":"rohitpagedar"},"change_message_id":"7c20fa3b72cc93682cb9e0880698503dafc9a616","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":318,"context_line":"    let :facts do"},{"line_number":319,"context_line":"      @default_facts.merge!({"},{"line_number":320,"context_line":"        :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":321,"context_line":"        :processorcount \u003d\u003e 5"},{"line_number":322,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"1a26ad4f_16c8a321","line":319,"in_reply_to":"1a26ad4f_dc180f87","updated":"2015-10-29 16:36:52.000000000","message":"Done, as per https://review.openstack.org/#/c/240247/1","commit_id":"6bf379dfaa450124b631f8947af0e20c2834ea6b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f7679741ebe2c9d8ad2b9766ac26b78b9e747496","unresolved":false,"context_lines":[{"line_number":316,"context_line":""},{"line_number":317,"context_line":"  context \u0027on Debian platforms\u0027 do"},{"line_number":318,"context_line":"    let :facts do"},{"line_number":319,"context_line":"      @default_facts.merge({"},{"line_number":320,"context_line":"        :osfamily       \u003d\u003e \u0027Debian\u0027,"},{"line_number":321,"context_line":"        :processorcount \u003d\u003e 5"},{"line_number":322,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"fa80f949_f66d1fcd","line":319,"updated":"2015-11-03 20:12:24.000000000","message":"@default_facts doesn\u0027t exist here so just use the standalone fact hash here","commit_id":"cbcb236e6f51441167775f59c783ebd9c20902d0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f7679741ebe2c9d8ad2b9766ac26b78b9e747496","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":334,"context_line":"    let :facts do"},{"line_number":335,"context_line":"      @default_facts.merge({"},{"line_number":336,"context_line":"        :osfamily       \u003d\u003e \u0027RedHat\u0027,"},{"line_number":337,"context_line":"        :processorcount \u003d\u003e 5"},{"line_number":338,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"fa80f949_b668f7bb","line":335,"updated":"2015-11-03 20:12:24.000000000","message":"@default_facts doesn\u0027t exist here so just use the standalone fact hash here","commit_id":"cbcb236e6f51441167775f59c783ebd9c20902d0"},{"author":{"_account_id":18815,"name":"Rohit Pagedar","email":"rohitpagedar@gmail.com","username":"rohitpagedar"},"change_message_id":"44a2cc6197ef57ce0d21d8ca52d861c281b83325","unresolved":false,"context_lines":[{"line_number":332,"context_line":""},{"line_number":333,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":334,"context_line":"    let :facts do"},{"line_number":335,"context_line":"      @default_facts.merge({"},{"line_number":336,"context_line":"        :osfamily       \u003d\u003e \u0027RedHat\u0027,"},{"line_number":337,"context_line":"        :processorcount \u003d\u003e 5"},{"line_number":338,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":9,"id":"fa80f949_d6cb3b71","line":335,"in_reply_to":"fa80f949_b668f7bb","updated":"2015-11-03 20:22:19.000000000","message":"Done","commit_id":"cbcb236e6f51441167775f59c783ebd9c20902d0"}],"spec/spec_helper.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7b87e595d1578b9c2b0584011144f815669cb35d","unresolved":false,"context_lines":[{"line_number":5,"context_line":"RSpec.configure do |c|"},{"line_number":6,"context_line":"  c.alias_it_should_behave_like_to :it_configures, \u0027configures\u0027"},{"line_number":7,"context_line":"  c.alias_it_should_behave_like_to :it_raises, \u0027raises\u0027"},{"line_number":8,"context_line":"  c.before :each do"},{"line_number":9,"context_line":"    @default_facts \u003d { :os_service_default \u003d\u003e \u0027\u003cSERVICE DEFAULT\u003e\u0027 }"},{"line_number":10,"context_line":"  end"},{"line_number":11,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"fa80f949_8f3e0ab7","line":8,"updated":"2015-11-03 13:59:52.000000000","message":"please drop it","commit_id":"56a563824326e7243ac7d70b559a35a30a2a5e90"}]}