)]}'
{"manifests/params.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d55b9d70773d6f68063cd906cdf57e66acdf35fa","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      $network_service_name         \u003d \u0027nova-network\u0027"},{"line_number":93,"context_line":"      $objectstore_service_name     \u003d \u0027nova-objectstore\u0027"},{"line_number":94,"context_line":"      $scheduler_service_name       \u003d \u0027nova-scheduler\u0027"},{"line_number":95,"context_line":"      $vncproxy_service_name        \u003d \u0027nova-novncproxy\u0027"},{"line_number":96,"context_line":"      $serialproxy_service_name     \u003d \u0027nova-serialproxy\u0027"},{"line_number":97,"context_line":"      $tgt_service_name             \u003d \u0027tgt\u0027"},{"line_number":98,"context_line":"      # debian specific nova config"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_0ba90790","line":95,"updated":"2015-11-11 16:04:04.000000000","message":"as i can remember, we also have problems with \u0027nova-novncproxy\u0027 in Debian. Check please this package.","commit_id":"38089cafa9c309cf4f5e6521680b25005491b6dd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"792e0242c9737f156418d03b2f32c7654cdabbc4","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      $network_service_name         \u003d \u0027nova-network\u0027"},{"line_number":93,"context_line":"      $objectstore_service_name     \u003d \u0027nova-objectstore\u0027"},{"line_number":94,"context_line":"      $scheduler_service_name       \u003d \u0027nova-scheduler\u0027"},{"line_number":95,"context_line":"      $vncproxy_service_name        \u003d \u0027nova-novncproxy\u0027"},{"line_number":96,"context_line":"      $serialproxy_service_name     \u003d \u0027nova-serialproxy\u0027"},{"line_number":97,"context_line":"      $tgt_service_name             \u003d \u0027tgt\u0027"},{"line_number":98,"context_line":"      # debian specific nova config"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_bc149fe8","line":95,"in_reply_to":"da85f559_0ba90790","updated":"2015-11-12 08:19:01.000000000","message":"The above is a variable for the service name (ie: the startup script for init), *not* the package name. And both are the same in Debian and Ubuntu, so there\u0027s nothing to correct here.","commit_id":"38089cafa9c309cf4f5e6521680b25005491b6dd"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"9f9d4c0e2122cd7119cfcfece73eadc0bd7f61bb","unresolved":false,"context_lines":[{"line_number":92,"context_line":"      $network_service_name         \u003d \u0027nova-network\u0027"},{"line_number":93,"context_line":"      $objectstore_service_name     \u003d \u0027nova-objectstore\u0027"},{"line_number":94,"context_line":"      $scheduler_service_name       \u003d \u0027nova-scheduler\u0027"},{"line_number":95,"context_line":"      $vncproxy_service_name        \u003d \u0027nova-novncproxy\u0027"},{"line_number":96,"context_line":"      $serialproxy_service_name     \u003d \u0027nova-serialproxy\u0027"},{"line_number":97,"context_line":"      $tgt_service_name             \u003d \u0027tgt\u0027"},{"line_number":98,"context_line":"      # debian specific nova config"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_7f92a44d","line":95,"in_reply_to":"da85f559_bc149fe8","updated":"2015-11-12 10:17:20.000000000","message":"I was confused by https://bugs.launchpad.net/mos/+bug/1468230 \nAll packages names (from a bug) are defined below. This patch is ok.","commit_id":"38089cafa9c309cf4f5e6521680b25005491b6dd"},{"author":{"_account_id":6476,"name":"Thomas Goirand","email":"thomas@goirand.fr","username":"thomas-goirand"},"change_message_id":"792e0242c9737f156418d03b2f32c7654cdabbc4","unresolved":false,"context_lines":[{"line_number":105,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-consoleproxy\u0027"},{"line_number":106,"context_line":"          # Use default provider on Debian"},{"line_number":107,"context_line":"          $special_service_provider \u003d undef"},{"line_number":108,"context_line":"          $nova_log_group               \u003d \u0027nova\u0027"},{"line_number":109,"context_line":"          $libvirt_service_name         \u003d \u0027libvirtd\u0027"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"        default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_5cbd73d6","line":108,"updated":"2015-11-12 08:19:01.000000000","message":"Debian is also using the adm group. It has been the case for a while. So this variable should get out of the conditional, and set as adm in both cases.","commit_id":"38089cafa9c309cf4f5e6521680b25005491b6dd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8e29d9f7e552cf51e95b90fcec78b7f34dff3046","unresolved":false,"context_lines":[{"line_number":105,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-consoleproxy\u0027"},{"line_number":106,"context_line":"          # Use default provider on Debian"},{"line_number":107,"context_line":"          $special_service_provider \u003d undef"},{"line_number":108,"context_line":"          $nova_log_group               \u003d \u0027nova\u0027"},{"line_number":109,"context_line":"          $libvirt_service_name         \u003d \u0027libvirtd\u0027"},{"line_number":110,"context_line":"        }"},{"line_number":111,"context_line":"        default: {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da85f559_43957930","line":108,"in_reply_to":"da85f559_5cbd73d6","updated":"2015-11-12 14:45:55.000000000","message":"Done","commit_id":"38089cafa9c309cf4f5e6521680b25005491b6dd"}],"spec/classes/nova_compute_libvirt_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0ff8bf2bc798999c68af128c0b759a91f34aea3d","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  shared_examples \u0027redhat-nova-compute-libvirt\u0027 do"},{"line_number":149,"context_line":"    before do"},{"line_number":150,"context_line":"      facts.merge!({ :operatingsystem \u003d\u003e \u0027RedHat\u0027, :osfamily \u003d\u003e \u0027RedHat\u0027,"},{"line_number":151,"context_line":"        :operatingsystemrelease \u003d\u003e 6.5,"},{"line_number":152,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u00276\u0027 })"},{"line_number":153,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_65ce6c85","line":150,"updated":"2015-11-16 11:27:44.000000000","message":"facts.merge i guess","commit_id":"7b52544e614861dea15bdae53e6e27498bcbc0d7"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a2104466e1931963eab363b0acf842c821581af5","unresolved":false,"context_lines":[{"line_number":147,"context_line":""},{"line_number":148,"context_line":"  shared_examples \u0027redhat-nova-compute-libvirt\u0027 do"},{"line_number":149,"context_line":"    before do"},{"line_number":150,"context_line":"      facts.merge!({ :operatingsystem \u003d\u003e \u0027RedHat\u0027, :osfamily \u003d\u003e \u0027RedHat\u0027,"},{"line_number":151,"context_line":"        :operatingsystemrelease \u003d\u003e 6.5,"},{"line_number":152,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u00276\u0027 })"},{"line_number":153,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"ba8a016a_e240080a","line":150,"in_reply_to":"ba8a016a_65ce6c85","updated":"2015-11-16 14:24:29.000000000","message":"No in this case it\u0027s facts.merge! because it\u0027s a before loop.  We need merge! here because we\u0027re overriding the default facts provided by the initial loop down below.","commit_id":"7b52544e614861dea15bdae53e6e27498bcbc0d7"}]}