)]}'
{"manifests/availability_zone.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ef0213785ddd685ed1f015f1b653cdb976bd5c70","unresolved":false,"context_lines":[{"line_number":15,"context_line":"class nova::availability_zone ("},{"line_number":16,"context_line":"  $default_availability_zone          \u003d undef,"},{"line_number":17,"context_line":"  $default_schedule_zone              \u003d undef,"},{"line_number":18,"context_line":"  $internal_service_availability_zone \u003d undef,"},{"line_number":19,"context_line":") {"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  # NOTE(dalees): In order to keep backward compatibility from nova::compute we"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_b55eb943","line":18,"range":{"start_line":18,"start_character":40,"end_line":18,"end_character":45},"updated":"2015-12-30 12:26:19.000000000","message":"can be use $::os_service_default fact here i guess.","commit_id":"1e382a3a4532134655845ab8ab1793def3373a41"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"57f918cb7dda732ba6fad02dce1e838f3e83a3e7","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#  [*internal_service_availability_zone*]"},{"line_number":16,"context_line":"#   (optional) The availability zone to show internal services under."},{"line_number":17,"context_line":"#   Defaults to $::os_service_default"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class nova::availability_zone ("},{"line_number":20,"context_line":"  $default_availability_zone          \u003d $::os_service_default,"},{"line_number":21,"context_line":"  $default_schedule_zone              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dae33548_ddc4e841","line":18,"updated":"2016-02-15 11:15:47.000000000","message":"# should be here","commit_id":"c7310b8a1d1beea9fcfd2cec2a6a52379c96d9c7"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"94e6e4bfe45c8f8e5d22e60e30fd378e9e6ebcae","unresolved":false,"context_lines":[{"line_number":15,"context_line":"#  [*internal_service_availability_zone*]"},{"line_number":16,"context_line":"#   (optional) The availability zone to show internal services under."},{"line_number":17,"context_line":"#   Defaults to $::os_service_default"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":"class nova::availability_zone ("},{"line_number":20,"context_line":"  $default_availability_zone          \u003d $::os_service_default,"},{"line_number":21,"context_line":"  $default_schedule_zone              \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dae33548_3d799394","line":18,"in_reply_to":"dae33548_ddc4e841","updated":"2016-02-15 11:26:45.000000000","message":"Done","commit_id":"c7310b8a1d1beea9fcfd2cec2a6a52379c96d9c7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"57f918cb7dda732ba6fad02dce1e838f3e83a3e7","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  nova_config {"},{"line_number":38,"context_line":"    \u0027DEFAULT/default_availability_zone\u0027: value \u003d\u003e $default_availability_zone_real;"},{"line_number":39,"context_line":"    \u0027DEFAULT/default_schedule_zone\u0027: value \u003d\u003e $default_schedule_zone_real;"},{"line_number":40,"context_line":"    \u0027DEFAULT/internal_service_availability_zone\u0027: value \u003d\u003e $internal_service_availability_zone_real;"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dae33548_fd2f2cf4","line":39,"updated":"2016-02-15 11:15:47.000000000","message":"alignment :)","commit_id":"c7310b8a1d1beea9fcfd2cec2a6a52379c96d9c7"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"94e6e4bfe45c8f8e5d22e60e30fd378e9e6ebcae","unresolved":false,"context_lines":[{"line_number":36,"context_line":""},{"line_number":37,"context_line":"  nova_config {"},{"line_number":38,"context_line":"    \u0027DEFAULT/default_availability_zone\u0027: value \u003d\u003e $default_availability_zone_real;"},{"line_number":39,"context_line":"    \u0027DEFAULT/default_schedule_zone\u0027: value \u003d\u003e $default_schedule_zone_real;"},{"line_number":40,"context_line":"    \u0027DEFAULT/internal_service_availability_zone\u0027: value \u003d\u003e $internal_service_availability_zone_real;"},{"line_number":41,"context_line":"  }"},{"line_number":42,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"dae33548_9d6edfc7","line":39,"in_reply_to":"dae33548_fd2f2cf4","updated":"2016-02-15 11:26:45.000000000","message":"Done","commit_id":"c7310b8a1d1beea9fcfd2cec2a6a52379c96d9c7"}],"manifests/compute.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"109a16981412db3175b4b3139f05dcf0475bbf77","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":137,"context_line":"  $default_availability_zone          \u003d undef,"},{"line_number":138,"context_line":"  $default_schedule_zone              \u003d undef,"},{"line_number":139,"context_line":"  $internal_service_availability_zone \u003d undef,"},{"line_number":140,"context_line":") {"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a7b0d38_446e8230","line":139,"updated":"2015-12-24 13:37:57.000000000","message":"we usually move parameters to deprecated if they are deprecated for Openstack service, i think they should not be marked as deprecated","commit_id":"35993719f90b0a38062e3d8199067cfd20d9277a"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"378b0fc251082773dbf6875b85c457ebf6600c5b","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":137,"context_line":"  $default_availability_zone          \u003d undef,"},{"line_number":138,"context_line":"  $default_schedule_zone              \u003d undef,"},{"line_number":139,"context_line":"  $internal_service_availability_zone \u003d undef,"},{"line_number":140,"context_line":") {"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a7b0d38_0a82c194","line":139,"in_reply_to":"1a7b0d38_2fe30f35","updated":"2015-12-24 14:30:02.000000000","message":"Actually Nikita you\u0027re wrong. We can deprecate parameters, because of some another reasons than Openstack deprecation.","commit_id":"35993719f90b0a38062e3d8199067cfd20d9277a"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"410cdf03fc73b6325d16a617601cbd6809b6c99f","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":137,"context_line":"  $default_availability_zone          \u003d undef,"},{"line_number":138,"context_line":"  $default_schedule_zone              \u003d undef,"},{"line_number":139,"context_line":"  $internal_service_availability_zone \u003d undef,"},{"line_number":140,"context_line":") {"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a7b0d38_ea0895db","line":139,"in_reply_to":"1a7b0d38_2fe30f35","updated":"2015-12-24 14:11:41.000000000","message":"yes of course, we need to keep them, it is needed for backward compatibility, you can check for example how parameters for glance api logging were moved from glance::api to glance::api::logging and do something similar","commit_id":"35993719f90b0a38062e3d8199067cfd20d9277a"},{"author":{"_account_id":14394,"name":"Dale Smith","email":"dale@catalystcloud.nz","username":"dalees"},"change_message_id":"15416f902242ef3a3595f8a24163975f6f378893","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":137,"context_line":"  $default_availability_zone          \u003d undef,"},{"line_number":138,"context_line":"  $default_schedule_zone              \u003d undef,"},{"line_number":139,"context_line":"  $internal_service_availability_zone \u003d undef,"},{"line_number":140,"context_line":") {"},{"line_number":141,"context_line":""},{"line_number":142,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1a7b0d38_2fe30f35","line":139,"in_reply_to":"1a7b0d38_446e8230","updated":"2015-12-24 13:46:06.000000000","message":"Removing them isn\u0027t the answer, as that will break the existing interface.\n\nWould it be better to keep the same functionality of nova::compute and introduce the new parameters to nova with the warnings added?","commit_id":"35993719f90b0a38062e3d8199067cfd20d9277a"}],"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ef0213785ddd685ed1f015f1b653cdb976bd5c70","unresolved":false,"context_lines":[{"line_number":410,"context_line":"  $upgrade_level_intercell            \u003d undef,"},{"line_number":411,"context_line":"  $upgrade_level_network              \u003d undef,"},{"line_number":412,"context_line":"  $upgrade_level_scheduler            \u003d undef,"},{"line_number":413,"context_line":"  $default_availability_zone          \u003d \u0027nova\u0027,"},{"line_number":414,"context_line":"  $default_schedule_zone              \u003d undef,"},{"line_number":415,"context_line":"  $internal_service_availability_zone \u003d \u0027internal\u0027,"},{"line_number":416,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"fa69d971_f53af1e6","line":413,"range":{"start_line":413,"start_character":41,"end_line":413,"end_character":45},"updated":"2015-12-30 12:26:19.000000000","message":"i think will be better use here also undef and set to some defaults in your new class.\n\nalso i\u0027m not sure, do we really need include in this class?","commit_id":"1e382a3a4532134655845ab8ab1793def3373a41"}]}