)]}'
{"manifests/init.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"2162f5f4e082c504b51e0e5a053ddaebd49ff12e","unresolved":false,"context_lines":[{"line_number":357,"context_line":"  $slave_connection                   \u003d undef,"},{"line_number":358,"context_line":"  $api_database_connection            \u003d undef,"},{"line_number":359,"context_line":"  $api_slave_connection               \u003d undef,"},{"line_number":360,"context_line":"  $block_device_allocate_retries      \u003d undef,"},{"line_number":361,"context_line":"  $block_device_allocate_retries_interval   \u003d   undef,"},{"line_number":362,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":363,"context_line":"  $database_min_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5aef4532_ef04174b","line":360,"range":{"start_line":360,"start_character":3,"end_line":360,"end_character":32},"updated":"2016-03-09 14:21:16.000000000","message":"can we switch to $::os_service_default here?","commit_id":"03b2f0348662b6f26789686a9d0f4dec3b135475"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"071d45bf78b33e99c622080a3667a2ceb1de3a24","unresolved":false,"context_lines":[{"line_number":357,"context_line":"  $slave_connection                   \u003d undef,"},{"line_number":358,"context_line":"  $api_database_connection            \u003d undef,"},{"line_number":359,"context_line":"  $api_slave_connection               \u003d undef,"},{"line_number":360,"context_line":"  $block_device_allocate_retries      \u003d undef,"},{"line_number":361,"context_line":"  $block_device_allocate_retries_interval   \u003d   undef,"},{"line_number":362,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":363,"context_line":"  $database_min_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5aef4532_242901e7","line":360,"in_reply_to":"5aef4532_ef04174b","updated":"2016-03-09 15:12:09.000000000","message":"I am not fully familiar with $::os_service_default but I agree that would make sense.","commit_id":"03b2f0348662b6f26789686a9d0f4dec3b135475"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5d77cbd31d4dc5a80375e8d7a8485870242b5003","unresolved":false,"context_lines":[{"line_number":666,"context_line":"    nova_config { \u0027DEFAULT/notification_driver\u0027: ensure \u003d\u003e absent; }"},{"line_number":667,"context_line":"  }"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"  if $block_device_allocate_retries {"},{"line_number":670,"context_line":"    nova_config {"},{"line_number":671,"context_line":"      \u0027DEFAULT/block_device_allocate_retries\u0027: value \u003d\u003e $block_device_allocate_retries;"},{"line_number":672,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5aef4532_6674a067","line":669,"updated":"2016-03-09 17:59:06.000000000","message":"These if clauses are not necessary when using $::os_service_default so just put these values into the nova_config block below","commit_id":"c71ff735d238383db1ce56eef05ad55a9f91889b"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"4369521f3908a72fada5a5987e4ab54659bb0927","unresolved":false,"context_lines":[{"line_number":666,"context_line":"    nova_config { \u0027DEFAULT/notification_driver\u0027: ensure \u003d\u003e absent; }"},{"line_number":667,"context_line":"  }"},{"line_number":668,"context_line":""},{"line_number":669,"context_line":"  if $block_device_allocate_retries {"},{"line_number":670,"context_line":"    nova_config {"},{"line_number":671,"context_line":"      \u0027DEFAULT/block_device_allocate_retries\u0027: value \u003d\u003e $block_device_allocate_retries;"},{"line_number":672,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5aef4532_bdd4f61f","line":669,"in_reply_to":"5aef4532_6674a067","updated":"2016-03-09 18:29:17.000000000","message":"Done","commit_id":"c71ff735d238383db1ce56eef05ad55a9f91889b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d529d685ada7e76eb0b5af59d6613f2a8e62195e","unresolved":false,"context_lines":[{"line_number":358,"context_line":"  $api_database_connection            \u003d undef,"},{"line_number":359,"context_line":"  $api_slave_connection               \u003d undef,"},{"line_number":360,"context_line":"  $block_device_allocate_retries      \u003d $::os_service_default,"},{"line_number":361,"context_line":"  $block_device_allocate_retries_interval   \u003d   $::os_service_default,"},{"line_number":362,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":363,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":364,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5aef4532_d8256c5c","line":361,"range":{"start_line":361,"start_character":41,"end_line":361,"end_character":44},"updated":"2016-03-10 10:34:23.000000000","message":"need to align this somehow","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"c27a0a434aa67216980101058e7607b42699715d","unresolved":false,"context_lines":[{"line_number":358,"context_line":"  $api_database_connection            \u003d undef,"},{"line_number":359,"context_line":"  $api_slave_connection               \u003d undef,"},{"line_number":360,"context_line":"  $block_device_allocate_retries      \u003d $::os_service_default,"},{"line_number":361,"context_line":"  $block_device_allocate_retries_interval   \u003d   $::os_service_default,"},{"line_number":362,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":363,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":364,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5aef4532_c86631ba","line":361,"in_reply_to":"5aef4532_93e5860a","updated":"2016-03-10 13:12:58.000000000","message":"Done","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6f5b72c76d17c4667479d8d014c5da612eaeeb1a","unresolved":false,"context_lines":[{"line_number":358,"context_line":"  $api_database_connection            \u003d undef,"},{"line_number":359,"context_line":"  $api_slave_connection               \u003d undef,"},{"line_number":360,"context_line":"  $block_device_allocate_retries      \u003d $::os_service_default,"},{"line_number":361,"context_line":"  $block_device_allocate_retries_interval   \u003d   $::os_service_default,"},{"line_number":362,"context_line":"  $database_idle_timeout              \u003d undef,"},{"line_number":363,"context_line":"  $database_min_pool_size             \u003d undef,"},{"line_number":364,"context_line":"  $database_max_pool_size             \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5aef4532_93e5860a","line":361,"range":{"start_line":361,"start_character":41,"end_line":361,"end_character":44},"in_reply_to":"5aef4532_d8256c5c","updated":"2016-03-10 11:11:03.000000000","message":"You can move it on next line","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d529d685ada7e76eb0b5af59d6613f2a8e62195e","unresolved":false,"context_lines":[{"line_number":679,"context_line":"    \u0027DEFAULT/report_interval\u0027:     value \u003d\u003e $report_interval;"},{"line_number":680,"context_line":"    \u0027DEFAULT/use_ipv6\u0027:            value \u003d\u003e $use_ipv6;"},{"line_number":681,"context_line":"    \u0027DEFAULT/block_device_allocate_retries\u0027:          value \u003d\u003e $block_device_allocate_retries;"},{"line_number":682,"context_line":"    \u0027DEFAULT/block_device_allocate_retries_interval\u0027: value \u003d\u003e $block_device_allocate_retries_interval;"},{"line_number":683,"context_line":"  }"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"  if $notify_on_state_change and $notify_on_state_change in [\u0027vm_state\u0027, \u0027vm_and_task_state\u0027] {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5aef4532_f81e680a","line":682,"range":{"start_line":682,"start_character":51,"end_line":682,"end_character":53},"updated":"2016-03-10 10:34:23.000000000","message":"same here","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"c27a0a434aa67216980101058e7607b42699715d","unresolved":false,"context_lines":[{"line_number":679,"context_line":"    \u0027DEFAULT/report_interval\u0027:     value \u003d\u003e $report_interval;"},{"line_number":680,"context_line":"    \u0027DEFAULT/use_ipv6\u0027:            value \u003d\u003e $use_ipv6;"},{"line_number":681,"context_line":"    \u0027DEFAULT/block_device_allocate_retries\u0027:          value \u003d\u003e $block_device_allocate_retries;"},{"line_number":682,"context_line":"    \u0027DEFAULT/block_device_allocate_retries_interval\u0027: value \u003d\u003e $block_device_allocate_retries_interval;"},{"line_number":683,"context_line":"  }"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"  if $notify_on_state_change and $notify_on_state_change in [\u0027vm_state\u0027, \u0027vm_and_task_state\u0027] {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5aef4532_280875d9","line":682,"in_reply_to":"5aef4532_d3eb8eda","updated":"2016-03-10 13:12:58.000000000","message":"Done","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6f5b72c76d17c4667479d8d014c5da612eaeeb1a","unresolved":false,"context_lines":[{"line_number":679,"context_line":"    \u0027DEFAULT/report_interval\u0027:     value \u003d\u003e $report_interval;"},{"line_number":680,"context_line":"    \u0027DEFAULT/use_ipv6\u0027:            value \u003d\u003e $use_ipv6;"},{"line_number":681,"context_line":"    \u0027DEFAULT/block_device_allocate_retries\u0027:          value \u003d\u003e $block_device_allocate_retries;"},{"line_number":682,"context_line":"    \u0027DEFAULT/block_device_allocate_retries_interval\u0027: value \u003d\u003e $block_device_allocate_retries_interval;"},{"line_number":683,"context_line":"  }"},{"line_number":684,"context_line":""},{"line_number":685,"context_line":"  if $notify_on_state_change and $notify_on_state_change in [\u0027vm_state\u0027, \u0027vm_and_task_state\u0027] {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5aef4532_d3eb8eda","line":682,"range":{"start_line":682,"start_character":51,"end_line":682,"end_character":53},"in_reply_to":"5aef4532_f81e680a","updated":"2016-03-10 11:11:03.000000000","message":"same here","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"}],"spec/classes/nova_init_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"f32dc6623d15094748f68759649e3b59bfbfa03b","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_port\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":67,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_password\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":68,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_virtual_host\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":69,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/block_device_allocate_retries\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":70,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/block_device_allocate_retries_interval\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":71,"context_line":"        is_expected.to contain_nova_config(\u0027cinder/os_region_name\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":72,"context_line":"        is_expected.to contain_nova_config(\u0027cinder/catalog_info\u0027).with(\u0027value\u0027 \u003d\u003e \u0027volumev2:cinderv2:publicURL\u0027)"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"5aef4532_cb313d5c","line":69,"range":{"start_line":69,"start_character":95,"end_line":69,"end_character":97},"updated":"2016-03-09 17:50:16.000000000","message":"with_ensure(\u0027\u003cSERVICE DEFAULT\u003e\u0027)","commit_id":"c71ff735d238383db1ce56eef05ad55a9f91889b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2a8d80a30a80c594e33301100a015f5b8cfae0a4","unresolved":false,"context_lines":[{"line_number":66,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_port\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":67,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_password\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":68,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_virtual_host\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":69,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/block_device_allocate_retries\u0027).with_ensure(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":70,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/block_device_allocate_retries_interval\u0027).with_ensure(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":71,"context_line":"        is_expected.to contain_nova_config(\u0027cinder/os_region_name\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":72,"context_line":"        is_expected.to contain_nova_config(\u0027cinder/catalog_info\u0027).with(\u0027value\u0027 \u003d\u003e \u0027volumev2:cinderv2:publicURL\u0027)"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5aef4532_33601701","line":69,"range":{"start_line":69,"start_character":84,"end_line":69,"end_character":95},"updated":"2016-03-09 19:09:01.000000000","message":"with_value","commit_id":"e25ff52ac057f1cea9790f4eeb345a57d3284f36"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"2a8d80a30a80c594e33301100a015f5b8cfae0a4","unresolved":false,"context_lines":[{"line_number":67,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_password\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":68,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/rabbit_virtual_host\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":69,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/block_device_allocate_retries\u0027).with_ensure(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":70,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/block_device_allocate_retries_interval\u0027).with_ensure(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":71,"context_line":"        is_expected.to contain_nova_config(\u0027cinder/os_region_name\u0027).with_ensure(\u0027absent\u0027)"},{"line_number":72,"context_line":"        is_expected.to contain_nova_config(\u0027cinder/catalog_info\u0027).with(\u0027value\u0027 \u003d\u003e \u0027volumev2:cinderv2:publicURL\u0027)"},{"line_number":73,"context_line":"      end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"5aef4532_135d1b47","line":70,"range":{"start_line":70,"start_character":93,"end_line":70,"end_character":104},"updated":"2016-03-09 19:09:01.000000000","message":"with_value","commit_id":"e25ff52ac057f1cea9790f4eeb345a57d3284f36"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"d529d685ada7e76eb0b5af59d6613f2a8e62195e","unresolved":false,"context_lines":[{"line_number":115,"context_line":"          :upgrade_level_network              \u003d\u003e \u00271.0.0\u0027,"},{"line_number":116,"context_line":"          :upgrade_level_scheduler            \u003d\u003e \u00271.0.0\u0027,"},{"line_number":117,"context_line":"          :block_device_allocate_retries      \u003d\u003e \u002760\u0027,"},{"line_number":118,"context_line":"          :block_device_allocate_retries_interval \u003d\u003e \u00273\u0027 }"},{"line_number":119,"context_line":"      end"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      it \u0027installs packages\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5aef4532_381570e4","line":118,"range":{"start_line":118,"start_character":52,"end_line":118,"end_character":53},"updated":"2016-03-10 10:34:23.000000000","message":"same here","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"},{"author":{"_account_id":11444,"name":"Radoslaw Smigielski","display_name":"Radek","email":"rsmigiel@redhat.com","username":"radek"},"change_message_id":"c27a0a434aa67216980101058e7607b42699715d","unresolved":false,"context_lines":[{"line_number":115,"context_line":"          :upgrade_level_network              \u003d\u003e \u00271.0.0\u0027,"},{"line_number":116,"context_line":"          :upgrade_level_scheduler            \u003d\u003e \u00271.0.0\u0027,"},{"line_number":117,"context_line":"          :block_device_allocate_retries      \u003d\u003e \u002760\u0027,"},{"line_number":118,"context_line":"          :block_device_allocate_retries_interval \u003d\u003e \u00273\u0027 }"},{"line_number":119,"context_line":"      end"},{"line_number":120,"context_line":""},{"line_number":121,"context_line":"      it \u0027installs packages\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5aef4532_485a21f3","line":118,"in_reply_to":"5aef4532_381570e4","updated":"2016-03-10 13:12:58.000000000","message":"Done","commit_id":"3909035ef71c5cf129d89c3f5089fe13ca317458"}]}