)]}'
{"manifests/params.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"cd58c75ca6920e296c951ed90cac7f224afdd6ff","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          $spicehtml5proxy_package_name \u003d \u0027nova-spiceproxy\u0027"},{"line_number":121,"context_line":"          $spicehtml5proxy_service_name \u003d \u0027nova-spiceproxy\u0027"},{"line_number":122,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-novncproxy\u0027"},{"line_number":123,"context_line":"          # some of the services need to be started form the systemd/upstart provider"},{"line_number":124,"context_line":"          case $::operatingsystemrelease {"},{"line_number":125,"context_line":"            \u002716.04\u0027: {"},{"line_number":126,"context_line":"              $special_service_provider \u003d \u0027systemd\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_fc60a537","line":123,"range":{"start_line":123,"start_character":38,"end_line":123,"end_character":60},"updated":"2016-03-16 12:26:53.000000000","message":"here is a typo, i guess \"from\"","commit_id":"fa35b39e380baec9e54454bdd6cb6a3ec48d921d"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"b9b78aadd9a816973f319177eb52495277a26c28","unresolved":false,"context_lines":[{"line_number":120,"context_line":"          $spicehtml5proxy_package_name \u003d \u0027nova-spiceproxy\u0027"},{"line_number":121,"context_line":"          $spicehtml5proxy_service_name \u003d \u0027nova-spiceproxy\u0027"},{"line_number":122,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-novncproxy\u0027"},{"line_number":123,"context_line":"          # some of the services need to be started form the systemd/upstart provider"},{"line_number":124,"context_line":"          case $::operatingsystemrelease {"},{"line_number":125,"context_line":"            \u002716.04\u0027: {"},{"line_number":126,"context_line":"              $special_service_provider \u003d \u0027systemd\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_0d839d57","line":123,"range":{"start_line":123,"start_character":38,"end_line":123,"end_character":60},"in_reply_to":"1af94dfe_fc60a537","updated":"2016-03-16 13:07:16.000000000","message":"oops, that\u0027s previous commit typo, I would fix it in next patch set.","commit_id":"fa35b39e380baec9e54454bdd6cb6a3ec48d921d"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"aa27e8f6bf6318fdae6d3b6150d0f83f7f293ba5","unresolved":false,"context_lines":[{"line_number":121,"context_line":"          $spicehtml5proxy_service_name \u003d \u0027nova-spiceproxy\u0027"},{"line_number":122,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-novncproxy\u0027"},{"line_number":123,"context_line":"          # some of the services need to be started form the systemd/upstart provider"},{"line_number":124,"context_line":"          case $::operatingsystemrelease {"},{"line_number":125,"context_line":"            \u002716.04\u0027: {"},{"line_number":126,"context_line":"              $special_service_provider \u003d \u0027systemd\u0027"},{"line_number":127,"context_line":"            }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_0296ccef","line":124,"range":{"start_line":124,"start_character":15,"end_line":124,"end_character":40},"updated":"2016-03-16 12:58:21.000000000","message":"AFAIK debian also uses systemd, so probably it makes sense to extend this case and also cover Debian","commit_id":"fa35b39e380baec9e54454bdd6cb6a3ec48d921d"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"b9b78aadd9a816973f319177eb52495277a26c28","unresolved":false,"context_lines":[{"line_number":121,"context_line":"          $spicehtml5proxy_service_name \u003d \u0027nova-spiceproxy\u0027"},{"line_number":122,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-novncproxy\u0027"},{"line_number":123,"context_line":"          # some of the services need to be started form the systemd/upstart provider"},{"line_number":124,"context_line":"          case $::operatingsystemrelease {"},{"line_number":125,"context_line":"            \u002716.04\u0027: {"},{"line_number":126,"context_line":"              $special_service_provider \u003d \u0027systemd\u0027"},{"line_number":127,"context_line":"            }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_6dc0617d","line":124,"range":{"start_line":124,"start_character":15,"end_line":124,"end_character":40},"in_reply_to":"1af94dfe_0296ccef","updated":"2016-03-16 13:07:16.000000000","message":"sure, it should extend support for it, but I\u0027m not so familiar with Debian system, it might take a little time for the next patch set :)","commit_id":"fa35b39e380baec9e54454bdd6cb6a3ec48d921d"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"edf6be0e4dea150b2a4df5f64b8ee82c5c47f4b6","unresolved":false,"context_lines":[{"line_number":121,"context_line":"          $spicehtml5proxy_service_name \u003d \u0027nova-spiceproxy\u0027"},{"line_number":122,"context_line":"          $vncproxy_package_name    \u003d \u0027nova-novncproxy\u0027"},{"line_number":123,"context_line":"          # some of the services need to be started form the systemd/upstart provider"},{"line_number":124,"context_line":"          case $::operatingsystemrelease {"},{"line_number":125,"context_line":"            \u002716.04\u0027: {"},{"line_number":126,"context_line":"              $special_service_provider \u003d \u0027systemd\u0027"},{"line_number":127,"context_line":"            }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1af94dfe_c8f243d2","line":124,"range":{"start_line":124,"start_character":15,"end_line":124,"end_character":40},"in_reply_to":"1af94dfe_6dc0617d","updated":"2016-03-16 13:22:38.000000000","message":"before Debian squeeze (\u003c\u003d6), default with upstart, after Debian wheezy (\u003e\u003d7), default with systemd. Am I right?","commit_id":"fa35b39e380baec9e54454bdd6cb6a3ec48d921d"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"233fb38eb0e4d78724b7d16208de184759da4373","unresolved":false,"context_lines":[{"line_number":116,"context_line":"          # became default in Debian Jessie (8)"},{"line_number":117,"context_line":"          # reference:"},{"line_number":118,"context_line":"          #   https://www.debian.org/releases/wheezy/amd64/release-notes/ch-whats-new.en.html#systemd"},{"line_number":119,"context_line":"          #   https://www.debian.org/releases/jessie/amd64/release-notes/ch-whats-new.en.html#systemd"},{"line_number":120,"context_line":"          if (versioncmp($::operatingsystemmajrelease, \u00278\u0027) \u003e\u003d 0) {"},{"line_number":121,"context_line":"            $special_service_provider \u003d \u0027systemd\u0027"},{"line_number":122,"context_line":"          }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_e8ae1597","line":119,"range":{"start_line":119,"start_character":37,"end_line":119,"end_character":45},"updated":"2016-03-16 15:41:00.000000000","message":"it\u0027s just my opinion: I think it\u0027s enough to have these links and comments only in commit message","commit_id":"2758902a7c8fb86a7b107a7d5496e19badd02852"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"70b95125d28c806d37bedba7293b4fd9ac4ea71f","unresolved":false,"context_lines":[{"line_number":117,"context_line":"          # reference:"},{"line_number":118,"context_line":"          #   https://www.debian.org/releases/wheezy/amd64/release-notes/ch-whats-new.en.html#systemd"},{"line_number":119,"context_line":"          #   https://www.debian.org/releases/jessie/amd64/release-notes/ch-whats-new.en.html#systemd"},{"line_number":120,"context_line":"          if (versioncmp($::operatingsystemmajrelease, \u00278\u0027) \u003e\u003d 0) {"},{"line_number":121,"context_line":"            $special_service_provider \u003d \u0027systemd\u0027"},{"line_number":122,"context_line":"          }"},{"line_number":123,"context_line":"          else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_6ed7aded","line":120,"updated":"2016-03-16 16:08:44.000000000","message":"Documentation is good, let\u0027s keep it for people reading manifests.","commit_id":"2758902a7c8fb86a7b107a7d5496e19badd02852"},{"author":{"_account_id":10753,"name":"guessi","email":"guessi@gmail.com","username":"guessi"},"change_message_id":"d402a8404fd9f603126ca94ad3ba24919a49b64c","unresolved":false,"context_lines":[{"line_number":117,"context_line":"          # reference:"},{"line_number":118,"context_line":"          #   https://www.debian.org/releases/wheezy/amd64/release-notes/ch-whats-new.en.html#systemd"},{"line_number":119,"context_line":"          #   https://www.debian.org/releases/jessie/amd64/release-notes/ch-whats-new.en.html#systemd"},{"line_number":120,"context_line":"          if (versioncmp($::operatingsystemmajrelease, \u00278\u0027) \u003e\u003d 0) {"},{"line_number":121,"context_line":"            $special_service_provider \u003d \u0027systemd\u0027"},{"line_number":122,"context_line":"          }"},{"line_number":123,"context_line":"          else {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1af94dfe_6e732d16","line":120,"in_reply_to":"1af94dfe_6ed7aded","updated":"2016-03-16 16:11:05.000000000","message":"working on it, fixing","commit_id":"2758902a7c8fb86a7b107a7d5496e19badd02852"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"04fe2aeb0d962a3699aa02f0d0918529cbf9d736","unresolved":false,"context_lines":[{"line_number":107,"context_line":"      # debian specific nova config"},{"line_number":108,"context_line":"      $root_helper                  \u003d \u0027sudo nova-rootwrap\u0027"},{"line_number":109,"context_line":"      $lock_path                    \u003d \u0027/var/lock/nova\u0027"},{"line_number":110,"context_line":"      # lint:ignore:only_variable_string"},{"line_number":111,"context_line":"      case $::os_package_type {"},{"line_number":112,"context_line":"        \u0027debian\u0027: {"},{"line_number":113,"context_line":"          $spicehtml5proxy_package_name \u003d \u0027nova-consoleproxy\u0027"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1af94dfe_d6c64148","line":110,"updated":"2016-03-16 23:31:10.000000000","message":"Is this necessary? I think versioncmp($::operatingsystemmajrelease, \u00278\u0027) works fine.\n\nEven if it is necessary it is not good to disable the check for this whole block, should only be done in concise bits.","commit_id":"22015dda41ae3677ab2d1e20bb0320f37852ba98"}]}