)]}'
{"manifests/network/neutron.pp":[{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"95b3fbe602a98eaca8c3ac584e9d5ea21d82ae47","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  include ::nova::deps"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if $network_api_class !\u003d undef {"},{"line_number":158,"context_line":"    warning(\u0027network_api_class is deprecated. It does not take any affect\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  # neutron_admin params removed in Mitaka"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba0121b8_2250a831","line":158,"updated":"2016-03-31 21:30:43.000000000","message":"This is deprecated in mitaka, which means it is still effective in mitaka (http://docs.openstack.org/releasenotes/nova/mitaka.html#deprecation-notes). We do not remove functionality from a parameter that is still valid. Issue a warning that it is deprecated and will be removed in the future, but it must still take effect if the user sets it.","commit_id":"bd484f09bb5a109edc6c3597ed22b29014960a6d"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d93432fb05b1c228cd1d88ff579197eea5ee7984","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  include ::nova::deps"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if $network_api_class !\u003d undef {"},{"line_number":158,"context_line":"    warning(\u0027network_api_class is deprecated. It does not take any affect\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  # neutron_admin params removed in Mitaka"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba0121b8_bebb13c3","line":158,"updated":"2016-04-01 13:51:30.000000000","message":"Well, the network_api_class parameter is really useless, because we now have the boolean that whether or not enable neutron api. What is the use-case of keeping it?","commit_id":"bd484f09bb5a109edc6c3597ed22b29014960a6d"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"ab36c3955e95da05b40805f1428d16e5530cc0fa","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  include ::nova::deps"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if $network_api_class !\u003d undef {"},{"line_number":158,"context_line":"    warning(\u0027network_api_class is deprecated. It does not take any affect\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  # neutron_admin params removed in Mitaka"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba0121b8_600ba67d","line":158,"in_reply_to":"ba0121b8_2250a831","updated":"2016-04-01 09:38:17.000000000","message":"But what\u0027s the purpose of setting it if in this change we always set use_neutron to True and this is a neutron-only related class?","commit_id":"bd484f09bb5a109edc6c3597ed22b29014960a6d"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3237c44fc4b29c7622bc5cdabee30957094f45c1","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  include ::nova::deps"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if $network_api_class !\u003d undef {"},{"line_number":158,"context_line":"    warning(\u0027network_api_class is deprecated. It does not take any affect\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  # neutron_admin params removed in Mitaka"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba0121b8_e7098596","line":158,"in_reply_to":"ba0121b8_600ba67d","updated":"2016-04-01 12:50:34.000000000","message":"well, agree with Sergey.\n\nThis class is using, when neutron is enabled.\n\nBut we can replace $network_api_class on $use_neutron - for keeping functionality and set it to \u0027true\u0027 by default.\n\nColleen, thought?","commit_id":"bd484f09bb5a109edc6c3597ed22b29014960a6d"},{"author":{"_account_id":8482,"name":"Colleen Murphy","email":"colleen@gazlene.net","username":"krinkle"},"change_message_id":"9591b3a9667ac489e6078bc940582302edcaf1b5","unresolved":false,"context_lines":[{"line_number":155,"context_line":"  include ::nova::deps"},{"line_number":156,"context_line":""},{"line_number":157,"context_line":"  if $network_api_class !\u003d undef {"},{"line_number":158,"context_line":"    warning(\u0027network_api_class is deprecated. It does not take any affect\u0027)"},{"line_number":159,"context_line":"  }"},{"line_number":160,"context_line":""},{"line_number":161,"context_line":"  # neutron_admin params removed in Mitaka"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"ba0121b8_1ec83454","line":158,"in_reply_to":"ba0121b8_bebb13c3","updated":"2016-04-01 16:55:48.000000000","message":"Okay, you\u0027re right that someone using this class definitely wants use_neutron to be true. Instead of the warning and the commit message saying the parameter is deprecated, can we reword them to just say it no longer has any effect? Since we\u0027re not going through a normal deprecation period.","commit_id":"bd484f09bb5a109edc6c3597ed22b29014960a6d"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"6d800babeba032312d14b35e1325ceebaa3a21f9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#"},{"line_number":123,"context_line":"# [*network_api_class*]"},{"line_number":124,"context_line":"#   (optional) The full class name of the network API class."},{"line_number":125,"context_line":"#   This parameter doesn\u0027t take any affect"},{"line_number":126,"context_line":"#"},{"line_number":127,"context_line":"class nova::network::neutron ("},{"line_number":128,"context_line":"  $neutron_password                \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_6aa430b9","line":125,"range":{"start_line":125,"start_character":36,"end_line":125,"end_character":42},"updated":"2016-04-07 15:17:06.000000000","message":"Missing the \u0027DEPRECATED.\u0027 bit at the beginning? Maybe it isn\u0027t relevant considering Colleen\u0027s comment about it not going through the usual deprecation process.  \n\nLanguage nit. How about \"This parameter has no affect\"? Probably not that important though - I\u0027m not going to begrudge the language around a parameter that doesn\u0027t do anything ;)","commit_id":"5f10471e8827d48277c905d832a245f786ff1083"},{"author":{"_account_id":20993,"name":"Cody Eilrich","email":"cody.eilrich@ericsson.com","username":"ceilrich"},"change_message_id":"801832e3611537b44690835ad64f1f5ca93d17a9","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#"},{"line_number":123,"context_line":"# [*network_api_class*]"},{"line_number":124,"context_line":"#   (optional) The full class name of the network API class."},{"line_number":125,"context_line":"#   This parameter doesn\u0027t take any affect"},{"line_number":126,"context_line":"#"},{"line_number":127,"context_line":"class nova::network::neutron ("},{"line_number":128,"context_line":"  $neutron_password                \u003d false,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_e3e06b2b","line":125,"range":{"start_line":125,"start_character":36,"end_line":125,"end_character":42},"updated":"2016-04-07 15:22:12.000000000","message":"s/affect/effect/","commit_id":"5f10471e8827d48277c905d832a245f786ff1083"},{"author":{"_account_id":20993,"name":"Cody Eilrich","email":"cody.eilrich@ericsson.com","username":"ceilrich"},"change_message_id":"801832e3611537b44690835ad64f1f5ca93d17a9","unresolved":false,"context_lines":[{"line_number":156,"context_line":"  include ::nova::deps"},{"line_number":157,"context_line":""},{"line_number":158,"context_line":"  if $network_api_class !\u003d undef {"},{"line_number":159,"context_line":"    warning(\u0027network_api_class does not take any affect\u0027)"},{"line_number":160,"context_line":"  }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"  # neutron_admin params removed in Mitaka"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"9a061dce_83cc0fbc","line":159,"range":{"start_line":159,"start_character":49,"end_line":159,"end_character":55},"updated":"2016-04-07 15:22:12.000000000","message":"s/affect/effect/","commit_id":"5f10471e8827d48277c905d832a245f786ff1083"}]}