)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8175,"name":"Rafael Folco","email":"rfolco@redhat.com","username":"rfolco"},"change_message_id":"4563d98b8f46035d31681f297c2718664b0351d2","unresolved":false,"context_lines":[{"line_number":7,"context_line":"Fix libvirtd_opts when using systemd"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"You see the following error when using puppet:"},{"line_number":10,"context_line":"Error: Could not start Service[libvirt]: Execution of \u0027/bin/systemctl start libvirt-bin\u0027 returned 1: Job for libvirt-bin.service failed because the control process exited with error code. See \"systemctl status libvirt-bin.service\" and \"journalctl -xe\" for details."},{"line_number":11,"context_line":""},{"line_number":12,"context_line":"This is because you cannot start the libvirt-bin service twice in a row."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"9a061dce_e4dd9115","line":10,"range":{"start_line":10,"start_character":70,"end_line":10,"end_character":75},"updated":"2016-04-05 16:48:19.000000000","message":"Subsequent lines should be wrapped at 72 characters. \nhttps://wiki.openstack.org/wiki/GitCommitMessages","commit_id":"e5d81ba9097d54849b197e60ece933d06a1582b4"}],"manifests/migration/libvirt.pp":[{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"3432904d1057657fbb9fcd8bcab9ee9460bff9e0","unresolved":false,"context_lines":[{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      if (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":163,"context_line":"        # If systemd is being used then libvirtd is already being launched correctly and"},{"line_number":164,"context_line":"        # adding -d causes a second consecutive start to fail which causes puppet to fail. "},{"line_number":165,"context_line":"        $libvirtd_opts \u003d \u0027libvirtd_opts\u003d\"-l\"\u0027"},{"line_number":166,"context_line":"      } else {"},{"line_number":167,"context_line":"        $libvirtd_opts \u003d \u0027libvirtd_opts\u003d\"-d -l\"\u0027"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_09d53eb8","line":164,"range":{"start_line":164,"start_character":90,"end_line":164,"end_character":91},"updated":"2016-04-05 16:34:22.000000000","message":"trailing space","commit_id":"e5d81ba9097d54849b197e60ece933d06a1582b4"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"3432904d1057657fbb9fcd8bcab9ee9460bff9e0","unresolved":false,"context_lines":[{"line_number":169,"context_line":""},{"line_number":170,"context_line":"      file_line { \"/etc/default/${::nova::compute::libvirt::libvirt_service_name} libvirtd opts\":"},{"line_number":171,"context_line":"        path  \u003d\u003e \"/etc/default/${::nova::compute::libvirt::libvirt_service_name}\","},{"line_number":172,"context_line":"        line  \u003d\u003e \u0027libvirtd_opts\u003d\"-d -l\"\u0027,"},{"line_number":173,"context_line":"        match \u003d\u003e \u0027libvirtd_opts\u003d\u0027,"},{"line_number":174,"context_line":"        tag   \u003d\u003e \u0027libvirt-file_line\u0027,"},{"line_number":175,"context_line":"      }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a061dce_09109ea7","line":172,"range":{"start_line":172,"start_character":0,"end_line":172,"end_character":41},"updated":"2016-04-05 16:34:22.000000000","message":"This probably needs to be\n\n  line  \u003d\u003e \"libvirtd_opts\u003d\\\"${libvirtd_opts}\\\"\",","commit_id":"e5d81ba9097d54849b197e60ece933d06a1582b4"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"dbcf8c3d16e8df68e6dcfcf67700136d6873f296","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        }"},{"line_number":160,"context_line":"      }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      if (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":163,"context_line":"        # If systemd is being used then libvirtd is already being launched correctly and"},{"line_number":164,"context_line":"        # adding -d causes a second consecutive start to fail which causes puppet to fail."},{"line_number":165,"context_line":"        $libvirtd_opts \u003d \u0027libvirtd_opts\u003d\"-l\"\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"9a061dce_fbfbf544","line":162,"updated":"2016-04-07 14:26:40.000000000","message":"could we test operatingsystem \u003d\u003d Ubuntu too?","commit_id":"2e43d3c07b82a11cb7527ceb754a8c1aca28979c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"05267b45ab0f4c323486754a0d01b861652cfdf8","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        }"},{"line_number":160,"context_line":"      }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      if (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":163,"context_line":"        # If systemd is being used then libvirtd is already being launched correctly and"},{"line_number":164,"context_line":"        # adding -d causes a second consecutive start to fail which causes puppet to fail."},{"line_number":165,"context_line":"        $libvirtd_opts \u003d \u0027libvirtd_opts\u003d\"-l\"\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dab17558_da38d0a2","line":162,"in_reply_to":"9a061dce_fbfbf544","updated":"2016-05-10 17:33:27.000000000","message":"Agree, Debian OS has its own release versions","commit_id":"2e43d3c07b82a11cb7527ceb754a8c1aca28979c"},{"author":{"_account_id":7979,"name":"Mikhail S Medvedev","email":"mihailmed@gmail.com","username":"msmedved"},"change_message_id":"4999bfeb0cbbec40e94d330ce1a89e10b13b3875","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        }"},{"line_number":160,"context_line":"      }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      if (versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0) {"},{"line_number":163,"context_line":"        # If systemd is being used then libvirtd is already being launched correctly and"},{"line_number":164,"context_line":"        # adding -d causes a second consecutive start to fail which causes puppet to fail."},{"line_number":165,"context_line":"        $libvirtd_opts \u003d \u0027libvirtd_opts\u003d\"-l\"\u0027"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dab17558_377129a9","line":162,"in_reply_to":"dab17558_da38d0a2","updated":"2016-05-10 22:32:21.000000000","message":"Done","commit_id":"2e43d3c07b82a11cb7527ceb754a8c1aca28979c"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1baff6925c99a3eeb3c0ccedc75350836cc6b015","unresolved":false,"context_lines":[{"line_number":159,"context_line":"        }"},{"line_number":160,"context_line":"      }"},{"line_number":161,"context_line":""},{"line_number":162,"context_line":"      if versioncmp($::operatingsystemmajrelease, \u002716\u0027) \u003e\u003d 0 and $::operatingsystem \u003d\u003d \u0027Ubuntu\u0027 {"},{"line_number":163,"context_line":"        # If systemd is being used then libvirtd is already being launched correctly and"},{"line_number":164,"context_line":"        # adding -d causes a second consecutive start to fail which causes puppet to fail."},{"line_number":165,"context_line":"        $libvirtd_opts \u003d \u0027libvirtd_opts\u003d\"-l\"\u0027"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"dab17558_91056f12","line":162,"updated":"2016-05-11 10:55:34.000000000","message":"I think it would be better to check OS name first and only then check its version","commit_id":"30fb127dd72f831466eaa11f2d0e34e29c9d54bd"}],"spec/classes/nova_compute_libvirt_spec.rb":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d3d9e1e0caec3440be54f2337bd368452e2a7cd0","unresolved":false,"context_lines":[{"line_number":170,"context_line":"      end"},{"line_number":171,"context_line":"    end"},{"line_number":172,"context_line":"  end"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  shared_examples \u0027debian-nova-compute-libvirt-release-16\u0027 do"},{"line_number":175,"context_line":"    describe \u0027with default parameters\u0027 do"},{"line_number":176,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"bab6814e_6cb6e68b","line":173,"updated":"2016-05-18 11:44:34.000000000","message":"i dropped test for this class for now, let\u0027s wait total xenial support in our manifests","commit_id":"30fb127dd72f831466eaa11f2d0e34e29c9d54bd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1baff6925c99a3eeb3c0ccedc75350836cc6b015","unresolved":false,"context_lines":[{"line_number":171,"context_line":"    end"},{"line_number":172,"context_line":"  end"},{"line_number":173,"context_line":""},{"line_number":174,"context_line":"  shared_examples \u0027debian-nova-compute-libvirt-release-16\u0027 do"},{"line_number":175,"context_line":"    describe \u0027with default parameters\u0027 do"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"      it { is_expected.to contain_class(\u0027nova::params\u0027)}"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dab17558_87536d16","line":174,"updated":"2016-05-11 10:55:34.000000000","message":"I suggest to rename these test to ubuntu-nova-compute-libvirt-release-16","commit_id":"30fb127dd72f831466eaa11f2d0e34e29c9d54bd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1baff6925c99a3eeb3c0ccedc75350836cc6b015","unresolved":false,"context_lines":[{"line_number":492,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":493,"context_line":"        :operatingsystem \u003d\u003e \u0027Debian\u0027,"},{"line_number":494,"context_line":"        :os_package_family \u003d\u003e \u0027debian\u0027,"},{"line_number":495,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u002715\u0027"},{"line_number":496,"context_line":"      })"},{"line_number":497,"context_line":"    end"},{"line_number":498,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dab17558_2c2a66db","line":495,"updated":"2016-05-11 10:55:34.000000000","message":"the latest Debian release is 8. I\u0027m not sure that this test is needed.","commit_id":"30fb127dd72f831466eaa11f2d0e34e29c9d54bd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1baff6925c99a3eeb3c0ccedc75350836cc6b015","unresolved":false,"context_lines":[{"line_number":518,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":519,"context_line":"        :operatingsystem \u003d\u003e \u0027Debian\u0027,"},{"line_number":520,"context_line":"        :os_package_family \u003d\u003e \u0027debian\u0027,"},{"line_number":521,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u002716\u0027"},{"line_number":522,"context_line":"      })"},{"line_number":523,"context_line":"    end"},{"line_number":524,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dab17558_4c440ab6","line":521,"updated":"2016-05-11 10:55:34.000000000","message":"same here","commit_id":"30fb127dd72f831466eaa11f2d0e34e29c9d54bd"}],"spec/classes/nova_migration_libvirt_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1baff6925c99a3eeb3c0ccedc75350836cc6b015","unresolved":false,"context_lines":[{"line_number":122,"context_line":"  context \u0027on Debian platforms release 16\u0027 do"},{"line_number":123,"context_line":"    let :facts do"},{"line_number":124,"context_line":"      @default_facts.merge({"},{"line_number":125,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":126,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u002716\u0027"},{"line_number":127,"context_line":"      })"},{"line_number":128,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dab17558_cc463a7a","line":125,"updated":"2016-05-11 10:55:34.000000000","message":":operatingsystem \u003d\u003e \u0027Ubuntu\u0027,","commit_id":"30fb127dd72f831466eaa11f2d0e34e29c9d54bd"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"1baff6925c99a3eeb3c0ccedc75350836cc6b015","unresolved":false,"context_lines":[{"line_number":134,"context_line":"  context \u0027on Debian platforms release 15\u0027 do"},{"line_number":135,"context_line":"    let :facts do"},{"line_number":136,"context_line":"      @default_facts.merge({"},{"line_number":137,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":138,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u002715\u0027"},{"line_number":139,"context_line":"      })"},{"line_number":140,"context_line":"    end"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"dab17558_0c5de246","line":137,"updated":"2016-05-11 10:55:34.000000000","message":":operatingsystem \u003d\u003e \u0027Ubuntu\u0027,","commit_id":"30fb127dd72f831466eaa11f2d0e34e29c9d54bd"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"66e96e68b3132341011eb43180980948263db71f","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      @default_facts.merge({"},{"line_number":126,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":127,"context_line":"        :operatingsystem \u003d\u003e \u0027Ubuntu\u0027,"},{"line_number":128,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u002716\u0027"},{"line_number":129,"context_line":"      })"},{"line_number":130,"context_line":"    end"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"bab6814e_60825e54","line":128,"updated":"2016-05-18 14:08:35.000000000","message":"unit tests fails on latest puppet because we also require this fact set on other distros that are tested. Not obvious but a real problem in this case.","commit_id":"57ba91a59c4330f1e3e817cf4c1b592376deb808"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"048c7c828b0c7322761962479bf7dd904bb41a05","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  context \u0027on Debian platforms release\u0027 do"},{"line_number":137,"context_line":"    let :facts do"},{"line_number":138,"context_line":"      @default_facts.merge({"},{"line_number":139,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027"},{"line_number":140,"context_line":"        :operatingsystem \u003d\u003e \u0027Debian\u0027,"},{"line_number":141,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u00278\u0027"},{"line_number":142,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"bab6814e_c4503761","line":139,"updated":"2016-05-19 15:57:37.000000000","message":"\u0027,\u0027 is missed","commit_id":"9a3f17cba18d268b9f6c8513cfa5c1ce2ffb2bb7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e5785ebcf4066d75b30ca8eeb1d31c9ff22f7fdb","unresolved":false,"context_lines":[{"line_number":136,"context_line":"  context \u0027on Debian platforms release\u0027 do"},{"line_number":137,"context_line":"    let :facts do"},{"line_number":138,"context_line":"      @default_facts.merge({"},{"line_number":139,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027"},{"line_number":140,"context_line":"        :operatingsystem \u003d\u003e \u0027Debian\u0027,"},{"line_number":141,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u00278\u0027"},{"line_number":142,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"bab6814e_24314306","line":139,"in_reply_to":"bab6814e_c4503761","updated":"2016-05-19 16:01:18.000000000","message":"Done","commit_id":"9a3f17cba18d268b9f6c8513cfa5c1ce2ffb2bb7"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"8aec66c8db48bc23e0e210958bfd26305d6ac587","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":150,"context_line":"    let :facts do"},{"line_number":151,"context_line":"      @default_facts.merge({"},{"line_number":152,"context_line":"        :osfamily \u003d\u003e \u0027RedHat\u0027"},{"line_number":153,"context_line":"        :operatingsystem \u003d\u003e \u0027CentOS\u0027,"},{"line_number":154,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u00277.0\u0027"},{"line_number":155,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"bab6814e_64efcb87","line":152,"updated":"2016-05-19 15:58:01.000000000","message":"same here","commit_id":"9a3f17cba18d268b9f6c8513cfa5c1ce2ffb2bb7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"e5785ebcf4066d75b30ca8eeb1d31c9ff22f7fdb","unresolved":false,"context_lines":[{"line_number":149,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":150,"context_line":"    let :facts do"},{"line_number":151,"context_line":"      @default_facts.merge({"},{"line_number":152,"context_line":"        :osfamily \u003d\u003e \u0027RedHat\u0027"},{"line_number":153,"context_line":"        :operatingsystem \u003d\u003e \u0027CentOS\u0027,"},{"line_number":154,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u00277.0\u0027"},{"line_number":155,"context_line":"      })"}],"source_content_type":"text/x-ruby","patch_set":8,"id":"bab6814e_64198b88","line":152,"in_reply_to":"bab6814e_64efcb87","updated":"2016-05-19 16:01:18.000000000","message":"Done","commit_id":"9a3f17cba18d268b9f6c8513cfa5c1ce2ffb2bb7"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"822bf5ca30bb622158cd996769d69f5b5a101077","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      @default_facts.merge({"},{"line_number":126,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":127,"context_line":"        :operatingsystem \u003d\u003e \u0027Ubuntu\u0027,"},{"line_number":128,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u002716\u0027"},{"line_number":129,"context_line":"      })"},{"line_number":130,"context_line":"    end"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"bab6814e_9c7ddf70","line":128,"updated":"2016-05-19 17:43:39.000000000","message":"don\u0027t get why puppet-latest broken: http://logs.openstack.org/06/301806/9/check/gate-puppet-nova-puppet-unit-latest-centos-7/cba8c0c/console.html#_2016-05-19_16_27_24_484\n\nAll facts passed for 3 cases. Any ideas?","commit_id":"ad8b19433e528676fb374f9a49b2c648433e41c9"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"9ac067c0cdba624eec21695a0dc5c2e9f7271c18","unresolved":false,"context_lines":[{"line_number":125,"context_line":"      @default_facts.merge({"},{"line_number":126,"context_line":"        :osfamily \u003d\u003e \u0027Debian\u0027,"},{"line_number":127,"context_line":"        :operatingsystem \u003d\u003e \u0027Ubuntu\u0027,"},{"line_number":128,"context_line":"        :operatingsystemmajrelease \u003d\u003e \u002716\u0027"},{"line_number":129,"context_line":"      })"},{"line_number":130,"context_line":"    end"},{"line_number":131,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":9,"id":"bab6814e_853c62e3","line":128,"in_reply_to":"bab6814e_9c7ddf70","updated":"2016-05-19 19:39:33.000000000","message":"It\u0027s because of where this is. Additional tests need to be updated (nova::compute::libvirt being one of them)","commit_id":"ad8b19433e528676fb374f9a49b2c648433e41c9"}]}