)]}'
{"manifests/api.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"e8e774670a21e674d8a8c1e0f3b63e437506ec5d","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  include ::cinder::client"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if $volume_api_class {"},{"line_number":223,"context_line":"    warning(\u0027volume_api_class parameter is deprecated and will be removed in a future release.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  if $ec2_listen_port or $ec2_workers or $keystone_ec2_url {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_730240b6","line":223,"range":{"start_line":223,"start_character":12,"end_line":223,"end_character":93},"updated":"2016-04-21 11:59:01.000000000","message":"Please mention that this parameter has no effect, as you removed if from a config file","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ddc6984a2a2204de4b04880f56adc36e83c639a","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  include ::cinder::client"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if $volume_api_class {"},{"line_number":223,"context_line":"    warning(\u0027volume_api_class parameter is deprecated and will be removed in a future release.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  if $ec2_listen_port or $ec2_workers or $keystone_ec2_url {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_53ff44aa","line":223,"updated":"2016-04-21 11:59:06.000000000","message":"so, you marked this parameter as deprecated, but removed it from config. May be then will be better raise warning with:\n\n\u003cparameter\u003e has no effect ?","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ea8b547368cf7cb94756f71aff5d7e04c1e4f6ba","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  include ::cinder::client"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if $volume_api_class {"},{"line_number":223,"context_line":"    warning(\u0027volume_api_class parameter is deprecated and will be removed in a future release.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  if $ec2_listen_port or $ec2_workers or $keystone_ec2_url {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_96f1ca6d","line":223,"in_reply_to":"1a122d0e_53ff44aa","updated":"2016-04-21 12:27:01.000000000","message":"Done","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"19a21293f24bba573622689f5b9045cb63caf68b","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  include ::cinder::client"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if $volume_api_class {"},{"line_number":223,"context_line":"    warning(\u0027volume_api_class parameter is deprecatedi, has no effect and will be removed in a future release.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  if $ec2_listen_port or $ec2_workers or $keystone_ec2_url {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_fd9f094e","line":223,"range":{"start_line":223,"start_character":53,"end_line":223,"end_character":54},"updated":"2016-04-22 11:30:24.000000000","message":"typo :)","commit_id":"a67e09af09524b0166140d5bb4a0d4bc14c5e470"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3c44d3da1334b049e0cea390077d772078ff90e7","unresolved":false,"context_lines":[{"line_number":220,"context_line":"  include ::cinder::client"},{"line_number":221,"context_line":""},{"line_number":222,"context_line":"  if $volume_api_class {"},{"line_number":223,"context_line":"    warning(\u0027volume_api_class parameter is deprecatedi, has no effect and will be removed in a future release.\u0027)"},{"line_number":224,"context_line":"  }"},{"line_number":225,"context_line":""},{"line_number":226,"context_line":"  if $ec2_listen_port or $ec2_workers or $keystone_ec2_url {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"1a122d0e_b3cacb4d","line":223,"range":{"start_line":223,"start_character":53,"end_line":223,"end_character":54},"in_reply_to":"1a122d0e_fd9f094e","updated":"2016-04-22 20:12:03.000000000","message":"Done","commit_id":"a67e09af09524b0166140d5bb4a0d4bc14c5e470"}],"manifests/conductor.pp":[{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"e8e774670a21e674d8a8c1e0f3b63e437506ec5d","unresolved":false,"context_lines":[{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if $use_local {"},{"line_number":39,"context_line":"    warning(\u0027use_local parameter is deprecated and will be dropped in a future release.\u0027)"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_b32a182e","line":39,"range":{"start_line":39,"start_character":13,"end_line":39,"end_character":32},"updated":"2016-04-21 11:59:01.000000000","message":"The same as in previous file","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ddc6984a2a2204de4b04880f56adc36e83c639a","unresolved":false,"context_lines":[{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if $use_local {"},{"line_number":39,"context_line":"    warning(\u0027use_local parameter is deprecated and will be dropped in a future release.\u0027)"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_d3299439","line":39,"updated":"2016-04-21 11:59:06.000000000","message":"same","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ea8b547368cf7cb94756f71aff5d7e04c1e4f6ba","unresolved":false,"context_lines":[{"line_number":36,"context_line":") {"},{"line_number":37,"context_line":""},{"line_number":38,"context_line":"  if $use_local {"},{"line_number":39,"context_line":"    warning(\u0027use_local parameter is deprecated and will be dropped in a future release.\u0027)"},{"line_number":40,"context_line":"  }"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_76fb4e48","line":39,"in_reply_to":"1a122d0e_d3299439","updated":"2016-04-21 12:27:01.000000000","message":"Done","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"}],"manifests/network/neutron.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ddc6984a2a2204de4b04880f56adc36e83c639a","unresolved":false,"context_lines":[{"line_number":154,"context_line":"  include ::nova::deps"},{"line_number":155,"context_line":""},{"line_number":156,"context_line":"  if $network_api_class !\u003d undef {"},{"line_number":157,"context_line":"    warning(\u0027network_api_class has no effect and will be dropped in a future release.\u0027)"},{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  if $security_group_api !\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_131cac12","line":157,"updated":"2016-04-21 11:59:06.000000000","message":"same","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ddc6984a2a2204de4b04880f56adc36e83c639a","unresolved":false,"context_lines":[{"line_number":158,"context_line":"  }"},{"line_number":159,"context_line":""},{"line_number":160,"context_line":"  if $security_group_api !\u003d undef {"},{"line_number":161,"context_line":"    warning(\u0027security_group_api has no effect and will be dropped in a future release.\u0027)"},{"line_number":162,"context_line":"  }"},{"line_number":163,"context_line":""},{"line_number":164,"context_line":"  # neutron_admin params removed in Mitaka"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_331f280b","line":161,"updated":"2016-04-21 11:59:06.000000000","message":"same","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"6ddc6984a2a2204de4b04880f56adc36e83c639a","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    \u0027neutron/auth_url\u0027:                value \u003d\u003e $neutron_auth_url_real;"},{"line_number":233,"context_line":"    \u0027neutron/ovs_bridge\u0027:              value \u003d\u003e $neutron_ovs_bridge;"},{"line_number":234,"context_line":"    \u0027neutron/extension_sync_interval\u0027: value \u003d\u003e $neutron_extension_sync_interval;"},{"line_number":235,"context_line":"    \u0027neutron/auth_type\u0027:               value \u003d\u003e $neutron_auth_plugin;"},{"line_number":236,"context_line":"  }"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"  if ! $neutron_ca_certificates_file {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_535104d8","line":235,"updated":"2016-04-21 11:59:06.000000000","message":"this is not obvious, may be we should update paramter too? not only config section","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"ea8b547368cf7cb94756f71aff5d7e04c1e4f6ba","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    \u0027neutron/auth_url\u0027:                value \u003d\u003e $neutron_auth_url_real;"},{"line_number":233,"context_line":"    \u0027neutron/ovs_bridge\u0027:              value \u003d\u003e $neutron_ovs_bridge;"},{"line_number":234,"context_line":"    \u0027neutron/extension_sync_interval\u0027: value \u003d\u003e $neutron_extension_sync_interval;"},{"line_number":235,"context_line":"    \u0027neutron/auth_type\u0027:               value \u003d\u003e $neutron_auth_plugin;"},{"line_number":236,"context_line":"  }"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"  if ! $neutron_ca_certificates_file {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_b6616614","line":235,"in_reply_to":"1a122d0e_139f8c51","updated":"2016-04-21 12:27:01.000000000","message":"I wanted to reduce the impact on deployments. Maybe I can add the new parameter and let users set it.","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"},{"author":{"_account_id":7604,"name":"Sergey Kolekonov","email":"skolekonov@mirantis.com","username":"skolekonov"},"change_message_id":"b37aa896d4d8ab493163d8845622bf12d08a4f2f","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    \u0027neutron/auth_url\u0027:                value \u003d\u003e $neutron_auth_url_real;"},{"line_number":233,"context_line":"    \u0027neutron/ovs_bridge\u0027:              value \u003d\u003e $neutron_ovs_bridge;"},{"line_number":234,"context_line":"    \u0027neutron/extension_sync_interval\u0027: value \u003d\u003e $neutron_extension_sync_interval;"},{"line_number":235,"context_line":"    \u0027neutron/auth_type\u0027:               value \u003d\u003e $neutron_auth_plugin;"},{"line_number":236,"context_line":"  }"},{"line_number":237,"context_line":""},{"line_number":238,"context_line":"  if ! $neutron_ca_certificates_file {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a122d0e_139f8c51","line":235,"in_reply_to":"1a122d0e_535104d8","updated":"2016-04-21 12:01:21.000000000","message":"This looks acceptable, just to not increase number of options","commit_id":"1e3a732a5d0b7b17102f437b519fbccc394b5951"}]}