)]}'
{"manifests/compute/ironic.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4bdebcd6a2bb97795f6f339eacfdfa0657a38ff0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   Defaults to $::os_service_default."},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"class nova::compute::ironic ("},{"line_number":42,"context_line":"  $admin_username        \u003d \u0027admin\u0027,"},{"line_number":43,"context_line":"  $admin_password        \u003d \u0027ironic\u0027,"},{"line_number":44,"context_line":"  $admin_url             \u003d \u0027http://127.0.0.1:35357/v2.0\u0027,"},{"line_number":45,"context_line":"  $admin_tenant_name     \u003d \u0027services\u0027,"},{"line_number":46,"context_line":"  $api_endpoint          \u003d \u0027http://127.0.0.1:6385/v1\u0027,"},{"line_number":47,"context_line":"  $max_concurrent_builds \u003d $::os_service_default,"},{"line_number":48,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":49,"context_line":"  $admin_user            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_a15be520","line":46,"range":{"start_line":42,"start_character":0,"end_line":46,"end_character":54},"updated":"2016-05-17 15:58:12.000000000","message":"let\u0027s switch to undef","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"41a4160f7af59cdf1bff6893d339d47185afd3d5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"#   Defaults to $::os_service_default."},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"class nova::compute::ironic ("},{"line_number":42,"context_line":"  $admin_username        \u003d \u0027admin\u0027,"},{"line_number":43,"context_line":"  $admin_password        \u003d \u0027ironic\u0027,"},{"line_number":44,"context_line":"  $admin_url             \u003d \u0027http://127.0.0.1:35357/v2.0\u0027,"},{"line_number":45,"context_line":"  $admin_tenant_name     \u003d \u0027services\u0027,"},{"line_number":46,"context_line":"  $api_endpoint          \u003d \u0027http://127.0.0.1:6385/v1\u0027,"},{"line_number":47,"context_line":"  $max_concurrent_builds \u003d $::os_service_default,"},{"line_number":48,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":49,"context_line":"  $admin_user            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_e18ccd36","line":46,"range":{"start_line":42,"start_character":0,"end_line":46,"end_character":54},"in_reply_to":"dab17558_a15be520","updated":"2016-05-17 16:03:53.000000000","message":"Done","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"968cc5bd124a3e521bdcda89507282e18c037702","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $admin_password        \u003d undef,"},{"line_number":44,"context_line":"  $admin_url             \u003d undef,"},{"line_number":45,"context_line":"  $admin_tenant_name     \u003d undef,"},{"line_number":46,"context_line":"  $api_endpoint          \u003d undef,"},{"line_number":47,"context_line":"  $max_concurrent_builds \u003d $::os_service_default,"},{"line_number":48,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":49,"context_line":"  $admin_user            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_402bda82","line":46,"updated":"2016-05-18 14:06:24.000000000","message":"should we deprecate them?","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"bbc058df23f60953ba922dfde3e593b780f1e04a","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $admin_password        \u003d undef,"},{"line_number":44,"context_line":"  $admin_url             \u003d undef,"},{"line_number":45,"context_line":"  $admin_tenant_name     \u003d undef,"},{"line_number":46,"context_line":"  $api_endpoint          \u003d undef,"},{"line_number":47,"context_line":"  $max_concurrent_builds \u003d $::os_service_default,"},{"line_number":48,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":49,"context_line":"  $admin_user            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_6fe69bb5","line":46,"in_reply_to":"bab6814e_402bda82","updated":"2016-05-19 11:00:58.000000000","message":"Agree here","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"de58a9896e77b54df032ae0865e213148114b0e9","unresolved":false,"context_lines":[{"line_number":43,"context_line":"  $admin_password        \u003d undef,"},{"line_number":44,"context_line":"  $admin_url             \u003d undef,"},{"line_number":45,"context_line":"  $admin_tenant_name     \u003d undef,"},{"line_number":46,"context_line":"  $api_endpoint          \u003d undef,"},{"line_number":47,"context_line":"  $max_concurrent_builds \u003d $::os_service_default,"},{"line_number":48,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":49,"context_line":"  $admin_user            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_0afb73c2","line":46,"in_reply_to":"bab6814e_6fe69bb5","updated":"2016-05-19 13:39:41.000000000","message":"+1","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"}],"manifests/ironic/common.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4bdebcd6a2bb97795f6f339eacfdfa0657a38ff0","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $admin_password    \u003d undef,"},{"line_number":26,"context_line":"  $admin_tenant_name \u003d undef,"},{"line_number":27,"context_line":"  $admin_url         \u003d undef,"},{"line_number":28,"context_line":"  $api_endpoint      \u003d undef,"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_de1c0879","line":28,"updated":"2016-05-17 15:58:12.000000000","message":"better to have undef in compute class and here should be defaults, imho","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"41a4160f7af59cdf1bff6893d339d47185afd3d5","unresolved":false,"context_lines":[{"line_number":25,"context_line":"  $admin_password    \u003d undef,"},{"line_number":26,"context_line":"  $admin_tenant_name \u003d undef,"},{"line_number":27,"context_line":"  $admin_url         \u003d undef,"},{"line_number":28,"context_line":"  $api_endpoint      \u003d undef,"},{"line_number":29,"context_line":") {"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_c19d4967","line":28,"in_reply_to":"dab17558_de1c0879","updated":"2016-05-17 16:03:53.000000000","message":"Done","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4bdebcd6a2bb97795f6f339eacfdfa0657a38ff0","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::nova::deps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  $admin_username_real \u003d pick("},{"line_number":34,"context_line":"    $admin_username,"},{"line_number":35,"context_line":"    $::nova::compute::ironic::admin_username,"},{"line_number":36,"context_line":"    $::nova::compute::ironic::admin_user,"},{"line_number":37,"context_line":"    \u0027ironic\u0027)"},{"line_number":38,"context_line":"  $admin_password_real \u003d pick("},{"line_number":39,"context_line":"    $admin_password,"},{"line_number":40,"context_line":"    $::nova::compute::ironic::admin_password,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_2121b59e","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":13},"updated":"2016-05-17 15:58:12.000000000","message":"$admin_username_real \u003d pick(\n    $::nova::compute::ironic::admin_username,\n    $::nova::compute::ironic::admin_user,\n    $admin_username,)","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"41a4160f7af59cdf1bff6893d339d47185afd3d5","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::nova::deps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  $admin_username_real \u003d pick("},{"line_number":34,"context_line":"    $admin_username,"},{"line_number":35,"context_line":"    $::nova::compute::ironic::admin_username,"},{"line_number":36,"context_line":"    $::nova::compute::ironic::admin_user,"},{"line_number":37,"context_line":"    \u0027ironic\u0027)"},{"line_number":38,"context_line":"  $admin_password_real \u003d pick("},{"line_number":39,"context_line":"    $admin_password,"},{"line_number":40,"context_line":"    $::nova::compute::ironic::admin_password,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_61929d58","line":37,"range":{"start_line":33,"start_character":0,"end_line":37,"end_character":13},"in_reply_to":"dab17558_2121b59e","updated":"2016-05-17 16:03:53.000000000","message":"Done","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4bdebcd6a2bb97795f6f339eacfdfa0657a38ff0","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    $admin_password,"},{"line_number":40,"context_line":"    $::nova::compute::ironic::admin_password,"},{"line_number":41,"context_line":"    $::nova::compute::ironic::admin_passwd,"},{"line_number":42,"context_line":"    \u0027ironic\u0027)"},{"line_number":43,"context_line":"  $admin_tenant_name_real \u003d pick("},{"line_number":44,"context_line":"    $admin_tenant_name,"},{"line_number":45,"context_line":"    $::nova::compute::ironic::admin_tenant_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_4155d9f7","line":42,"updated":"2016-05-17 15:58:12.000000000","message":"same and below","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"41a4160f7af59cdf1bff6893d339d47185afd3d5","unresolved":false,"context_lines":[{"line_number":39,"context_line":"    $admin_password,"},{"line_number":40,"context_line":"    $::nova::compute::ironic::admin_password,"},{"line_number":41,"context_line":"    $::nova::compute::ironic::admin_passwd,"},{"line_number":42,"context_line":"    \u0027ironic\u0027)"},{"line_number":43,"context_line":"  $admin_tenant_name_real \u003d pick("},{"line_number":44,"context_line":"    $admin_tenant_name,"},{"line_number":45,"context_line":"    $::nova::compute::ironic::admin_tenant_name,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_41a9598f","line":42,"in_reply_to":"dab17558_4155d9f7","updated":"2016-05-17 16:03:53.000000000","message":"Done","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4bdebcd6a2bb97795f6f339eacfdfa0657a38ff0","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027ironic/admin_username\u0027:            value \u003d\u003e $admin_username_real;"},{"line_number":58,"context_line":"    \u0027ironic/admin_password\u0027:            value \u003d\u003e $admin_password_real;"},{"line_number":59,"context_line":"    \u0027ironic/admin_url\u0027:                 value \u003d\u003e $admin_url_real;"},{"line_number":60,"context_line":"    \u0027ironic/admin_tenant_name\u0027:         value \u003d\u003e $admin_tenant_name_real;"},{"line_number":61,"context_line":"    \u0027ironic/api_endpoint\u0027:              value \u003d\u003e $api_endpoint_real;"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_01011105","line":60,"updated":"2016-05-17 15:58:12.000000000","message":"aligment","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"41a4160f7af59cdf1bff6893d339d47185afd3d5","unresolved":false,"context_lines":[{"line_number":57,"context_line":"    \u0027ironic/admin_username\u0027:            value \u003d\u003e $admin_username_real;"},{"line_number":58,"context_line":"    \u0027ironic/admin_password\u0027:            value \u003d\u003e $admin_password_real;"},{"line_number":59,"context_line":"    \u0027ironic/admin_url\u0027:                 value \u003d\u003e $admin_url_real;"},{"line_number":60,"context_line":"    \u0027ironic/admin_tenant_name\u0027:         value \u003d\u003e $admin_tenant_name_real;"},{"line_number":61,"context_line":"    \u0027ironic/api_endpoint\u0027:              value \u003d\u003e $api_endpoint_real;"},{"line_number":62,"context_line":"  }"},{"line_number":63,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dab17558_01a3d1b2","line":60,"in_reply_to":"dab17558_01011105","updated":"2016-05-17 16:03:53.000000000","message":"Done","commit_id":"a5a769765884bbe8f3f80de8319bd4756dd8c558"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"4b93ea9c5dbadab96658f0738fcc2dd0e4da35c1","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::nova::deps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  $admin_username_real \u003d pick("},{"line_number":34,"context_line":"    $::nova::compute::ironic::admin_username,"},{"line_number":35,"context_line":"    $::nova::compute::ironic::admin_user,"},{"line_number":36,"context_line":"    $admin_username)"},{"line_number":37,"context_line":"  $admin_password_real \u003d pick("},{"line_number":38,"context_line":"    $::nova::compute::ironic::admin_password,"},{"line_number":39,"context_line":"    $::nova::compute::ironic::admin_passwd,"},{"line_number":40,"context_line":"    $admin_password)"},{"line_number":41,"context_line":"  $admin_tenant_name_real \u003d pick("},{"line_number":42,"context_line":"    $::nova::compute::ironic::admin_tenant_name,"},{"line_number":43,"context_line":"    $admin_tenant_name)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_fab8d6e7","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":20},"updated":"2016-05-18 07:41:51.000000000","message":"was:\n\n  $admin_username_real \u003d pick($admin_user, $admin_username)\n  $admin_password_real \u003d pick($admin_passwd, $admin_password)\n\nyou should keep same order here:\n\n  $admin_username_real \u003d pick(\n    $::nova::compute::ironic::admin_user,\n    $::nova::compute::ironic::admin_username,\n    $admin_username)\n\nsame for password","commit_id":"ed89fd63d232db5d0f063d6ea5f2974e030307ad"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"2d631c73546a9fbb6300f7fab253e8a81b9a42ce","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  include ::nova::deps"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"  $admin_username_real \u003d pick("},{"line_number":34,"context_line":"    $::nova::compute::ironic::admin_username,"},{"line_number":35,"context_line":"    $::nova::compute::ironic::admin_user,"},{"line_number":36,"context_line":"    $admin_username)"},{"line_number":37,"context_line":"  $admin_password_real \u003d pick("},{"line_number":38,"context_line":"    $::nova::compute::ironic::admin_password,"},{"line_number":39,"context_line":"    $::nova::compute::ironic::admin_passwd,"},{"line_number":40,"context_line":"    $admin_password)"},{"line_number":41,"context_line":"  $admin_tenant_name_real \u003d pick("},{"line_number":42,"context_line":"    $::nova::compute::ironic::admin_tenant_name,"},{"line_number":43,"context_line":"    $admin_tenant_name)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bab6814e_cbc0a6e3","line":40,"range":{"start_line":33,"start_character":0,"end_line":40,"end_character":20},"in_reply_to":"bab6814e_fab8d6e7","updated":"2016-05-18 08:59:45.000000000","message":"Done","commit_id":"ed89fd63d232db5d0f063d6ea5f2974e030307ad"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"32070bbe155728882d687b76bb76f5d3a5cda9cb","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::ironic::common"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# [*admin_username*]"},{"line_number":4,"context_line":"#   The admin username for Ironic to connect to Nova."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_7e6496e4","line":1,"updated":"2016-05-19 08:07:50.000000000","message":"As far I understood this class should contain common parameters for all nova-* services in Ironic section.","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b2248b62fc658cc009f84d560392335de04e65c0","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::ironic::common"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# [*admin_username*]"},{"line_number":4,"context_line":"#   The admin username for Ironic to connect to Nova."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_6414fd43","line":1,"in_reply_to":"bab6814e_0f854fac","updated":"2016-05-19 11:20:24.000000000","message":"There is a full list of parameters in ironic section from nova.conf.samle https://paste.mirantis.net/show/2283/","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ef7e87f33f98d266339a423b8faef754c38273d3","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::ironic::common"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# [*admin_username*]"},{"line_number":4,"context_line":"#   The admin username for Ironic to connect to Nova."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_d78f5921","line":1,"in_reply_to":"bab6814e_6414fd43","updated":"2016-05-19 11:44:58.000000000","message":"Ok, if you want - you can add all parameters in one patch.","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"bbc058df23f60953ba922dfde3e593b780f1e04a","unresolved":false,"context_lines":[{"line_number":1,"context_line":"# \u003d\u003d Class: nova::ironic::common"},{"line_number":2,"context_line":"#"},{"line_number":3,"context_line":"# [*admin_username*]"},{"line_number":4,"context_line":"#   The admin username for Ironic to connect to Nova."}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_0f854fac","line":1,"in_reply_to":"bab6814e_7e6496e4","updated":"2016-05-19 11:00:58.000000000","message":"For now we have only 5 parameters, haven\u0027t we?","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"2988ec589cbe675f676427cfdb04f76ace07206e","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   The url for Ironic api endpoint."},{"line_number":21,"context_line":"#   Defaults to \u0027http://127.0.0.1:6385/v1\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::ironic::common ("},{"line_number":24,"context_line":"  $admin_username    \u003d \u0027admin\u0027,"},{"line_number":25,"context_line":"  $admin_password    \u003d \u0027ironic\u0027,"},{"line_number":26,"context_line":"  $admin_tenant_name \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_43ec5d8f","line":23,"updated":"2016-05-19 08:04:21.000000000","message":"All these parameters are required for both nova:api and nova:compute","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"bbc058df23f60953ba922dfde3e593b780f1e04a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   The url for Ironic api endpoint."},{"line_number":21,"context_line":"#   Defaults to \u0027http://127.0.0.1:6385/v1\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::ironic::common ("},{"line_number":24,"context_line":"  $admin_username    \u003d \u0027admin\u0027,"},{"line_number":25,"context_line":"  $admin_password    \u003d \u0027ironic\u0027,"},{"line_number":26,"context_line":"  $admin_tenant_name \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_af4a4381","line":23,"in_reply_to":"bab6814e_43ec5d8f","updated":"2016-05-19 11:00:58.000000000","message":"So what? We don\u0027t have right now any parameters in nova::api.\n\nAlso, including this class in nova::api is not necessary. Why? Becase we may dont use ironic at all. Why we need to spawn extra parameters in config then?","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"de58a9896e77b54df032ae0865e213148114b0e9","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   The url for Ironic api endpoint."},{"line_number":21,"context_line":"#   Defaults to \u0027http://127.0.0.1:6385/v1\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::ironic::common ("},{"line_number":24,"context_line":"  $admin_username    \u003d \u0027admin\u0027,"},{"line_number":25,"context_line":"  $admin_password    \u003d \u0027ironic\u0027,"},{"line_number":26,"context_line":"  $admin_tenant_name \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_2a69178c","line":23,"in_reply_to":"bab6814e_97c5d13d","updated":"2016-05-19 13:39:41.000000000","message":"I don not mind ether.","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"b2248b62fc658cc009f84d560392335de04e65c0","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   The url for Ironic api endpoint."},{"line_number":21,"context_line":"#   Defaults to \u0027http://127.0.0.1:6385/v1\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::ironic::common ("},{"line_number":24,"context_line":"  $admin_username    \u003d \u0027admin\u0027,"},{"line_number":25,"context_line":"  $admin_password    \u003d \u0027ironic\u0027,"},{"line_number":26,"context_line":"  $admin_tenant_name \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_c1b95bcd","line":23,"in_reply_to":"bab6814e_af4a4381","updated":"2016-05-19 11:20:24.000000000","message":"If you do not using Ironic, then this parameters will be with default values and there is no need to set them.\n\nBesides this parameters are used by nova baremetal api which is a part of nova.","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"ef7e87f33f98d266339a423b8faef754c38273d3","unresolved":false,"context_lines":[{"line_number":20,"context_line":"#   The url for Ironic api endpoint."},{"line_number":21,"context_line":"#   Defaults to \u0027http://127.0.0.1:6385/v1\u0027"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::ironic::common ("},{"line_number":24,"context_line":"  $admin_username    \u003d \u0027admin\u0027,"},{"line_number":25,"context_line":"  $admin_password    \u003d \u0027ironic\u0027,"},{"line_number":26,"context_line":"  $admin_tenant_name \u003d \u0027services\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bab6814e_97c5d13d","line":23,"in_reply_to":"bab6814e_c1b95bcd","updated":"2016-05-19 11:44:58.000000000","message":"I\u0027m disagree with including this class to nova::api. There are no any reasons for that.\n\nWe have include for nova::compute::ironic only because for keeping backward compatibility.","commit_id":"a4396fb001466512547ed83ededafef907ac5ba5"}],"spec/classes/nova_ironic_common_spec.rb":[{"author":{"_account_id":14525,"name":"Vasyl Saienko","email":"vsaienko@mirantis.com","username":"vsaienko"},"change_message_id":"8c79a1f9ef33376988c7211c859ff91543c08027","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/admin_url\u0027).with_value(\u0027http://10.0.0.10:35357/v2.0\u0027)"},{"line_number":32,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/admin_tenant_name\u0027).with_value(\u0027services2\u0027)"},{"line_number":33,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/api_endpoint\u0027).with_value(\u0027http://10.0.0.10:6385/v1\u0027)"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":"  end"},{"line_number":36,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"bab6814e_0bbc676b","line":34,"updated":"2016-05-18 10:19:09.000000000","message":"it looks that end for context is missed here. That is why tests are failing.","commit_id":"ba88a7caadbafdae80a5ac5ec171c8356dfc7a61"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"804ab7d4a65699c6fc23102acaad6f4dac7b3163","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/admin_url\u0027).with_value(\u0027http://10.0.0.10:35357/v2.0\u0027)"},{"line_number":32,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/admin_tenant_name\u0027).with_value(\u0027services2\u0027)"},{"line_number":33,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/api_endpoint\u0027).with_value(\u0027http://10.0.0.10:6385/v1\u0027)"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":"  end"},{"line_number":36,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"bab6814e_d64e8295","line":34,"in_reply_to":"bab6814e_0bbc676b","updated":"2016-05-18 10:33:04.000000000","message":"also you should to call your \u0027nova-ironic-common\u0027 shared example","commit_id":"ba88a7caadbafdae80a5ac5ec171c8356dfc7a61"},{"author":{"_account_id":8259,"name":"Andrey Shestakov","email":"ashestakov@mirantis.com","username":"ashestakov"},"change_message_id":"7c856d66387d96fb6e3dab096ec63a126961555b","unresolved":false,"context_lines":[{"line_number":31,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/admin_url\u0027).with_value(\u0027http://10.0.0.10:35357/v2.0\u0027)"},{"line_number":32,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/admin_tenant_name\u0027).with_value(\u0027services2\u0027)"},{"line_number":33,"context_line":"      is_expected.to contain_nova_config(\u0027ironic/api_endpoint\u0027).with_value(\u0027http://10.0.0.10:6385/v1\u0027)"},{"line_number":34,"context_line":"    end"},{"line_number":35,"context_line":"  end"},{"line_number":36,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"bab6814e_3c124f63","line":34,"in_reply_to":"bab6814e_d64e8295","updated":"2016-05-18 10:59:09.000000000","message":"Done","commit_id":"ba88a7caadbafdae80a5ac5ec171c8356dfc7a61"}]}