)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"8f5d969cda2347f2e64de50fc843dd762c900efa","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mykyta Karpin \u003cmkarpin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-19 14:41:54 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ssl middleware configuration option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I22deb886706fe71115a04fb52a7051be4783a5c4"},{"line_number":10,"context_line":"Related-bug: #1576740"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_70f8334a","line":7,"updated":"2016-05-19 12:32:53.000000000","message":"it\u0027s not necessarily an SSL thing, it might be the case of a reverse proxy","commit_id":"e4d955c37e50974da6ce6865ae1e291230bc0e39"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"ad370229a8de0249026acb12707e4fafd45dcf36","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Mykyta Karpin \u003cmkarpin@mirantis.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-05-19 14:41:54 +0300"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add ssl middleware configuration option"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I22deb886706fe71115a04fb52a7051be4783a5c4"},{"line_number":10,"context_line":"Related-bug: #1576740"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"bab6814e_668fddcc","line":7,"in_reply_to":"bab6814e_70f8334a","updated":"2016-05-19 12:59:41.000000000","message":"Done","commit_id":"e4d955c37e50974da6ce6865ae1e291230bc0e39"}],"manifests/api.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"73ac5048ebda25e6c1b1facc476086afe15282db","unresolved":false,"context_lines":[{"line_number":316,"context_line":"    \u0027DEFAULT/default_floating_pool\u0027:           value \u003d\u003e $default_floating_pool;"},{"line_number":317,"context_line":"    \u0027DEFAULT/fping_path\u0027:                      value \u003d\u003e $fping_path;"},{"line_number":318,"context_line":"    \u0027osapi_v3/enabled\u0027:                        value \u003d\u003e $osapi_v3;"},{"line_number":319,"context_line":"    \u0027oslo_middleware/secure_proxy_ssl_header\u0027: value \u003d\u003e $secure_proxy_ssl_header;"},{"line_number":320,"context_line":"  }"},{"line_number":321,"context_line":""},{"line_number":322,"context_line":"  if ($neutron_metadata_proxy_shared_secret){"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bab6814e_081394b9","line":319,"updated":"2016-05-19 07:43:47.000000000","message":"It seems that this is only taking into account the ssl middleware, which is not included by default in nova and is set for deprecation https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/ssl.py\n\nWouldn\u0027t it be better to propose the setting of this https://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/http_proxy_to_wsgi.py ? It\u0027s not included in nova, but it is included in Heat by default, and could potentially be proposed for nova too.","commit_id":"2b525c6351d047559771007c4caf94f00d67f920"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"8f5d969cda2347f2e64de50fc843dd762c900efa","unresolved":false,"context_lines":[{"line_number":137,"context_line":"#   Defaults to false"},{"line_number":138,"context_line":"#"},{"line_number":139,"context_line":"# [*enable_proxy_headers_parsing*]"},{"line_number":140,"context_line":"#   (optional) Enables SSL request handling from HTTPProxyToWSGI middleware."},{"line_number":141,"context_line":"#   (boolean value)"},{"line_number":142,"context_line":"#   Defaults to $::os_service_default"},{"line_number":143,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_506ecf2f","line":140,"updated":"2016-05-19 12:32:53.000000000","message":"I think we could come up with a better description here. SSL is definitely one case, but there is also a general case of running nova-api behind a reverse proxy -  both  are solved by HTTPProxyToWSGI WSGI middleware.\n\n\nCan we use the help text from oslo_middleware?\n\nhttps://github.com/openstack/oslo.middleware/blob/master/oslo_middleware/http_proxy_to_wsgi.py#L19-L33","commit_id":"e4d955c37e50974da6ce6865ae1e291230bc0e39"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"ad370229a8de0249026acb12707e4fafd45dcf36","unresolved":false,"context_lines":[{"line_number":137,"context_line":"#   Defaults to false"},{"line_number":138,"context_line":"#"},{"line_number":139,"context_line":"# [*enable_proxy_headers_parsing*]"},{"line_number":140,"context_line":"#   (optional) Enables SSL request handling from HTTPProxyToWSGI middleware."},{"line_number":141,"context_line":"#   (boolean value)"},{"line_number":142,"context_line":"#   Defaults to $::os_service_default"},{"line_number":143,"context_line":"#"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_c61209b4","line":140,"in_reply_to":"bab6814e_506ecf2f","updated":"2016-05-19 12:59:41.000000000","message":"Done","commit_id":"e4d955c37e50974da6ce6865ae1e291230bc0e39"},{"author":{"_account_id":6849,"name":"Roman Podoliaka","email":"roman.podoliaka@gmail.com","username":"rpodolyaka"},"change_message_id":"8f5d969cda2347f2e64de50fc843dd762c900efa","unresolved":false,"context_lines":[{"line_number":180,"context_line":"#"},{"line_number":181,"context_line":"class nova::api("},{"line_number":182,"context_line":"  $admin_password,"},{"line_number":183,"context_line":"  $enabled                      \u003d true,"},{"line_number":184,"context_line":"  $manage_service               \u003d true,"},{"line_number":185,"context_line":"  $api_paste_config             \u003d \u0027api-paste.ini\u0027,"},{"line_number":186,"context_line":"  $ensure_package               \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_d0ee3f8a","line":183,"updated":"2016-05-19 12:32:53.000000000","message":"nit: not sure why these lines are changed? have you changed whitespaces?","commit_id":"e4d955c37e50974da6ce6865ae1e291230bc0e39"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"ad370229a8de0249026acb12707e4fafd45dcf36","unresolved":false,"context_lines":[{"line_number":180,"context_line":"#"},{"line_number":181,"context_line":"class nova::api("},{"line_number":182,"context_line":"  $admin_password,"},{"line_number":183,"context_line":"  $enabled                      \u003d true,"},{"line_number":184,"context_line":"  $manage_service               \u003d true,"},{"line_number":185,"context_line":"  $api_paste_config             \u003d \u0027api-paste.ini\u0027,"},{"line_number":186,"context_line":"  $ensure_package               \u003d \u0027present\u0027,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_06a09142","line":183,"in_reply_to":"bab6814e_d0ee3f8a","updated":"2016-05-19 12:59:41.000000000","message":"it is because i need to align in case if i add the longest parameter,\nyes just changed whitespaces","commit_id":"e4d955c37e50974da6ce6865ae1e291230bc0e39"}]}