)]}'
{"manifests/compute.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e37208a4cf07f0a0b525b17a3794aa9abc7a43ea","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#   (optional) Deprecated. The MTU size for the interfaces managed by nova"},{"line_number":123,"context_line":"#   Defaults to undef"},{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"#  [*compute_manager*]"},{"line_number":126,"context_line":"#   Deprecated. Compute manager"},{"line_number":127,"context_line":"#   The driver that will manage the running instances."},{"line_number":128,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_f67c0ab7","line":125,"updated":"2016-05-25 14:43:30.000000000","message":"we use this one in TripleO because we deploy ironic to deploy baremetal instances and I\u0027m not sure Nova has plans to replace it. They deprecate it in the code but without replacement. Can you confirm it? If yes, I suggest we keep the parameter for now.\n\nSee https://github.com/openstack/nova/blob/a3da334656bac94967af58d1b9a95dbb26ebf44b/nova/conf/service.py#L62-L67","commit_id":"935c24f8a55a76d7a8dfed9787ea8f9355ef9115"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"747f8aabbf58134efacdcbc3af2da3bc184325a8","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#   (optional) Deprecated. The MTU size for the interfaces managed by nova"},{"line_number":123,"context_line":"#   Defaults to undef"},{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"#  [*compute_manager*]"},{"line_number":126,"context_line":"#   Deprecated. Compute manager"},{"line_number":127,"context_line":"#   The driver that will manage the running instances."},{"line_number":128,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_4e5a61f3","line":125,"in_reply_to":"bab6814e_f44870b5","updated":"2016-05-26 15:26:26.000000000","message":"ok cool","commit_id":"935c24f8a55a76d7a8dfed9787ea8f9355ef9115"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"1c4634171bcc723cc8431c8fe15790c6c06bb74f","unresolved":false,"context_lines":[{"line_number":122,"context_line":"#   (optional) Deprecated. The MTU size for the interfaces managed by nova"},{"line_number":123,"context_line":"#   Defaults to undef"},{"line_number":124,"context_line":"#"},{"line_number":125,"context_line":"#  [*compute_manager*]"},{"line_number":126,"context_line":"#   Deprecated. Compute manager"},{"line_number":127,"context_line":"#   The driver that will manage the running instances."},{"line_number":128,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"bab6814e_f44870b5","line":125,"in_reply_to":"bab6814e_f67c0ab7","updated":"2016-05-25 21:29:22.000000000","message":"Emilien, I have confirmed see [1][2]\n\nI\u0027ll roll back compute_manager but i\u0027ll add notes in the code about why we didn\u0027t deprecated ok?\n\n[1]http://docs.openstack.org/mitaka/config-reference/compute/config-options.html\n[2]http://docs.openstack.org/mitaka/config-reference/tables/conf-changes/nova.html","commit_id":"935c24f8a55a76d7a8dfed9787ea8f9355ef9115"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"58b5166ebc3550d4380d4107e2c4a372d2423427","unresolved":false,"context_lines":[{"line_number":179,"context_line":"  }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  if $compute_manager {"},{"line_number":182,"context_line":"    warning(\u0027compute_manager parameter is deprecated, but still has no effect since Ironic use, this will be removed in a future release.\u0027)"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  include ::nova::availability_zone"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"bab6814e_be9de90b","line":182,"updated":"2016-05-26 21:51:50.000000000","message":"this message is confusing. The parameter has effect when using Ironic.\n\nI would rather say:\n\"This parameter is marked as deprecated in Nova but still needed when Ironic is used. It will be removed once Nova removes it.","commit_id":"d30ee850cb8df685d5fa9ac38f1e126572857c08"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"0ee0ab2d2ac4db8c8a376f8e153dacd45e866395","unresolved":false,"context_lines":[{"line_number":179,"context_line":"  }"},{"line_number":180,"context_line":""},{"line_number":181,"context_line":"  if $compute_manager {"},{"line_number":182,"context_line":"    warning(\u0027compute_manager parameter is deprecated, but still has no effect since Ironic use, this will be removed in a future release.\u0027)"},{"line_number":183,"context_line":"  }"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"  include ::nova::availability_zone"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"bab6814e_612be482","line":182,"in_reply_to":"bab6814e_be9de90b","updated":"2016-05-26 21:57:57.000000000","message":"Done","commit_id":"d30ee850cb8df685d5fa9ac38f1e126572857c08"}],"manifests/init.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b47592e79429ac0dca106cb9de1f8a4fb7a88444","unresolved":false,"context_lines":[{"line_number":587,"context_line":"    \u0027DEFAULT/image_service\u0027:                value \u003d\u003e $image_service;"},{"line_number":588,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:                value \u003d\u003e $auth_strategy;"},{"line_number":589,"context_line":"    #TODO(iurygregory): Memcached servers or None for in process cache."},{"line_number":590,"context_line":"    # “memcached_servers” opt is deprecated in Mitaka."},{"line_number":591,"context_line":"    # In Newton release oslo.cache config options should be used as this "},{"line_number":592,"context_line":"    # option will be removed. Please add a [cache] group in your nova.conf"},{"line_number":593,"context_line":"    # file and add “enable” and “memcache_servers” option in this section."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_de66edeb","line":590,"range":{"start_line":590,"start_character":6,"end_line":590,"end_character":25},"updated":"2016-05-21 14:31:58.000000000","message":"these quotes are causing your failures.","commit_id":"90b10d0701a709699069028c37e3d76628e1e029"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b47592e79429ac0dca106cb9de1f8a4fb7a88444","unresolved":false,"context_lines":[{"line_number":590,"context_line":"    # “memcached_servers” opt is deprecated in Mitaka."},{"line_number":591,"context_line":"    # In Newton release oslo.cache config options should be used as this "},{"line_number":592,"context_line":"    # option will be removed. Please add a [cache] group in your nova.conf"},{"line_number":593,"context_line":"    # file and add “enable” and “memcache_servers” option in this section."},{"line_number":594,"context_line":"  }"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"  # we keep \"nova.openstack.common.rpc.impl_kombu\" for backward compatibility"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bab6814e_3e6299d8","line":593,"range":{"start_line":593,"start_character":19,"end_line":593,"end_character":50},"updated":"2016-05-21 14:31:58.000000000","message":"these too","commit_id":"90b10d0701a709699069028c37e3d76628e1e029"}]}