)]}'
{"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9512ac3ddeb8b83777b3f7f7068498d8bf548e6b","unresolved":false,"context_lines":[{"line_number":633,"context_line":"  }"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"  # maintain backwards compatibility"},{"line_number":636,"context_line":"  ensure_resource(\u0027class\u0027, \u0027::nova::scheduler::filter\u0027, {})"},{"line_number":637,"context_line":"  $real_cpu_allocation_ratio \u003d pick($::nova::scheduler::filter::cpu_allocation_ratio, $cpu_allocation_ratio)"},{"line_number":638,"context_line":"  $real_ram_allocation_ratio \u003d pick($::nova::scheduler::filter::ram_allocation_ratio, $ram_allocation_ratio)"},{"line_number":639,"context_line":"  $real_disk_allocation_ratio \u003d pick($::nova::scheduler::filter::disk_allocation_ratio, $disk_allocation_ratio)"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1aa78d24_6ed3eb04","line":636,"updated":"2016-07-06 14:04:32.000000000","message":"that won\u0027t work, you have a duplicated resource here.\n\nhttp://logs.openstack.org/17/323117/13/check/gate-puppet-openstack-integration-3-scenario001-tempest-centos-7/5b02fc2/console.html#_2016-07-05_05_00_04_265977","commit_id":"1cb4f777c4b5be0d75ad8a0fdeea50ee167d8eaf"},{"author":{"_account_id":6851,"name":"Marcus Furlong","email":"furlongm@gmail.com","username":"furlongm"},"change_message_id":"c0cebc4c44902b53e19915f024da606640c3f40a","unresolved":false,"context_lines":[{"line_number":633,"context_line":"  }"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"  # maintain backwards compatibility"},{"line_number":636,"context_line":"  ensure_resource(\u0027class\u0027, \u0027::nova::scheduler::filter\u0027, {})"},{"line_number":637,"context_line":"  $real_cpu_allocation_ratio \u003d pick($::nova::scheduler::filter::cpu_allocation_ratio, $cpu_allocation_ratio)"},{"line_number":638,"context_line":"  $real_ram_allocation_ratio \u003d pick($::nova::scheduler::filter::ram_allocation_ratio, $ram_allocation_ratio)"},{"line_number":639,"context_line":"  $real_disk_allocation_ratio \u003d pick($::nova::scheduler::filter::disk_allocation_ratio, $disk_allocation_ratio)"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1aa78d24_9de0cf2a","line":636,"in_reply_to":"1aa78d24_6ed3eb04","updated":"2016-07-07 12:56:03.000000000","message":"Not sure how to fix this?\n\nDeclare with ensure_resource in puppet-openstack-integration, fuel, etc?\n\nOr is there a better way to tackle this?","commit_id":"1cb4f777c4b5be0d75ad8a0fdeea50ee167d8eaf"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"c5da40de55fe14c2e368dedbe8f676380ac8977f","unresolved":false,"context_lines":[{"line_number":633,"context_line":"  }"},{"line_number":634,"context_line":""},{"line_number":635,"context_line":"  # maintain backwards compatibility"},{"line_number":636,"context_line":"  ensure_resource(\u0027class\u0027, \u0027::nova::scheduler::filter\u0027, {})"},{"line_number":637,"context_line":"  $real_cpu_allocation_ratio \u003d pick($::nova::scheduler::filter::cpu_allocation_ratio, $cpu_allocation_ratio)"},{"line_number":638,"context_line":"  $real_ram_allocation_ratio \u003d pick($::nova::scheduler::filter::ram_allocation_ratio, $ram_allocation_ratio)"},{"line_number":639,"context_line":"  $real_disk_allocation_ratio \u003d pick($::nova::scheduler::filter::disk_allocation_ratio, $disk_allocation_ratio)"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1aa78d24_999fb502","line":636,"in_reply_to":"1aa78d24_9de0cf2a","updated":"2016-07-11 13:03:25.000000000","message":"try:\n\n  $real_cpu_allocation_ratio \u003d pick($::nova::scheduler::filter::cpu_allocation_ratio, $cpu_allocation_ratio)\n\n  ensure_resource(\u0027nova_config\u0027, \u0027DEFAULT/cpu_allocation_ratio\u0027, { value \u003d\u003e $real_cpu_allocation_ratio })","commit_id":"1cb4f777c4b5be0d75ad8a0fdeea50ee167d8eaf"}],"manifests/scheduler/filter.pp":[{"author":{"_account_id":1607,"name":"Yu xingchao","email":"yuxcer@gmail.com","username":"yuxcer"},"change_message_id":"4c1970d441886896fa0c4bc31afe1894d0879886","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  include ::nova::deps"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  if $cpu_allocation_ratio {"},{"line_number":88,"context_line":"    warning(\u0027cpu_allocation_ratio is deprecated in nova::scheduler::filter, please add to nova::init instead\u0027)"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  if $ram_allocation_ratio {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_f24c0b72","line":88,"updated":"2016-05-31 08:14:18.000000000","message":"Actually this is not backward compatible, you can this:\nhttps://github.com/openstack/puppet-rally/blob/master/manifests/init.pp#L30","commit_id":"d8b08ae4e595c2dd3075afffe6714b64bd02e637"},{"author":{"_account_id":6851,"name":"Marcus Furlong","email":"furlongm@gmail.com","username":"furlongm"},"change_message_id":"71fcfe86f0e75fcfa5b4d2d299a96cb623cce725","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  include ::nova::deps"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  if $cpu_allocation_ratio {"},{"line_number":88,"context_line":"    warning(\u0027cpu_allocation_ratio is deprecated in nova::scheduler::filter, please add to nova::init instead\u0027)"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  if $ram_allocation_ratio {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_b0608802","line":88,"in_reply_to":"9abb7d3a_6801476a","updated":"2016-06-01 00:14:00.000000000","message":"Oops, I missed the part about ensure_resources. Do you have a link to an example of how I should use this function?","commit_id":"d8b08ae4e595c2dd3075afffe6714b64bd02e637"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"26f9e2f231e1ae832f63596742aad02e41295a0d","unresolved":false,"context_lines":[{"line_number":85,"context_line":"  include ::nova::deps"},{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  if $cpu_allocation_ratio {"},{"line_number":88,"context_line":"    warning(\u0027cpu_allocation_ratio is deprecated in nova::scheduler::filter, please add to nova::init instead\u0027)"},{"line_number":89,"context_line":"  }"},{"line_number":90,"context_line":""},{"line_number":91,"context_line":"  if $ram_allocation_ratio {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"9abb7d3a_6801476a","line":88,"in_reply_to":"9abb7d3a_f24c0b72","updated":"2016-05-31 10:10:23.000000000","message":"+1, Also you can use ensure_resources function here.","commit_id":"d8b08ae4e595c2dd3075afffe6714b64bd02e637"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"4fcde674e4360566dc1d3d73bf5fb907610fae36","unresolved":false,"context_lines":[{"line_number":54,"context_line":"#"},{"line_number":55,"context_line":"# DEPRECATED PARAMETERS"},{"line_number":56,"context_line":"#"},{"line_number":57,"context_line":"# [*cpu_allocation_ratio*]"},{"line_number":58,"context_line":"#   (optional) Virtual CPU to Physical CPU allocation ratio"},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*ram_allocation_ratio*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7aa08908_fecd18b8","line":57,"range":{"start_line":57,"start_character":4,"end_line":57,"end_character":24},"updated":"2016-06-07 02:43:01.000000000","message":"A decription of default value is best to be added for the option.","commit_id":"34bb7573836f022a1b575dbf4d6e378a30c528cf"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"4fcde674e4360566dc1d3d73bf5fb907610fae36","unresolved":false,"context_lines":[{"line_number":57,"context_line":"# [*cpu_allocation_ratio*]"},{"line_number":58,"context_line":"#   (optional) Virtual CPU to Physical CPU allocation ratio"},{"line_number":59,"context_line":"#"},{"line_number":60,"context_line":"# [*ram_allocation_ratio*]"},{"line_number":61,"context_line":"#   (optional) Virtual ram to physical ram allocation ratio"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*disk_allocation_ratio*]"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7aa08908_be3a7096","line":60,"range":{"start_line":60,"start_character":3,"end_line":60,"end_character":24},"updated":"2016-06-07 02:43:01.000000000","message":"same","commit_id":"34bb7573836f022a1b575dbf4d6e378a30c528cf"},{"author":{"_account_id":9414,"name":"zhongshengping","email":"chdzsp@163.com","username":"ZhongShengping"},"change_message_id":"4fcde674e4360566dc1d3d73bf5fb907610fae36","unresolved":false,"context_lines":[{"line_number":60,"context_line":"# [*ram_allocation_ratio*]"},{"line_number":61,"context_line":"#   (optional) Virtual ram to physical ram allocation ratio"},{"line_number":62,"context_line":"#"},{"line_number":63,"context_line":"# [*disk_allocation_ratio*]"},{"line_number":64,"context_line":"#   (optional) Virtual disk to physical disk allocation ratio"},{"line_number":65,"context_line":"#"},{"line_number":66,"context_line":"class nova::scheduler::filter ("}],"source_content_type":"text/x-puppet","patch_set":10,"id":"7aa08908_fe44f81b","line":63,"range":{"start_line":63,"start_character":4,"end_line":63,"end_character":25},"updated":"2016-06-07 02:43:01.000000000","message":"same","commit_id":"34bb7573836f022a1b575dbf4d6e378a30c528cf"}],"releasenotes/notes/move-scheduler-ratios-to-top-level-76c6383d828e6d4a.yaml":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9a28301165396d3d70b9e6b577b00ab55d858b99","unresolved":false,"context_lines":[{"line_number":12,"context_line":"    replaced by:"},{"line_number":13,"context_line":"    $::nova::cpu_allocation_ratio"},{"line_number":14,"context_line":"    $::nova::ram_allocation_ratio"},{"line_number":15,"context_line":"    $::nova::disk_allocation_ratio"}],"source_content_type":"text/x-yaml","patch_set":15,"id":"1aa78d24_d4f6e45b","line":15,"updated":"2016-07-12 13:29:55.000000000","message":"Wow this is a long release note :-) Why not keeping it simple:\n\n  deprecations:\n    - The following parameters moved from ::nova::scheduler::filter to\n       ::nova so they can be configured at top level: cpu_allocation_ratio, ram_allocation_ratio and disk_allocation_ratio","commit_id":"83298dc496653856266031e97405b0b591607724"}],"spec/classes/nova_init_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"8921992a47847fa43b88a1e7b37ad461bc5901db","unresolved":false,"context_lines":[{"line_number":551,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/ram_allocation_ratio\u0027).with_value(\u00272.0\u0027) }"},{"line_number":552,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/disk_allocation_ratio\u0027).with_value(\u00271.5\u0027) }"},{"line_number":553,"context_line":"    end"},{"line_number":554,"context_line":""},{"line_number":555,"context_line":"  end"},{"line_number":556,"context_line":""},{"line_number":557,"context_line":"  context \u0027on Debian platforms\u0027 do"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"9abb7d3a_c1265bcd","line":554,"updated":"2016-05-31 07:25:27.000000000","message":"please add also a case with these parameters set to default values (os services default)","commit_id":"c65bf7f3068c80079556736666e2fc3f360ad506"}]}