)]}'
{"spec/classes/nova_compute_rbd_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"35e05be769cedf206f8b1268986f40ee820eae57","unresolved":false,"context_lines":[{"line_number":182,"context_line":"    #end"},{"line_number":183,"context_line":""},{"line_number":184,"context_line":"    #it_configures \u0027nova compute rbd\u0027"},{"line_number":185,"context_line":"  #end"},{"line_number":186,"context_line":""},{"line_number":187,"context_line":"  on_supported_os({"},{"line_number":188,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aa08908_ce5ba3f5","line":185,"updated":"2016-06-09 09:55:45.000000000","message":"probably needs to be removed","commit_id":"91b3038ba8bf056fdb22acf8e2991767f984fcb7"}],"spec/classes/nova_compute_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"35e05be769cedf206f8b1268986f40ee820eae57","unresolved":false,"context_lines":[{"line_number":246,"context_line":"#    end"},{"line_number":247,"context_line":"#"},{"line_number":248,"context_line":"#    it_behaves_like \u0027nova-compute\u0027"},{"line_number":249,"context_line":"#  end"},{"line_number":250,"context_line":""},{"line_number":251,"context_line":"  on_supported_os({"},{"line_number":252,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aa08908_8e3a3b97","line":249,"updated":"2016-06-09 09:55:45.000000000","message":"probably needs to be removed","commit_id":"91b3038ba8bf056fdb22acf8e2991767f984fcb7"}],"spec/classes/nova_conductor_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"35e05be769cedf206f8b1268986f40ee820eae57","unresolved":false,"context_lines":[{"line_number":78,"context_line":"  }).each do |os,facts|"},{"line_number":79,"context_line":"    context \"on #{os}\" do"},{"line_number":80,"context_line":"      let (:facts) do"},{"line_number":81,"context_line":"        facts.merge!(OSDefaults.get_facts({ :processorcount \u003d\u003e 5 }))"},{"line_number":82,"context_line":"      end"},{"line_number":83,"context_line":""},{"line_number":84,"context_line":"      let (:platform_params) do"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aa08908_cecd63b9","line":81,"updated":"2016-06-09 09:55:45.000000000","message":"I didn\u0027t find where this fact is used, do we really need it here?","commit_id":"91b3038ba8bf056fdb22acf8e2991767f984fcb7"}],"spec/classes/nova_consoleauth_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"35e05be769cedf206f8b1268986f40ee820eae57","unresolved":false,"context_lines":[{"line_number":26,"context_line":"#      :name         \u003d\u003e \u0027nova-consoleauth\u0027,"},{"line_number":27,"context_line":"#      :package_name \u003d\u003e \u0027openstack-nova-console\u0027,"},{"line_number":28,"context_line":"#      :service_name \u003d\u003e \u0027openstack-nova-consoleauth\u0027 }"},{"line_number":29,"context_line":"#  end"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  on_supported_os({"},{"line_number":32,"context_line":"    :supported_os \u003d\u003e OSDefaults.get_supported_os"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aa08908_ce7f2365","line":29,"updated":"2016-06-09 09:55:45.000000000","message":"probably needs to be removed","commit_id":"91b3038ba8bf056fdb22acf8e2991767f984fcb7"}],"spec/classes/nova_db_mysql_api_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"35e05be769cedf206f8b1268986f40ee820eae57","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      )}"},{"line_number":57,"context_line":"    end"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    context \u0027overriding allowed_hosts param equals to host param\u0027 do"},{"line_number":60,"context_line":"      let :params do"},{"line_number":61,"context_line":"        { :password       \u003d\u003e \u0027novapass2\u0027,"},{"line_number":62,"context_line":"          :allowed_hosts  \u003d\u003e \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aa08908_8e507b0c","line":59,"updated":"2016-06-09 09:55:45.000000000","message":"what\u0027s the actual difference between this and test above (\u0027overriding allowed_hosts param to string\u0027)? What\u0027s the value to test \u0027allowed_hosts equals to host\u0027?","commit_id":"91b3038ba8bf056fdb22acf8e2991767f984fcb7"}],"spec/classes/nova_db_mysql_spec.rb":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"35e05be769cedf206f8b1268986f40ee820eae57","unresolved":false,"context_lines":[{"line_number":56,"context_line":"      )}"},{"line_number":57,"context_line":"    end"},{"line_number":58,"context_line":""},{"line_number":59,"context_line":"    context \u0027overriding allowed_hosts param equals to host param\u0027 do"},{"line_number":60,"context_line":"      let :params do"},{"line_number":61,"context_line":"        { :password       \u003d\u003e \u0027novapass2\u0027,"},{"line_number":62,"context_line":"          :allowed_hosts  \u003d\u003e \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"7aa08908_0e780b2b","line":59,"updated":"2016-06-09 09:55:45.000000000","message":"same question here","commit_id":"91b3038ba8bf056fdb22acf8e2991767f984fcb7"}],"spec/classes/nova_db_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"826fe99850cc9d80af9fa88f0d4def6c51409545","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      when \u0027Debian\u0027"},{"line_number":91,"context_line":"        it_configures \u0027nova::db\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        context \u0027using pymysql driver\u0027 do"},{"line_number":94,"context_line":"          let :params do"},{"line_number":95,"context_line":"            { :database_connection   \u003d\u003e \u0027mysql+pymysql://user:pass@db/db\u0027, }"},{"line_number":96,"context_line":"          end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7aa08908_d96dcb05","line":93,"updated":"2016-06-10 20:39:28.000000000","message":"Should just move these into shared example(s) and just use it_confgures \"nova::db::mysql #{facts[:osfamily]}\" or something. See https://github.com/openstack/puppet-glance/blob/master/spec/classes/glance_api_spec.rb#L413","commit_id":"c3d0e86cbc891d5a07a7052c8e9ffb82b9c60d14"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"804ec380beb27428e59b074c8a9ea218110af611","unresolved":false,"context_lines":[{"line_number":90,"context_line":"      when \u0027Debian\u0027"},{"line_number":91,"context_line":"        it_configures \u0027nova::db\u0027"},{"line_number":92,"context_line":""},{"line_number":93,"context_line":"        context \u0027using pymysql driver\u0027 do"},{"line_number":94,"context_line":"          let :params do"},{"line_number":95,"context_line":"            { :database_connection   \u003d\u003e \u0027mysql+pymysql://user:pass@db/db\u0027, }"},{"line_number":96,"context_line":"          end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"7aa08908_d2b0f28d","line":93,"in_reply_to":"7aa08908_d96dcb05","updated":"2016-06-11 18:23:24.000000000","message":"Done, Thanks Alex!","commit_id":"c3d0e86cbc891d5a07a7052c8e9ffb82b9c60d14"}]}
