)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"a228048fbab6100b14b5c71fcaf6537347d9ab2f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     Daniel Pawlik \u003cdaniel.pawlik@corp.ovh.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-18 11:44:35 +0000"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add support for MultiStrOpt for nova_config"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Change-Id: I6be7bb4cea1906bd98c513bd2d01153e4643e3ac"},{"line_number":10,"context_line":"Closes-Bug: #1591998"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":3,"id":"dada55a8_7b4f2b34","line":7,"updated":"2016-07-26 14:25:22.000000000","message":"Need more verbage here. I\u0027m not sure why this change is needed.","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"}],"manifests/scheduler/filter.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"7e81ce39456db8a15bb6d9ddc487ec67daf19d22","unresolved":false,"context_lines":[{"line_number":75,"context_line":"  $ram_allocation_ratio                \u003d \u00271.5\u0027,"},{"line_number":76,"context_line":"  $isolated_images                     \u003d false,"},{"line_number":77,"context_line":"  $isolated_hosts                      \u003d false,"},{"line_number":78,"context_line":"  $scheduler_available_filters         \u003d [\u0027nova.scheduler.filters.all_filters\u0027],"},{"line_number":79,"context_line":"  $scheduler_default_filters           \u003d false,"},{"line_number":80,"context_line":"  $scheduler_weight_classes            \u003d \u0027nova.scheduler.weights.all_weighers\u0027,"},{"line_number":81,"context_line":"  $baremetal_scheduler_default_filters \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7aa08908_2df1626b","line":78,"updated":"2016-06-15 21:18:02.000000000","message":"this is not backward compatible, please use any2array in the manifest. Something like:\n\n$scheduler_available_filters_real \u003d any2array($scheduler_available_filters)\n\nand use $scheduler_available_filters_real in the nova_config.","commit_id":"9a99dae0b6e6570f8fc3ba0b10986397e248d09e"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"a228048fbab6100b14b5c71fcaf6537347d9ab2f","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*scheduler_available_filters*]"},{"line_number":36,"context_line":"#   (optional) (Array) Filter classes available to the scheduler"},{"line_number":37,"context_line":"#   Defaults to \u0027nova.scheduler.filters.all_filters\u0027"},{"line_number":38,"context_line":"#"},{"line_number":39,"context_line":"# [*scheduler_default_filters*]"},{"line_number":40,"context_line":"#   (optional) An array of filters to be used by default"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_38ae592e","line":37,"updated":"2016-07-26 14:25:22.000000000","message":"Should update line to square brackets","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"15f3a91c860a46f912ff55f6f3637a498bcec0b8","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    $scheduler_default_filters_real \u003d $::os_service_default"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  $scheduler_available_filters_real \u003d any2array($scheduler_available_filters)"},{"line_number":102,"context_line":"  validate_array($scheduler_available_filters_real)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if !is_service_default($baremetal_scheduler_default_filters) and !empty($baremetal_scheduler_default_filters){"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_35ff85ab","line":101,"updated":"2016-07-20 14:58:42.000000000","message":"how this patch is related to the commit message?","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"a228048fbab6100b14b5c71fcaf6537347d9ab2f","unresolved":false,"context_lines":[{"line_number":98,"context_line":"    $scheduler_default_filters_real \u003d $::os_service_default"},{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  $scheduler_available_filters_real \u003d any2array($scheduler_available_filters)"},{"line_number":102,"context_line":"  validate_array($scheduler_available_filters_real)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if !is_service_default($baremetal_scheduler_default_filters) and !empty($baremetal_scheduler_default_filters){"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_9855c51f","line":101,"in_reply_to":"dada55a8_35ff85ab","updated":"2016-07-26 14:25:22.000000000","message":"I agree. Commit message needs more details of why this change is occurring.","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"15f3a91c860a46f912ff55f6f3637a498bcec0b8","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  $scheduler_available_filters_real \u003d any2array($scheduler_available_filters)"},{"line_number":102,"context_line":"  validate_array($scheduler_available_filters_real)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if !is_service_default($baremetal_scheduler_default_filters) and !empty($baremetal_scheduler_default_filters){"},{"line_number":105,"context_line":"    validate_array($baremetal_scheduler_default_filters)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_952e3141","line":102,"updated":"2016-07-20 14:58:42.000000000","message":"this validation is useless, since we use any2array before.","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"a228048fbab6100b14b5c71fcaf6537347d9ab2f","unresolved":false,"context_lines":[{"line_number":99,"context_line":"  }"},{"line_number":100,"context_line":""},{"line_number":101,"context_line":"  $scheduler_available_filters_real \u003d any2array($scheduler_available_filters)"},{"line_number":102,"context_line":"  validate_array($scheduler_available_filters_real)"},{"line_number":103,"context_line":""},{"line_number":104,"context_line":"  if !is_service_default($baremetal_scheduler_default_filters) and !empty($baremetal_scheduler_default_filters){"},{"line_number":105,"context_line":"    validate_array($baremetal_scheduler_default_filters)"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_9b5f7f0e","line":102,"in_reply_to":"dada55a8_952e3141","updated":"2016-07-26 14:25:22.000000000","message":"I\u0027d prefer to check if its a string and send a warning, for backwards compatibility sake, and then do the any2array for a short term. The validate array is useless in this case though but will be needed later if any2array is removed.","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"05b4c880e758d33b286bcffa84a5db5a4ab5595f","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  }"},{"line_number":101,"context_line":""},{"line_number":102,"context_line":"  if is_array($scheduler_available_filters) {"},{"line_number":103,"context_line":"    $scheduler_available_filters_real \u003d any2array($scheduler_available_filters)"},{"line_number":104,"context_line":"  } else {"},{"line_number":105,"context_line":"    warning(\u0027scheduler_available_filters must be an array and will fail in the future\u0027)"},{"line_number":106,"context_line":"    $scheduler_available_filters_real \u003d $scheduler_available_filters"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_d9839601","line":103,"updated":"2016-07-27 09:46:37.000000000","message":"I am a bit confused. If it is already array here, why are you converting it?","commit_id":"812bb177b98f626bcb6caa7a27b8fca3e3d5f902"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"05b4c880e758d33b286bcffa84a5db5a4ab5595f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"    $scheduler_available_filters_real \u003d any2array($scheduler_available_filters)"},{"line_number":104,"context_line":"  } else {"},{"line_number":105,"context_line":"    warning(\u0027scheduler_available_filters must be an array and will fail in the future\u0027)"},{"line_number":106,"context_line":"    $scheduler_available_filters_real \u003d $scheduler_available_filters"},{"line_number":107,"context_line":"  }"},{"line_number":108,"context_line":""},{"line_number":109,"context_line":"  if !is_service_default($baremetal_scheduler_default_filters) and !empty($baremetal_scheduler_default_filters){"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_39a632ae","line":106,"updated":"2016-07-27 09:46:37.000000000","message":"I guess \u0027any2array\u0027 should be here","commit_id":"812bb177b98f626bcb6caa7a27b8fca3e3d5f902"}],"spec/classes/nova_scheduler_filter_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"15f3a91c860a46f912ff55f6f3637a498bcec0b8","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_host_subset_size\u0027).with_value(\u00271\u0027) }"},{"line_number":15,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/max_io_ops_per_host\u0027).with_value(\u00278\u0027) }"},{"line_number":16,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/max_instances_per_host\u0027).with_value(\u002750\u0027) }"},{"line_number":17,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_available_filters\u0027).with_value([\u0027nova.scheduler.filters.all_filters\u0027]) }"},{"line_number":18,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_weight_classes\u0027).with_value(\u0027nova.scheduler.weights.all_weighers\u0027) }"},{"line_number":19,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_use_baremetal_filters\u0027).with_value(false) }"},{"line_number":20,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/isolated_images\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"dada55a8_7533bdab","line":17,"updated":"2016-07-20 14:58:42.000000000","message":"I don\u0027t see any test that validate multi values thing.","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"4aae10862beeda39f78f5a05ce5738bbc92b7e70","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_host_subset_size\u0027).with_value(\u00271\u0027) }"},{"line_number":15,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/max_io_ops_per_host\u0027).with_value(\u00278\u0027) }"},{"line_number":16,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/max_instances_per_host\u0027).with_value(\u002750\u0027) }"},{"line_number":17,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_available_filters\u0027).with_value([\u0027nova.scheduler.filters.all_filters\u0027]) }"},{"line_number":18,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_weight_classes\u0027).with_value(\u0027nova.scheduler.weights.all_weighers\u0027) }"},{"line_number":19,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_use_baremetal_filters\u0027).with_value(false) }"},{"line_number":20,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/isolated_images\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"dada55a8_3b24930b","line":17,"in_reply_to":"dada55a8_3bdbf37d","updated":"2016-07-26 14:32:25.000000000","message":"Correction, we do not need to test for multivalue if we\u0027re doing any2array for backwards compat.","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"},{"author":{"_account_id":8318,"name":"Matthew J Black","email":"mjblack@gmail.com","username":"mjblack"},"change_message_id":"a228048fbab6100b14b5c71fcaf6537347d9ab2f","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_host_subset_size\u0027).with_value(\u00271\u0027) }"},{"line_number":15,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/max_io_ops_per_host\u0027).with_value(\u00278\u0027) }"},{"line_number":16,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/max_instances_per_host\u0027).with_value(\u002750\u0027) }"},{"line_number":17,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_available_filters\u0027).with_value([\u0027nova.scheduler.filters.all_filters\u0027]) }"},{"line_number":18,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_weight_classes\u0027).with_value(\u0027nova.scheduler.weights.all_weighers\u0027) }"},{"line_number":19,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/scheduler_use_baremetal_filters\u0027).with_value(false) }"},{"line_number":20,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/isolated_images\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027) }"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"dada55a8_3bdbf37d","line":17,"in_reply_to":"dada55a8_7533bdab","updated":"2016-07-26 14:25:22.000000000","message":"Here is an example of testing multi values.\n\nhttps://github.com/openstack/puppet-neutron/blob/master/spec/classes/neutron_server_spec.rb#L231-L243","commit_id":"7919fcd10eef60013df8516532f1f7372172c937"}]}