)]}'
{"manifests/api.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"010717b6ecc8a3f4fa13ee0693854c536188efcd","unresolved":false,"context_lines":[{"line_number":366,"context_line":"#   (optional) DEPRECATED. The port on which the EC2 API will listen."},{"line_number":367,"context_line":"#   Defaults to port undef"},{"line_number":368,"context_line":"#"},{"line_number":369,"context_line":"# [*auth_version*]"},{"line_number":370,"context_line":"#   (optional) API version of the admin Identity API endpoint"},{"line_number":371,"context_line":"#   for example, use \u0027v3\u0027 for the keystone version 3.0 api"},{"line_number":372,"context_line":"#   Defaults to false"},{"line_number":373,"context_line":"#"},{"line_number":374,"context_line":"# [*osapi_v3*]"},{"line_number":375,"context_line":"#   (optional) DEPRECATED. Enable or not Nova API v3"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_aa5bb620","line":372,"range":{"start_line":369,"start_character":0,"end_line":372,"end_character":21},"updated":"2016-07-13 13:06:19.000000000","message":"if it\u0027s not deprecated anymore, please move it out of # DEPRECATED section.","commit_id":"5c4e76fc0ed3b229dbd10651877c787516953cde"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"831559b3484b574738902505c32a053a85804418","unresolved":false,"context_lines":[{"line_number":366,"context_line":"#   (optional) DEPRECATED. The port on which the EC2 API will listen."},{"line_number":367,"context_line":"#   Defaults to port undef"},{"line_number":368,"context_line":"#"},{"line_number":369,"context_line":"# [*auth_version*]"},{"line_number":370,"context_line":"#   (optional) API version of the admin Identity API endpoint"},{"line_number":371,"context_line":"#   for example, use \u0027v3\u0027 for the keystone version 3.0 api"},{"line_number":372,"context_line":"#   Defaults to false"},{"line_number":373,"context_line":"#"},{"line_number":374,"context_line":"# [*osapi_v3*]"},{"line_number":375,"context_line":"#   (optional) DEPRECATED. Enable or not Nova API v3"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_cae3a2a2","line":372,"range":{"start_line":369,"start_character":0,"end_line":372,"end_character":21},"in_reply_to":"1aa78d24_aa5bb620","updated":"2016-07-14 03:04:55.000000000","message":"Sure","commit_id":"5c4e76fc0ed3b229dbd10651877c787516953cde"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"010717b6ecc8a3f4fa13ee0693854c536188efcd","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"  nova_config {"},{"line_number":651,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $admin_tenant_name;"},{"line_number":652,"context_line":"    \u0027keystone_authtoken/admin_user\u0027:        value \u003d\u003e $admin_user;"},{"line_number":653,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:    value \u003d\u003e $admin_password, secret \u003d\u003e true;"},{"line_number":654,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri;"},{"line_number":655,"context_line":"  }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"  if ($ratelimits !\u003d undef) {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_aa4e1635","line":654,"range":{"start_line":651,"start_character":0,"end_line":654,"end_character":66},"updated":"2016-07-13 13:06:19.000000000","message":"why not moving those parameters in the previous resource?","commit_id":"5c4e76fc0ed3b229dbd10651877c787516953cde"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"831559b3484b574738902505c32a053a85804418","unresolved":false,"context_lines":[{"line_number":648,"context_line":""},{"line_number":649,"context_line":""},{"line_number":650,"context_line":"  nova_config {"},{"line_number":651,"context_line":"    \u0027keystone_authtoken/admin_tenant_name\u0027: value \u003d\u003e $admin_tenant_name;"},{"line_number":652,"context_line":"    \u0027keystone_authtoken/admin_user\u0027:        value \u003d\u003e $admin_user;"},{"line_number":653,"context_line":"    \u0027keystone_authtoken/admin_password\u0027:    value \u003d\u003e $admin_password, secret \u003d\u003e true;"},{"line_number":654,"context_line":"    \u0027keystone_authtoken/identity_uri\u0027:      value \u003d\u003e $identity_uri;"},{"line_number":655,"context_line":"  }"},{"line_number":656,"context_line":""},{"line_number":657,"context_line":"  if ($ratelimits !\u003d undef) {"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_52462022","line":654,"range":{"start_line":651,"start_character":0,"end_line":654,"end_character":66},"in_reply_to":"1aa78d24_aa4e1635","updated":"2016-07-14 03:04:55.000000000","message":"Well in the resource we only added parameters from keystonemiddleware documentation. We don\u0027t have admin_tenant_name, admin_user, admin_password and identity_uri in the resource.\n\nBut according to [1] Nova have those options, but looking at the defaul nova.conf [2] I only see admin_* in ironic section..\n\nMaybe we should contact someone in Nova..\n\n[1] http://docs.openstack.org/mitaka/config-reference/compute/config-options.html#nova-authentication \n[2] http://docs.openstack.org/developer/nova/sample_config.html","commit_id":"5c4e76fc0ed3b229dbd10651877c787516953cde"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"15294aa53bad4991f77a9d11575907a41051f4ce","unresolved":false,"context_lines":[{"line_number":511,"context_line":""},{"line_number":512,"context_line":"  if $identity_uri {"},{"line_number":513,"context_line":"    warning(\u0027nova::api::identity_uri is deprecated, use nova::api::auth_uri\u0027)"},{"line_number":514,"context_line":"    $auth_uri_real \u003d $identity_uri"},{"line_number":515,"context_line":"  } else {"},{"line_number":516,"context_line":"    $auth_uri_real \u003d $auth_uri"},{"line_number":517,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":17,"id":"dada55a8_0c7af387","line":514,"updated":"2016-07-21 16:54:39.000000000","message":"no, auth_uri already existed before, so we need to use it for backward compatibility. This is why your patch is failing now.","commit_id":"eece2e5f88544b1bf586ed9652c3cb9b6c0435bc"}],"manifests/init.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"010717b6ecc8a3f4fa13ee0693854c536188efcd","unresolved":false,"context_lines":[{"line_number":614,"context_line":"  nova_config {"},{"line_number":615,"context_line":"    \u0027DEFAULT/image_service\u0027:                value \u003d\u003e $image_service;"},{"line_number":616,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:                value \u003d\u003e $auth_strategy;"},{"line_number":617,"context_line":"    \u0027keystone_authtoken/memcached_servers\u0027: value \u003d\u003e join(any2array($memcached_servers), \u0027,\u0027);"},{"line_number":618,"context_line":"    \u0027DEFAULT/host\u0027:                         value \u003d\u003e $host;"},{"line_number":619,"context_line":"  }"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_6ac70e45","side":"PARENT","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":94},"updated":"2016-07-13 13:06:19.000000000","message":"you should maybe deprecate the memcached_servers parameter and add it in api.pp. In api.pp, use pick for backward compatibility. Ping me on IRC if you need help for that.","commit_id":"dd6ebe9298dd9dc0146a406c08c543aefdb3e982"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"831559b3484b574738902505c32a053a85804418","unresolved":false,"context_lines":[{"line_number":614,"context_line":"  nova_config {"},{"line_number":615,"context_line":"    \u0027DEFAULT/image_service\u0027:                value \u003d\u003e $image_service;"},{"line_number":616,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:                value \u003d\u003e $auth_strategy;"},{"line_number":617,"context_line":"    \u0027keystone_authtoken/memcached_servers\u0027: value \u003d\u003e join(any2array($memcached_servers), \u0027,\u0027);"},{"line_number":618,"context_line":"    \u0027DEFAULT/host\u0027:                         value \u003d\u003e $host;"},{"line_number":619,"context_line":"  }"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_92fec8ac","side":"PARENT","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":94},"in_reply_to":"1aa78d24_6ac70e45","updated":"2016-07-14 03:04:55.000000000","message":"Oh it makes sense, i\u0027ll update to undef and the pick function will work well :D\nShould I add a warning?","commit_id":"dd6ebe9298dd9dc0146a406c08c543aefdb3e982"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e45d707ed8d7208105405bde29497209c3f55c73","unresolved":false,"context_lines":[{"line_number":614,"context_line":"  nova_config {"},{"line_number":615,"context_line":"    \u0027DEFAULT/image_service\u0027:                value \u003d\u003e $image_service;"},{"line_number":616,"context_line":"    \u0027DEFAULT/auth_strategy\u0027:                value \u003d\u003e $auth_strategy;"},{"line_number":617,"context_line":"    \u0027keystone_authtoken/memcached_servers\u0027: value \u003d\u003e join(any2array($memcached_servers), \u0027,\u0027);"},{"line_number":618,"context_line":"    \u0027DEFAULT/host\u0027:                         value \u003d\u003e $host;"},{"line_number":619,"context_line":"  }"},{"line_number":620,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1aa78d24_8929559e","side":"PARENT","line":617,"range":{"start_line":617,"start_character":0,"end_line":617,"end_character":94},"in_reply_to":"1aa78d24_92fec8ac","updated":"2016-07-14 20:00:10.000000000","message":"yes, it\u0027s a deprecation","commit_id":"dd6ebe9298dd9dc0146a406c08c543aefdb3e982"}]}