)]}'
{"manifests/scheduler/filter.pp":[{"author":{"_account_id":4328,"name":"Steven Hardy","email":"steven.hardy@suse.com","username":"shardy"},"change_message_id":"3c76ded86bce79ebe5c03d794598b25216ef946d","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  # The following values are following this rule:"},{"line_number":88,"context_line":"  # - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":89,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":90,"context_line":"  # - Otherwise, fallback to default."},{"line_number":91,"context_line":"  if !is_service_default($scheduler_default_filters) and !empty($scheduler_default_filters){"},{"line_number":92,"context_line":"    validate_array($scheduler_default_filters)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_b0d572ba","line":89,"range":{"start_line":89,"start_character":55,"end_line":89,"end_character":60},"updated":"2016-07-05 13:22:54.000000000","message":"Is the \"not empty\" contraint really needed?\n\nAre there any situations where you might need/want to specify an empty list (e.g if ::os_service_default defaults to some list and you want to clear it?)","commit_id":"1924f521dce7ecab9e6a8408074b47f8ab057a31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"141e613b58581844600172c6bc653407483f2ada","unresolved":false,"context_lines":[{"line_number":86,"context_line":""},{"line_number":87,"context_line":"  # The following values are following this rule:"},{"line_number":88,"context_line":"  # - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":89,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":90,"context_line":"  # - Otherwise, fallback to default."},{"line_number":91,"context_line":"  if !is_service_default($scheduler_default_filters) and !empty($scheduler_default_filters){"},{"line_number":92,"context_line":"    validate_array($scheduler_default_filters)"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1aa78d24_01223ab9","line":89,"range":{"start_line":89,"start_character":55,"end_line":89,"end_character":60},"in_reply_to":"1aa78d24_b0d572ba","updated":"2016-07-05 14:16:31.000000000","message":"I thought tripleo wanted to set the parameter to [] by default, am I wrong?","commit_id":"1924f521dce7ecab9e6a8408074b47f8ab057a31"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"d0586aa6d7f3b70c0f5ba00ec38f85e9216e5222","unresolved":false,"context_lines":[{"line_number":88,"context_line":"  # - default is $::os_service_default so Puppet won\u0027t try to configure it."},{"line_number":89,"context_line":"  # - if set, we\u0027ll validate it\u0027s an array that is not empty and configure the parameter."},{"line_number":90,"context_line":"  # - Otherwise, fallback to default."},{"line_number":91,"context_line":"  if !is_service_default($scheduler_default_filters) and !empty($scheduler_default_filters){"},{"line_number":92,"context_line":"    validate_array($scheduler_default_filters)"},{"line_number":93,"context_line":"    $scheduler_default_filters_real \u003d join($scheduler_default_filters, \u0027,\u0027)"},{"line_number":94,"context_line":"  } else {"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"1aa78d24_33085a91","line":91,"updated":"2016-07-05 18:33:26.000000000","message":"Note for reviewers that plan to -1 me because of \"empty\" usage:\nWe need \"empty\" function here because if we set a value, we want to check it\u0027s not an empty array ([]).","commit_id":"cdc0657d22e7bd0d386f5d2a96ed0e4754b216bf"},{"author":{"_account_id":360,"name":"Dan Prince","email":"dprince@redhat.com","username":"dan-prince"},"change_message_id":"719b8df54a92336559d8b7a270c75e88104550d2","unresolved":false,"context_lines":[{"line_number":29,"context_line":"#   Defaults to \u00278\u0027"},{"line_number":30,"context_line":"#"},{"line_number":31,"context_line":"# [*isolated_images*]"},{"line_number":32,"context_line":"#   (optional) An array of imgages to run on isolated host"},{"line_number":33,"context_line":"#   Defaults to $::os_service_default"},{"line_number":34,"context_line":"#"},{"line_number":35,"context_line":"# [*isolated_hosts*]"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1aa78d24_f6976de9","line":32,"updated":"2016-07-07 14:51:20.000000000","message":"images","commit_id":"1ed7700c2543d510021fa109050a6048151478ba"}]}