)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"022840ff610f66852fe06473f60dcde2ad5b3d0f","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     karthik s \u003cksundara@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-18 21:35:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow the vcpu_pin_set to be configurable via THT."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The THT shall provide an empty list as default value for"},{"line_number":10,"context_line":"vcpu_pin_set. This patch allows puppet-nova to handle empty lists"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_b99e3d54","line":7,"updated":"2016-07-18 19:07:48.000000000","message":"remove THT here, there is nothing with TripleO directly in this patch.","commit_id":"ac527e497a79bbc079917aa392dfca0c30e9d730"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"f1912afc3d9ac3186eb5d9071b3fffbc01d8783d","unresolved":false,"context_lines":[{"line_number":4,"context_line":"Commit:     karthik s \u003cksundara@redhat.com\u003e"},{"line_number":5,"context_line":"CommitDate: 2016-07-18 21:35:34 +0530"},{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow the vcpu_pin_set to be configurable via THT."},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The THT shall provide an empty list as default value for"},{"line_number":10,"context_line":"vcpu_pin_set. This patch allows puppet-nova to handle empty lists"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"dada55a8_80cf687e","line":7,"in_reply_to":"dada55a8_b99e3d54","updated":"2016-07-19 06:10:19.000000000","message":"Done","commit_id":"ac527e497a79bbc079917aa392dfca0c30e9d730"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"8704c9450b2a7b07f7504590fac240f26309d742","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow the vcpu_pin_set to be configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The THT shall provide an empty list as default value for"},{"line_number":10,"context_line":"vcpu_pin_set. This patch allows puppet-nova to handle empty lists"},{"line_number":11,"context_line":"for vcpu_pin_set."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_f51d9f73","line":9,"updated":"2016-07-21 19:55:54.000000000","message":"next time, don\u0027t mention tripleo in commit message. This module is not related to tripleo directly.","commit_id":"7fa1780a63c394df8a5eb0a2ed4708e7343ddbd0"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"22ad024042e6927be75e9562abc09490007e1c3c","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Allow the vcpu_pin_set to be configurable"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"The THT shall provide an empty list as default value for"},{"line_number":10,"context_line":"vcpu_pin_set. This patch allows puppet-nova to handle empty lists"},{"line_number":11,"context_line":"for vcpu_pin_set."},{"line_number":12,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":7,"id":"dada55a8_39cd6066","line":9,"in_reply_to":"dada55a8_f51d9f73","updated":"2016-07-22 06:13:19.000000000","message":"Done","commit_id":"7fa1780a63c394df8a5eb0a2ed4708e7343ddbd0"}],"manifests/compute.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"26bd47658a21efc4b460642244e0be6668ffe32b","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  if !is_service_default($vcpu_pin_set) and !empty($vcpu_pin_set){"},{"line_number":210,"context_line":"    validate_array($vcpu_pin_set)"},{"line_number":211,"context_line":"    $vcpu_pin_set_real \u003d join(any2array($vcpu_pin_set), \u0027,\u0027)"},{"line_number":212,"context_line":"  } else {"},{"line_number":213,"context_line":"    $vcpu_pin_set_real \u003d $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_b9875d0e","line":210,"updated":"2016-07-18 19:07:23.000000000","message":"please remove this line. We hav any2array later that will ensure we translate the parameter into an array anyway.","commit_id":"ac527e497a79bbc079917aa392dfca0c30e9d730"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"b5f1def5d49926f1393e57b8094ab6c316495baa","unresolved":false,"context_lines":[{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  if !is_service_default($vcpu_pin_set) and !empty($vcpu_pin_set){"},{"line_number":210,"context_line":"    validate_array($vcpu_pin_set)"},{"line_number":211,"context_line":"    $vcpu_pin_set_real \u003d join(any2array($vcpu_pin_set), \u0027,\u0027)"},{"line_number":212,"context_line":"  } else {"},{"line_number":213,"context_line":"    $vcpu_pin_set_real \u003d $::os_service_default"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_80212850","line":210,"in_reply_to":"dada55a8_b9875d0e","updated":"2016-07-19 06:08:38.000000000","message":"Done","commit_id":"ac527e497a79bbc079917aa392dfca0c30e9d730"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"26bd47658a21efc4b460642244e0be6668ffe32b","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  nova_config {"},{"line_number":217,"context_line":"    \u0027DEFAULT/vcpu_pin_set\u0027:                      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":218,"context_line":"  }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  if ($vnc_enabled) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_197dc91c","line":217,"updated":"2016-07-18 19:07:23.000000000","message":"remove useless space.","commit_id":"ac527e497a79bbc079917aa392dfca0c30e9d730"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"b5f1def5d49926f1393e57b8094ab6c316495baa","unresolved":false,"context_lines":[{"line_number":214,"context_line":"  }"},{"line_number":215,"context_line":""},{"line_number":216,"context_line":"  nova_config {"},{"line_number":217,"context_line":"    \u0027DEFAULT/vcpu_pin_set\u0027:                      value \u003d\u003e $vcpu_pin_set_real;"},{"line_number":218,"context_line":"  }"},{"line_number":219,"context_line":""},{"line_number":220,"context_line":"  if ($vnc_enabled) {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_c01b201a","line":217,"in_reply_to":"dada55a8_197dc91c","updated":"2016-07-19 06:08:38.000000000","message":"Done","commit_id":"ac527e497a79bbc079917aa392dfca0c30e9d730"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"7c2635b6f0aa1658865bbfd5e6d727240360838a","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    \u0027keymgr/api_class\u0027:                          value \u003d\u003e $keymgr_api_class;"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  if !is_service_default($vcpu_pin_set) and !empty($vcpu_pin_set){"},{"line_number":210,"context_line":"    $vcpu_pin_set_real \u003d join(any2array($vcpu_pin_set), \u0027,\u0027)"},{"line_number":211,"context_line":"  } else {"},{"line_number":212,"context_line":"    $vcpu_pin_set_real \u003d $::os_service_default"},{"line_number":213,"context_line":"  }"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"  nova_config {"},{"line_number":216,"context_line":"    \u0027DEFAULT/vcpu_pin_set\u0027: value \u003d\u003e $vcpu_pin_set_real;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_253b203a","line":213,"range":{"start_line":209,"start_character":2,"end_line":213,"end_character":3},"updated":"2016-07-19 10:41:50.000000000","message":"you can use \u0027pick\u0027 function:\n\n$vcpu_pin_set_real \u003d pick(join(any2array($vcpu_pin_set), \u0027,\u0027), $::os_service_default)","commit_id":"8e5e8662f26b2e6689a434c9adfd3bcfc566181b"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"b826649ff6d299ac406f0a662d3cb1238031b3db","unresolved":false,"context_lines":[{"line_number":206,"context_line":"    \u0027keymgr/api_class\u0027:                          value \u003d\u003e $keymgr_api_class;"},{"line_number":207,"context_line":"  }"},{"line_number":208,"context_line":""},{"line_number":209,"context_line":"  if !is_service_default($vcpu_pin_set) and !empty($vcpu_pin_set){"},{"line_number":210,"context_line":"    $vcpu_pin_set_real \u003d join(any2array($vcpu_pin_set), \u0027,\u0027)"},{"line_number":211,"context_line":"  } else {"},{"line_number":212,"context_line":"    $vcpu_pin_set_real \u003d $::os_service_default"},{"line_number":213,"context_line":"  }"},{"line_number":214,"context_line":""},{"line_number":215,"context_line":"  nova_config {"},{"line_number":216,"context_line":"    \u0027DEFAULT/vcpu_pin_set\u0027: value \u003d\u003e $vcpu_pin_set_real;"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"dada55a8_b6ce1ab2","line":213,"range":{"start_line":209,"start_character":2,"end_line":213,"end_character":3},"in_reply_to":"dada55a8_253b203a","updated":"2016-07-19 15:20:34.000000000","message":"Done","commit_id":"8e5e8662f26b2e6689a434c9adfd3bcfc566181b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"e6608e80e8ee386145eec142c17ec13d3969f7ca","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    \u0027barbican/auth_endpoint\u0027:                    value \u003d\u003e $barbican_auth_endpoint;"},{"line_number":224,"context_line":"    \u0027barbican/barbican_endpoint\u0027:                value \u003d\u003e $barbican_endpoint;"},{"line_number":225,"context_line":"    \u0027barbican/barbican_api_version\u0027:             value \u003d\u003e $barbican_api_version;"},{"line_number":226,"context_line":"    \u0027keymgr/api_class\u0027:                          value \u003d\u003e $keymgr_api_class;"},{"line_number":227,"context_line":"  }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"  $vcpu_pin_set_real \u003d pick(join(any2array($vcpu_pin_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_361d0abe","line":226,"updated":"2016-07-19 15:24:58.000000000","message":"why did you add this line? It was updated here - https://review.openstack.org/#/c/343102/. I think you did a mistake during re-base.","commit_id":"64c9b3d669095a3593f5fdebb138c6a139b5fb9b"},{"author":{"_account_id":18904,"name":"Karthik S","email":"ksundara@redhat.com","username":"karthiks"},"change_message_id":"097d1797c67fd4d0a7dd8243709d32ff513edd70","unresolved":false,"context_lines":[{"line_number":223,"context_line":"    \u0027barbican/auth_endpoint\u0027:                    value \u003d\u003e $barbican_auth_endpoint;"},{"line_number":224,"context_line":"    \u0027barbican/barbican_endpoint\u0027:                value \u003d\u003e $barbican_endpoint;"},{"line_number":225,"context_line":"    \u0027barbican/barbican_api_version\u0027:             value \u003d\u003e $barbican_api_version;"},{"line_number":226,"context_line":"    \u0027keymgr/api_class\u0027:                          value \u003d\u003e $keymgr_api_class;"},{"line_number":227,"context_line":"  }"},{"line_number":228,"context_line":""},{"line_number":229,"context_line":"  $vcpu_pin_set_real \u003d pick(join(any2array($vcpu_pin_set), \u0027,\u0027), $::os_service_default)"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"dada55a8_c15e6675","line":226,"in_reply_to":"dada55a8_361d0abe","updated":"2016-07-19 15:39:32.000000000","message":"Yes, got introduced during rebase.","commit_id":"64c9b3d669095a3593f5fdebb138c6a139b5fb9b"}]}