)]}'
{"manifests/init.pp":[{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"36af21f6d1163c5590f52c335cea689ea26c259c","unresolved":false,"context_lines":[{"line_number":779,"context_line":"    \u0027upgrade_levels/scheduler\u0027:   value \u003d\u003e $upgrade_level_scheduler;"},{"line_number":780,"context_line":"  }"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"  if $monkey_patch {"},{"line_number":783,"context_line":"    if !$monkey_patch_modules {"},{"line_number":784,"context_line":"      fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":785,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_1372a6e3","line":782,"updated":"2016-07-25 10:05:29.000000000","message":"if !is_service_default($monkey_patch) {\n  if is_service_default($monkey_patch_modules) {\n    fail(...)\n  }\n}","commit_id":"1b14c314fdc4609aee94be5d97e1ba0ade732039"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"40f67725edeb11fd41ed92fe8945b3efd435d2fe","unresolved":false,"context_lines":[{"line_number":779,"context_line":"    \u0027upgrade_levels/scheduler\u0027:   value \u003d\u003e $upgrade_level_scheduler;"},{"line_number":780,"context_line":"  }"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"  if $monkey_patch {"},{"line_number":783,"context_line":"    if !$monkey_patch_modules {"},{"line_number":784,"context_line":"      fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":785,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_d43cfde2","line":782,"in_reply_to":"dada55a8_11119504","updated":"2016-07-27 10:09:41.000000000","message":"ah, I got the idea. That\u0027s fine if both are set to $::os_service_default.","commit_id":"1b14c314fdc4609aee94be5d97e1ba0ade732039"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"70a19dd5e24093aefd3b781969c72b5f3a179977","unresolved":false,"context_lines":[{"line_number":779,"context_line":"    \u0027upgrade_levels/scheduler\u0027:   value \u003d\u003e $upgrade_level_scheduler;"},{"line_number":780,"context_line":"  }"},{"line_number":781,"context_line":""},{"line_number":782,"context_line":"  if $monkey_patch {"},{"line_number":783,"context_line":"    if !$monkey_patch_modules {"},{"line_number":784,"context_line":"      fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":785,"context_line":"    }"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_11119504","line":782,"in_reply_to":"dada55a8_1372a6e3","updated":"2016-07-27 02:33:10.000000000","message":"i think if monkey_patch\u003d false,monkey_patch_modules\u003d something;\nthis monkey_patch_modules has no any effect,but donot lead to fail;\n monkey_patch_modules service_default value is nova.compute.api:nova.notifications.notify_decorator. maybe，we cloud not judge these values","commit_id":"1b14c314fdc4609aee94be5d97e1ba0ade732039"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"36af21f6d1163c5590f52c335cea689ea26c259c","unresolved":false,"context_lines":[{"line_number":785,"context_line":"    }"},{"line_number":786,"context_line":"    nova_config {"},{"line_number":787,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":788,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules;"},{"line_number":789,"context_line":"    }"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_f33a72e6","line":788,"updated":"2016-07-25 10:05:29.000000000","message":"monkey_patch_modules is array, so I\u0027d prefer to see here join(any2array($monkey_patch_modules), \u0027,\u0027);","commit_id":"1b14c314fdc4609aee94be5d97e1ba0ade732039"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"70a19dd5e24093aefd3b781969c72b5f3a179977","unresolved":false,"context_lines":[{"line_number":785,"context_line":"    }"},{"line_number":786,"context_line":"    nova_config {"},{"line_number":787,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":788,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules;"},{"line_number":789,"context_line":"    }"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"dada55a8_a16f96c2","line":788,"in_reply_to":"dada55a8_f33a72e6","updated":"2016-07-27 02:33:10.000000000","message":"Done,thanks","commit_id":"1b14c314fdc4609aee94be5d97e1ba0ade732039"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"26350d4a809e80cf886ffe7d9bd2fb1542321bb8","unresolved":false,"context_lines":[{"line_number":786,"context_line":"    }"},{"line_number":787,"context_line":"    nova_config {"},{"line_number":788,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":789,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e join(any2array($monkey_patch_modules), \u0027,\u0027);"},{"line_number":790,"context_line":"    }"},{"line_number":791,"context_line":"  }"},{"line_number":792,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"bacf61ea_9cba47e0","line":789,"updated":"2016-07-28 10:35:45.000000000","message":"you added validate_array($monkey_patch_modules), so any2array is useless here","commit_id":"b65c270a71336e1da025f8349e4647798c7239d8"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6762435d4b62f0e5f88392c235de92df0f89a794","unresolved":false,"context_lines":[{"line_number":534,"context_line":"  $disk_allocation_ratio                  \u003d $::os_service_default,"},{"line_number":535,"context_line":"  $purge_config                           \u003d false,"},{"line_number":536,"context_line":"  $monkey_patch                           \u003d $::os_service_default,"},{"line_number":537,"context_line":"  $monkey_patch_modules                   \u003d [$::os_service_default],"},{"line_number":538,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":539,"context_line":"  $verbose                                \u003d undef,"},{"line_number":540,"context_line":") inherits nova::params {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_b9d3005f","line":537,"updated":"2016-08-02 15:18:23.000000000","message":"just don\u0027t do that.\n\nLook how we do somewhere else:\nhttps://github.com/openstack/puppet-nova/blob/master/manifests/scheduler/filter.pp#L91-L100","commit_id":"95d532f78a4a8445e3e283a0749ce3c5aaf4bd21"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"695269b3f3e9d6c957625a1572eb5936ce0ff3b8","unresolved":false,"context_lines":[{"line_number":534,"context_line":"  $disk_allocation_ratio                  \u003d $::os_service_default,"},{"line_number":535,"context_line":"  $purge_config                           \u003d false,"},{"line_number":536,"context_line":"  $monkey_patch                           \u003d $::os_service_default,"},{"line_number":537,"context_line":"  $monkey_patch_modules                   \u003d [$::os_service_default],"},{"line_number":538,"context_line":"  # DEPRECATED PARAMETERS"},{"line_number":539,"context_line":"  $verbose                                \u003d undef,"},{"line_number":540,"context_line":") inherits nova::params {"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"bacf61ea_229d340a","line":537,"in_reply_to":"bacf61ea_b9d3005f","updated":"2016-08-08 03:02:20.000000000","message":"thanks，done","commit_id":"95d532f78a4a8445e3e283a0749ce3c5aaf4bd21"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"a4f3e8bf88ddf99ce791cdcf848ef923906c1b05","unresolved":false,"context_lines":[{"line_number":787,"context_line":"  }"},{"line_number":788,"context_line":"  if $monkey_patch and !is_service_default($monkey_patch_modules) and empty($monkey_patch_modules) {"},{"line_number":789,"context_line":"    fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"  nova_config {"},{"line_number":792,"context_line":"    \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":793,"context_line":"    \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules_real;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"fa7ab95a_fe4ecfbf","line":790,"updated":"2016-09-01 14:09:20.000000000","message":"I had forgotten that these configurations exist. IIRC, these are for testing purposes. I wonder if an info or warn message might be appropriate when these are enabled (as well as comment to the descriptions maybe?). Thinking of two reasons: 1. in case somebody screws up and moves a testing config into deployment, they might see it in the logs and 2. can make it obvious during run to those that want it that it\u0027s happening.","commit_id":"106be9ec3e31e77a71b8316b0552416cad7e8c07"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"9020238a41d01e3088fe064169c681458f084a84","unresolved":false,"context_lines":[{"line_number":787,"context_line":"  }"},{"line_number":788,"context_line":"  if $monkey_patch and !is_service_default($monkey_patch_modules) and empty($monkey_patch_modules) {"},{"line_number":789,"context_line":"    fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"  nova_config {"},{"line_number":792,"context_line":"    \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":793,"context_line":"    \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules_real;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_cf590837","line":790,"in_reply_to":"5a8bc5a2_1cc1d580","updated":"2016-10-09 01:26:20.000000000","message":"Done，thank you very much.","commit_id":"106be9ec3e31e77a71b8316b0552416cad7e8c07"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"b95742f495dca819b644b1f370fbae92b1f06416","unresolved":false,"context_lines":[{"line_number":787,"context_line":"  }"},{"line_number":788,"context_line":"  if $monkey_patch and !is_service_default($monkey_patch_modules) and empty($monkey_patch_modules) {"},{"line_number":789,"context_line":"    fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"  nova_config {"},{"line_number":792,"context_line":"    \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":793,"context_line":"    \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules_real;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a89bdaa_f96efb2d","line":790,"in_reply_to":"9a89bdaa_ce90d498","updated":"2016-09-06 12:25:53.000000000","message":"No, I meant warning when monkeypatching is used at all, not when it is misconfigured. It was just a suggestion in any case.","commit_id":"106be9ec3e31e77a71b8316b0552416cad7e8c07"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"601cd5b5f3718e6b0d053208227c491fd6010873","unresolved":false,"context_lines":[{"line_number":787,"context_line":"  }"},{"line_number":788,"context_line":"  if $monkey_patch and !is_service_default($monkey_patch_modules) and empty($monkey_patch_modules) {"},{"line_number":789,"context_line":"    fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"  nova_config {"},{"line_number":792,"context_line":"    \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":793,"context_line":"    \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules_real;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a89bdaa_dce7bc44","line":790,"in_reply_to":"9a89bdaa_ce90d498","updated":"2016-09-09 01:55:26.000000000","message":"can you use a example?","commit_id":"106be9ec3e31e77a71b8316b0552416cad7e8c07"},{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"c437ebf964283504c884ea82db42824146a89642","unresolved":false,"context_lines":[{"line_number":787,"context_line":"  }"},{"line_number":788,"context_line":"  if $monkey_patch and !is_service_default($monkey_patch_modules) and empty($monkey_patch_modules) {"},{"line_number":789,"context_line":"    fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"  nova_config {"},{"line_number":792,"context_line":"    \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":793,"context_line":"    \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules_real;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"5a8bc5a2_1cc1d580","line":790,"in_reply_to":"9a89bdaa_dce7bc44","updated":"2016-09-23 14:46:19.000000000","message":"I just mean:\n\nif $monkey_patch { \n  warn(\"Nova modules are configured to monkey_patch\") \n}\n\nor something like that. It\u0027s just a suggestion in any case. My -1 is for the lack of relnote.","commit_id":"106be9ec3e31e77a71b8316b0552416cad7e8c07"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"4ea7265e29eedce0c82f6c15452c70183a950d8a","unresolved":false,"context_lines":[{"line_number":787,"context_line":"  }"},{"line_number":788,"context_line":"  if $monkey_patch and !is_service_default($monkey_patch_modules) and empty($monkey_patch_modules) {"},{"line_number":789,"context_line":"    fail(\u0027The monkey_patch_modules is required when monkey_patch is set to true\u0027)"},{"line_number":790,"context_line":"  }"},{"line_number":791,"context_line":"  nova_config {"},{"line_number":792,"context_line":"    \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":793,"context_line":"    \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e $monkey_patch_modules_real;"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"9a89bdaa_ce90d498","line":790,"in_reply_to":"fa7ab95a_fe4ecfbf","updated":"2016-09-05 01:57:46.000000000","message":"done ,do  you meaing is i should give  warn not fail","commit_id":"106be9ec3e31e77a71b8316b0552416cad7e8c07"}],"spec/classes/nova_init_spec.rb":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"80533baf1bd7b257d5c245fd9948bb09cf0e88f1","unresolved":false,"context_lines":[{"line_number":590,"context_line":"      end"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/monkey_patch\u0027).with_value(\u0027true\u0027) }"},{"line_number":593,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/monkey_patch_modules\u0027).with_value(\u0027nova.api.ec2.cloud:nova.notifications.notify_decorator\u0027) }"},{"line_number":594,"context_line":"    end"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"9ad45d7e_d6b8332d","line":593,"updated":"2016-08-12 15:58:48.000000000","message":"it would have been cool to have a test when modules are empty and monkey is enabled.","commit_id":"1b261e2388304cd91db66b6e63920a0a0c32fcef"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"2a1405c6dbe6a3c2ce3a2da5e5065b33af09747f","unresolved":false,"context_lines":[{"line_number":590,"context_line":"      end"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/monkey_patch\u0027).with_value(\u0027true\u0027) }"},{"line_number":593,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/monkey_patch_modules\u0027).with_value(\u0027nova.api.ec2.cloud:nova.notifications.notify_decorator\u0027) }"},{"line_number":594,"context_line":"    end"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1ac06dbe_c0795afe","line":593,"in_reply_to":"1ac06dbe_9e5fc440","updated":"2016-08-22 04:12:47.000000000","message":"i have  a question,when rake spec, the adding of the raise error will passing?","commit_id":"1b261e2388304cd91db66b6e63920a0a0c32fcef"},{"author":{"_account_id":17070,"name":"Xiaohua Yuan","email":"yuanxiaohuaeva@gmail.com","username":"xiaohua"},"change_message_id":"f9ee3bc2168fef120ee8e659ef7b3aa507da6d86","unresolved":false,"context_lines":[{"line_number":590,"context_line":"      end"},{"line_number":591,"context_line":""},{"line_number":592,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/monkey_patch\u0027).with_value(\u0027true\u0027) }"},{"line_number":593,"context_line":"      it { is_expected.to contain_nova_config(\u0027DEFAULT/monkey_patch_modules\u0027).with_value(\u0027nova.api.ec2.cloud:nova.notifications.notify_decorator\u0027) }"},{"line_number":594,"context_line":"    end"},{"line_number":595,"context_line":""},{"line_number":596,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":4,"id":"1ac06dbe_9e5fc440","line":593,"in_reply_to":"9ad45d7e_d6b8332d","updated":"2016-08-22 01:27:42.000000000","message":"thanks，done","commit_id":"1b261e2388304cd91db66b6e63920a0a0c32fcef"}]}