)]}'
{"manifests/migration/qemu.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"56732e02a4ff3c693f17dffad62e29f0adecad63","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   Defaults to 49215."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class nova::migration::qemu("},{"line_number":20,"context_line":"  $configure_qemu \u003d false,"},{"line_number":21,"context_line":"  $migration_port_min \u003d 49152,"},{"line_number":22,"context_line":"  $migration_port_max \u003d 49215,"},{"line_number":23,"context_line":"){"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_5bb9032e","line":20,"updated":"2016-10-04 14:07:39.000000000","message":"nit: alignment","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"56732e02a4ff3c693f17dffad62e29f0adecad63","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  if $configure_qemu {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Anchor[\u0027nova::config::begin\u0027]"},{"line_number":30,"context_line":"    -\u003e File_line\u003c| tag \u003d\u003d \u0027qemu-augeas\u0027|\u003e"},{"line_number":31,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    File_line\u003c| tag \u003d\u003d \u0027qemu-augeas\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_fb864f12","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":16},"updated":"2016-10-04 14:07:39.000000000","message":"should not it be Augeas?","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"05c2791e3a3ed84d59b94963e87be4fd47d69ec0","unresolved":false,"context_lines":[{"line_number":27,"context_line":"  if $configure_qemu {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Anchor[\u0027nova::config::begin\u0027]"},{"line_number":30,"context_line":"    -\u003e File_line\u003c| tag \u003d\u003d \u0027qemu-augeas\u0027|\u003e"},{"line_number":31,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    File_line\u003c| tag \u003d\u003d \u0027qemu-augeas\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_fb71efe1","line":30,"range":{"start_line":30,"start_character":7,"end_line":30,"end_character":16},"in_reply_to":"1a95cdbc_fb864f12","updated":"2016-10-04 14:12:21.000000000","message":"oh, how i missed it??) will fix","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"56732e02a4ff3c693f17dffad62e29f0adecad63","unresolved":false,"context_lines":[{"line_number":30,"context_line":"    -\u003e File_line\u003c| tag \u003d\u003d \u0027qemu-augeas\u0027|\u003e"},{"line_number":31,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    File_line\u003c| tag \u003d\u003d \u0027qemu-augeas\u0027 |\u003e"},{"line_number":34,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    augeas { \u0027qemu-conf-migration-ports\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_5b76633f","line":33,"range":{"start_line":33,"start_character":4,"end_line":33,"end_character":13},"updated":"2016-10-04 14:07:39.000000000","message":"same","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"56732e02a4ff3c693f17dffad62e29f0adecad63","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027rm migration_port_max\u0027,"},{"line_number":50,"context_line":"      ],"},{"line_number":51,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_db98b36d","line":52,"updated":"2016-10-04 14:07:39.000000000","message":"i think restart also has to be here","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"63b752388512d1aa173a4dc66584bde5dda7487c","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027rm migration_port_max\u0027,"},{"line_number":50,"context_line":"      ],"},{"line_number":51,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_fe02bd6e","line":52,"in_reply_to":"1a95cdbc_1ec4c990","updated":"2016-10-04 14:18:05.000000000","message":"it will be done by lines 33-34 when they are fixed","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"67a71a8c5f6525c2acb6bdd5c920da35ad254d15","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027rm migration_port_max\u0027,"},{"line_number":50,"context_line":"      ],"},{"line_number":51,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_1ec4c990","line":52,"in_reply_to":"1a95cdbc_3b099732","updated":"2016-10-04 14:14:39.000000000","message":"libvirt service, no?","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"06561acae6a436bf99bd4168d51487d11095213a","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027rm migration_port_max\u0027,"},{"line_number":50,"context_line":"      ],"},{"line_number":51,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_04bb9c73","line":52,"in_reply_to":"1a95cdbc_611d3266","updated":"2016-10-04 14:46:40.000000000","message":"ah you right, will fix","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"05c2791e3a3ed84d59b94963e87be4fd47d69ec0","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027rm migration_port_max\u0027,"},{"line_number":50,"context_line":"      ],"},{"line_number":51,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_3b099732","line":52,"in_reply_to":"1a95cdbc_db98b36d","updated":"2016-10-04 14:12:21.000000000","message":"hmm restart of what?)","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"0710fe595562c4752a06a2cdb4fd2f6c60a8ae97","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027rm migration_port_max\u0027,"},{"line_number":50,"context_line":"      ],"},{"line_number":51,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":52,"context_line":"    }"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"1a95cdbc_611d3266","line":52,"in_reply_to":"1a95cdbc_fe02bd6e","updated":"2016-10-04 14:21:55.000000000","message":"No, it will not be done. Because they are under \u0027true\u0027 condition. Then you need to move those lines out of if block.","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"57989da887b6ce385fe7ba52e36adcff4e31cbcc","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":34,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    augeas { \u0027qemu-conf-migration-ports\u0027:"},{"line_number":37,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_d01de0be","line":34,"updated":"2016-10-04 18:50:07.000000000","message":"Since the service management is optional do we need to do soemthing like ~\u003e Service\u003c| title \u003d\u003d \u0027libvirt\u0027 |\u003e","commit_id":"c26e56255dbe0bf355f847fdca0cdd19b314698c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"8ea064e838a51e75193de5b8ee3ae52ba62a871d","unresolved":false,"context_lines":[{"line_number":26,"context_line":""},{"line_number":27,"context_line":"  if $configure_qemu {"},{"line_number":28,"context_line":""},{"line_number":29,"context_line":"    Anchor[\u0027nova::config::begin\u0027]"},{"line_number":30,"context_line":"    -\u003e Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":31,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":32,"context_line":""},{"line_number":33,"context_line":"    Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":34,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"    augeas { \u0027qemu-conf-migration-ports\u0027:"},{"line_number":37,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_0482b700","line":34,"range":{"start_line":29,"start_character":0,"end_line":34,"end_character":25},"updated":"2016-10-04 15:57:11.000000000","message":"i think you can just move this out of if block","commit_id":"c26e56255dbe0bf355f847fdca0cdd19b314698c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"57989da887b6ce385fe7ba52e36adcff4e31cbcc","unresolved":false,"context_lines":[{"line_number":49,"context_line":"        \u0027rm migration_port_max\u0027,"},{"line_number":50,"context_line":"      ],"},{"line_number":51,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":52,"context_line":"      notify  \u003d\u003e Service[\u0027libvirt\u0027],"},{"line_number":53,"context_line":"    }"},{"line_number":54,"context_line":"  }"},{"line_number":55,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"1a95cdbc_f0781cfb","line":52,"updated":"2016-10-04 18:50:07.000000000","message":"this is redundant if you move the notification out of the if/else block","commit_id":"c26e56255dbe0bf355f847fdca0cdd19b314698c"},{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"3c7468923fb036a87f511c9c4695e7ea3cdf5503","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":32,"context_line":"  ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $configure_qemu {"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a95cdbc_e68842ea","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":23},"updated":"2016-10-05 13:47:39.000000000","message":"please take a look on Alex\u0027 comment for this on prev patch set.","commit_id":"1c19735a9a40ca8f47aa9bc83a237cc16501ef1b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"80c711f89d1cc708f3a11f9d70d39c3a5ba3cf8b","unresolved":false,"context_lines":[{"line_number":29,"context_line":"  -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":32,"context_line":"  ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $configure_qemu {"},{"line_number":35,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":9,"id":"1a95cdbc_e67202e5","line":32,"range":{"start_line":32,"start_character":0,"end_line":32,"end_character":23},"in_reply_to":"1a95cdbc_e68842ea","updated":"2016-10-05 13:50:47.000000000","message":"I\u0027m ok with this since the user should probably be already managing the service within their catalog if they plan on adjusting configuration items.  Otherwise they might end up not actually restarting the service because it failed silently","commit_id":"1c19735a9a40ca8f47aa9bc83a237cc16501ef1b"}],"releasenotes/notes/add_migration_qemu_class-3b3386696dd597c2.yaml":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e0bd481d21b2e87bf356da948812af15b24f2928","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Add class for management of migration"},{"line_number":4,"context_line":"    options in qemu.conf "}],"source_content_type":"text/x-yaml","patch_set":7,"id":"1a95cdbc_9b81cb50","line":4,"range":{"start_line":4,"start_character":24,"end_line":4,"end_character":25},"updated":"2016-10-04 14:03:18.000000000","message":"sneaky trailing space","commit_id":"67b8b70d3ec1a31f3fd66dddc1eef5ed5df3b58f"}],"spec/classes/nova_migration_qemu_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"23f36771284e793ac76f0d584949109179f5e3c6","unresolved":false,"context_lines":[{"line_number":57,"context_line":"         facts.merge!(OSDefaults.get_facts())"},{"line_number":58,"context_line":"       end"},{"line_number":59,"context_line":"     end"},{"line_number":60,"context_line":"     it_configures \u0027nova migration with qemu\u0027"},{"line_number":61,"context_line":"  end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3a98d1f4_ccc82258","line":60,"updated":"2016-10-03 16:37:31.000000000","message":"this needs to be in the context block -^ move it between the two ends on line 58/59","commit_id":"6b341e3cbf6450ab9142e7dc0f4588bdfebb0666"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"0c92ac05a6245d9f76f8550baf3fd14b23683a48","unresolved":false,"context_lines":[{"line_number":57,"context_line":"         facts.merge!(OSDefaults.get_facts())"},{"line_number":58,"context_line":"       end"},{"line_number":59,"context_line":"     end"},{"line_number":60,"context_line":"     it_configures \u0027nova migration with qemu\u0027"},{"line_number":61,"context_line":"  end"},{"line_number":62,"context_line":""},{"line_number":63,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3a98d1f4_9aeb8c12","line":60,"in_reply_to":"3a98d1f4_ccc82258","updated":"2016-10-04 09:38:10.000000000","message":"thanks Alex! will correct this","commit_id":"6b341e3cbf6450ab9142e7dc0f4588bdfebb0666"}]}