)]}'
{"manifests/init.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d9186f4c649cf8f96edda12c17687d0c99a96e50","unresolved":false,"context_lines":[{"line_number":233,"context_line":"#"},{"line_number":234,"context_line":"# [*log_dir*]"},{"line_number":235,"context_line":"#   (optional) Directory where logs should be stored."},{"line_number":236,"context_line":"#   If set to $::os_service_default, it will not log to any directory."},{"line_number":237,"context_line":"#   Defaults to undef"},{"line_number":238,"context_line":"#"},{"line_number":239,"context_line":"# [*state_path*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a95cdbc_60e4ec3a","line":236,"updated":"2016-10-06 10:26:14.000000000","message":"this parameter kept only for backward compatibility with logging class. So, not sure that we need this. At least old description is still true","commit_id":"675bd227ba2438d9bd71418bd47b0432798fb940"}],"manifests/logging.pp":[{"author":{"_account_id":7745,"name":"Denis Egorenko","email":"degorenko@mirantis.com","username":"degorenko"},"change_message_id":"d9186f4c649cf8f96edda12c17687d0c99a96e50","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"#  [*log_dir*]"},{"line_number":24,"context_line":"#    (optional) Directory where logs should be stored."},{"line_number":25,"context_line":"#    If set to $::os_service_default, it will not log to any directory."},{"line_number":26,"context_line":"#    Defaults to \u0027/var/log/nova\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#  [*logging_context_format_string*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a95cdbc_00c6c899","line":25,"updated":"2016-10-06 10:26:14.000000000","message":"same here, old description is still true","commit_id":"675bd227ba2438d9bd71418bd47b0432798fb940"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"1b7ee28540670d8b37a6fe28aa0823e1499082ce","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"#  [*log_dir*]"},{"line_number":24,"context_line":"#    (optional) Directory where logs should be stored."},{"line_number":25,"context_line":"#    If set to $::os_service_default, it will not log to any directory."},{"line_number":26,"context_line":"#    Defaults to \u0027/var/log/nova\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#  [*logging_context_format_string*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a95cdbc_fc5eca10","line":25,"updated":"2016-10-06 18:04:27.000000000","message":"yea for log_dir much like log_file we need to reference $::os_service_default as the way to remove it because false gets passed to the provider which ends up as False in the config which ultimate gets interpreted as a file or directory name.","commit_id":"675bd227ba2438d9bd71418bd47b0432798fb940"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7e22ed67064b6488d10953574d8e9456467704c2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"#  [*log_dir*]"},{"line_number":24,"context_line":"#    (optional) Directory where logs should be stored."},{"line_number":25,"context_line":"#    If set to $::os_service_default, it will not log to any directory."},{"line_number":26,"context_line":"#    Defaults to \u0027/var/log/nova\u0027"},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#  [*logging_context_format_string*]"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a95cdbc_cbdec13e","line":25,"in_reply_to":"1a95cdbc_00c6c899","updated":"2016-10-06 10:49:51.000000000","message":"hmm here https://bugs.launchpad.net/puppet-nova/+bug/1600294 it is stated that false value leads to failure on startup of nova process","commit_id":"675bd227ba2438d9bd71418bd47b0432798fb940"}]}