)]}'
{"manifests/compute/xenserver.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b6e0a7d4e9ce87d01c5fc2598d079a78a0b3b499","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   (optional) DEPRECATED: This parameter does nothing."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::compute::xenserver("},{"line_number":24,"context_line":"  $xenapi_connection_url,"},{"line_number":25,"context_line":"  $xenapi_connection_username,"},{"line_number":26,"context_line":"  $xenapi_connection_password,"},{"line_number":27,"context_line":"  $compute_driver \u003d \u0027xenapi.XenAPIDriver\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_34ed9eef","side":"PARENT","line":24,"updated":"2016-11-01 21:13:50.000000000","message":"Not that anyone was necessarily using this, but to maintain backwards compatibility we should properly deprecate these and replace with connection_{url,username,password}.","commit_id":"b735b67158035cee7b2e44ac64bb0a1d82df10dd"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7c92459136a12350b48788246f949d5686230e6f","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   (optional) DEPRECATED: This parameter does nothing."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::compute::xenserver("},{"line_number":24,"context_line":"  $xenapi_connection_url,"},{"line_number":25,"context_line":"  $xenapi_connection_username,"},{"line_number":26,"context_line":"  $xenapi_connection_password,"},{"line_number":27,"context_line":"  $compute_driver \u003d \u0027xenapi.XenAPIDriver\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_14809a8a","side":"PARENT","line":24,"in_reply_to":"ba5da102_141fbab7","updated":"2016-11-01 21:30:25.000000000","message":"Yea so traditionally for something like this, they get put in the deprecated section with a new default value of undef and a warning that they are deprecated and to use $newvar.  In this case, I\u0027m not even sure you need to rename these other than for aesthetics so it\u0027d probably be best to leave these alone and forgo the work required for proper deprecation. The issue with the rename is that you\u0027ll break anyone who is currently using these. Since these are required parameters, that\u0027s everyone who uses this class.\n\n\nA very long and painful process would be to set them all to undef and do some if else blocks to verify that at least one of the versions of the variables be set.","commit_id":"b735b67158035cee7b2e44ac64bb0a1d82df10dd"},{"author":{"_account_id":21748,"name":"Michal Adamczyk","email":"vanditboy@gmail.com","username":"vanditboy"},"change_message_id":"fb975ce7372e958337e0de8f6d6d007dde37ea43","unresolved":false,"context_lines":[{"line_number":21,"context_line":"#   (optional) DEPRECATED: This parameter does nothing."},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"class nova::compute::xenserver("},{"line_number":24,"context_line":"  $xenapi_connection_url,"},{"line_number":25,"context_line":"  $xenapi_connection_username,"},{"line_number":26,"context_line":"  $xenapi_connection_password,"},{"line_number":27,"context_line":"  $compute_driver \u003d \u0027xenapi.XenAPIDriver\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"ba5da102_141fbab7","side":"PARENT","line":24,"in_reply_to":"ba5da102_34ed9eef","updated":"2016-11-01 21:22:56.000000000","message":"What do you mean by \"properly deprecate these\"? Put them under the # DEPRECATED PARAMETERS section?","commit_id":"b735b67158035cee7b2e44ac64bb0a1d82df10dd"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3c0ae799212cb610ef3f46f31696d81f653c8ca7","unresolved":false,"context_lines":[{"line_number":17,"context_line":"#   (optional) Compute driver."},{"line_number":18,"context_line":"#   Defaults to \u0027xenapi.XenAPIDriver\u0027"},{"line_number":19,"context_line":"#"},{"line_number":20,"context_line":"# [*ovs_integration_bridge*]"},{"line_number":21,"context_line":"#   (optional) Name of Integration Bridge used by Open vSwitch (string value)"},{"line_number":22,"context_line":"#"},{"line_number":23,"context_line":"# [*agent_timeout*]"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_00e29cd5","line":20,"updated":"2016-12-01 14:34:56.000000000","message":"can you please add the Deafults to $::os_service_default ? (do this for all parameters)","commit_id":"4c94d4b7e3713aa473e5cc0f04459a31fe5ef1bb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3c0ae799212cb610ef3f46f31696d81f653c8ca7","unresolved":false,"context_lines":[{"line_number":259,"context_line":"    warning(\u0027The xenapi_inject_image parameter is deprecated and has no effect.\u0027)"},{"line_number":260,"context_line":"  }"},{"line_number":261,"context_line":""},{"line_number":262,"context_line":"  if $xenapi_connection_url !\u003d undef {"},{"line_number":263,"context_line":"    warning(\u0027The xenapi_connection_url parameter is deprecated, please use connection_url.\u0027)"},{"line_number":264,"context_line":"  }"},{"line_number":265,"context_line":""},{"line_number":266,"context_line":"  if $xenapi_connection_username !\u003d undef {"},{"line_number":267,"context_line":"    warning(\u0027The xenapi_connection_username parameter is deprecated, please use connection_username.\u0027)"},{"line_number":268,"context_line":"  }"},{"line_number":269,"context_line":""},{"line_number":270,"context_line":"  if $xenapi_connection_password !\u003d undef {"},{"line_number":271,"context_line":"    warning(\u0027The xenapi_connection_password parameter is deprecated, please use connection_password.\u0027)"},{"line_number":272,"context_line":"  }"},{"line_number":273,"context_line":""},{"line_number":274,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_606d1032","line":271,"range":{"start_line":262,"start_character":0,"end_line":271,"end_character":16},"updated":"2016-12-01 14:34:56.000000000","message":"you can just use if $parameter here \u003d)","commit_id":"4c94d4b7e3713aa473e5cc0f04459a31fe5ef1bb"},{"author":{"_account_id":15519,"name":"Iury Gregory Melo Ferreira","display_name":"Iury Gregory","email":"iurygregory@gmail.com","username":"iurygregory"},"change_message_id":"3c0ae799212cb610ef3f46f31696d81f653c8ca7","unresolved":false,"context_lines":[{"line_number":320,"context_line":"    \u0027xenserver/vif_driver\u0027:                            value \u003d\u003e $vif_driver;"},{"line_number":321,"context_line":"    \u0027xenserver/image_upload_handler\u0027:                  value \u003d\u003e $image_upload_handler;"},{"line_number":322,"context_line":"    \u0027xenserver/introduce_vdi_retry_wait\u0027:              value \u003d\u003e $introduce_vdi_retry_wait;"},{"line_number":323,"context_line":"    \u0027DEFAULT/xenapi_connection_url\u0027:                   value \u003d\u003e $xenapi_connection_url;"},{"line_number":324,"context_line":"    \u0027DEFAULT/xenapi_connection_username\u0027:              value \u003d\u003e $xenapi_connection_username;"},{"line_number":325,"context_line":"    \u0027DEFAULT/xenapi_connection_password\u0027:              value \u003d\u003e $xenapi_connection_password;"},{"line_number":326,"context_line":"  }"},{"line_number":327,"context_line":""},{"line_number":328,"context_line":"  ensure_packages([\u0027python-pip\u0027])"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"3a71b18c_40173451","line":325,"range":{"start_line":323,"start_character":0,"end_line":325,"end_character":92},"updated":"2016-12-01 14:34:56.000000000","message":"You have no problem in set the new parameters and the deprecated parameters ? also this is not backward compatible,\nyou should evaluate if the deprecated parameter is set.\nMaybe connection_username should recive the value of xenapi_connection_username if set.. (same for the other deprecated ones)","commit_id":"4c94d4b7e3713aa473e5cc0f04459a31fe5ef1bb"}]}