)]}'
{"manifests/metadata/novajoin/api.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"4e67b004cf3c58a4bb9776726fc22a73adde03b3","unresolved":false,"context_lines":[{"line_number":72,"context_line":") inherits nova::metadata::novajoin::params {"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"  if $enable_ipa_client_install {"},{"line_number":75,"context_line":"    require ::nova::metadata::novajoin::ipaclient"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":""},{"line_number":78,"context_line":"  if $ipa_principal \u003d\u003d undef {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a74a57a_c397708e","line":75,"range":{"start_line":75,"start_character":4,"end_line":75,"end_character":49},"updated":"2016-11-25 09:00:51.000000000","message":"it is incorrect, it will not work, I think you need :\n\ninclude ::nova::metadata::novajoin::ipaclient","commit_id":"2137c789b5063c26251a0307977fca8b6b6fc6ed"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"8ddd4eecaa9be2de8866129830b89b540217f69f","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  if $enable_ipa_client_install {"},{"line_number":84,"context_line":"    # ipa_client_install should be completed before this manifest"},{"line_number":85,"context_line":"    require ::nova::metadata::novajoin::ipaclient"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  $opt1 \u003d \"--principal ${ipa_principal} --user ${nova_user}\""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a71b18c_ba98bec1","line":85,"updated":"2016-12-05 09:17:36.000000000","message":"I think it should be:\ninclude ::nova::metadata::novajoin::ipaclient","commit_id":"2a5d7c28fa7f210f2439592139e19d263e903c2d"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"593cbaa1bca23b9271a33f568113a683f0060a8a","unresolved":false,"context_lines":[{"line_number":82,"context_line":""},{"line_number":83,"context_line":"  if $enable_ipa_client_install {"},{"line_number":84,"context_line":"    # ipa_client_install should be completed before this manifest"},{"line_number":85,"context_line":"    require ::nova::metadata::novajoin::ipaclient"},{"line_number":86,"context_line":"  }"},{"line_number":87,"context_line":""},{"line_number":88,"context_line":"  $opt1 \u003d \"--principal ${ipa_principal} --user ${nova_user}\""}],"source_content_type":"text/x-puppet","patch_set":12,"id":"3a71b18c_35767fa4","line":85,"in_reply_to":"3a71b18c_ba98bec1","updated":"2016-12-05 09:38:58.000000000","message":"sorry looks like it is a new function","commit_id":"2a5d7c28fa7f210f2439592139e19d263e903c2d"}],"manifests/metadata/novajoin/ipaclient.pp":[{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"b59384c4c5c6a6bc44b1fec92712eb1563e60ef2","unresolved":false,"context_lines":[{"line_number":22,"context_line":"#   (optional) Force install."},{"line_number":23,"context_line":"#   Defaults to false"},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"# [*hostname*]"},{"line_number":26,"context_line":"#   (optional) Hostname of client"},{"line_number":27,"context_line":"#   If not set, ipa-client-install takes nodename from uname"},{"line_number":28,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_4f2bd133","line":25,"updated":"2016-11-21 22:00:29.000000000","message":"I\u0027m ok with the variable name but I\u0027d document that IPA expects a FQDN, not an IP address or short name.","commit_id":"e2a5eae2af12cf13fc5a0793015abcbe570daa2b"},{"author":{"_account_id":7662,"name":"Rob Crittenden","email":"rcritten@redhat.com","username":"rcritten"},"change_message_id":"b59384c4c5c6a6bc44b1fec92712eb1563e60ef2","unresolved":false,"context_lines":[{"line_number":88,"context_line":"    ipapython.sysrestore.FileStore(\\\"/var/lib/ipa-client/sysrestore\\\").has_files() else 1)\u0027\""},{"line_number":89,"context_line":""},{"line_number":90,"context_line":"  # TODO(alee) figure out how to allow force-reinstalls"},{"line_number":91,"context_line":"  # run ipa client install script"},{"line_number":92,"context_line":"  exec { \u0027ipaclient-install-script\u0027:"},{"line_number":93,"context_line":"    command \u003d\u003e \"/usr/sbin/ipa-client-install ${install_opts}\","},{"line_number":94,"context_line":"    require \u003d\u003e Package[\u0027ipa-client\u0027],"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"7a77a97e_6fa5edb3","line":91,"updated":"2016-11-21 22:00:29.000000000","message":"I\u0027m not sure force re-install makes sense. An OTP is only valid once, are you suggesting one could re-provision the OTP and force it to try to install again? If so you can try the --force-join option. Not sure this works with an OTP.","commit_id":"e2a5eae2af12cf13fc5a0793015abcbe570daa2b"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"3cf1997d8bad00314a9459ae98ab0ad0ff31a87c","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to undef"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class nova::metadata::novajoin::ipaclient ("},{"line_number":37,"context_line":"  $otp            \u003d undef,"},{"line_number":38,"context_line":"  $ensure_package \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $ipa_domain     \u003d undef,"},{"line_number":40,"context_line":"  $fqdn           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a74a57a_e0cf34b1","line":37,"updated":"2016-11-30 17:20:21.000000000","message":"I think it should be required parameter","commit_id":"0bf54bdb3ee1f0c11f753f1c180420efe30c3977"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"6fa6f2865cc38fffc1e2a0d15e60576a07c0a359","unresolved":false,"context_lines":[{"line_number":34,"context_line":"#   Defaults to undef"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"class nova::metadata::novajoin::ipaclient ("},{"line_number":37,"context_line":"  $otp            \u003d undef,"},{"line_number":38,"context_line":"  $ensure_package \u003d \u0027present\u0027,"},{"line_number":39,"context_line":"  $ipa_domain     \u003d undef,"},{"line_number":40,"context_line":"  $fqdn           \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a74a57a_b74bc058","line":37,"in_reply_to":"5a74a57a_e0cf34b1","updated":"2016-11-30 18:56:39.000000000","message":"will fix.","commit_id":"0bf54bdb3ee1f0c11f753f1c180420efe30c3977"},{"author":{"_account_id":7732,"name":"IvanBerezovskiy","email":"ivan.berezovskii@gmail.com","username":"iberezovskiy"},"change_message_id":"3cf1997d8bad00314a9459ae98ab0ad0ff31a87c","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      $ipa_client_package  \u003d \u0027ipa-client\u0027"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"    \u0027Debian\u0027: {"},{"line_number":50,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"    default: {"},{"line_number":53,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a74a57a_20ddac42","line":50,"updated":"2016-11-30 17:20:21.000000000","message":"I guess it names freeipa-client. If it\u0027s correct, you need to move this block to params.pp","commit_id":"0bf54bdb3ee1f0c11f753f1c180420efe30c3977"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"6fa6f2865cc38fffc1e2a0d15e60576a07c0a359","unresolved":false,"context_lines":[{"line_number":47,"context_line":"      $ipa_client_package  \u003d \u0027ipa-client\u0027"},{"line_number":48,"context_line":"    }"},{"line_number":49,"context_line":"    \u0027Debian\u0027: {"},{"line_number":50,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"},{"line_number":51,"context_line":"    }"},{"line_number":52,"context_line":"    default: {"},{"line_number":53,"context_line":"      fail(\"Unsupported osfamily: ${::osfamily} operatingsystem\")"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"5a74a57a_d7b4bc36","line":50,"in_reply_to":"5a74a57a_20ddac42","updated":"2016-11-30 18:56:39.000000000","message":"yes - I was planning on setting this once I had a chance to test it out.  There may for instance be version dependencies.\n\nI can let this fall through to default for now.\n\nEmilien asked me to remove params.pp - which is why this shows up here.","commit_id":"0bf54bdb3ee1f0c11f753f1c180420efe30c3977"}],"spec/classes/nova_metadata_novajoin_ipaclient_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"4e67b004cf3c58a4bb9776726fc22a73adde03b3","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027nova::metadata::novajoin::ipaclient\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":"  let :facts do"},{"line_number":6,"context_line":"    @default_facts.merge("},{"line_number":7,"context_line":"      {"},{"line_number":8,"context_line":"        :osfamily       \u003d\u003e \u0027RedHat\u0027,"},{"line_number":9,"context_line":"        :processorcount \u003d\u003e \u00277\u0027,"},{"line_number":10,"context_line":"      }"},{"line_number":11,"context_line":"    )"},{"line_number":12,"context_line":"  end"},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"  let :params do"},{"line_number":15,"context_line":"    {"}],"source_content_type":"text/x-ruby","patch_set":5,"id":"5a74a57a_434e0070","line":12,"range":{"start_line":5,"start_character":2,"end_line":12,"end_character":5},"updated":"2016-11-25 09:00:51.000000000","message":"you don\u0027t need this because you have lines 60-69","commit_id":"2137c789b5063c26251a0307977fca8b6b6fc6ed"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"7539a5aefe53fe8ecbaaae984ff93a4f087a55c1","unresolved":false,"context_lines":[{"line_number":48,"context_line":"  end"},{"line_number":49,"context_line":""},{"line_number":50,"context_line":"  describe \u0027on RedHat platforms\u0027 do"},{"line_number":51,"context_line":"    let :facts do"},{"line_number":52,"context_line":"      @default_facts.merge({"},{"line_number":53,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"},{"line_number":54,"context_line":"        :operatingsystemrelease \u003d\u003e \u00277\u0027,"},{"line_number":55,"context_line":"      })"},{"line_number":56,"context_line":"    end"},{"line_number":57,"context_line":""},{"line_number":58,"context_line":"    it_behaves_like \u0027nova-metadata-novajoin-ipaclient\u0027"},{"line_number":59,"context_line":"  end"}],"source_content_type":"text/x-ruby","patch_set":11,"id":"3a71b18c_25d6d1c5","line":56,"range":{"start_line":51,"start_character":0,"end_line":56,"end_character":7},"updated":"2016-12-01 12:12:44.000000000","message":"let :facts do\n      OSDefaults.get_facts({\n        :osfamily        \u003d\u003e \u0027RedHat\u0027,\n        :operatingsystem \u003d\u003e \u0027RedHat\u0027,\n      })\n    end","commit_id":"79a08b3f416ed0fcd3de9a0a601db4fa6fbad97a"}]}