)]}'
{"manifests/keystone/auth_placement.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"a6fa928719c8ca0b13dd7b083a36174f74de62d4","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $region                  \u003d \u0027RegionOne\u0027,"},{"line_number":64,"context_line":"  $tenant                  \u003d \u0027services\u0027,"},{"line_number":65,"context_line":"  $email                   \u003d \u0027placement@localhost\u0027,"},{"line_number":66,"context_line":"  # should we have microversion support here?"},{"line_number":67,"context_line":"  $public_url              \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":68,"context_line":"  $internal_url            \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":69,"context_line":"  $admin_url               \u003d \u0027http://127.0.0.1:8778\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_c1784ac7","line":66,"updated":"2016-12-03 16:17:21.000000000","message":"I asked to cdent. In the meantime, I tested without and it seems to work fine.","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"67ba68280890d27a26e31dd3cf2847886cb54ad6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $region                  \u003d \u0027RegionOne\u0027,"},{"line_number":64,"context_line":"  $tenant                  \u003d \u0027services\u0027,"},{"line_number":65,"context_line":"  $email                   \u003d \u0027placement@localhost\u0027,"},{"line_number":66,"context_line":"  # should we have microversion support here?"},{"line_number":67,"context_line":"  $public_url              \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":68,"context_line":"  $internal_url            \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":69,"context_line":"  $admin_url               \u003d \u0027http://127.0.0.1:8778\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_6384d3d3","line":66,"in_reply_to":"3a71b18c_2dde4c11","updated":"2016-12-04 22:29:22.000000000","message":"Done","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3c00ac4beb61e5cd39798e2c05c56a5a50375f7e","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $region                  \u003d \u0027RegionOne\u0027,"},{"line_number":64,"context_line":"  $tenant                  \u003d \u0027services\u0027,"},{"line_number":65,"context_line":"  $email                   \u003d \u0027placement@localhost\u0027,"},{"line_number":66,"context_line":"  # should we have microversion support here?"},{"line_number":67,"context_line":"  $public_url              \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":68,"context_line":"  $internal_url            \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":69,"context_line":"  $admin_url               \u003d \u0027http://127.0.0.1:8778\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_2dde4c11","line":66,"in_reply_to":"3a71b18c_c1784ac7","updated":"2016-12-04 12:14:26.000000000","message":"I think you mean whether a version in the URL is required here? It\u0027s not. The intention is that a version will _never_ show up in the placement URLs. Instead the major version will always be \u00271\u0027 and microversions (in OpenStack-API-Version: placement 1.nn headers) will be used when there are changes.\n\nSo the URL in keystone will always be the base endpoint. Assuming you are configured apache to have a virtual host only listening on port 8778 then what you have here is correct.\n\nIn devstack we have things set up so that placement listens on port 8778 at \u0027/\u0027 and on port 80 at /placement and register the latter with keystone. This is because  there\u0027s been a general goal of getting all the services to eventually represent themselves on port 80.\n\nSince people will presumably be configuring this setting explicitly when using this code, I would guess that this default is fine.","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9a5be8c08b716e72c3bc7e659560c64ac44dab76","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  include ::nova::deps"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if $configure_endpoint {"},{"line_number":77,"context_line":"    Keystone_endpoint[\"${region}/${service_name}::placement\"] ~\u003e Service \u003c| name \u003d\u003d \u0027nova-api\u0027 |\u003e"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  keystone::resource::service_identity { \u0027placement\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_d698f2c2","line":77,"updated":"2016-12-05 10:22:15.000000000","message":"Is this supposed to be \u0027nova-api\u0027 here?","commit_id":"a51704466fe1c78217d1a10d698038021bd016f3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"80503ea5cc8f2560d974c8091c876178548433d8","unresolved":false,"context_lines":[{"line_number":74,"context_line":"  include ::nova::deps"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  if $configure_endpoint {"},{"line_number":77,"context_line":"    Keystone_endpoint[\"${region}/${service_name}::placement\"] ~\u003e Service \u003c| name \u003d\u003d \u0027nova-api\u0027 |\u003e"},{"line_number":78,"context_line":"  }"},{"line_number":79,"context_line":""},{"line_number":80,"context_line":"  keystone::resource::service_identity { \u0027placement\u0027:"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_f6532e69","line":77,"in_reply_to":"3a71b18c_d698f2c2","updated":"2016-12-05 10:35:06.000000000","message":"I think I\u0027m going to remove it, we don\u0027t need it. It was needed in the past when we deployed nova without wsgi.","commit_id":"a51704466fe1c78217d1a10d698038021bd016f3"},{"author":{"_account_id":7166,"name":"Sylvain Bauza","email":"sbauza@redhat.com","username":"sbauza"},"change_message_id":"793034a2394b8fe60424fa43a71fc2b9ec75b89f","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $region                  \u003d \u0027RegionOne\u0027,"},{"line_number":64,"context_line":"  $tenant                  \u003d \u0027services\u0027,"},{"line_number":65,"context_line":"  $email                   \u003d \u0027placement@localhost\u0027,"},{"line_number":66,"context_line":"  $public_url              \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":67,"context_line":"  $internal_url            \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":68,"context_line":"  $admin_url               \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":69,"context_line":"  $configure_endpoint      \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a6eadb0_f4d432be","line":66,"range":{"start_line":66,"start_character":46,"end_line":66,"end_character":51},"updated":"2016-12-20 15:35:25.000000000","message":"devstack is adding the service catalog entry on the port 80 with the /placement endpoint https://github.com/openstack-dev/devstack/blob/51a225c5d7f7d8655be62cab0e4d677b6839f35a/lib/placement#L133\n\nYou should totally remove any occurrence of that port, also because that port is used by Senlin too. Context here http://lists.openstack.org/pipermail/openstack-dev/2016-December/109219.html\n\nFWIW, I proposed a change against Devstack for removing all usages of 8778 https://review.openstack.org/#/c/413118/\n\nHTH.","commit_id":"00b5643a0d22b28e1005fcceddbe7aae828ef5f0"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"f45524178f8d8a67d416ae1374aa08debb21d4c6","unresolved":false,"context_lines":[{"line_number":63,"context_line":"  $region                  \u003d \u0027RegionOne\u0027,"},{"line_number":64,"context_line":"  $tenant                  \u003d \u0027services\u0027,"},{"line_number":65,"context_line":"  $email                   \u003d \u0027placement@localhost\u0027,"},{"line_number":66,"context_line":"  $public_url              \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":67,"context_line":"  $internal_url            \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":68,"context_line":"  $admin_url               \u003d \u0027http://127.0.0.1:8778\u0027,"},{"line_number":69,"context_line":"  $configure_endpoint      \u003d true,"}],"source_content_type":"text/x-puppet","patch_set":13,"id":"1a6eadb0_d412d661","line":66,"range":{"start_line":66,"start_character":46,"end_line":66,"end_character":51},"in_reply_to":"1a6eadb0_f4d432be","updated":"2016-12-20 15:38:17.000000000","message":"ack. We\u0027ll address this issue in a following patch.\nSince this is a default parameter, anyone can override it with their custom port (80 or whatever), so it\u0027s \"ok\" to default it to 8778 now.\nBut we need to address it, you\u0027re right. I\u0027ll follow up with a patch later this week.","commit_id":"00b5643a0d22b28e1005fcceddbe7aae828ef5f0"}],"manifests/params.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3c00ac4beb61e5cd39798e2c05c56a5a50375f7e","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      $nova_log_group                    \u003d \u0027nova\u0027"},{"line_number":52,"context_line":"      $nova_wsgi_script_path             \u003d \u0027/var/www/cgi-bin/nova\u0027"},{"line_number":53,"context_line":"      $nova_api_wsgi_script_source       \u003d \u0027/usr/lib/python2.7/site-packages/nova/wsgi/nova-api.py\u0027"},{"line_number":54,"context_line":"      $nova_placement_wsgi_script_source \u003d \u0027/usr/lib/python2.7/site-packages/nova/api/openstack/placement/wsgi.py\u0027"},{"line_number":55,"context_line":"      case $::operatingsystem {"},{"line_number":56,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027, \u0027Scientific\u0027, \u0027OracleLinux\u0027: {"},{"line_number":57,"context_line":"          if (versioncmp($::operatingsystemmajrelease, \u00277\u0027) \u003c 0) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_8d392044","line":54,"updated":"2016-12-04 12:14:26.000000000","message":"Two issues here:\n\n* the value here is wrong. You want whatever the path is to the pbr-generated script \u0027nova-placement-api\u0027. It may be in /usr/local/bin, depending on how things have been packaged. The wsgi.py module is used by that script, but the script is required as the thing which exports the \u0027application\u0027 symbol that the mod_wsgi (or other wsgi servers) require.\n\n* Since placement is going to become its own independent service eventually, you could save yourself a whole lot of reformatting by getting rid of the \u0027nova_\u0027 that starts the variable and just have \u0027placement_wsgi_script_source\u0027","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"67ba68280890d27a26e31dd3cf2847886cb54ad6","unresolved":false,"context_lines":[{"line_number":51,"context_line":"      $nova_log_group                    \u003d \u0027nova\u0027"},{"line_number":52,"context_line":"      $nova_wsgi_script_path             \u003d \u0027/var/www/cgi-bin/nova\u0027"},{"line_number":53,"context_line":"      $nova_api_wsgi_script_source       \u003d \u0027/usr/lib/python2.7/site-packages/nova/wsgi/nova-api.py\u0027"},{"line_number":54,"context_line":"      $nova_placement_wsgi_script_source \u003d \u0027/usr/lib/python2.7/site-packages/nova/api/openstack/placement/wsgi.py\u0027"},{"line_number":55,"context_line":"      case $::operatingsystem {"},{"line_number":56,"context_line":"        \u0027RedHat\u0027, \u0027CentOS\u0027, \u0027Scientific\u0027, \u0027OracleLinux\u0027: {"},{"line_number":57,"context_line":"          if (versioncmp($::operatingsystemmajrelease, \u00277\u0027) \u003c 0) {"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_64385a3e","line":54,"in_reply_to":"3a71b18c_8d392044","updated":"2016-12-04 22:29:22.000000000","message":"Done","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3c00ac4beb61e5cd39798e2c05c56a5a50375f7e","unresolved":false,"context_lines":[{"line_number":107,"context_line":"      $nova_log_group                    \u003d \u0027adm\u0027"},{"line_number":108,"context_line":"      $nova_wsgi_script_path             \u003d \u0027/usr/lib/cgi-bin/nova\u0027"},{"line_number":109,"context_line":"      $nova_api_wsgi_script_source       \u003d \u0027/usr/lib/python2.7/dist-packages/nova/wsgi/nova-api.py\u0027"},{"line_number":110,"context_line":"      $nova_placement_wsgi_script_source \u003d \u0027/usr/lib/python2.7/dist-packages/nova/api/openstack/placement/wsgi.py\u0027"},{"line_number":111,"context_line":"      # debian specific nova config"},{"line_number":112,"context_line":"      $root_helper                       \u003d \u0027sudo nova-rootwrap\u0027"},{"line_number":113,"context_line":"      $lock_path                         \u003d \u0027/var/lock/nova\u0027"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_ad409ca6","line":110,"updated":"2016-12-04 12:14:26.000000000","message":"see above","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3293a4a243b9c3e21330640ac1bed322d2f1e309","unresolved":false,"context_lines":[{"line_number":9,"context_line":"    \u0027RedHat\u0027: {"},{"line_number":10,"context_line":"      # package names"},{"line_number":11,"context_line":"      $api_package_name              \u003d \u0027openstack-nova-api\u0027"},{"line_number":12,"context_line":"      $placement_package_name        \u003d \u0027openstack-nova-placement-api\u0027"},{"line_number":13,"context_line":"      $cells_package_name            \u003d \u0027openstack-nova-cells\u0027"},{"line_number":14,"context_line":"      $cert_package_name             \u003d \u0027openstack-nova-cert\u0027"},{"line_number":15,"context_line":"      $common_package_name           \u003d \u0027openstack-nova-common\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a6eadb0_db886b25","line":12,"updated":"2016-12-13 17:26:06.000000000","message":"As I think I\u0027ve mentioned before there\u0027s going to come a time when the placement code is at least in its own repo, if not in its own project, so using the \u0027string\u0027 nova in the name is probably not great.\n\nOf course that\u0027s not something that\u0027s controlled here, so I guess this is just the way it goes.","commit_id":"1fbe1b58b174f6c0bce960c558f99dd63a052c8e"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3293a4a243b9c3e21330640ac1bed322d2f1e309","unresolved":false,"context_lines":[{"line_number":112,"context_line":"      $placement_wsgi_script_source \u003d \u0027/usr/bin/nova-placement-api\u0027"},{"line_number":113,"context_line":"      # debian specific nova config"},{"line_number":114,"context_line":"      $root_helper                       \u003d \u0027sudo nova-rootwrap\u0027"},{"line_number":115,"context_line":"      $lock_path                         \u003d \u0027/var/lock/nova\u0027"},{"line_number":116,"context_line":"      case $::os_package_type {"},{"line_number":117,"context_line":"        \u0027debian\u0027: {"},{"line_number":118,"context_line":"          $spicehtml5proxy_package_name    \u003d \u0027nova-consoleproxy\u0027"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a6eadb0_fbe0c7ce","line":115,"updated":"2016-12-13 17:26:06.000000000","message":"unnecessary whitespace changes?","commit_id":"1fbe1b58b174f6c0bce960c558f99dd63a052c8e"}],"manifests/placement.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3293a4a243b9c3e21330640ac1bed322d2f1e309","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*auth_type*]"},{"line_number":12,"context_line":"#   Name of the auth type to load (string value)"},{"line_number":13,"context_line":"#   Defaults to \u0027assword\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*project_name*]"},{"line_number":16,"context_line":"#   (optional) Project name for connecting to Nova Placement API service in"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a6eadb0_7bf4b786","line":13,"updated":"2016-12-13 17:26:06.000000000","message":"I think you\u0027re missing a \u0027p\u0027 here :)\n\nAlthough if this stays as is it will be THE GREATEST EASTER EGG EVER ;)","commit_id":"1fbe1b58b174f6c0bce960c558f99dd63a052c8e"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"fa794bba886db6ef57b0e98a33f9523e44c28bc9","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#"},{"line_number":11,"context_line":"# [*auth_type*]"},{"line_number":12,"context_line":"#   Name of the auth type to load (string value)"},{"line_number":13,"context_line":"#   Defaults to \u0027assword\u0027"},{"line_number":14,"context_line":"#"},{"line_number":15,"context_line":"# [*project_name*]"},{"line_number":16,"context_line":"#   (optional) Project name for connecting to Nova Placement API service in"}],"source_content_type":"text/x-puppet","patch_set":11,"id":"1a6eadb0_8447741c","line":13,"in_reply_to":"1a6eadb0_7bf4b786","updated":"2016-12-13 18:24:00.000000000","message":"lol. you made my day.","commit_id":"1fbe1b58b174f6c0bce960c558f99dd63a052c8e"}],"manifests/wsgi/apache.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e6e6481b986d00e4350b6075d643136f3e80a4bd","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    fail(\u0027::nova::api class must be declared in composition layer.\u0027)"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  warning(\u0027nova::wsgi::apache is deprecated and will be removed in a future release, please use nova::wsgi::apache::api\u0027)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  ::openstacklib::wsgi::apache { \u0027nova_api_wsgi\u0027:"},{"line_number":114,"context_line":"    bind_host           \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_b2d6094d","line":111,"updated":"2016-12-05 19:13:30.000000000","message":"You should just remove all the code in this class and have it call the new class. That way we don\u0027t have to maintain 2 places for very long","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"f0326846688e0bd233b562a4674051bccab5c9d6","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    fail(\u0027::nova::api class must be declared in composition layer.\u0027)"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  warning(\u0027nova::wsgi::apache is deprecated and will be removed in a future release, please use nova::wsgi::apache::api\u0027)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  ::openstacklib::wsgi::apache { \u0027nova_api_wsgi\u0027:"},{"line_number":114,"context_line":"    bind_host           \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_a0e6ac12","line":111,"in_reply_to":"3a71b18c_a0c30c88","updated":"2016-12-05 23:32:34.000000000","message":"yea we should have one class per service, was just wondering if it would make sense to have this class call those two classes.  For this comment it was to nuke this class and use the new nova::wsgi::apache_api to provide the existing functionality so we don\u0027t have the duplicated configuration in both nova::wsgi::apache and nova::wsgi::apache_api","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2501be3dba054bbda7f8f995cc463d00597581fc","unresolved":false,"context_lines":[{"line_number":108,"context_line":"    fail(\u0027::nova::api class must be declared in composition layer.\u0027)"},{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  warning(\u0027nova::wsgi::apache is deprecated and will be removed in a future release, please use nova::wsgi::apache::api\u0027)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  ::openstacklib::wsgi::apache { \u0027nova_api_wsgi\u0027:"},{"line_number":114,"context_line":"    bind_host           \u003d\u003e $bind_host,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_a0c30c88","line":111,"in_reply_to":"3a71b18c_b2d6094d","updated":"2016-12-05 23:26:14.000000000","message":"I prefer this option, so we have one class per service. Wdyt?","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bd71395db5d09abff4278e4275be6136fb37e267","unresolved":false,"context_lines":[{"line_number":109,"context_line":"  }"},{"line_number":110,"context_line":""},{"line_number":111,"context_line":"  warning(\u0027nova::wsgi::apache is deprecated and will be removed in a future release, please use nova::wsgi::apache::api\u0027)"},{"line_number":112,"context_line":""},{"line_number":113,"context_line":"  ::openstacklib::wsgi::apache { \u0027nova_api_wsgi\u0027:"},{"line_number":114,"context_line":"    bind_host           \u003d\u003e $bind_host,"},{"line_number":115,"context_line":"    bind_port           \u003d\u003e $api_port,"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_7271d143","line":112,"updated":"2016-12-05 19:19:51.000000000","message":"Alternatively would it be possible to leave nova::wsgi::apache and have it include both the api and placement services? So we could just configure both with a single include of nova::wsgi::apache?","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"}],"manifests/wsgi/apache_api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e6e6481b986d00e4350b6075d643136f3e80a4bd","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $ssl_crl_path  \u003d undef,"},{"line_number":91,"context_line":"  $ssl_crl       \u003d undef,"},{"line_number":92,"context_line":"  $ssl_certs_dir \u003d undef,"},{"line_number":93,"context_line":"  $threads       \u003d $::processorcount,"},{"line_number":94,"context_line":"  $priority      \u003d \u002710\u0027,"},{"line_number":95,"context_line":") {"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_52bcd505","line":93,"updated":"2016-12-05 19:13:30.000000000","message":"os_workers or processorcount?","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2501be3dba054bbda7f8f995cc463d00597581fc","unresolved":false,"context_lines":[{"line_number":90,"context_line":"  $ssl_crl_path  \u003d undef,"},{"line_number":91,"context_line":"  $ssl_crl       \u003d undef,"},{"line_number":92,"context_line":"  $ssl_certs_dir \u003d undef,"},{"line_number":93,"context_line":"  $threads       \u003d $::processorcount,"},{"line_number":94,"context_line":"  $priority      \u003d \u002710\u0027,"},{"line_number":95,"context_line":") {"},{"line_number":96,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_003920a4","line":93,"in_reply_to":"3a71b18c_52bcd505","updated":"2016-12-05 23:26:14.000000000","message":"will change it in next patchset. Btw, I took example from current code.","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"}],"manifests/wsgi/apache_placement.pp":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3c00ac4beb61e5cd39798e2c05c56a5a50375f7e","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"#   [*api_port*]"},{"line_number":30,"context_line":"#     The port for Nova API service."},{"line_number":31,"context_line":"#     Optional. Defaults to 8774"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"#   [*bind_host*]"},{"line_number":34,"context_line":"#     The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_2d13acb9","line":31,"updated":"2016-12-04 12:14:26.000000000","message":"this is referring to the nova default, not the placement default","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"67ba68280890d27a26e31dd3cf2847886cb54ad6","unresolved":false,"context_lines":[{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"#   [*api_port*]"},{"line_number":30,"context_line":"#     The port for Nova API service."},{"line_number":31,"context_line":"#     Optional. Defaults to 8774"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"#   [*bind_host*]"},{"line_number":34,"context_line":"#     The host/ip address Apache will listen on."}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_8441f6ab","line":31,"in_reply_to":"3a71b18c_2d13acb9","updated":"2016-12-04 22:29:22.000000000","message":"Done","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"9a5be8c08b716e72c3bc7e659560c64ac44dab76","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#     Optional. Defaults to $::fqdn"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"#   [*api_port*]"},{"line_number":30,"context_line":"#     The port for Nova API service."},{"line_number":31,"context_line":"#     Optional. Defaults to 8778"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"#   [*bind_host*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_b6cd36b9","line":30,"updated":"2016-12-05 10:22:15.000000000","message":"Placement","commit_id":"a51704466fe1c78217d1a10d698038021bd016f3"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"80503ea5cc8f2560d974c8091c876178548433d8","unresolved":false,"context_lines":[{"line_number":27,"context_line":"#     Optional. Defaults to $::fqdn"},{"line_number":28,"context_line":"#"},{"line_number":29,"context_line":"#   [*api_port*]"},{"line_number":30,"context_line":"#     The port for Nova API service."},{"line_number":31,"context_line":"#     Optional. Defaults to 8778"},{"line_number":32,"context_line":"#"},{"line_number":33,"context_line":"#   [*bind_host*]"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a71b18c_96b4ba82","line":30,"in_reply_to":"3a71b18c_b6cd36b9","updated":"2016-12-05 10:35:06.000000000","message":"Done","commit_id":"a51704466fe1c78217d1a10d698038021bd016f3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e6e6481b986d00e4350b6075d643136f3e80a4bd","unresolved":false,"context_lines":[{"line_number":92,"context_line":"  $ssl_crl_path   \u003d undef,"},{"line_number":93,"context_line":"  $ssl_crl        \u003d undef,"},{"line_number":94,"context_line":"  $ssl_certs_dir  \u003d undef,"},{"line_number":95,"context_line":"  $threads        \u003d $::processorcount,"},{"line_number":96,"context_line":"  $priority       \u003d \u002710\u0027,"},{"line_number":97,"context_line":"  $ensure_package \u003d \u0027present\u0027,"},{"line_number":98,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":10,"id":"3a71b18c_32c3d98a","line":95,"updated":"2016-12-05 19:13:30.000000000","message":"same os_workers or processorcount?","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"}],"releasenotes/notes/nova-placement-30566167309fd124.yaml":[{"author":{"_account_id":11564,"name":"Chris Dent","email":"cdent@anticdent.org","username":"chdent"},"change_message_id":"3c00ac4beb61e5cd39798e2c05c56a5a50375f7e","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Nova Placement API deployment in WSGI with Apache by using nova::wsgi::apache_placement."},{"line_number":4,"context_line":"  - Keystones resources support for Nova Placement API by using nova::keystone::auth_placement."},{"line_number":5,"context_line":"  - Allow to configure [placement] section in nova.conf by using nova::placement."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - nova::wsgi::apache is deprecated in favor of nova::wsgi::apache_api."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a71b18c_4d1628a8","line":4,"updated":"2016-12-04 12:14:26.000000000","message":"s/Keystones/Keystone/ ?","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"67ba68280890d27a26e31dd3cf2847886cb54ad6","unresolved":false,"context_lines":[{"line_number":1,"context_line":"---"},{"line_number":2,"context_line":"features:"},{"line_number":3,"context_line":"  - Nova Placement API deployment in WSGI with Apache by using nova::wsgi::apache_placement."},{"line_number":4,"context_line":"  - Keystones resources support for Nova Placement API by using nova::keystone::auth_placement."},{"line_number":5,"context_line":"  - Allow to configure [placement] section in nova.conf by using nova::placement."},{"line_number":6,"context_line":"deprecations:"},{"line_number":7,"context_line":"  - nova::wsgi::apache is deprecated in favor of nova::wsgi::apache_api."}],"source_content_type":"text/x-yaml","patch_set":2,"id":"3a71b18c_a43ef225","line":4,"in_reply_to":"3a71b18c_4d1628a8","updated":"2016-12-04 22:29:22.000000000","message":"Done","commit_id":"c02ca6f50d7352a3c798bcb474b23ff01e780503"}],"spec/classes/nova_keystone_auth_placement_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e6e6481b986d00e4350b6075d643136f3e80a4bd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      :internal_url           \u003d\u003e \u0027http://127.0.0.1:8778\u0027,"},{"line_number":17,"context_line":"      :admin_url              \u003d\u003e \u0027http://127.0.0.1:8778\u0027 }"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  context \u0027with default parameters\u0027 do"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    it { is_expected.to contain_keystone_user(\u0027placement\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_12c6dd99","line":19,"updated":"2016-12-05 19:13:30.000000000","message":"Should use rspec-puppet-facts and shared_examples for these","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"2501be3dba054bbda7f8f995cc463d00597581fc","unresolved":false,"context_lines":[{"line_number":16,"context_line":"      :internal_url           \u003d\u003e \u0027http://127.0.0.1:8778\u0027,"},{"line_number":17,"context_line":"      :admin_url              \u003d\u003e \u0027http://127.0.0.1:8778\u0027 }"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  context \u0027with default parameters\u0027 do"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"    it { is_expected.to contain_keystone_user(\u0027placement\u0027).with("}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_403f9886","line":19,"in_reply_to":"3a71b18c_12c6dd99","updated":"2016-12-05 23:26:14.000000000","message":"probably, I just copy/pasted the tests from existing nova wsgi api. I\u0027ll do it in next patchset","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"}],"spec/classes/nova_placement_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e6e6481b986d00e4350b6075d643136f3e80a4bd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"  let :params do"},{"line_number":17,"context_line":"    { :password \u003d\u003e \u0027s3cr3t\u0027 }"},{"line_number":18,"context_line":"  end"},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  context \u0027with required parameters\u0027 do"},{"line_number":21,"context_line":"    it \u0027configures [placement] parameters in nova.conf\u0027 do"},{"line_number":22,"context_line":"      is_expected.to contain_nova_config(\u0027placement/password\u0027).with_value(params[:password]).with_secret(true)"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_d2c70596","line":19,"updated":"2016-12-05 19:13:30.000000000","message":"should use rspec-puppet-facts and shared_examples_for","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"}],"spec/classes/nova_wsgi_apache_api_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e6e6481b986d00e4350b6075d643136f3e80a4bd","unresolved":false,"context_lines":[{"line_number":131,"context_line":""},{"line_number":132,"context_line":"  end"},{"line_number":133,"context_line":""},{"line_number":134,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":135,"context_line":"    let :facts do"},{"line_number":136,"context_line":"      global_facts.merge({"},{"line_number":137,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_f2cc01bd","line":134,"updated":"2016-12-05 19:13:30.000000000","message":"on_supported_os....","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"}],"spec/classes/nova_wsgi_apache_placement_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"e6e6481b986d00e4350b6075d643136f3e80a4bd","unresolved":false,"context_lines":[{"line_number":137,"context_line":""},{"line_number":138,"context_line":"  end"},{"line_number":139,"context_line":""},{"line_number":140,"context_line":"  context \u0027on RedHat platforms\u0027 do"},{"line_number":141,"context_line":"    let :facts do"},{"line_number":142,"context_line":"      global_facts.merge({"},{"line_number":143,"context_line":"        :osfamily               \u003d\u003e \u0027RedHat\u0027,"}],"source_content_type":"text/x-ruby","patch_set":10,"id":"3a71b18c_92d10d5a","line":140,"updated":"2016-12-05 19:13:30.000000000","message":"on_supported_os...","commit_id":"3d856a2eb2cb8b95fa464c43da279ef0e369e2a6"}]}