)]}'
{"manifests/conductor.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"cc647dc95df916d035f58d0851c295f75228359e","unresolved":false,"context_lines":[{"line_number":38,"context_line":"  $manage_service      \u003d true,"},{"line_number":39,"context_line":"  $ensure_package      \u003d \u0027present\u0027,"},{"line_number":40,"context_line":"  $workers             \u003d undef,"},{"line_number":41,"context_line":"  $enable_new_services \u003d true,"},{"line_number":42,"context_line":"  # DEPREACTED PARAMETERS"},{"line_number":43,"context_line":"  $use_local           \u003d undef,"},{"line_number":44,"context_line":") {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3a71b18c_945e55e7","line":41,"updated":"2016-12-12 11:02:45.000000000","message":"should be os_service_default http://docs.openstack.org/developer/puppet-openstack-guide/coding-style.html#config-file-defaults-and-parameters","commit_id":"a4d8e5713302f281f5d5c506a8951c6405beabf8"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"586731171653eee32c3cffaf57827019164badae","unresolved":false,"context_lines":[{"line_number":64,"context_line":"      \u0027conductor/workers\u0027: value \u003d\u003e $workers;"},{"line_number":65,"context_line":"    }"},{"line_number":66,"context_line":"  }"},{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  if ! $enable_new_services {"},{"line_number":69,"context_line":"    nova_config {"},{"line_number":70,"context_line":"      \u0027DEFAULT/enable_new_services\u0027: value \u003d\u003e false"},{"line_number":71,"context_line":"    }"},{"line_number":72,"context_line":"  } else {"},{"line_number":73,"context_line":"    nova_config {"},{"line_number":74,"context_line":"      \u0027DEFAULT/enable_new_services\u0027: ensure \u003d\u003e absent"},{"line_number":75,"context_line":"    }"},{"line_number":76,"context_line":"  }"},{"line_number":77,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"3a71b18c_c92e738b","line":76,"range":{"start_line":67,"start_character":0,"end_line":76,"end_character":3},"updated":"2016-12-12 13:07:31.000000000","message":"when you have $os_service_default you don\u0027t need the if statement, just - \n\n\u0027DEFAULT/enable_new_services\u0027: value \u003d\u003e $enable_new_services\n\nbecause if $enable_new_service set to os service default this option will be automatically absent from the config","commit_id":"5af81a0e84db301532630f7e645559525a92569d"}]}