)]}'
{"manifests/compute/libvirt/qemu.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cae92ee2c038e37d84950c4b4762e003ea4e2dd","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (optional) Maximum number of processes that can be run by qemu user."},{"line_number":17,"context_line":"#   Defaults to 4096."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class nova::compute::libvirt::qemu("},{"line_number":20,"context_line":"  $configure_qemu \u003d false,"},{"line_number":21,"context_line":"  $max_files      \u003d 1024,"},{"line_number":22,"context_line":"  $max_processes  \u003d 4096,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_86115860","line":19,"updated":"2016-12-19 13:36:00.000000000","message":"why not using nova::compute::libvirt?","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"298b93a7596cf03e255a7b65de15ae75022b6909","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (optional) Maximum number of processes that can be run by qemu user."},{"line_number":17,"context_line":"#   Defaults to 4096."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class nova::compute::libvirt::qemu("},{"line_number":20,"context_line":"  $configure_qemu \u003d false,"},{"line_number":21,"context_line":"  $max_files      \u003d 1024,"},{"line_number":22,"context_line":"  $max_processes  \u003d 4096,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_94bcde6d","line":19,"in_reply_to":"1a6eadb0_42845ab0","updated":"2016-12-20 15:45:52.000000000","message":"Since this is a subset of what would be included in libvirt, I think this makes sense as it\u0027s own class.","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f9af707107834ae53d4944e32c37023625dda8d","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (optional) Maximum number of processes that can be run by qemu user."},{"line_number":17,"context_line":"#   Defaults to 4096."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class nova::compute::libvirt::qemu("},{"line_number":20,"context_line":"  $configure_qemu \u003d false,"},{"line_number":21,"context_line":"  $max_files      \u003d 1024,"},{"line_number":22,"context_line":"  $max_processes  \u003d 4096,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_42845ab0","line":19,"in_reply_to":"1a6eadb0_86115860","updated":"2016-12-20 10:42:10.000000000","message":"I think we could do that too but the changes in this class go into qemu.conf not libvirtd.conf and while the class initially deals with the limits only, I think it could be extended in the future to configure more settings\n\nYet, I don\u0027t have a strong opinion on the subjetct so if you still think this should go in libvirt class, just comment here and I\u0027ll move it","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9badfc599c64e0b312f9d8ff44d3877c6a63d089","unresolved":false,"context_lines":[{"line_number":16,"context_line":"#   (optional) Maximum number of processes that can be run by qemu user."},{"line_number":17,"context_line":"#   Defaults to 4096."},{"line_number":18,"context_line":"#"},{"line_number":19,"context_line":"class nova::compute::libvirt::qemu("},{"line_number":20,"context_line":"  $configure_qemu \u003d false,"},{"line_number":21,"context_line":"  $max_files      \u003d 1024,"},{"line_number":22,"context_line":"  $max_processes  \u003d 4096,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_8b159c9c","line":19,"in_reply_to":"1a6eadb0_94bcde6d","updated":"2016-12-20 16:06:09.000000000","message":"ok, fair enough. OK for its own class.","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cae92ee2c038e37d84950c4b4762e003ea4e2dd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":33,"context_line":"  ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $configure_qemu {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":38,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_e6084c30","line":35,"updated":"2016-12-19 13:36:00.000000000","message":"why this boolean?","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"298b93a7596cf03e255a7b65de15ae75022b6909","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":33,"context_line":"  ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $configure_qemu {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":38,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_48ff0aaa","line":35,"in_reply_to":"1a6eadb0_42ab7a1e","updated":"2016-12-20 15:45:52.000000000","message":"I think we can get rid of this if we add some logic around the augeas changes. The issue I have with this is that it requires that you configure both max_files and max_processes so it\u0027s not exactly flexible by the end user since it dictates you must specify all the values. This deviates from how we traditionally handle configuration changes in the openstack modules. \n\nLet me thing about some options for constructing a $changes that could be used more similarly to what we have today with the providers.","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c5e6f7292339970744e1d5a293a408c034bfe2fd","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":33,"context_line":"  ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $configure_qemu {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":38,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_fe916c9b","line":35,"in_reply_to":"1a6eadb0_48ff0aaa","updated":"2016-12-20 16:14:23.000000000","message":"agreed, it\u0027s not great that it assumes you\u0027re configuring or unconfiguring both of them at the same time ... can I just default to undef and check against that?","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f9af707107834ae53d4944e32c37023625dda8d","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":33,"context_line":"  ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $configure_qemu {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":38,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_42ab7a1e","line":35,"in_reply_to":"1a6eadb0_e6084c30","updated":"2016-12-20 10:42:10.000000000","message":"copies the migration class behavior","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"828b8e4b522bc45adda7de528200cfda2d7dd204","unresolved":false,"context_lines":[{"line_number":32,"context_line":"  Augeas\u003c| tag \u003d\u003d \u0027qemu-conf-augeas\u0027|\u003e"},{"line_number":33,"context_line":"  ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":34,"context_line":""},{"line_number":35,"context_line":"  if $configure_qemu {"},{"line_number":36,"context_line":""},{"line_number":37,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":38,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"da4df55a_1a5f7c73","line":35,"in_reply_to":"1a6eadb0_fe916c9b","updated":"2016-12-21 23:26:32.000000000","message":"I couldn\u0027t really think of a dynamic way to build up the changes without resorting to ruby code, but I don\u0027t know if we want to do that or not.","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"3cae92ee2c038e37d84950c4b4762e003ea4e2dd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      ],"},{"line_number":43,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"  } else {"},{"line_number":46,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":47,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"},{"line_number":48,"context_line":"      changes \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_d1122858","line":45,"updated":"2016-12-19 13:36:00.000000000","message":"I don\u0027t understand why we would override default configuration by default.","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"9badfc599c64e0b312f9d8ff44d3877c6a63d089","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      ],"},{"line_number":43,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"  } else {"},{"line_number":46,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":47,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"},{"line_number":48,"context_line":"      changes \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_6b7920fc","line":45,"in_reply_to":"1a6eadb0_48162af2","updated":"2016-12-20 16:06:09.000000000","message":"fair enough","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"c5e6f7292339970744e1d5a293a408c034bfe2fd","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      ],"},{"line_number":43,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"  } else {"},{"line_number":46,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":47,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"},{"line_number":48,"context_line":"      changes \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_be71b4aa","line":45,"in_reply_to":"1a6eadb0_6b7920fc","updated":"2016-12-20 16:14:23.000000000","message":"though fwiw, I tried to mimic migrations/qemu.pp but I don\u0027t like the conditional much either... feels like we could just assume the user wants to do the qemu.conf editing only if the class is included","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"298b93a7596cf03e255a7b65de15ae75022b6909","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      ],"},{"line_number":43,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"  } else {"},{"line_number":46,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":47,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"},{"line_number":48,"context_line":"      changes \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_48162af2","line":45,"in_reply_to":"1a6eadb0_d1122858","updated":"2016-12-20 15:45:52.000000000","message":"Technically (currently) this is the default. the default install does not have max_files or max_processes defined.","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"},{"author":{"_account_id":6796,"name":"Giulio Fidente","email":"gfidente@redhat.com","username":"gfidente"},"change_message_id":"5f9af707107834ae53d4944e32c37023625dda8d","unresolved":false,"context_lines":[{"line_number":42,"context_line":"      ],"},{"line_number":43,"context_line":"      tag     \u003d\u003e \u0027qemu-conf-augeas\u0027,"},{"line_number":44,"context_line":"    }"},{"line_number":45,"context_line":"  } else {"},{"line_number":46,"context_line":"    augeas { \u0027qemu-conf-limits\u0027:"},{"line_number":47,"context_line":"      context \u003d\u003e \u0027/files/etc/libvirt/qemu.conf\u0027,"},{"line_number":48,"context_line":"      changes \u003d\u003e ["}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_220cbe41","line":45,"in_reply_to":"1a6eadb0_d1122858","updated":"2016-12-20 10:42:10.000000000","message":"again, copies the behavior we implemented in migration/qemu.conf","commit_id":"d30b05d55ad82cfb95619b51bb9a241577841338"}]}