)]}'
{"manifests/cron/archive_deleted_rows.pp":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f5e074ed51f0a1ca042abca90abee26c22e17443","unresolved":false,"context_lines":[{"line_number":61,"context_line":"  $weekday     \u003d \u0027*\u0027,"},{"line_number":62,"context_line":"  $max_rows    \u003d \u0027100\u0027,"},{"line_number":63,"context_line":"  $user        \u003d \u0027nova\u0027,"},{"line_number":64,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowsflush.log\u0027"},{"line_number":65,"context_line":"  $empty_table \u003d false,"},{"line_number":66,"context_line":") {"},{"line_number":67,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_75b92dec","line":64,"range":{"start_line":64,"start_character":50,"end_line":64,"end_character":51},"updated":"2016-12-19 19:44:49.000000000","message":"\u0027,","commit_id":"b3d0b5fb00489a1c17a8caa644a9585aafcd34f9"},{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"f6a3e29490e6bbbbff546c9515c58881412513d5","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  include ::nova::deps"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  $until_complete \u003d \u0027\u0027"},{"line_number":71,"context_line":"  if $empty_table {"},{"line_number":72,"context_line":"    $until_complete \u003d \u0027--until_complete\u0027"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"},{"line_number":76,"context_line":"    command     \u003d\u003e \"nova-manage db archive_deleted_rows --max_rows ${max_rows} ${until_complete} \u003e\u003e${destination} 2\u003e\u00261\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_0395283f","line":73,"range":{"start_line":70,"start_character":0,"end_line":73,"end_character":3},"updated":"2016-12-19 18:35:34.000000000","message":"I think calling the parameter until_complete would be more straightforward for the user.\nIf necessary you can hide the \u0027--until_complete\u0027 string in a $until_complete_real or something, like is done elsewhere.","commit_id":"b3d0b5fb00489a1c17a8caa644a9585aafcd34f9"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f5e074ed51f0a1ca042abca90abee26c22e17443","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  include ::nova::deps"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  $until_complete \u003d \u0027\u0027"},{"line_number":71,"context_line":"  if $empty_table {"},{"line_number":72,"context_line":"    $until_complete \u003d \u0027--until_complete\u0027"},{"line_number":73,"context_line":"  }"},{"line_number":74,"context_line":""},{"line_number":75,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"},{"line_number":76,"context_line":"    command     \u003d\u003e \"nova-manage db archive_deleted_rows --max_rows ${max_rows} ${until_complete} \u003e\u003e${destination} 2\u003e\u00261\","}],"source_content_type":"text/x-puppet","patch_set":2,"id":"1a6eadb0_d5e12100","line":73,"range":{"start_line":70,"start_character":0,"end_line":73,"end_character":3},"in_reply_to":"1a6eadb0_0395283f","updated":"2016-12-19 19:44:49.000000000","message":"Sure thing, in the next patchset Ill post these fixes","commit_id":"b3d0b5fb00489a1c17a8caa644a9585aafcd34f9"},{"author":{"_account_id":16771,"name":"mpolenchuk","email":"mpolenchuk@mirantis.com","username":"mpolenchuk"},"change_message_id":"2c7df7ead1949795b1273af8ec4cb200e41deb88","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  include ::nova::deps"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $until_complete {"},{"line_number":71,"context_line":"    $cron_command \u003d \"nova-manage db archive_deleted_rows --max_rows ${max_rows} --until_complete \u003e\u003e${destination} 2\u003e\u00261\""},{"line_number":72,"context_line":"  }else{"},{"line_number":73,"context_line":"    $cron_command \u003d \"nova-manage db archive_deleted_rows --max_rows ${max_rows} \u003e\u003e${destination} 2\u003e\u00261\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"},{"line_number":77,"context_line":"    command     \u003d\u003e $cron_command,"},{"line_number":78,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":79,"context_line":"    user        \u003d\u003e $user,"},{"line_number":80,"context_line":"    minute      \u003d\u003e $minute,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a6eadb0_65c4f65e","line":77,"range":{"start_line":70,"start_character":2,"end_line":77,"end_character":33},"updated":"2016-12-20 14:05:54.000000000","message":"What about the following? :\n\nif $until_complete  {\n $until_complete_opt \u003d \u0027--until_complete\u0027\n}\n\ncron { \u0027nova-manage db archive_deleted_rows\u0027:\n    command \u003d\u003e \"nova-manage db archive_deleted_rows --max_rows ${max_rows} ${until_complete_opt} \u003e\u003e${destination} 2\u003e\u00261\",\n...","commit_id":"084902e2c4773f08fc81c3ac195edf4ba7414df6"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"3772032299ca35f1f48812e3ccd49a3a59c0f2a4","unresolved":false,"context_lines":[{"line_number":67,"context_line":""},{"line_number":68,"context_line":"  include ::nova::deps"},{"line_number":69,"context_line":""},{"line_number":70,"context_line":"  if $until_complete {"},{"line_number":71,"context_line":"    $cron_command \u003d \"nova-manage db archive_deleted_rows --max_rows ${max_rows} --until_complete \u003e\u003e${destination} 2\u003e\u00261\""},{"line_number":72,"context_line":"  }else{"},{"line_number":73,"context_line":"    $cron_command \u003d \"nova-manage db archive_deleted_rows --max_rows ${max_rows} \u003e\u003e${destination} 2\u003e\u00261\""},{"line_number":74,"context_line":"  }"},{"line_number":75,"context_line":""},{"line_number":76,"context_line":"  cron { \u0027nova-manage db archive_deleted_rows\u0027:"},{"line_number":77,"context_line":"    command     \u003d\u003e $cron_command,"},{"line_number":78,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":79,"context_line":"    user        \u003d\u003e $user,"},{"line_number":80,"context_line":"    minute      \u003d\u003e $minute,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"1a6eadb0_48baaf24","line":77,"range":{"start_line":70,"start_character":2,"end_line":77,"end_character":33},"in_reply_to":"1a6eadb0_65c4f65e","updated":"2016-12-20 14:17:16.000000000","message":"cool, fixed","commit_id":"084902e2c4773f08fc81c3ac195edf4ba7414df6"}],"spec/classes/nova_cron_archive_deleted_rows_spec.rb":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"dc642a9c6df5b5b0343bc377440a31799e5e8309","unresolved":false,"context_lines":[{"line_number":14,"context_line":"      :weekday     \u003d\u003e \u0027*\u0027,"},{"line_number":15,"context_line":"      :max_rows    \u003d\u003e \u0027100\u0027,"},{"line_number":16,"context_line":"      :user        \u003d\u003e \u0027nova\u0027,"},{"line_number":17,"context_line":"      :empty_table \u003d\u003e false,"},{"line_number":18,"context_line":"      :destination \u003d\u003e \u0027/var/log/nova/nova-rowsflush.log\u0027 }"},{"line_number":19,"context_line":"  end"},{"line_number":20,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a6eadb0_6e0f8a88","line":17,"range":{"start_line":17,"start_character":7,"end_line":17,"end_character":18},"updated":"2016-12-20 07:48:43.000000000","message":"s/empty_table/until_complete/","commit_id":"980cf1b401b1cf8c52de29b20fafddd5a3f54520"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"dc642a9c6df5b5b0343bc377440a31799e5e8309","unresolved":false,"context_lines":[{"line_number":40,"context_line":"      :weekday     \u003d\u003e \u0027*\u0027,"},{"line_number":41,"context_line":"      :max_rows    \u003d\u003e \u0027100\u0027,"},{"line_number":42,"context_line":"      :user        \u003d\u003e \u0027nova\u0027,"},{"line_number":43,"context_line":"      :empty_table \u003d\u003e true,"},{"line_number":44,"context_line":"      :destination \u003d\u003e \u0027/var/log/nova/nova-rowsflush.log\u0027 }"},{"line_number":45,"context_line":"  end"},{"line_number":46,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"1a6eadb0_ce209efa","line":43,"range":{"start_line":43,"start_character":7,"end_line":43,"end_character":18},"updated":"2016-12-20 07:48:43.000000000","message":"s/empty_table/until_complete/","commit_id":"980cf1b401b1cf8c52de29b20fafddd5a3f54520"}]}