)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a class to run the db online_data_migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We aren\u0027t running the online_data_migrations in undercloud"},{"line_number":10,"context_line":"puppet-stack-config. This adds the class and spec to puppet-nova"},{"line_number":11,"context_line":"and then we can call it from instack-undercloud as with other"},{"line_number":12,"context_line":"migrations."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_7653a46b","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":19},"updated":"2017-01-17 12:51:17.000000000","message":"This thing doesn\u0027t need to be mentioned in puppet-nova. It\u0027s too specific to TripleO.","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add a class to run the db online_data_migrations"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We aren\u0027t running the online_data_migrations in undercloud"},{"line_number":10,"context_line":"puppet-stack-config. This adds the class and spec to puppet-nova"},{"line_number":11,"context_line":"and then we can call it from instack-undercloud as with other"},{"line_number":12,"context_line":"migrations."},{"line_number":13,"context_line":""}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_7740fe34","line":10,"range":{"start_line":9,"start_character":0,"end_line":10,"end_character":19},"in_reply_to":"7a3c09a3_7653a46b","updated":"2017-01-17 13:49:58.000000000","message":"Done","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We aren\u0027t running the online_data_migrations in undercloud"},{"line_number":10,"context_line":"puppet-stack-config. This adds the class and spec to puppet-nova"},{"line_number":11,"context_line":"and then we can call it from instack-undercloud as with other"},{"line_number":12,"context_line":"migrations."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibb119c280b5b6d07db06a63dd9efcc2526355f5f"},{"line_number":15,"context_line":"Related-Bug: 1656791"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_f6cdd431","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":10},"updated":"2017-01-17 12:51:17.000000000","message":"same thing.","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":8,"context_line":""},{"line_number":9,"context_line":"We aren\u0027t running the online_data_migrations in undercloud"},{"line_number":10,"context_line":"puppet-stack-config. This adds the class and spec to puppet-nova"},{"line_number":11,"context_line":"and then we can call it from instack-undercloud as with other"},{"line_number":12,"context_line":"migrations."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibb119c280b5b6d07db06a63dd9efcc2526355f5f"},{"line_number":15,"context_line":"Related-Bug: 1656791"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_9749ea62","line":12,"range":{"start_line":11,"start_character":4,"end_line":12,"end_character":10},"in_reply_to":"7a3c09a3_f6cdd431","updated":"2017-01-17 13:49:58.000000000","message":"Done","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet-stack-config. This adds the class and spec to puppet-nova"},{"line_number":11,"context_line":"and then we can call it from instack-undercloud as with other"},{"line_number":12,"context_line":"migrations."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibb119c280b5b6d07db06a63dd9efcc2526355f5f"},{"line_number":15,"context_line":"Related-Bug: 1656791"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_7601e437","line":13,"updated":"2017-01-17 12:51:17.000000000","message":"Keep it simple and write:\n\nAdd support for db online_data_migrations\n\nThis class will run nova db online_data_migrations, useful when upgrading Nova between X and Y versions. (etc)","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":10,"context_line":"puppet-stack-config. This adds the class and spec to puppet-nova"},{"line_number":11,"context_line":"and then we can call it from instack-undercloud as with other"},{"line_number":12,"context_line":"migrations."},{"line_number":13,"context_line":""},{"line_number":14,"context_line":"Change-Id: Ibb119c280b5b6d07db06a63dd9efcc2526355f5f"},{"line_number":15,"context_line":"Related-Bug: 1656791"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"7a3c09a3_b746e64c","line":13,"in_reply_to":"7a3c09a3_7601e437","updated":"2017-01-17 13:49:58.000000000","message":"Done","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"}],"manifests/api.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"3c1dae11bbe50191c7ece249e7ce3eab058f89b3","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  $metadata_workers                     \u003d $::processorcount,"},{"line_number":233,"context_line":"  $sync_db                              \u003d true,"},{"line_number":234,"context_line":"  $sync_db_api                          \u003d true,"},{"line_number":235,"context_line":"  $db_online_data_migrations            \u003d true,"},{"line_number":236,"context_line":"  $neutron_metadata_proxy_shared_secret \u003d undef,"},{"line_number":237,"context_line":"  $default_floating_pool                \u003d \u0027nova\u0027,"},{"line_number":238,"context_line":"  $pci_alias                            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"5a3905b3_0d1f5f5b","line":235,"updated":"2017-01-24 13:50:44.000000000","message":"why we are setting this to true by default, if this is needed only for upgrade?","commit_id":"93d8945d1de2131823162ad91617fa70f2b70bc6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"4ddd27bd2b3a46e695ef4b1d7e4c5e927e213a4f","unresolved":false,"context_lines":[{"line_number":232,"context_line":"  $metadata_workers                     \u003d $::processorcount,"},{"line_number":233,"context_line":"  $sync_db                              \u003d true,"},{"line_number":234,"context_line":"  $sync_db_api                          \u003d true,"},{"line_number":235,"context_line":"  $db_online_data_migrations            \u003d true,"},{"line_number":236,"context_line":"  $neutron_metadata_proxy_shared_secret \u003d undef,"},{"line_number":237,"context_line":"  $default_floating_pool                \u003d \u0027nova\u0027,"},{"line_number":238,"context_line":"  $pci_alias                            \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3a461143_cb650ae2","line":235,"in_reply_to":"5a3905b3_0d1f5f5b","updated":"2017-01-26 08:31:13.000000000","message":"I am not sure if it is needed only for upgrade, would like to get some more feedback from nova folks about this. thanks for looking. rebase incoming to fix the merge conflict.","commit_id":"93d8945d1de2131823162ad91617fa70f2b70bc6"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"f105e451cb5ab9b6cf7d7a31b4f49e2343edf438","unresolved":false,"context_lines":[{"line_number":68,"context_line":"# [*db_online_data_migrations*]"},{"line_number":69,"context_line":"#   (optional) Run nova-manage db online_data_migrations on api nodes after"},{"line_number":70,"context_line":"#   installing the package."},{"line_number":71,"context_line":"#   Defaults to true"},{"line_number":72,"context_line":"#"},{"line_number":73,"context_line":"# [*neutron_metadata_proxy_shared_secret*]"},{"line_number":74,"context_line":"#   (optional) Shared secret to validate proxies Neutron metadata requests"}],"source_content_type":"text/x-puppet","patch_set":7,"id":"3a461143_a9ca7c9f","line":71,"updated":"2017-01-26 13:10:22.000000000","message":"will default this to false then and it will have to be set explicitly when invoked if upgrade","commit_id":"4619d25280c6f95edd727f013f431ed03121018b"}],"manifests/db/online_data_migrations.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#   (optional) String of extra command line parameters to append"},{"line_number":8,"context_line":"#   to the nova-manage db sync command. These will be inserted in"},{"line_number":9,"context_line":"#   the command line between \u0027nova-manage\u0027 and \u0027db sync\u0027."},{"line_number":10,"context_line":"#   Defaults to undef"},{"line_number":11,"context_line":"# [*db_sync_timeout*]"},{"line_number":12,"context_line":"#   (optional) Timeout for the execution of the db_sync"},{"line_number":13,"context_line":"#   Defaults to 300."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_b68eeccd","line":10,"updated":"2017-01-17 12:51:17.000000000","message":"add an extra line with #","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":7,"context_line":"#   (optional) String of extra command line parameters to append"},{"line_number":8,"context_line":"#   to the nova-manage db sync command. These will be inserted in"},{"line_number":9,"context_line":"#   the command line between \u0027nova-manage\u0027 and \u0027db sync\u0027."},{"line_number":10,"context_line":"#   Defaults to undef"},{"line_number":11,"context_line":"# [*db_sync_timeout*]"},{"line_number":12,"context_line":"#   (optional) Timeout for the execution of the db_sync"},{"line_number":13,"context_line":"#   Defaults to 300."}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_97600ad1","line":10,"in_reply_to":"7a3c09a3_b68eeccd","updated":"2017-01-17 13:49:58.000000000","message":"Done","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   Defaults to undef"},{"line_number":11,"context_line":"# [*db_sync_timeout*]"},{"line_number":12,"context_line":"#   (optional) Timeout for the execution of the db_sync"},{"line_number":13,"context_line":"#   Defaults to 300."},{"line_number":14,"context_line":"class nova::db::online_data_migrations("},{"line_number":15,"context_line":" $extra_params \u003d undef,"},{"line_number":16,"context_line":" $db_sync_timeout \u003d 300,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_d6bd3869","line":13,"updated":"2017-01-17 12:51:17.000000000","message":"same here","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":10,"context_line":"#   Defaults to undef"},{"line_number":11,"context_line":"# [*db_sync_timeout*]"},{"line_number":12,"context_line":"#   (optional) Timeout for the execution of the db_sync"},{"line_number":13,"context_line":"#   Defaults to 300."},{"line_number":14,"context_line":"class nova::db::online_data_migrations("},{"line_number":15,"context_line":" $extra_params \u003d undef,"},{"line_number":16,"context_line":" $db_sync_timeout \u003d 300,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_97b72a39","line":13,"in_reply_to":"7a3c09a3_d6bd3869","updated":"2017-01-17 13:49:58.000000000","message":"Done","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   (optional) Timeout for the execution of the db_sync"},{"line_number":13,"context_line":"#   Defaults to 300."},{"line_number":14,"context_line":"class nova::db::online_data_migrations("},{"line_number":15,"context_line":" $extra_params \u003d undef,"},{"line_number":16,"context_line":" $db_sync_timeout \u003d 300,"},{"line_number":17,"context_line":") {"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_36b91c7a","line":15,"updated":"2017-01-17 12:51:17.000000000","message":"align the \"\u003d\"","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":12,"context_line":"#   (optional) Timeout for the execution of the db_sync"},{"line_number":13,"context_line":"#   Defaults to 300."},{"line_number":14,"context_line":"class nova::db::online_data_migrations("},{"line_number":15,"context_line":" $extra_params \u003d undef,"},{"line_number":16,"context_line":" $db_sync_timeout \u003d 300,"},{"line_number":17,"context_line":") {"},{"line_number":18,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_d7d1b258","line":15,"in_reply_to":"7a3c09a3_36b91c7a","updated":"2017-01-17 13:49:58.000000000","message":"Done","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":15,"context_line":" $extra_params \u003d undef,"},{"line_number":16,"context_line":" $db_sync_timeout \u003d 300,"},{"line_number":17,"context_line":") {"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":"  include ::nova::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_f66954fa","line":18,"updated":"2017-01-17 12:51:17.000000000","message":"remove useless line","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":15,"context_line":" $extra_params \u003d undef,"},{"line_number":16,"context_line":" $db_sync_timeout \u003d 300,"},{"line_number":17,"context_line":") {"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":"  include ::nova::params"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_9753aae1","line":18,"in_reply_to":"7a3c09a3_f66954fa","updated":"2017-01-17 13:49:58.000000000","message":"Done","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":17,"context_line":") {"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":"  include ::nova::params"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  exec { \u0027nova-db-online-data-migrations\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_56606801","line":20,"updated":"2017-01-17 12:51:17.000000000","message":"you missed to add the resource in ::nova::deps for correct ordering.","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":17,"context_line":") {"},{"line_number":18,"context_line":""},{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":"  include ::nova::params"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  exec { \u0027nova-db-online-data-migrations\u0027:"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_d75ff2e2","line":20,"in_reply_to":"7a3c09a3_56606801","updated":"2017-01-17 13:49:58.000000000","message":"thanks, i missed that completely. In fact I am not sure if it needs to run before or after dbsync_api (from the bz via the related LP bug, it needs to happen after the dbsync, but not sure about dbsync_api). I\u0027ll add it as after for  now.","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"52f83f0cf1327daccd9535bca84ad7c3a58a2e1a","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":"  include ::nova::params"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  exec { \u0027nova-db-online-data-migrations\u0027:"},{"line_number":24,"context_line":"    command     \u003d\u003e \"/usr/bin/nova-manage ${extra_params} db online_data_migrations\","},{"line_number":25,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":26,"context_line":"    try_sleep   \u003d\u003e 5,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_310cc63a","line":23,"updated":"2017-01-17 12:51:17.000000000","message":"from where should we run this exec? nova-api node? in that case, can you do something like:\nhttps://github.com/openstack/puppet-nova/blob/190d6d98a8c0fa38763079aebe41faf9294ae244/manifests/api.pp#L403-L405 in nova::api?","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"36a2ec52ff2cc00aa53981c76a99c0080df30920","unresolved":false,"context_lines":[{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":"  include ::nova::params"},{"line_number":22,"context_line":""},{"line_number":23,"context_line":"  exec { \u0027nova-db-online-data-migrations\u0027:"},{"line_number":24,"context_line":"    command     \u003d\u003e \"/usr/bin/nova-manage ${extra_params} db online_data_migrations\","},{"line_number":25,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":26,"context_line":"    try_sleep   \u003d\u003e 5,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_d7c8d224","line":23,"in_reply_to":"7a3c09a3_310cc63a","updated":"2017-01-17 13:49:58.000000000","message":"++ thanks Emilien fixes incoming","commit_id":"f8ee7244bf404428ce86fbe4ee5fee224db7d2ba"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"500ae720a4d845de8d46b81d18eb641983dc2d6a","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    subscribe   \u003d\u003e ["},{"line_number":32,"context_line":"      Anchor[\u0027nova::install::end\u0027],"},{"line_number":33,"context_line":"      Anchor[\u0027nova::config::end\u0027],"},{"line_number":34,"context_line":"      Anchor[\u0027nova::db_online_data_migrations::begin\u0027]"},{"line_number":35,"context_line":"    ],"},{"line_number":36,"context_line":"    notify      \u003d\u003e Anchor[\u0027nova::db_online_data_migrations::end\u0027],"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_2228efe1","line":34,"range":{"start_line":34,"start_character":14,"end_line":34,"end_character":52},"updated":"2017-01-17 14:42:35.000000000","message":"Where is this defined? I don\u0027t see it in nova::deps","commit_id":"2697f72b8e4fa9a8bae57d0be629d223d2075161"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"900b92e44372866303d15d54ea58951aad0a128c","unresolved":false,"context_lines":[{"line_number":31,"context_line":"    subscribe   \u003d\u003e ["},{"line_number":32,"context_line":"      Anchor[\u0027nova::install::end\u0027],"},{"line_number":33,"context_line":"      Anchor[\u0027nova::config::end\u0027],"},{"line_number":34,"context_line":"      Anchor[\u0027nova::db_online_data_migrations::begin\u0027]"},{"line_number":35,"context_line":"    ],"},{"line_number":36,"context_line":"    notify      \u003d\u003e Anchor[\u0027nova::db_online_data_migrations::end\u0027],"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_6322c4a4","line":34,"range":{"start_line":34,"start_character":14,"end_line":34,"end_character":52},"in_reply_to":"7a3c09a3_2228efe1","updated":"2017-01-18 11:16:47.000000000","message":"thanks Alex added to latest version incoming, not sure if its right thanks for your comments in advance","commit_id":"2697f72b8e4fa9a8bae57d0be629d223d2075161"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"500ae720a4d845de8d46b81d18eb641983dc2d6a","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      Anchor[\u0027nova::config::end\u0027],"},{"line_number":34,"context_line":"      Anchor[\u0027nova::db_online_data_migrations::begin\u0027]"},{"line_number":35,"context_line":"    ],"},{"line_number":36,"context_line":"    notify      \u003d\u003e Anchor[\u0027nova::db_online_data_migrations::end\u0027],"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_621e77bc","line":36,"range":{"start_line":36,"start_character":27,"end_line":36,"end_character":63},"updated":"2017-01-17 14:42:35.000000000","message":"same","commit_id":"2697f72b8e4fa9a8bae57d0be629d223d2075161"},{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"900b92e44372866303d15d54ea58951aad0a128c","unresolved":false,"context_lines":[{"line_number":33,"context_line":"      Anchor[\u0027nova::config::end\u0027],"},{"line_number":34,"context_line":"      Anchor[\u0027nova::db_online_data_migrations::begin\u0027]"},{"line_number":35,"context_line":"    ],"},{"line_number":36,"context_line":"    notify      \u003d\u003e Anchor[\u0027nova::db_online_data_migrations::end\u0027],"},{"line_number":37,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_833df0c5","line":36,"range":{"start_line":36,"start_character":27,"end_line":36,"end_character":63},"in_reply_to":"7a3c09a3_621e77bc","updated":"2017-01-18 11:16:47.000000000","message":"Done","commit_id":"2697f72b8e4fa9a8bae57d0be629d223d2075161"}],"spec/classes/nova_db_online_data_migrations_spec.rb":[{"author":{"_account_id":8449,"name":"Marios Andreou","email":"marios.andreou@gmail.com","username":"marios"},"change_message_id":"c774c14707b6a7337496af1827ec2d98efb4ca26","unresolved":false,"context_lines":[{"line_number":15,"context_line":"        :subscribe   \u003d\u003e [\u0027Anchor[nova::install::end]\u0027,"},{"line_number":16,"context_line":"                         \u0027Anchor[nova::config::end]\u0027,"},{"line_number":17,"context_line":"                         \u0027Anchor[nova::db_online_data_migrations::begin]\u0027],"},{"line_number":18,"context_line":"        :notify      \u003d\u003e \u0027Anchor[nova::db_online_data_migrations::end]\u0027,"},{"line_number":19,"context_line":"      )"},{"line_number":20,"context_line":"    end"},{"line_number":21,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":6,"id":"3a461143_d1d690c4","line":18,"updated":"2017-01-26 12:19:48.000000000","message":"forgot to update these \n\nhttp://logs.openstack.org/49/421249/6/check/gate-puppet-nova-puppet-unit-3.6-centos-7/63cc599/console.html#_2017-01-26_09_13_42_161480","commit_id":"3513696f00df94168b9ecdc7020ba2666359bb2e"}]}