)]}'
{"manifests/metadata/novajoin/api.pp":[{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"53dd686378cd55752db0a9eae20c3a676fb3969f","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  $ipa_domain                \u003d undef,"},{"line_number":104,"context_line":"  $join_listen_port          \u003d $::os_service_default,"},{"line_number":105,"context_line":"  $keystone_auth_url         \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":106,"context_line":"  $keytab                    \u003d \u0027/etc/nova/krb5.keytab\u0027,"},{"line_number":107,"context_line":"  $log_dir                   \u003d \u0027/var/log/novajoin\u0027,"},{"line_number":108,"context_line":"  $manage_service            \u003d true,"},{"line_number":109,"context_line":"  $nova_user                 \u003d \u0027nova\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_95ed03f2","line":106,"updated":"2017-01-18 20:02:04.000000000","message":"shouldn\u0027t the default be this anyway on novajoin? os_service_default should be fine, no?","commit_id":"b7e572e69a43ece65b8aecf258f9b51e5005f686"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"53dd686378cd55752db0a9eae20c3a676fb3969f","unresolved":false,"context_lines":[{"line_number":190,"context_line":"                -p nova/${::fqdn} -k ${keytab} \u0026\u0026 chown ${nova_user}: ${keytab}\","},{"line_number":191,"context_line":"    creates \u003d\u003e \"${keytab}\","},{"line_number":192,"context_line":"    require \u003d\u003e Package[\u0027python-novajoin\u0027]"},{"line_number":193,"context_line":"  }"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  Novajoin_config\u003c||\u003e ~\u003e Service\u003c| title \u003d\u003d \u0027nova-api\u0027|\u003e"},{"line_number":196,"context_line":"  Exec[\u0027get-service-user-keytab\u0027] ~\u003e Service[\u0027novajoin-server\u0027]"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7a3c09a3_d58b0b1d","line":193,"updated":"2017-01-18 20:02:04.000000000","message":"you could probably keep track of this file in a file puppet resource and set the ownership there.","commit_id":"b7e572e69a43ece65b8aecf258f9b51e5005f686"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"77d01b531a4dd58bc2a633c34b5ed92f2f8a310a","unresolved":false,"context_lines":[{"line_number":103,"context_line":"  $ipa_domain                \u003d undef,"},{"line_number":104,"context_line":"  $join_listen_port          \u003d $::os_service_default,"},{"line_number":105,"context_line":"  $keystone_auth_url         \u003d \u0027http://127.0.0.1:35357/\u0027,"},{"line_number":106,"context_line":"  $keytab                    \u003d \u0027/etc/nova/krb5.keytab\u0027,"},{"line_number":107,"context_line":"  $log_dir                   \u003d \u0027/var/log/novajoin\u0027,"},{"line_number":108,"context_line":"  $manage_service            \u003d true,"},{"line_number":109,"context_line":"  $nova_user                 \u003d \u0027nova\u0027,"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_eb0d86e9","line":106,"updated":"2017-01-18 20:40:08.000000000","message":"this value is fine. os_service_default won\u0027t be useful since we need to use this for the kinit.","commit_id":"0d614b049dd0025697d77c102189e835e68d2de3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"b587ae3e392e0037cdd0f590ba82d699cd8821c8","unresolved":false,"context_lines":[{"line_number":187,"context_line":""},{"line_number":188,"context_line":"  exec { \u0027get-service-user-keytab\u0027:"},{"line_number":189,"context_line":"    command \u003d\u003e \"/usr/bin/kinit -kt /etc/krb5.keytab \u0026\u0026 ipa-getkeytab -s `grep xmlrpc_uri /etc/ipa/default.conf  | cut -d/ -f3` \\"},{"line_number":190,"context_line":"                -p nova/${::fqdn} -k ${keytab} \u0026\u0026 chown ${nova_user}: ${keytab}\","},{"line_number":191,"context_line":"    creates \u003d\u003e \"${keytab}\","},{"line_number":192,"context_line":"    require \u003d\u003e Package[\u0027python-novajoin\u0027]"},{"line_number":193,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"7a3c09a3_75c33739","line":190,"range":{"start_line":190,"start_character":47,"end_line":190,"end_character":79},"updated":"2017-01-18 20:03:16.000000000","message":"Should we just run the kinit as the $nova_user?  Exec takes a user parameter...\n\nAlternatively, it might be better to \nensure_resource(\u0027file\u0027, $keytab, { owner \u003d\u003e $nova_user, require \u003d\u003e Exec[\u0027get-service-user-keytab\u0027] })","commit_id":"0d614b049dd0025697d77c102189e835e68d2de3"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"fa33381cc78422fc4849d5b79680da28d6424a97","unresolved":false,"context_lines":[{"line_number":188,"context_line":"  exec { \u0027get-service-user-keytab\u0027:"},{"line_number":189,"context_line":"    command \u003d\u003e \"/usr/bin/kinit -kt /etc/krb5.keytab \u0026\u0026 ipa-getkeytab -s `grep xmlrpc_uri /etc/ipa/default.conf  | cut -d/ -f3` \\"},{"line_number":190,"context_line":"                -p nova/${::fqdn} -k ${keytab}\","},{"line_number":191,"context_line":"    creates \u003d\u003e \"${keytab}\","},{"line_number":192,"context_line":"    require \u003d\u003e Package[\u0027python-novajoin\u0027]"},{"line_number":193,"context_line":"  }"},{"line_number":194,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"7a3c09a3_7c3ddbba","line":191,"range":{"start_line":191,"start_character":4,"end_line":191,"end_character":26},"updated":"2017-01-18 22:29:12.000000000","message":"I\u0027m kinda surprised that puppet-lint did\u0027t catch this one. But you don\u0027t need to quote this. creates \u003d\u003e $keytab","commit_id":"bb13846229cff37adae4c79cee3d42643f3fb81a"}]}