)]}'
{"manifests/metadata/novajoin/api.pp":[{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"3049979b4ebb389e5a6a813d8b3348f752773fee","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $nova_password,"},{"line_number":101,"context_line":"  $transport_url,"},{"line_number":102,"context_line":"  $bind_address              \u003d \u00270.0.0.0\u0027,"},{"line_number":103,"context_line":"  $listen_port               \u003d \u00279090\u0027,"},{"line_number":104,"context_line":"  $api_paste_config          \u003d \u0027/etc/nova/join-api-paste.ini\u0027,"},{"line_number":105,"context_line":"  $auth_strategy             \u003d $::os_service_default,"},{"line_number":106,"context_line":"  $auth_type                 \u003d \u0027password\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a3905b3_e621d2fc","line":103,"updated":"2017-01-20 20:29:27.000000000","message":"These should be $::os_service_default","commit_id":"09d46c2eedf0b6a829ebd99256a8e32cd7ed0e33"},{"author":{"_account_id":9914,"name":"Ade Lee","email":"alee@redhat.com","username":"alee"},"change_message_id":"a30bde2e43f6e237b60649ff0e5f2f609aed47ba","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $nova_password,"},{"line_number":101,"context_line":"  $transport_url,"},{"line_number":102,"context_line":"  $bind_address              \u003d \u00270.0.0.0\u0027,"},{"line_number":103,"context_line":"  $listen_port               \u003d \u00279090\u0027,"},{"line_number":104,"context_line":"  $api_paste_config          \u003d \u0027/etc/nova/join-api-paste.ini\u0027,"},{"line_number":105,"context_line":"  $auth_strategy             \u003d $::os_service_default,"},{"line_number":106,"context_line":"  $auth_type                 \u003d \u0027password\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a3905b3_119c5a68","line":103,"in_reply_to":"5a3905b3_66d242d4","updated":"2017-01-20 20:49:43.000000000","message":"Fair enough - Seems to be consistent for other services.\nAs mentioned in IRC though, considering that this is a microservice, we should change the default in novajoin to 127.0.0.1 by default.","commit_id":"09d46c2eedf0b6a829ebd99256a8e32cd7ed0e33"},{"author":{"_account_id":10873,"name":"Juan Antonio Osorio Robles","email":"jaosorior@redhat.com","username":"ejuaoso"},"change_message_id":"1e065db546c2ff412051b130ffdcff2c63a9555a","unresolved":false,"context_lines":[{"line_number":100,"context_line":"  $nova_password,"},{"line_number":101,"context_line":"  $transport_url,"},{"line_number":102,"context_line":"  $bind_address              \u003d \u00270.0.0.0\u0027,"},{"line_number":103,"context_line":"  $listen_port               \u003d \u00279090\u0027,"},{"line_number":104,"context_line":"  $api_paste_config          \u003d \u0027/etc/nova/join-api-paste.ini\u0027,"},{"line_number":105,"context_line":"  $auth_strategy             \u003d $::os_service_default,"},{"line_number":106,"context_line":"  $auth_type                 \u003d \u0027password\u0027,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"5a3905b3_66d242d4","line":103,"in_reply_to":"5a3905b3_e621d2fc","updated":"2017-01-20 20:32:24.000000000","message":"did the same as it\u0027s done in the nova API manifest https://github.com/openstack/puppet-nova/blob/master/manifests/api.pp#L221","commit_id":"09d46c2eedf0b6a829ebd99256a8e32cd7ed0e33"}]}