)]}'
{"manifests/placement.pp":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9b4e11cef228d6af91ff9efaf572f1220a689a91","unresolved":false,"context_lines":[{"line_number":35,"context_line":"# [*os_interface*]"},{"line_number":36,"context_line":"#   (optional) interface name name used for getting the keystone endpoint for"},{"line_number":37,"context_line":"#   the placement API."},{"line_number":38,"context_line":"#   Defaults to \u0027RegionOne\u0027"},{"line_number":39,"context_line":"#"},{"line_number":40,"context_line":"# [*username*]"},{"line_number":41,"context_line":"#   (optional) Username for connecting to Nova Placement API service in admin context"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"fa31d9ce_b62c7f4b","line":38,"updated":"2017-02-13 08:30:04.000000000","message":"should be Defaults to $::os_service_default","commit_id":"f3712484135bee879050c8b2f3d721d2d16aca89"}],"spec/classes/nova_placement_spec.rb":[{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"9b4e11cef228d6af91ff9efaf572f1220a689a91","unresolved":false,"context_lines":[{"line_number":24,"context_line":"      is_expected.to contain_nova_config(\u0027placement/project_name\u0027).with_value(default_params[:project_name])"},{"line_number":25,"context_line":"      is_expected.to contain_nova_config(\u0027placement/project_domain_name\u0027).with_value(default_params[:project_domain_name])"},{"line_number":26,"context_line":"      is_expected.to contain_nova_config(\u0027placement/os_region_name\u0027).with_value(default_params[:os_region_name])"},{"line_number":27,"context_line":"      is_expected.to contain_nova_config(\u0027placement/os_interface\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":28,"context_line":"      is_expected.to contain_nova_config(\u0027placement/username\u0027).with_value(default_params[:username])"},{"line_number":29,"context_line":"      is_expected.to contain_nova_config(\u0027placement/user_domain_name\u0027).with_value(default_params[:user_domain_name])"},{"line_number":30,"context_line":"      is_expected.to contain_nova_config(\u0027placement/auth_url\u0027).with_value(default_params[:auth_url])"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"fa31d9ce_76f207d4","line":27,"updated":"2017-02-13 08:30:04.000000000","message":"I think it fails spec tests because you need to specify this parameter in  default_params (lines 6-12)","commit_id":"f3712484135bee879050c8b2f3d721d2d16aca89"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"96e5c1db25a9b11e8add6b6aff9ec987756f8d3f","unresolved":false,"context_lines":[{"line_number":2,"context_line":""},{"line_number":3,"context_line":"describe \u0027nova::placement\u0027 do"},{"line_number":4,"context_line":""},{"line_number":5,"context_line":""},{"line_number":6,"context_line":"  let :default_params do"},{"line_number":7,"context_line":"    { :auth_type           \u003d\u003e \u0027password\u0027,"},{"line_number":8,"context_line":"      :project_name        \u003d\u003e \u0027services\u0027,"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa31d9ce_d1f73af3","line":5,"updated":"2017-02-13 09:59:39.000000000","message":"nit: empty line","commit_id":"618b98d4a43c5e7baec887392479e7c0faa13dd4"},{"author":{"_account_id":18795,"name":"mkarpin","email":"mkarpin@mirantis.com","username":"nkarpin"},"change_message_id":"96e5c1db25a9b11e8add6b6aff9ec987756f8d3f","unresolved":false,"context_lines":[{"line_number":71,"context_line":"        facts.merge!(OSDefaults.get_facts())"},{"line_number":72,"context_line":"      end"},{"line_number":73,"context_line":""},{"line_number":74,"context_line":"      it_configures \u0027nova::placement\u0027"},{"line_number":75,"context_line":"    end"},{"line_number":76,"context_line":"  end"},{"line_number":77,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":2,"id":"fa31d9ce_31c0967b","line":74,"range":{"start_line":74,"start_character":6,"end_line":74,"end_character":20},"updated":"2017-02-13 09:59:39.000000000","message":"it_configures is a bit deprecated we use it_behaves_like here","commit_id":"618b98d4a43c5e7baec887392479e7c0faa13dd4"}]}