)]}'
{"manifests/cell_v2/discover_hosts.pp":[{"author":{"_account_id":9061,"name":"David Moreau Simard","email":"moi@dmsimard.com","username":"dmsimard"},"change_message_id":"248d33c7f9a8e6054c7e114a7a7652f13c74a079","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  include ::nova::deps"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  exec { \u0027nova-cell_v2-discover_hosts_sleep\u0027:"},{"line_number":22,"context_line":"    path        \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":23,"context_line":"    command     \u003d\u003e \"sleep ${sleep_seconds}\","},{"line_number":24,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":25,"context_line":"    subscribe   \u003d\u003e Anchor[\u0027nova::service::end\u0027],"},{"line_number":26,"context_line":"  } ~\u003e"},{"line_number":27,"context_line":"  exec { \u0027nova-cell_v2-discover_hosts\u0027:"},{"line_number":28,"context_line":"    path        \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":29,"context_line":"    command     \u003d\u003e \"nova-manage ${extra_params} cell_v2 discover_hosts --verbose\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba2be162_af99dad2","line":26,"range":{"start_line":21,"start_character":2,"end_line":26,"end_character":3},"updated":"2017-03-06 18:38:55.000000000","message":"If this is *really* required, please use puppet exec tries/try_sleep/timeout","commit_id":"2911c7c10d4a76757c9d3359db4b547c7b4d24b2"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"90e31aab573f6915dce41b9d0273a7b7e2a4c0c5","unresolved":false,"context_lines":[{"line_number":18,"context_line":""},{"line_number":19,"context_line":"  include ::nova::deps"},{"line_number":20,"context_line":""},{"line_number":21,"context_line":"  exec { \u0027nova-cell_v2-discover_hosts_sleep\u0027:"},{"line_number":22,"context_line":"    path        \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":23,"context_line":"    command     \u003d\u003e \"sleep ${sleep_seconds}\","},{"line_number":24,"context_line":"    refreshonly \u003d\u003e true,"},{"line_number":25,"context_line":"    subscribe   \u003d\u003e Anchor[\u0027nova::service::end\u0027],"},{"line_number":26,"context_line":"  } ~\u003e"},{"line_number":27,"context_line":"  exec { \u0027nova-cell_v2-discover_hosts\u0027:"},{"line_number":28,"context_line":"    path        \u003d\u003e [\u0027/bin\u0027, \u0027/usr/bin\u0027],"},{"line_number":29,"context_line":"    command     \u003d\u003e \"nova-manage ${extra_params} cell_v2 discover_hosts --verbose\","}],"source_content_type":"text/x-puppet","patch_set":3,"id":"ba2be162_4592fda0","line":26,"range":{"start_line":21,"start_character":2,"end_line":26,"end_character":3},"in_reply_to":"ba2be162_af99dad2","updated":"2017-03-06 19:19:31.000000000","message":"So that won\u0027t work because discover_hosts doesn\u0027t return failure if no hosts are found (and it probably shouldn\u0027t).  This basically is to address the single host race condition where we\u0027re setting up the service. So this might be better in just p-o-i because smarter downstream stuff will leverage heat/ansible/fuel to run this later after the compute registration tasks should be completed.","commit_id":"2911c7c10d4a76757c9d3359db4b547c7b4d24b2"}]}