)]}'
{"manifests/compute/libvirt.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7bf061a819568aa05eaf922690eb4b0396bf1198","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $migration_support                          \u003d false,"},{"line_number":134,"context_line":"  $libvirt_cpu_mode                           \u003d false,"},{"line_number":135,"context_line":"  $libvirt_cpu_model                          \u003d undef,"},{"line_number":136,"context_line":"  $libvirt_snapshot_image_format              \u003d undef,"},{"line_number":137,"context_line":"  $libvirt_disk_cachemodes                    \u003d [],"},{"line_number":138,"context_line":"  $libvirt_hw_disk_discard                    \u003d $::os_service_default,"},{"line_number":139,"context_line":"  $libvirt_hw_machine_type                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a30ddce_aca31dff","line":136,"range":{"start_line":136,"start_character":48,"end_line":136,"end_character":53},"updated":"2017-03-09 17:57:57.000000000","message":"Please use $::os_service_default.","commit_id":"0cb26eb7d945c25c47a74e0307649625793992b0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7bf061a819568aa05eaf922690eb4b0396bf1198","unresolved":false,"context_lines":[{"line_number":232,"context_line":"    }"},{"line_number":233,"context_line":"  }"},{"line_number":234,"context_line":""},{"line_number":235,"context_line":"  if $libvirt_snapshot_image_format !\u003d undef {"},{"line_number":236,"context_line":"    nova_config {"},{"line_number":237,"context_line":"      \u0027DEFAULT/snapshot_image_format\u0027: value \u003d\u003e $libvirt_snapshot_image_format;"},{"line_number":238,"context_line":"    }"},{"line_number":239,"context_line":"  } else {"},{"line_number":240,"context_line":"    nova_config {"},{"line_number":241,"context_line":"      \u0027DEFAULT/snapshot_image_format\u0027: ensure \u003d\u003e absent;"},{"line_number":242,"context_line":"    }"},{"line_number":243,"context_line":"  }"},{"line_number":244,"context_line":""},{"line_number":245,"context_line":"  if size($libvirt_disk_cachemodes) \u003e 0 {"},{"line_number":246,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9a30ddce_2cbd6d02","line":243,"range":{"start_line":235,"start_character":0,"end_line":243,"end_character":3},"updated":"2017-03-09 17:57:57.000000000","message":"By using $::os_service_default you don\u0027t need this logic. and you can just move the setting up to ~L217.  $::os_service_default causes the nova_config provider to do all this logic for you.","commit_id":"0cb26eb7d945c25c47a74e0307649625793992b0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30e416eeca719ff3e5c34dfc876543cc87005c04","unresolved":false,"context_lines":[{"line_number":33,"context_line":"#   cpu_mode\u003d\"custom\" and virt_type\u003d\"kvm|qemu\"."},{"line_number":34,"context_line":"#   Defaults to undef"},{"line_number":35,"context_line":"#"},{"line_number":36,"context_line":"# [*snapshot_image_format*]"},{"line_number":37,"context_line":"#   (optional) Format to save snapshots to. Some filesystems"},{"line_number":38,"context_line":"#   have a preference and only operate on raw or qcow2"},{"line_number":39,"context_line":"#   Defaults to undef"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a30ddce_78d71b4b","line":36,"range":{"start_line":36,"start_character":4,"end_line":36,"end_character":25},"updated":"2017-03-09 19:31:45.000000000","message":"libvirt_snapshot_image_format","commit_id":"e91a7982f44e3c3e06d8a38944cd3f42c272e42b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30e416eeca719ff3e5c34dfc876543cc87005c04","unresolved":false,"context_lines":[{"line_number":36,"context_line":"# [*snapshot_image_format*]"},{"line_number":37,"context_line":"#   (optional) Format to save snapshots to. Some filesystems"},{"line_number":38,"context_line":"#   have a preference and only operate on raw or qcow2"},{"line_number":39,"context_line":"#   Defaults to undef"},{"line_number":40,"context_line":"#"},{"line_number":41,"context_line":"# [*libvirt_disk_cachemodes*]"},{"line_number":42,"context_line":"#   (optional) A list of cachemodes for different disk types, e.g."}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a30ddce_f87b0b26","line":39,"range":{"start_line":39,"start_character":16,"end_line":39,"end_character":21},"updated":"2017-03-09 19:31:45.000000000","message":"$::os_service_default","commit_id":"e91a7982f44e3c3e06d8a38944cd3f42c272e42b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30e416eeca719ff3e5c34dfc876543cc87005c04","unresolved":false,"context_lines":[{"line_number":133,"context_line":"  $migration_support                          \u003d false,"},{"line_number":134,"context_line":"  $libvirt_cpu_mode                           \u003d false,"},{"line_number":135,"context_line":"  $libvirt_cpu_model                          \u003d undef,"},{"line_number":136,"context_line":"  $libvirt_snapshot_image_format              \u003d undef,"},{"line_number":137,"context_line":"  $libvirt_disk_cachemodes                    \u003d [],"},{"line_number":138,"context_line":"  $libvirt_hw_disk_discard                    \u003d $::os_service_default,"},{"line_number":139,"context_line":"  $libvirt_hw_machine_type                    \u003d $::os_service_default,"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a30ddce_58917746","line":136,"range":{"start_line":136,"start_character":48,"end_line":136,"end_character":53},"updated":"2017-03-09 19:31:45.000000000","message":"$::os_service_default","commit_id":"e91a7982f44e3c3e06d8a38944cd3f42c272e42b"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"30e416eeca719ff3e5c34dfc876543cc87005c04","unresolved":false,"context_lines":[{"line_number":213,"context_line":"    \u0027libvirt/inject_partition\u0027:    value \u003d\u003e $libvirt_inject_partition;"},{"line_number":214,"context_line":"    \u0027libvirt/hw_disk_discard\u0027:     value \u003d\u003e $libvirt_hw_disk_discard;"},{"line_number":215,"context_line":"    \u0027libvirt/hw_machine_type\u0027:     value \u003d\u003e $libvirt_hw_machine_type;"},{"line_number":216,"context_line":"    \u0027libvirt/enabled_perf_events\u0027: value \u003d\u003e $libvirt_enabled_perf_events;"},{"line_number":217,"context_line":"  }"},{"line_number":218,"context_line":""},{"line_number":219,"context_line":"  # cpu_model param is only valid if cpu_mode\u003dcustom"}],"source_content_type":"text/x-puppet","patch_set":3,"id":"9a30ddce_58d5f719","line":216,"updated":"2017-03-09 19:31:45.000000000","message":"Still need to add...\n\n\u0027libvirt/snapshot_image_format\u0027: value \u003d\u003e $libvirt_snapshot_image_format;","commit_id":"e91a7982f44e3c3e06d8a38944cd3f42c272e42b"}]}