)]}'
{"manifests/cell_v2/cell.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"c5781dba9fd54594ea790abd79b07c0667926a7a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::nova::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $transport_url {"},{"line_number":35,"context_line":"    $transport_url_real \u003d \"--transport-url\u003d${transport_url}\""},{"line_number":36,"context_line":"  } else {"},{"line_number":37,"context_line":"    $transport_url_real \u003d \u0027\u0027"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $database_connection {"},{"line_number":41,"context_line":"    $database_connection_real \u003d \"--database_connection\u003d${database_connection}\""},{"line_number":42,"context_line":"  } else {"},{"line_number":43,"context_line":"    $database_connection_real \u003d \u0027\u0027"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  exec { \"nova-cell_v2-cell-${title}\":"},{"line_number":47,"context_line":"    path      \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027 ],"},{"line_number":48,"context_line":"    command   \u003d\u003e \"nova-manage ${extra_params} cell_v2 create_cell --name\u003d${title} ${transport_url_real} ${database_connection_real}\","},{"line_number":49,"context_line":"    unless    \u003d\u003e \"nova-manage ${extra_params} cell_v2 list_cells | grep -q ${title}\","},{"line_number":50,"context_line":"    logoutput \u003d\u003e on_failure,"},{"line_number":51,"context_line":"    subscribe \u003d\u003e Anchor[\u0027nova::cell_v2::begin\u0027],"},{"line_number":52,"context_line":"    notify    \u003d\u003e Anchor[\u0027nova::cell_v2::end\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_9101463b","line":52,"range":{"start_line":34,"start_character":0,"end_line":52,"end_character":46},"updated":"2017-04-11 14:09:09.000000000","message":"you should switch this class over to use the provider now as well. that way people who were using this get the added benefits of update support right now without having to switch to the provider","commit_id":"691676e59fce41ac50079cfafc7af9cc8a555a6d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"abf7511612c4a42edb02e5bea9488159771f110b","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::nova::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $transport_url {"},{"line_number":35,"context_line":"    $transport_url_real \u003d \"--transport-url\u003d${transport_url}\""},{"line_number":36,"context_line":"  } else {"},{"line_number":37,"context_line":"    $transport_url_real \u003d \u0027\u0027"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $database_connection {"},{"line_number":41,"context_line":"    $database_connection_real \u003d \"--database_connection\u003d${database_connection}\""},{"line_number":42,"context_line":"  } else {"},{"line_number":43,"context_line":"    $database_connection_real \u003d \u0027\u0027"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  exec { \"nova-cell_v2-cell-${title}\":"},{"line_number":47,"context_line":"    path      \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027 ],"},{"line_number":48,"context_line":"    command   \u003d\u003e \"nova-manage ${extra_params} cell_v2 create_cell --name\u003d${title} ${transport_url_real} ${database_connection_real}\","},{"line_number":49,"context_line":"    unless    \u003d\u003e \"nova-manage ${extra_params} cell_v2 list_cells | grep -q ${title}\","},{"line_number":50,"context_line":"    logoutput \u003d\u003e on_failure,"},{"line_number":51,"context_line":"    subscribe \u003d\u003e Anchor[\u0027nova::cell_v2::begin\u0027],"},{"line_number":52,"context_line":"    notify    \u003d\u003e Anchor[\u0027nova::cell_v2::end\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_7d7fb3aa","line":52,"range":{"start_line":34,"start_character":0,"end_line":52,"end_character":46},"in_reply_to":"bff0334d_5cbf55a9","updated":"2017-04-11 16:03:23.000000000","message":"Actually it\u0027s just extra_params that\u0027s an issue. Pushed a new  patch.","commit_id":"691676e59fce41ac50079cfafc7af9cc8a555a6d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"5b7c2a9e47b767b5a68619e7ff5dca929729c676","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::nova::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $transport_url {"},{"line_number":35,"context_line":"    $transport_url_real \u003d \"--transport-url\u003d${transport_url}\""},{"line_number":36,"context_line":"  } else {"},{"line_number":37,"context_line":"    $transport_url_real \u003d \u0027\u0027"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $database_connection {"},{"line_number":41,"context_line":"    $database_connection_real \u003d \"--database_connection\u003d${database_connection}\""},{"line_number":42,"context_line":"  } else {"},{"line_number":43,"context_line":"    $database_connection_real \u003d \u0027\u0027"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  exec { \"nova-cell_v2-cell-${title}\":"},{"line_number":47,"context_line":"    path      \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027 ],"},{"line_number":48,"context_line":"    command   \u003d\u003e \"nova-manage ${extra_params} cell_v2 create_cell --name\u003d${title} ${transport_url_real} ${database_connection_real}\","},{"line_number":49,"context_line":"    unless    \u003d\u003e \"nova-manage ${extra_params} cell_v2 list_cells | grep -q ${title}\","},{"line_number":50,"context_line":"    logoutput \u003d\u003e on_failure,"},{"line_number":51,"context_line":"    subscribe \u003d\u003e Anchor[\u0027nova::cell_v2::begin\u0027],"},{"line_number":52,"context_line":"    notify    \u003d\u003e Anchor[\u0027nova::cell_v2::end\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_5cbf55a9","line":52,"range":{"start_line":34,"start_character":0,"end_line":52,"end_character":46},"in_reply_to":"bff0334d_5cc3d557","updated":"2017-04-11 14:29:21.000000000","message":"If it\u0027s too hard, then we can just leave it. Usually when we replace a resource with a provider we\u0027ll swap it out. We did this for some cinder items in the past.","commit_id":"691676e59fce41ac50079cfafc7af9cc8a555a6d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"e43b6ed4f16d7b184727c5da4a078b5f288b535c","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::nova::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $transport_url {"},{"line_number":35,"context_line":"    $transport_url_real \u003d \"--transport-url\u003d${transport_url}\""},{"line_number":36,"context_line":"  } else {"},{"line_number":37,"context_line":"    $transport_url_real \u003d \u0027\u0027"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $database_connection {"},{"line_number":41,"context_line":"    $database_connection_real \u003d \"--database_connection\u003d${database_connection}\""},{"line_number":42,"context_line":"  } else {"},{"line_number":43,"context_line":"    $database_connection_real \u003d \u0027\u0027"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  exec { \"nova-cell_v2-cell-${title}\":"},{"line_number":47,"context_line":"    path      \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027 ],"},{"line_number":48,"context_line":"    command   \u003d\u003e \"nova-manage ${extra_params} cell_v2 create_cell --name\u003d${title} ${transport_url_real} ${database_connection_real}\","},{"line_number":49,"context_line":"    unless    \u003d\u003e \"nova-manage ${extra_params} cell_v2 list_cells | grep -q ${title}\","},{"line_number":50,"context_line":"    logoutput \u003d\u003e on_failure,"},{"line_number":51,"context_line":"    subscribe \u003d\u003e Anchor[\u0027nova::cell_v2::begin\u0027],"},{"line_number":52,"context_line":"    notify    \u003d\u003e Anchor[\u0027nova::cell_v2::end\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_5cc3d557","line":52,"range":{"start_line":34,"start_character":0,"end_line":52,"end_character":46},"in_reply_to":"bff0334d_5cfcf5b3","updated":"2017-04-11 14:26:59.000000000","message":"True... I\u0027ll push a patch. Apis are different though so it\u0027s not a straight swap.","commit_id":"691676e59fce41ac50079cfafc7af9cc8a555a6d"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"eb0cecfd4281db173cd28b91cd5d5f2e6f37ab5a","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::nova::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $transport_url {"},{"line_number":35,"context_line":"    $transport_url_real \u003d \"--transport-url\u003d${transport_url}\""},{"line_number":36,"context_line":"  } else {"},{"line_number":37,"context_line":"    $transport_url_real \u003d \u0027\u0027"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $database_connection {"},{"line_number":41,"context_line":"    $database_connection_real \u003d \"--database_connection\u003d${database_connection}\""},{"line_number":42,"context_line":"  } else {"},{"line_number":43,"context_line":"    $database_connection_real \u003d \u0027\u0027"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  exec { \"nova-cell_v2-cell-${title}\":"},{"line_number":47,"context_line":"    path      \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027 ],"},{"line_number":48,"context_line":"    command   \u003d\u003e \"nova-manage ${extra_params} cell_v2 create_cell --name\u003d${title} ${transport_url_real} ${database_connection_real}\","},{"line_number":49,"context_line":"    unless    \u003d\u003e \"nova-manage ${extra_params} cell_v2 list_cells | grep -q ${title}\","},{"line_number":50,"context_line":"    logoutput \u003d\u003e on_failure,"},{"line_number":51,"context_line":"    subscribe \u003d\u003e Anchor[\u0027nova::cell_v2::begin\u0027],"},{"line_number":52,"context_line":"    notify    \u003d\u003e Anchor[\u0027nova::cell_v2::end\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_dc2365a6","line":52,"range":{"start_line":34,"start_character":0,"end_line":52,"end_character":46},"in_reply_to":"bff0334d_9101463b","updated":"2017-04-11 14:15:31.000000000","message":"could, but is there much point? multi-cell support is still a WIP in nova AFAIK. I doubt anybody would be using this directly, just via simple_setup","commit_id":"691676e59fce41ac50079cfafc7af9cc8a555a6d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"3f61b3b8006d0013d9f5e92ccaedaf095b8aa433","unresolved":false,"context_lines":[{"line_number":31,"context_line":""},{"line_number":32,"context_line":"  include ::nova::deps"},{"line_number":33,"context_line":""},{"line_number":34,"context_line":"  if $transport_url {"},{"line_number":35,"context_line":"    $transport_url_real \u003d \"--transport-url\u003d${transport_url}\""},{"line_number":36,"context_line":"  } else {"},{"line_number":37,"context_line":"    $transport_url_real \u003d \u0027\u0027"},{"line_number":38,"context_line":"  }"},{"line_number":39,"context_line":""},{"line_number":40,"context_line":"  if $database_connection {"},{"line_number":41,"context_line":"    $database_connection_real \u003d \"--database_connection\u003d${database_connection}\""},{"line_number":42,"context_line":"  } else {"},{"line_number":43,"context_line":"    $database_connection_real \u003d \u0027\u0027"},{"line_number":44,"context_line":"  }"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"  exec { \"nova-cell_v2-cell-${title}\":"},{"line_number":47,"context_line":"    path      \u003d\u003e [ \u0027/bin\u0027, \u0027/usr/bin\u0027 ],"},{"line_number":48,"context_line":"    command   \u003d\u003e \"nova-manage ${extra_params} cell_v2 create_cell --name\u003d${title} ${transport_url_real} ${database_connection_real}\","},{"line_number":49,"context_line":"    unless    \u003d\u003e \"nova-manage ${extra_params} cell_v2 list_cells | grep -q ${title}\","},{"line_number":50,"context_line":"    logoutput \u003d\u003e on_failure,"},{"line_number":51,"context_line":"    subscribe \u003d\u003e Anchor[\u0027nova::cell_v2::begin\u0027],"},{"line_number":52,"context_line":"    notify    \u003d\u003e Anchor[\u0027nova::cell_v2::end\u0027],"},{"line_number":53,"context_line":"  }"},{"line_number":54,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"bff0334d_5cfcf5b3","line":52,"range":{"start_line":34,"start_character":0,"end_line":52,"end_character":46},"in_reply_to":"bff0334d_dc2365a6","updated":"2017-04-11 14:25:07.000000000","message":"Never underestimate the end user.  It would be nice to reduce the code to manage for the rest of the cycle","commit_id":"691676e59fce41ac50079cfafc7af9cc8a555a6d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"49ad75c7fc45a480bcc13e029056f46e92d7127b","unresolved":false,"context_lines":[{"line_number":30,"context_line":""},{"line_number":31,"context_line":"  warning(\u0027nova::cell_v2::cell is deprecated by the nova_cell_v2 type in Pike and will be removed in the future.\u0027)"},{"line_number":32,"context_line":"  if $extra_params {"},{"line_number":33,"context_line":"    warning(\u0027The nova::cell_v2__cell::extra_params parameter is deprecated and will be ignored\u0027)"},{"line_number":34,"context_line":"  }"},{"line_number":35,"context_line":""},{"line_number":36,"context_line":"  include ::nova::deps"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"bff0334d_bf43c53e","line":33,"range":{"start_line":33,"start_character":30,"end_line":33,"end_character":32},"updated":"2017-04-12 15:44:39.000000000","message":"::","commit_id":"f531b7ae10593c95ea5d842e6ae38f8aab37063c"}]}