)]}'
{"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"11290c41d2d6ca87a82544633380db199384e033","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"  if $pci_alias {"},{"line_number":536,"context_line":"    nova_config {"},{"line_number":537,"context_line":"      \u0027pci/pci_alias\u0027: value \u003d\u003e join(check_array_of_hash($pci_alias), \u0027,\u0027);"},{"line_number":538,"context_line":"    }"},{"line_number":539,"context_line":"  }"},{"line_number":540,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f231b9d_b7d730c0","line":537,"updated":"2017-06-12 15:56:02.000000000","message":"It\u0027s an array of hashes so you can\u0027t just join it. That\u0027s specifically why it was this way. If this needs to be changed, it seems that some additional work will need to be done to get the data in the right format. The unit tests show what the problem is by the way. http://logs.openstack.org/11/472611/1/check/gate-puppet-nova-puppet-unit-4.5-centos-7/d0a2000/console.html#_2017-06-12_06_22_46_964288","commit_id":"700daab3cf403bc5cd5e0c85734a7358c24d24c6"},{"author":{"_account_id":6908,"name":"Simon Leinen","email":"simon.leinen@gmail.com","username":"simon-leinen"},"change_message_id":"133a6640a2a36a01a14b7f401d76f60cf92ed024","unresolved":false,"context_lines":[{"line_number":534,"context_line":""},{"line_number":535,"context_line":"  if $pci_alias {"},{"line_number":536,"context_line":"    nova_config {"},{"line_number":537,"context_line":"      \u0027pci/pci_alias\u0027: value \u003d\u003e join(any2array(check_array_of_hash($pci_alias)), \u0027,\u0027);"},{"line_number":538,"context_line":"    }"},{"line_number":539,"context_line":"  }"},{"line_number":540,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":2,"id":"5f201791_3ea14947","line":537,"updated":"2017-06-26 19:10:05.000000000","message":"This patch is a no-op! Note that the result of \"check_array_of_hash()\" is always a string.  That means any2array(...) will always return a single-element array containing that string.  That means join(..., \",\") will always return that same string.","commit_id":"9dde5a4108df2448bfd43010112d313f1a73395b"}]}