)]}'
{"manifests/compute/ironic.pp":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"6dafe8c89c600fbf2a2d84379ff9331c46d230e4","unresolved":false,"context_lines":[{"line_number":28,"context_line":"  package { \u0027python2-ironicclient\u0027:"},{"line_number":29,"context_line":"    ensure \u003d\u003e present,"},{"line_number":30,"context_line":"    tag    \u003d\u003e [\u0027openstack\u0027, \u0027nova-support-package\u0027],"},{"line_number":31,"context_line":"  }"},{"line_number":32,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"7f231b9d_a6650420","line":31,"updated":"2017-06-19 11:43:28.000000000","message":"we should rather consume this class:\nhttps://github.com/openstack/puppet-ironic/blob/master/manifests/client.pp\n\nThe code you wrote will lead to resource duplication in the case of having declared this package somewhere else in the catalog (e.g if nova ironic runs on the same node as nova compute node).\n\nAlso, the package name needs to be in params.pp.\nAnyway, we should make a new dependency on puppet-ironic and add the ironic::client class.\nPlease patch metadata.json and include ::ironic::client here.\nYou\u0027ll also need to update unit tests for nova::compute::ironic.\n\nThanks!","commit_id":"8c1fffb1103932cced97e85bcbec06e7087b2463"}],"metadata.json":[{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"32bb8a12144c5040baf815398a2bfa0cf6e383af","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"name\": \"openstack/ironic\","},{"line_number":30,"context_line":"            \"version_requirement\": \"\u003e\u003d10.0.0\""},{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"},{"line_number":33,"context_line":"            \"name\": \"openstack/keystone\","}],"source_content_type":"application/json","patch_set":2,"id":"7f231b9d_6cd46248","line":30,"updated":"2017-06-19 17:32:04.000000000","message":"I think you\u0027ll need an higher version from Pike.","commit_id":"fb958ab05a88c0b6a408e16751ae18598bbd72c0"},{"author":{"_account_id":10239,"name":"Dmitry Tantsur","email":"dtantsur@protonmail.com","username":"dtantsur"},"change_message_id":"bcb8a80c06c57fa9b57433fcc36cf7dd61b845f7","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"name\": \"openstack/ironic\","},{"line_number":30,"context_line":"            \"version_requirement\": \"\u003e\u003d10.0.0\""},{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"},{"line_number":33,"context_line":"            \"name\": \"openstack/keystone\","}],"source_content_type":"application/json","patch_set":2,"id":"7f231b9d_cebfd2ce","line":30,"in_reply_to":"7f231b9d_535a502a","updated":"2017-06-20 11:03:40.000000000","message":"I guess it\u0027s safer to pull in the matching version..","commit_id":"fb958ab05a88c0b6a408e16751ae18598bbd72c0"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"8608a8889c47898dbc78e7434d239ce18f9a0fb5","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"name\": \"openstack/ironic\","},{"line_number":30,"context_line":"            \"version_requirement\": \"\u003e\u003d10.0.0\""},{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"},{"line_number":33,"context_line":"            \"name\": \"openstack/keystone\","}],"source_content_type":"application/json","patch_set":2,"id":"7f231b9d_535a502a","line":30,"in_reply_to":"7f231b9d_6cd46248","updated":"2017-06-20 08:45:20.000000000","message":"Why, The class being used last changed in 10.0.0","commit_id":"fb958ab05a88c0b6a408e16751ae18598bbd72c0"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"0d63e5d4b905b3ad9f7e46caba14b1635a4264a9","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"name\": \"openstack/ironic\","},{"line_number":30,"context_line":"            \"version_requirement\": \"\u003e\u003d11.1.0 \u003c12.0.0\""},{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"},{"line_number":33,"context_line":"            \"name\": \"openstack/keystone\","}],"source_content_type":"application/json","patch_set":3,"id":"5f201791_85cbe951","line":30,"updated":"2017-06-21 14:45:47.000000000","message":"nit: 11.2.0 is the current rev to use. Doesn\u0027t really affect to much and we\u0027ll get them lined up again at the begining of queens","commit_id":"dc796c55b80a41627651fcdf5e256049dedea719"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"c2e0dbb61d1a1fdd12d8c6f4c9e8d99a6a1addde","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"name\": \"openstack/ironic\","},{"line_number":30,"context_line":"            \"version_requirement\": \"\u003e\u003d11.1.0 \u003c12.0.0\""},{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"},{"line_number":33,"context_line":"            \"name\": \"openstack/keystone\","}],"source_content_type":"application/json","patch_set":3,"id":"5f201791_b8b72c87","line":30,"in_reply_to":"5f201791_85cbe951","updated":"2017-06-21 15:18:41.000000000","message":"I took a look before setting this, puppet-ironic has no 11.2.0 tag in the repo, should I have looked somewhere else?","commit_id":"dc796c55b80a41627651fcdf5e256049dedea719"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"6e7cc075041018bbd05b8c4ff531d27082518849","unresolved":false,"context_lines":[{"line_number":27,"context_line":"        },"},{"line_number":28,"context_line":"        {"},{"line_number":29,"context_line":"            \"name\": \"openstack/ironic\","},{"line_number":30,"context_line":"            \"version_requirement\": \"\u003e\u003d11.1.0 \u003c12.0.0\""},{"line_number":31,"context_line":"        },"},{"line_number":32,"context_line":"        {"},{"line_number":33,"context_line":"            \"name\": \"openstack/keystone\","}],"source_content_type":"application/json","patch_set":3,"id":"5f201791_38079c1f","line":30,"in_reply_to":"5f201791_b8b72c87","updated":"2017-06-21 15:22:07.000000000","message":"This is fine, I think the metadata is already preped for the next release so 11.2.0 will be the next one. Just leave it","commit_id":"dc796c55b80a41627651fcdf5e256049dedea719"}],"spec/classes/nova_compute_ironic_spec.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"24e187597fadc8df920b737eb2c88d8744f7a46b","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      it \u0027configures ironic in nova.conf\u0027 do"},{"line_number":9,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/compute_driver\u0027).with_value(\u0027ironic.IronicDriver\u0027)"},{"line_number":10,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/max_concurrent_builds\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":11,"context_line":"        is_expected.to contain_class(\u0027::ironic::client\u0027)"},{"line_number":12,"context_line":"      end"},{"line_number":13,"context_line":"    end"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f201791_989d905b","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":40},"updated":"2017-06-21 15:07:47.000000000","message":"don\u0027t need the leading :: for the rspec test","commit_id":"dc796c55b80a41627651fcdf5e256049dedea719"},{"author":{"_account_id":1926,"name":"Derek Higgins","email":"derekh@redhat.com","username":"derekh"},"change_message_id":"c2e0dbb61d1a1fdd12d8c6f4c9e8d99a6a1addde","unresolved":false,"context_lines":[{"line_number":8,"context_line":"      it \u0027configures ironic in nova.conf\u0027 do"},{"line_number":9,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/compute_driver\u0027).with_value(\u0027ironic.IronicDriver\u0027)"},{"line_number":10,"context_line":"        is_expected.to contain_nova_config(\u0027DEFAULT/max_concurrent_builds\u0027).with_value(\u0027\u003cSERVICE DEFAULT\u003e\u0027)"},{"line_number":11,"context_line":"        is_expected.to contain_class(\u0027::ironic::client\u0027)"},{"line_number":12,"context_line":"      end"},{"line_number":13,"context_line":"    end"},{"line_number":14,"context_line":""}],"source_content_type":"text/x-ruby","patch_set":3,"id":"5f201791_b86ccc08","line":11,"range":{"start_line":11,"start_character":38,"end_line":11,"end_character":40},"in_reply_to":"5f201791_989d905b","updated":"2017-06-21 15:18:41.000000000","message":"will fix","commit_id":"dc796c55b80a41627651fcdf5e256049dedea719"}]}