)]}'
{"manifests/api.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8f7e035b34002a5f48d8a2ba29bef78f82f4ab07","unresolved":false,"context_lines":[{"line_number":540,"context_line":"  if $pci_alias and !is_service_default($pci_alias) and !empty($pci_alias) {"},{"line_number":541,"context_line":"    warning(\u0027The pci_alias parameter is deprecated. Please use nova::pci::aliases instead.\u0027)"},{"line_number":542,"context_line":"    $pci_alias_real \u003d to_array_of_json_strings($pci_alias)"},{"line_number":543,"context_line":"    ensure_resource(\u0027nova_config\u0027, \u0027pci/alias\u0027, { value \u003d\u003e $pci_alias_real })"},{"line_number":544,"context_line":"  } else {"},{"line_number":545,"context_line":"    include ::nova::pci"},{"line_number":546,"context_line":"  }"}],"source_content_type":"text/x-puppet","patch_set":12,"id":"7f287b81_c56720b7","line":543,"range":{"start_line":543,"start_character":0,"end_line":543,"end_character":77},"updated":"2017-08-28 16:58:14.000000000","message":"So the problem with this is that it can lead to order issues. The correct way to deprecate this is to just include ::nova::pci and then just pick($::nova::api::pci_alias, $aliases) over in ::nova::pci","commit_id":"3f7581a79dc2fe1ed48e9e53b7e04f3d8a038983"}],"manifests/compute.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a5569492b3574fb93c6ed5506c229cc9a37edf3c","unresolved":false,"context_lines":[{"line_number":201,"context_line":"  #pci_alias is needed in the compute configuration starting Ocata"},{"line_number":202,"context_line":"  if $pci_alias {"},{"line_number":203,"context_line":"    nova_config {"},{"line_number":204,"context_line":"      \u0027pci/pci_alias\u0027: value \u003d\u003e join(any2array(check_array_of_hash($pci_alias)), \u0027,\u0027);"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"  }"},{"line_number":207,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":3,"id":"3f1d235d_fdb97078","line":204,"range":{"start_line":204,"start_character":7,"end_line":204,"end_character":20},"updated":"2017-07-06 09:47:36.000000000","message":"Should be \u0027pci/alias\u0027 AFAICT","commit_id":"938c81648ef8505c6c15af4691e39635f6fe1a35"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"bf6d59382b39f413396225a303a9cc81e9830a00","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    nova_config {"},{"line_number":204,"context_line":"      \u0027pci/alias\u0027: value \u003d\u003e join(any2array(check_array_of_hash($pci_alias)), \u0027,\u0027);"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"  }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  # cryptsetup is required when Barbican is encrypting volumes"},{"line_number":209,"context_line":"  if $keymgr_api_class \u003d~ /barbican/ {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f1d235d_e49d46bc","line":206,"updated":"2017-07-06 18:34:31.000000000","message":"My concern here is when nova::api and nova::compute are colocated this will fail.  It might be a better idea to move this out to it\u0027s own configuration perhaps nova::pci where we can also move some of the other pci related configurations","commit_id":"551be7383fa0a3ee357fa877bf248708bf696507"},{"author":{"_account_id":16845,"name":"Sindhur","email":"smalleni@redhat.com","username":"smalleni"},"change_message_id":"d169303a5c8a04946adfeff0ad312e4b8b5c0024","unresolved":false,"context_lines":[{"line_number":203,"context_line":"    nova_config {"},{"line_number":204,"context_line":"      \u0027pci/alias\u0027: value \u003d\u003e join(any2array(check_array_of_hash($pci_alias)), \u0027,\u0027);"},{"line_number":205,"context_line":"    }"},{"line_number":206,"context_line":"  }"},{"line_number":207,"context_line":""},{"line_number":208,"context_line":"  # cryptsetup is required when Barbican is encrypting volumes"},{"line_number":209,"context_line":"  if $keymgr_api_class \u003d~ /barbican/ {"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"3f1d235d_a4974e3a","line":206,"in_reply_to":"3f1d235d_e49d46bc","updated":"2017-07-06 18:45:53.000000000","message":"Hey Alex,\nI\u0027m new to puppet. Any guidance/pointers on how to do this is much appreciated.","commit_id":"551be7383fa0a3ee357fa877bf248708bf696507"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"956c0326dab7a8e3b45d2abb7c9ee645af0dea81","unresolved":false,"context_lines":[{"line_number":197,"context_line":"  } else {"},{"line_number":198,"context_line":"    $pci_passthrough_real \u003d $::os_service_default"},{"line_number":199,"context_line":"  }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"  #pci/alias is needed in the compute configuration starting Ocata"},{"line_number":202,"context_line":"  if $pci_alias {"},{"line_number":203,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"3f1d235d_f50d6e3e","line":200,"updated":"2017-07-11 19:39:17.000000000","message":"So the best way to move this from nova::api to here is to remove the nova_config setting from nova::api and then you can use something like...\n\n$pci_alias_real \u003d pick($pci_alias, $::nova::api::pci_alias)\n\nif $pci_alias_real {\n  ...\n}\n\nI would also add a warning about pci_alias being deprecated in nova::api (if set) and indicate that it should be configured via nova::compute::pci_alias","commit_id":"8cc29704a216105c6f46148a1ad01d7679458c6b"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"b23514b7981b3a1fdaf2484cc0329b5f40434baa","unresolved":false,"context_lines":[{"line_number":197,"context_line":"  } else {"},{"line_number":198,"context_line":"    $pci_passthrough_real \u003d $::os_service_default"},{"line_number":199,"context_line":"  }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"  #pci/alias is needed in the compute configuration starting Ocata"},{"line_number":202,"context_line":"  if $pci_alias {"},{"line_number":203,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7f287b81_cb46aac1","line":200,"in_reply_to":"3f1d235d_f50d6e3e","updated":"2017-08-31 23:22:11.000000000","message":"done, I\u0027d forgotten about pick","commit_id":"8cc29704a216105c6f46148a1ad01d7679458c6b"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"608beab83959726110c046fd22ceedb81802d79d","unresolved":false,"context_lines":[{"line_number":197,"context_line":"  } else {"},{"line_number":198,"context_line":"    $pci_passthrough_real \u003d $::os_service_default"},{"line_number":199,"context_line":"  }"},{"line_number":200,"context_line":""},{"line_number":201,"context_line":"  #pci/alias is needed in the compute configuration starting Ocata"},{"line_number":202,"context_line":"  if $pci_alias {"},{"line_number":203,"context_line":"    nova_config {"}],"source_content_type":"text/x-puppet","patch_set":8,"id":"7f287b81_eb504661","line":200,"in_reply_to":"7f287b81_cb46aac1","updated":"2017-08-31 23:28:22.000000000","message":"\u003csigh/\u003ereplied to the wrong comment","commit_id":"8cc29704a216105c6f46148a1ad01d7679458c6b"}],"spec/classes/nova_compute_spec.rb":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"a5569492b3574fb93c6ed5506c229cc9a37edf3c","unresolved":false,"context_lines":[{"line_number":62,"context_line":"    end"},{"line_number":63,"context_line":""},{"line_number":64,"context_line":"    context \u0027with overridden parameters\u0027 do"},{"line_number":65,"context_line":"      let :params do"},{"line_number":66,"context_line":"        { :enabled                            \u003d\u003e false,"},{"line_number":67,"context_line":"          :ensure_package                     \u003d\u003e \u00272012.1-2\u0027,"},{"line_number":68,"context_line":"          :vncproxy_host                      \u003d\u003e \u0027127.0.0.1\u0027,"}],"source_content_type":"text/x-ruby","patch_set":3,"id":"3f1d235d_1808ba25","line":65,"range":{"start_line":65,"start_character":6,"end_line":65,"end_character":20},"updated":"2017-07-06 09:47:36.000000000","message":"Looks like this is missing the pci_alias param for the assertion below","commit_id":"938c81648ef8505c6c15af4691e39635f6fe1a35"}]}