)]}'
{"/COMMIT_MSG":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c050177d283d8054b2593a415ca15103db269d04","unresolved":false,"context_lines":[{"line_number":6,"context_line":""},{"line_number":7,"context_line":"Add libvirtd_config resource and nova::compute::libvirt::config class"},{"line_number":8,"context_line":""},{"line_number":9,"context_line":"Related-Bug: #1696504"},{"line_number":10,"context_line":"Change-Id: I30090bed2bda6f1c2d81d70c35f4bd1c71586d71"}],"source_content_type":"text/x-gerrit-commit-message","patch_set":1,"id":"3f1d235d_96205a4a","line":9,"range":{"start_line":9,"start_character":0,"end_line":9,"end_character":21},"updated":"2017-07-04 19:38:35.000000000","message":"Is this related? Looks more like a general refactoring","commit_id":"0f0d6b886b74547cafd7780462ba4bbe8e02b47e"}],"lib/puppet/provider/llibvirtd_config/ini_setting.rb":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"989b37752709ff72248b6d706a0aa37b9ccb5625","unresolved":false,"context_lines":[{"line_number":1,"context_line":"Puppet::Type.type(:libvirtd_config).provide("},{"line_number":2,"context_line":"  :ini_setting,"},{"line_number":3,"context_line":"  :parent \u003d\u003e Puppet::Type.type(:ini_setting).provider(:ruby)"},{"line_number":4,"context_line":") do"}],"source_content_type":"text/x-ruby","patch_set":7,"id":"3f1d235d_a3bfc8f9","line":1,"updated":"2017-07-11 16:01:29.000000000","message":"The failures are because this file is in a folder with the wrong name llibvirtd_config vs libvirtd_config","commit_id":"193296f8ba4506fafca4264d44ae0353c81c1c8c"}],"lib/puppet/type/libvirtd_config.rb":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"c050177d283d8054b2593a415ca15103db269d04","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  end"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  autorequire(:package) do"},{"line_number":43,"context_line":"    \u0027nova-common\u0027"},{"line_number":44,"context_line":"  end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f1d235d_f6daee48","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":17},"updated":"2017-07-04 19:38:35.000000000","message":"Is that correct?","commit_id":"0f0d6b886b74547cafd7780462ba4bbe8e02b47e"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"b0455d3fb589bc62cd39d087734de0d05ad5c640","unresolved":false,"context_lines":[{"line_number":40,"context_line":"  end"},{"line_number":41,"context_line":""},{"line_number":42,"context_line":"  autorequire(:package) do"},{"line_number":43,"context_line":"    \u0027nova-common\u0027"},{"line_number":44,"context_line":"  end"},{"line_number":45,"context_line":""},{"line_number":46,"context_line":"end"}],"source_content_type":"text/x-ruby","patch_set":1,"id":"3f1d235d_9f54ed54","line":43,"range":{"start_line":43,"start_character":4,"end_line":43,"end_character":17},"in_reply_to":"3f1d235d_f6daee48","updated":"2017-07-05 00:26:32.000000000","message":"Apparently not. But it\u0027s also broken for nova_config, since the package name is OS dependent.","commit_id":"0f0d6b886b74547cafd7780462ba4bbe8e02b47e"}],"manifests/migration/libvirt.pp":[{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"728381c79aa5c6e2816f17806f18cb63562167ad","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027|\u003e"},{"line_number":180,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027 |\u003e"},{"line_number":183,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if $override_uuid {"},{"line_number":186,"context_line":"      if ! $::libvirt_uuid {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f1d235d_d65ed274","line":183,"range":{"start_line":182,"start_character":4,"end_line":183,"end_character":25},"updated":"2017-07-04 19:54:44.000000000","message":"The old approach notifies the service when the config file is changed. Needs a different approach if we change to a resource provider.","commit_id":"0f0d6b886b74547cafd7780462ba4bbe8e02b47e"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"e1b09b8d453faeb72c8d01e03258d13a90bed1c2","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027|\u003e"},{"line_number":180,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027 |\u003e"},{"line_number":183,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if $override_uuid {"},{"line_number":186,"context_line":"      if ! $::libvirt_uuid {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f1d235d_5fd535e4","line":183,"range":{"start_line":182,"start_character":4,"end_line":183,"end_character":25},"in_reply_to":"3f1d235d_76901eee","updated":"2017-07-05 00:12:41.000000000","message":"Good catch! Thanks.\nDone","commit_id":"0f0d6b886b74547cafd7780462ba4bbe8e02b47e"},{"author":{"_account_id":23811,"name":"Oliver Walsh","email":"owalsh@redhat.com","username":"owalsh"},"change_message_id":"f92a9a66564af2ebb6fab304d3074558e47065a3","unresolved":false,"context_lines":[{"line_number":179,"context_line":"    -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027|\u003e"},{"line_number":180,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027 |\u003e"},{"line_number":183,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if $override_uuid {"},{"line_number":186,"context_line":"      if ! $::libvirt_uuid {"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"3f1d235d_76901eee","line":183,"range":{"start_line":182,"start_character":4,"end_line":183,"end_character":25},"in_reply_to":"3f1d235d_d65ed274","updated":"2017-07-04 19:57:31.000000000","message":"E.g for nova_config provider https://github.com/openstack/puppet-nova/blob/master/manifests/deps.pp#L17","commit_id":"0f0d6b886b74547cafd7780462ba4bbe8e02b47e"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"832a43999d7c19b5eb0a475a5ccac7a62e41a2a7","unresolved":false,"context_lines":[{"line_number":176,"context_line":""},{"line_number":177,"context_line":"  if $configure_libvirt {"},{"line_number":178,"context_line":"    Anchor[\u0027nova::config::begin\u0027]"},{"line_number":179,"context_line":"    -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027|\u003e"},{"line_number":180,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027 |\u003e"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f1d235d_f9b2c493","side":"PARENT","line":179,"range":{"start_line":179,"start_character":0,"end_line":179,"end_character":47},"updated":"2017-07-05 15:24:22.000000000","message":"We still need this because you still have one of these for the sysconfig editing","commit_id":"44310588994aec1fbbed5d008c4bb7126ebe6f1d"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"7ba7d2eb57d9879f3ca216bcca9ec62327f7f5a9","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  }"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"  if $configure_libvirt {"},{"line_number":178,"context_line":"    Anchor[\u0027nova::config::begin\u0027]"},{"line_number":179,"context_line":"    -\u003e Libvirtd_config\u003c||\u003e"},{"line_number":180,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    Libvirtd_config\u003c||\u003e"},{"line_number":183,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if $override_uuid {"},{"line_number":186,"context_line":"      if ! $::libvirt_uuid {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f1d235d_3dcee581","line":183,"range":{"start_line":178,"start_character":0,"end_line":183,"end_character":25},"updated":"2017-07-05 16:23:35.000000000","message":"So we can cheat a bit on the first block because we can just have the libvirtd_config go first (or you can flip them).  But for the service bit, we need to duplicate it because they each need to notify the services.\n\n    Anchor[\u0027nova::config::begin\u0027]\n    -\u003e Libvirtd_config\u003c||\u003e\n    -\u003e File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027|\u003e\n    -\u003e Anchor[\u0027nova::config::end\u0027]\n\n    Libvirtd_config\u003c||\u003e\n    ~\u003e Service[\u0027libvirt\u0027]\n\n    File_line\u003c| tag \u003d\u003d \u0027libvirt-file_line\u0027 |\u003e\n    ~\u003e Service[\u0027libvirt\u0027]","commit_id":"e27dd5bc7b9601a6e67dd66e56d12cd88ce791fb"},{"author":{"_account_id":19173,"name":"Sven Anderson","email":"sven@redhat.com","username":"ansiwen"},"change_message_id":"65732e1b7944fa3ff72ad77015dfa2ba8643fe45","unresolved":false,"context_lines":[{"line_number":175,"context_line":"  }"},{"line_number":176,"context_line":""},{"line_number":177,"context_line":"  if $configure_libvirt {"},{"line_number":178,"context_line":"    Anchor[\u0027nova::config::begin\u0027]"},{"line_number":179,"context_line":"    -\u003e Libvirtd_config\u003c||\u003e"},{"line_number":180,"context_line":"    -\u003e Anchor[\u0027nova::config::end\u0027]"},{"line_number":181,"context_line":""},{"line_number":182,"context_line":"    Libvirtd_config\u003c||\u003e"},{"line_number":183,"context_line":"    ~\u003e Service[\u0027libvirt\u0027]"},{"line_number":184,"context_line":""},{"line_number":185,"context_line":"    if $override_uuid {"},{"line_number":186,"context_line":"      if ! $::libvirt_uuid {"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"3f1d235d_83cebab1","line":183,"range":{"start_line":178,"start_character":0,"end_line":183,"end_character":25},"in_reply_to":"3f1d235d_3dcee581","updated":"2017-07-05 17:06:51.000000000","message":"Done","commit_id":"e27dd5bc7b9601a6e67dd66e56d12cd88ce791fb"}]}