)]}'
{"manifests/compute/libvirt/services.pp":[{"author":{"_account_id":6926,"name":"Bogdan Dobrelya","email":"bdobreli@redhat.com","username":"bogdando"},"change_message_id":"c2c1e76765d124b13c04497c59f191c4a3f0e084","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      require  \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # messagebus"},{"line_number":72,"context_line":"    if($::osfamily \u003d\u003d \u0027RedHat\u0027 and $::operatingsystem !\u003d \u0027Fedora\u0027) {"},{"line_number":73,"context_line":"      service { \u0027messagebus\u0027:"},{"line_number":74,"context_line":"        ensure   \u003d\u003e running,"},{"line_number":75,"context_line":"        enable   \u003d\u003e true,"},{"line_number":76,"context_line":"        name     \u003d\u003e $::nova::params::messagebus_service_name,"},{"line_number":77,"context_line":"        provider \u003d\u003e $::nova::params::special_service_provider,"},{"line_number":78,"context_line":"      }"},{"line_number":79,"context_line":"      Package[\u0027libvirt\u0027] -\u003e Service[\u0027messagebus\u0027] -\u003e Service[\u0027libvirt\u0027]"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # when nova-compute \u0026 libvirt run together"},{"line_number":83,"context_line":"    Service[\u0027libvirt\u0027] -\u003e Service\u003c| title \u003d\u003d \u0027nova-compute\u0027|\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_42ea370f","line":80,"range":{"start_line":71,"start_character":0,"end_line":80,"end_character":5},"updated":"2017-08-02 08:19:48.000000000","message":"Does the placement matter? I thought it doesn\u0027t in a puppet world.","commit_id":"ca1bdcfd7bf2888f4d7bfc57508079f96b9fb8d5"},{"author":{"_account_id":3153,"name":"Emilien Macchi","email":"emilien@redhat.com","username":"emilienm"},"change_message_id":"e95958cb17319d96ffb139d968fa5b5c14d89a46","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      require  \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # messagebus"},{"line_number":72,"context_line":"    if($::osfamily \u003d\u003d \u0027RedHat\u0027 and $::operatingsystem !\u003d \u0027Fedora\u0027) {"},{"line_number":73,"context_line":"      service { \u0027messagebus\u0027:"},{"line_number":74,"context_line":"        ensure   \u003d\u003e running,"},{"line_number":75,"context_line":"        enable   \u003d\u003e true,"},{"line_number":76,"context_line":"        name     \u003d\u003e $::nova::params::messagebus_service_name,"},{"line_number":77,"context_line":"        provider \u003d\u003e $::nova::params::special_service_provider,"},{"line_number":78,"context_line":"      }"},{"line_number":79,"context_line":"      Package[\u0027libvirt\u0027] -\u003e Service[\u0027messagebus\u0027] -\u003e Service[\u0027libvirt\u0027]"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # when nova-compute \u0026 libvirt run together"},{"line_number":83,"context_line":"    Service[\u0027libvirt\u0027] -\u003e Service\u003c| title \u003d\u003d \u0027nova-compute\u0027|\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_66d09d20","line":80,"range":{"start_line":71,"start_character":0,"end_line":80,"end_character":5},"in_reply_to":"df3967d1_42ea370f","updated":"2017-08-02 17:20:55.000000000","message":"it\u0027s better to have it explicit yeah. in puppet4 what counts is the order of resources. though in our modules we force placement.","commit_id":"ca1bdcfd7bf2888f4d7bfc57508079f96b9fb8d5"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"83be82fb1970bdf204e2e508bc542ce4acc46a2e","unresolved":false,"context_lines":[{"line_number":68,"context_line":"      require  \u003d\u003e Package[\u0027libvirt\u0027],"},{"line_number":69,"context_line":"    }"},{"line_number":70,"context_line":""},{"line_number":71,"context_line":"    # messagebus"},{"line_number":72,"context_line":"    if($::osfamily \u003d\u003d \u0027RedHat\u0027 and $::operatingsystem !\u003d \u0027Fedora\u0027) {"},{"line_number":73,"context_line":"      service { \u0027messagebus\u0027:"},{"line_number":74,"context_line":"        ensure   \u003d\u003e running,"},{"line_number":75,"context_line":"        enable   \u003d\u003e true,"},{"line_number":76,"context_line":"        name     \u003d\u003e $::nova::params::messagebus_service_name,"},{"line_number":77,"context_line":"        provider \u003d\u003e $::nova::params::special_service_provider,"},{"line_number":78,"context_line":"      }"},{"line_number":79,"context_line":"      Package[\u0027libvirt\u0027] -\u003e Service[\u0027messagebus\u0027] -\u003e Service[\u0027libvirt\u0027]"},{"line_number":80,"context_line":"    }"},{"line_number":81,"context_line":""},{"line_number":82,"context_line":"    # when nova-compute \u0026 libvirt run together"},{"line_number":83,"context_line":"    Service[\u0027libvirt\u0027] -\u003e Service\u003c| title \u003d\u003d \u0027nova-compute\u0027|\u003e"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"df3967d1_66fadd75","line":80,"range":{"start_line":71,"start_character":0,"end_line":80,"end_character":5},"in_reply_to":"df3967d1_66d09d20","updated":"2017-08-02 17:26:06.000000000","message":"In this case yes for newer versions it does when trying to reference it using the Package[\u0027libvirt\u0027] before it\u0027s actually declared it errors.  So because it\u0027s top down it was failing.","commit_id":"ca1bdcfd7bf2888f4d7bfc57508079f96b9fb8d5"}]}