)]}'
{"manifests/patch/config.pp":[{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"8821b3449fc9f024a09fa6aa27f941d38a5f902f","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if ($monkey_patch) {"},{"line_number":23,"context_line":"    nova_config {"},{"line_number":24,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":25,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e join($monkey_patch_modules,\u0027,\u0027);"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f436f4f_a499587a","line":22,"updated":"2017-08-17 16:43:41.000000000","message":"Please remove this if condition. Otherwise if someone sets it to false, the configs won\u0027t be cleared.","commit_id":"91130683c5e21a28876c365bedb3ca6dcd7c006c"},{"author":{"_account_id":18343,"name":"Lokesh Jain","email":"lokesh.jain@gmail.com","username":"lokesh-jain"},"change_message_id":"03eda485e3f949fb43dcefb746bb4f7c4fb5d2cf","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if ($monkey_patch) {"},{"line_number":23,"context_line":"    nova_config {"},{"line_number":24,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":25,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e join($monkey_patch_modules,\u0027,\u0027);"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"9f436f4f_de3400fe","line":22,"in_reply_to":"9f436f4f_a499587a","updated":"2017-08-18 17:20:42.000000000","message":"Added an else condition to clear the config when the value is not set","commit_id":"91130683c5e21a28876c365bedb3ca6dcd7c006c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"36be342936c3c5ed35adc7211a0e48bad90fd0a7","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if ($monkey_patch) {"},{"line_number":23,"context_line":"    nova_config {"},{"line_number":24,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":25,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e join($monkey_patch_modules,\u0027,\u0027);"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    nova_config {"},{"line_number":29,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         ensure \u003d\u003e absent;"},{"line_number":30,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: ensure \u003d\u003e absent;"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_5965cae0","line":32,"range":{"start_line":22,"start_character":0,"end_line":32,"end_character":3},"updated":"2017-08-18 17:26:27.000000000","message":"This is not necessary. So $::os_services_default results in the configuration being cleared.\n\nAll you need is:\n\n  nova_config {\n    \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;\n    \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e join($monkey_patch_modules,\u0027,\u0027);\n  }","commit_id":"3409105b2415c50601191b3375c5347b63ca3824"},{"author":{"_account_id":18343,"name":"Lokesh Jain","email":"lokesh.jain@gmail.com","username":"lokesh-jain"},"change_message_id":"9045358c848050a3436ce81e26223dbf22fc70f8","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if ($monkey_patch) {"},{"line_number":23,"context_line":"    nova_config {"},{"line_number":24,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":25,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e join($monkey_patch_modules,\u0027,\u0027);"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    nova_config {"},{"line_number":29,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         ensure \u003d\u003e absent;"},{"line_number":30,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: ensure \u003d\u003e absent;"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_833180ef","line":32,"range":{"start_line":22,"start_character":0,"end_line":32,"end_character":3},"in_reply_to":"9f436f4f_5965cae0","updated":"2017-08-18 19:49:30.000000000","message":"I added this so that nova.conf is in the same state as it as before the change. This includes not having monkey_patch and monkey_patch_modules parameters in nova.conf file. With what is being proposed, we will get monkey_path\u003dfalse in the nova.conf which I am trying to avoid. I am aiming for not having these values in the conf file. Please let me know your thoughts.","commit_id":"3409105b2415c50601191b3375c5347b63ca3824"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"61961e439eada7ee3e67ee48e6b7acdbf9bb3a5d","unresolved":false,"context_lines":[{"line_number":19,"context_line":""},{"line_number":20,"context_line":"  include ::nova::deps"},{"line_number":21,"context_line":""},{"line_number":22,"context_line":"  if ($monkey_patch) {"},{"line_number":23,"context_line":"    nova_config {"},{"line_number":24,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         value \u003d\u003e $monkey_patch;"},{"line_number":25,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: value \u003d\u003e join($monkey_patch_modules,\u0027,\u0027);"},{"line_number":26,"context_line":"    }"},{"line_number":27,"context_line":"  } else {"},{"line_number":28,"context_line":"    nova_config {"},{"line_number":29,"context_line":"      \u0027DEFAULT/monkey_patch\u0027:         ensure \u003d\u003e absent;"},{"line_number":30,"context_line":"      \u0027DEFAULT/monkey_patch_modules\u0027: ensure \u003d\u003e absent;"},{"line_number":31,"context_line":"    }"},{"line_number":32,"context_line":"  }"},{"line_number":33,"context_line":"}"}],"source_content_type":"text/x-puppet","patch_set":2,"id":"9f436f4f_e3496c32","line":32,"range":{"start_line":22,"start_character":0,"end_line":32,"end_character":3},"in_reply_to":"9f436f4f_833180ef","updated":"2017-08-18 20:00:39.000000000","message":"then set monkey_patch to $::os_service_default instead of true/false","commit_id":"3409105b2415c50601191b3375c5347b63ca3824"}]}