)]}'
{"manifests/compute.pp":[{"author":{"_account_id":6681,"name":"Brent Eagles","email":"beagles@redhat.com","username":"beagles"},"change_message_id":"cf30104dfff958a20302ece9724853bbbb02fed7","unresolved":false,"context_lines":[{"line_number":190,"context_line":"  $vcpu_pin_set_real \u003d pick(join(any2array($vcpu_pin_set), \u0027,\u0027), $::os_service_default)"},{"line_number":191,"context_line":""},{"line_number":192,"context_line":"  include ::nova::pci"},{"line_number":193,"context_line":"  include ::nova::compute::pci"},{"line_number":194,"context_line":""},{"line_number":195,"context_line":"  if $keymgr_api_class {"},{"line_number":196,"context_line":"    warning(\u0027The keymgr_api_class parameter is deprecated, use keymgr_backend\u0027)"}],"source_content_type":"text/x-puppet","patch_set":1,"id":"1f485f77_62cab84e","line":193,"updated":"2017-11-15 15:43:02.000000000","message":"At first glance, I thought this was a little weird. Especially when the related refactoring removed this from this file - I\u0027m not sure why it did that. The alias code was a completely different configuration and it\u0027s almost like this is expected to be on the controller as well as the compute nodes? I\u0027m not going to stand in the way of this fix since SR-IOV is currently broken but I think active puppet-nova devs should take a look at this and make sure that what has happened with PCI whitelist/alias configuration on compute nodes makes sense.","commit_id":"0d7c874b3d355344d37f47fae62d8bbafced201f"}]}