)]}'
{"/PATCHSET_LEVEL":[{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"09de8991155cdc36df932ee7d122a8aee5949782","unresolved":false,"context_lines":[],"source_content_type":"","patch_set":5,"id":"9fdcbcff_7889186a","updated":"2022-04-18 07:32:49.000000000","message":"This change has been inactive for more than 1 year and the dependent patch has never been merged.\n\nBecause we are now removing support for novajoin, I\u0027ll abandon this.\n\nPlease feel free to restore this if the fix is still needed.","commit_id":"934618462cc7a571a5c1c17ea502155b2227195d"}],"manifests/metadata/novajoin/api.pp":[{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"35c38938701499e556aa548067f315b8b3cb4f2d","unresolved":false,"context_lines":[{"line_number":125,"context_line":"  $join_listen_port          \u003d $::os_service_default,"},{"line_number":126,"context_line":"  $keystone_auth_url         \u003d \u0027http://127.0.0.1:5000/\u0027,"},{"line_number":127,"context_line":"  $keytab                    \u003d \u0027/etc/novajoin/krb5.keytab\u0027,"},{"line_number":128,"context_line":"  $dns_keytab                \u003d \u0027/home/stack/dns-krb5.keytab\u0027,"},{"line_number":129,"context_line":"  $log_dir                   \u003d \u0027/var/log/novajoin\u0027,"},{"line_number":130,"context_line":"  $manage_service            \u003d true,"},{"line_number":131,"context_line":"  $service_password          \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_1073b5e9","line":128,"range":{"start_line":128,"start_character":2,"end_line":128,"end_character":61},"updated":"2018-10-29 12:56:43.000000000","message":"Weird default values, is this correct?","commit_id":"f089c3374f703a30a1183e18243d388d4b08cdeb"},{"author":{"_account_id":16137,"name":"Tobias Urdin","email":"tobias.urdin@binero.com","username":"tobasco"},"change_message_id":"35c38938701499e556aa548067f315b8b3cb4f2d","unresolved":false,"context_lines":[{"line_number":130,"context_line":"  $manage_service            \u003d true,"},{"line_number":131,"context_line":"  $service_password          \u003d undef,"},{"line_number":132,"context_line":"  $service_user              \u003d \u0027novajoin\u0027,"},{"line_number":133,"context_line":"  $dns_service_user          \u003d \u0027mistral\u0027,"},{"line_number":134,"context_line":"  $project_domain_name       \u003d \u0027default\u0027,"},{"line_number":135,"context_line":"  $project_name              \u003d \u0027service\u0027,"},{"line_number":136,"context_line":"  $user_domain_id            \u003d \u0027default\u0027,"}],"source_content_type":"text/x-puppet","patch_set":4,"id":"3f79a3b5_306ef1fd","line":133,"range":{"start_line":133,"start_character":0,"end_line":133,"end_character":41},"updated":"2018-10-29 12:56:43.000000000","message":"and here","commit_id":"f089c3374f703a30a1183e18243d388d4b08cdeb"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90123b5d8b17a884fdd9445b48dace2eb8c56e96","unresolved":true,"context_lines":[{"line_number":139,"context_line":"  $join_listen_port          \u003d $::os_service_default,"},{"line_number":140,"context_line":"  $keystone_auth_url         \u003d \u0027http://127.0.0.1:5000/\u0027,"},{"line_number":141,"context_line":"  $keytab                    \u003d \u0027/etc/novajoin/krb5.keytab\u0027,"},{"line_number":142,"context_line":"  $dns_keytab                \u003d \u0027/home/stack/dns-krb5.keytab\u0027,"},{"line_number":143,"context_line":"  $log_dir                   \u003d \u0027/var/log/novajoin\u0027,"},{"line_number":144,"context_line":"  $manage_service            \u003d true,"},{"line_number":145,"context_line":"  $password                  \u003d undef,"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"e7099f23_fce717fc","line":142,"range":{"start_line":142,"start_character":32,"end_line":142,"end_character":59},"updated":"2021-01-06 04:39:55.000000000","message":"This is too specific to TripleO and IMO we shouldn\u0027t use this by default. Maybe we can use undef by default and enables dns entries management only if this parameter is set.","commit_id":"934618462cc7a571a5c1c17ea502155b2227195d"},{"author":{"_account_id":9816,"name":"Takashi Kajinami","email":"kajinamit@oss.nttdata.com","username":"kajinamit"},"change_message_id":"90123b5d8b17a884fdd9445b48dace2eb8c56e96","unresolved":true,"context_lines":[{"line_number":147,"context_line":"  $username                  \u003d \u0027novajoin\u0027,"},{"line_number":148,"context_line":"  $project_domain_name       \u003d \u0027Default\u0027,"},{"line_number":149,"context_line":"  $project_name              \u003d \u0027services\u0027,"},{"line_number":150,"context_line":"  $dns_service_user          \u003d \u0027mistral\u0027,"},{"line_number":151,"context_line":"  $configure_kerberos        \u003d false,"},{"line_number":152,"context_line":"  $ipa_realm                 \u003d undef,"},{"line_number":153,"context_line":"  # DEPRECATED PARAMETERS"}],"source_content_type":"text/x-puppet","patch_set":5,"id":"007205b6_6dd30379","line":150,"range":{"start_line":150,"start_character":32,"end_line":150,"end_character":39},"updated":"2021-01-06 04:39:55.000000000","message":"This is too specific to TripleO and IMO we shouldn\u0027t use this by default. I believe root would be the better default.","commit_id":"934618462cc7a571a5c1c17ea502155b2227195d"}]}