)]}'
{"manifests/cron/purge_shadow_tables.pp":[{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"c9c08f6c8cce9a7b714921bdf983e8dcc334358e","unresolved":false,"context_lines":[{"line_number":60,"context_line":"  $weekday     \u003d 6,"},{"line_number":61,"context_line":"  $user        \u003d undef,"},{"line_number":62,"context_line":"  $destination \u003d \u0027/var/log/nova/nova-rowspurge.log\u0027,"},{"line_number":63,"context_line":"  $max_days    \u003d 0,"},{"line_number":64,"context_line":"  $verbose     \u003d false,"},{"line_number":65,"context_line":") {"},{"line_number":66,"context_line":""}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df7087c5_194a6c54","line":63,"updated":"2018-03-22 16:47:34.000000000","message":"please rename to max_retention_days so operators will understand it better.","commit_id":"be4e9cd5f75dfd53478d0fb3450c73f22864e1b8"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"c9c08f6c8cce9a7b714921bdf983e8dcc334358e","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  $cron_cmd \u003d \u0027nova-manage db purge\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  cron { \u0027nova-manage db purge\u0027:"},{"line_number":80,"context_line":"    command     \u003d\u003e \"${cron_cmd} --before `date +%Y-%m-%d -d \u0027-${max_days} days\u0027` ${verbose_real} \u003e\u003e${destination} 2\u003e\u00261\","},{"line_number":81,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":82,"context_line":"    user        \u003d\u003e pick($user, $::nova::params::nova_user),"},{"line_number":83,"context_line":"    minute      \u003d\u003e $minute,"}],"source_content_type":"text/x-puppet","patch_set":6,"id":"df7087c5_f9d45849","line":80,"updated":"2018-03-22 16:47:34.000000000","message":"I guess the","commit_id":"be4e9cd5f75dfd53478d0fb3450c73f22864e1b8"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"a37cd34eb97c6aad6487cc62fc5b928ffb29471f","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  $cron_cmd \u003d \u0027nova-manage db purge\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  cron { \u0027nova-manage db purge\u0027:"},{"line_number":80,"context_line":"    command     \u003d\u003e \"${cron_cmd} --before `date --date\u003d\u0027today - ${max_retention_days} days\u0027 +%D` ${verbose_real} \u003e\u003e${destination} 2\u003e\u00261\","},{"line_number":81,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":82,"context_line":"    user        \u003d\u003e pick($user, $::nova::params::nova_user),"},{"line_number":83,"context_line":"    minute      \u003d\u003e $minute,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"df7087c5_c3239aa6","line":80,"range":{"start_line":80,"start_character":91,"end_line":80,"end_character":95},"updated":"2018-03-22 15:25:36.000000000","message":"This returns MM/DD/YY format, is that acceptable for the --before paramter?","commit_id":"3c7bb6d7dccbb7054315f56f64c030d4c5e1135c"},{"author":{"_account_id":11090,"name":"Sergii Golovatiuk","email":"sgolovat@redhat.com","username":"holser"},"change_message_id":"84d98e802e2ca5fef8085594e8b05ecc1b360a39","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  $cron_cmd \u003d \u0027nova-manage db purge\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  cron { \u0027nova-manage db purge\u0027:"},{"line_number":80,"context_line":"    command     \u003d\u003e \"${cron_cmd} --before `date --date\u003d\u0027today - ${max_retention_days} days\u0027 +%D` ${verbose_real} \u003e\u003e${destination} 2\u003e\u00261\","},{"line_number":81,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":82,"context_line":"    user        \u003d\u003e pick($user, $::nova::params::nova_user),"},{"line_number":83,"context_line":"    minute      \u003d\u003e $minute,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"df7087c5_d2a04545","line":80,"range":{"start_line":80,"start_character":91,"end_line":80,"end_character":95},"in_reply_to":"df7087c5_23e37636","updated":"2018-03-22 16:48:07.000000000","message":"yep","commit_id":"3c7bb6d7dccbb7054315f56f64c030d4c5e1135c"},{"author":{"_account_id":14985,"name":"Alex Schultz","email":"aschultz@next-development.com","username":"mwhahaha"},"change_message_id":"18d3a897555db573b2e38b45aff008055b0df621","unresolved":false,"context_lines":[{"line_number":77,"context_line":"  $cron_cmd \u003d \u0027nova-manage db purge\u0027"},{"line_number":78,"context_line":""},{"line_number":79,"context_line":"  cron { \u0027nova-manage db purge\u0027:"},{"line_number":80,"context_line":"    command     \u003d\u003e \"${cron_cmd} --before `date --date\u003d\u0027today - ${max_retention_days} days\u0027 +%D` ${verbose_real} \u003e\u003e${destination} 2\u003e\u00261\","},{"line_number":81,"context_line":"    environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":82,"context_line":"    user        \u003d\u003e pick($user, $::nova::params::nova_user),"},{"line_number":83,"context_line":"    minute      \u003d\u003e $minute,"}],"source_content_type":"text/x-puppet","patch_set":9,"id":"df7087c5_23e37636","line":80,"range":{"start_line":80,"start_character":91,"end_line":80,"end_character":95},"in_reply_to":"df7087c5_c3239aa6","updated":"2018-03-22 15:29:57.000000000","message":"To answer my own question, yes. https://github.com/openstack/nova/blob/37b4f77b5ed2c3606ebeae42ae2b1aedb0eda775/nova/cmd/manage.py#L587","commit_id":"3c7bb6d7dccbb7054315f56f64c030d4c5e1135c"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"15421e4f07bccc87ca0c7f3b33936dc7166650fa","unresolved":false,"context_lines":[{"line_number":23,"context_line":"#    (optional) Defaults to \u00270\u0027."},{"line_number":24,"context_line":"#"},{"line_number":25,"context_line":"#  [*hour*]"},{"line_number":26,"context_line":"#    (optional) Defaults to \u00275\u0027."},{"line_number":27,"context_line":"#"},{"line_number":28,"context_line":"#  [*monthday*]"},{"line_number":29,"context_line":"#    (optional) Defaults to \u0027*\u0027."}],"source_content_type":"text/x-puppet","patch_set":13,"id":"df7087c5_9c1f3c07","line":26,"range":{"start_line":26,"start_character":0,"end_line":26,"end_character":32},"updated":"2018-03-22 20:22:57.000000000","message":"Any reason behind this change?  The commit mentions nothing about it.","commit_id":"ea617d17fb391c3aae8f9759a9c997279683d405"},{"author":{"_account_id":1004,"name":"Mohammed Naser","email":"mnaser@vexxhost.com","username":"mnaser"},"change_message_id":"15421e4f07bccc87ca0c7f3b33936dc7166650fa","unresolved":false,"context_lines":[{"line_number":32,"context_line":"#    (optional) Defaults to \u0027*\u0027."},{"line_number":33,"context_line":"#"},{"line_number":34,"context_line":"#  [*weekday*]"},{"line_number":35,"context_line":"#    (optional) Defaults to \u0027*\u0027."},{"line_number":36,"context_line":"#"},{"line_number":37,"context_line":"#  [*user*]"},{"line_number":38,"context_line":"#    (optional) User with access to nova files."}],"source_content_type":"text/x-puppet","patch_set":13,"id":"df7087c5_5c1524e4","line":35,"range":{"start_line":35,"start_character":0,"end_line":35,"end_character":32},"updated":"2018-03-22 20:22:57.000000000","message":"Same here, we\u0027re changing functionality beneath our users, also no release note.  I\u0027d prefer that if we have a valid reason to change it, we at least add it in the release notes.","commit_id":"ea617d17fb391c3aae8f9759a9c997279683d405"}],"spec/classes/nova_cron_purge_shadow_tables.rb":[{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f1cca2b1fef27b507313d9b985ca7b39bfaddce6","unresolved":false,"context_lines":[{"line_number":23,"context_line":""},{"line_number":24,"context_line":"      it \u0027configures a nova purge cron with verbose output\u0027 do"},{"line_number":25,"context_line":"        is_expected.to contain_cron(\u0027nova-manage db purge\u0027).with("},{"line_number":26,"context_line":"          :command     \u003d\u003e \"nova-manage db purge --all --verbose \u003e\u003e#{params[:destination]} 2\u003e\u00261\","},{"line_number":27,"context_line":"          :user        \u003d\u003e \u0027nova\u0027,"},{"line_number":28,"context_line":"          :environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":29,"context_line":"          :user        \u003d\u003e params[:user],"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"df7087c5_9e82e2c7","line":26,"range":{"start_line":26,"start_character":50,"end_line":26,"end_character":53},"updated":"2018-03-22 11:10:24.000000000","message":"This should fail here but is not :(","commit_id":"be4e9cd5f75dfd53478d0fb3450c73f22864e1b8"},{"author":{"_account_id":20775,"name":"Carlos Camacho","email":"ccamacho@redhat.com","username":"ccamacho"},"change_message_id":"f1cca2b1fef27b507313d9b985ca7b39bfaddce6","unresolved":false,"context_lines":[{"line_number":46,"context_line":""},{"line_number":47,"context_line":"      it \u0027configures a nova purge cron without verbose output\u0027 do"},{"line_number":48,"context_line":"        is_expected.to contain_cron(\u0027nova-manage db purge\u0027).with("},{"line_number":49,"context_line":"          :command     \u003d\u003e \"nova-manage db purge --all  \u003e\u003e#{params[:destination]} 2\u003e\u00261\","},{"line_number":50,"context_line":"          :user        \u003d\u003e \u0027nova\u0027,"},{"line_number":51,"context_line":"          :environment \u003d\u003e \u0027PATH\u003d/bin:/usr/bin:/usr/sbin SHELL\u003d/bin/sh\u0027,"},{"line_number":52,"context_line":"          :user        \u003d\u003e params[:user],"}],"source_content_type":"text/x-ruby","patch_set":6,"id":"df7087c5_be8566d1","line":49,"range":{"start_line":49,"start_character":50,"end_line":49,"end_character":53},"updated":"2018-03-22 11:10:24.000000000","message":"This should fail here but is not :(","commit_id":"be4e9cd5f75dfd53478d0fb3450c73f22864e1b8"}]}